ruby_psigate 0.7.5 → 0.7.6

data/CHANGELOG

@@ -1,3 +1,4 @@
+v0.7.6. gateway handles connection problems gracefully
 v0.7.5. fixed bug: serializer works for ItemInfo
 v0.7.4. fixed bug: account charges can now be registered
 v0.7.3. fixed bugs related to account information (address, name) not being passed through to server

data/lib/ruby_psigate/gateway.rb

@@ -67,38 +67,44 @@ module RubyPsigate
       # 5) Parameterize and ensure it is properly formatted
       # 6) Send!
       
-      raise InvalidGatewayMode unless mode_set?
-      raise InvalidCredentials unless sufficient_login_credentials?
+      begin
+        raise InvalidGatewayMode unless mode_set?
+        raise InvalidCredentials unless sufficient_login_credentials?
 
-      if mode == :transaction
-        raise InvalidOrder unless order.valid?
+        if mode == :transaction
+          raise InvalidOrder unless order.valid?
 
-        @params = {}
-        @params[:Order] = {}
-        @params[:Order] = { :StoreID => options[:store_id], :Passphrase => options[:passphrase] }
-        @params[:Order].merge!(order.to_hash(order.action))
-        
-        @endpoint = "https://dev.psigate.com:7989/Messenger/XMLMessenger"
-      end
+          @params = {}
+          @params[:Order] = {}
+          @params[:Order] = { :StoreID => options[:store_id], :Passphrase => options[:passphrase] }
+          @params[:Order].merge!(order.to_hash(order.action))
 
-      if mode == :account_manager
-        # raise InvalidAccount unless account.valid?
-        
-        # Parameterize based on account manager
-        @params = {}
-        @params[:Request] = {}
-        @params[:Request] = { :CID => options[:cid], :UserID => options[:user_id], :Password => options[:password] }
-        @params[:Request].merge!(account.to_hash(account.action))
-        
-        @endpoint = "https://dev.psigate.com:8645/Messenger/AMMessenger"
+          @endpoint = "https://dev.psigate.com:7989/Messenger/XMLMessenger"
+        end
+
+        if mode == :account_manager
+          # raise InvalidAccount unless account.valid?
+
+          # Parameterize based on account manager
+          @params = {}
+          @params[:Request] = {}
+          @params[:Request] = { :CID => options[:cid], :UserID => options[:user_id], :Password => options[:password] }
+          @params[:Request].merge!(account.to_hash(account.action))
+
+          @endpoint = "https://dev.psigate.com:8645/Messenger/AMMessenger"
+        end
+
+        # Serializes the parameters to xml      
+        @params = Serializer.new(@params, :header => true).to_xml
+
+        @connection = Connection.new(@endpoint)
+        @response = @connection.post(@params)
+        Response.new(@response)
+      rescue ConnectionError => e
+        @response = false
       end
 
-      # Serializes the parameters to xml      
-      @params = Serializer.new(@params, :header => true).to_xml
-      
-      @connection = Connection.new(@endpoint)
-      @response = @connection.post(@params)
-      Response.new(@response)
+      @response
     end
     
     private

data/ruby_psigate.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ruby_psigate}
-  s.version = "0.7.5"
+  s.version = "0.7.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Simon Chiu"]

data/test/unit/gateway_test.rb

@@ -107,6 +107,35 @@ module RubyPsigate
         assert_raises(InvalidCredentials) { @gateway.commit! }        
       end
     end
+    
+    context "connection error handling" do
+      should "handle connection error" do
+        RubyPsigate::Connection.any_instance.stubs(:post).raises(ConnectionError)
+        
+        
+        @gateway = RubyPsigate::Gateway.new(:store_id => "teststore", :passphrase => "psigate1234")
+
+        @order = RubyPsigate::Order.new
+        @order.amount = 10.00
+        @order.action = :sale
+        @order.email = "bob@gmail.com"
+
+        @credit_card = RubyPsigate::CreditCard.new(
+          :number => "4111111111111111",
+          :month  => "12",
+          :year   => "2011",
+          :verification_value => "123",
+          :name   => "Bob John"
+        )
+
+        @order.cc = @credit_card      
+
+        @gateway.order = @order
+
+        assert !@gateway.commit!
+        
+      end
+    end
 
   end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 7
-  - 5
-  version: 0.7.5
+  - 6
+  version: 0.7.6
 platform: ruby
 authors: 
 - Simon Chiu