ruby_parser 3.20.1 → 3.20.2

data/lib/ruby3_parser.yy

@@ -104,9 +104,9 @@ rule
                       result = iter
                     }
 
-     begin_block: tLCURLY { result = lexer.lineno } top_compstmt tRCURLY
+     begin_block: tLCURLY top_compstmt tRCURLY
                     {
-                      _, line, stmt, _ = val
+                      (_, line), stmt, _ = val
                       result = new_iter s(:preexe).line(line), 0, stmt
                     }
 
@@ -639,7 +639,7 @@ rule
                     }
                 | tSTAR
                     {
-                      l = lexer.lineno
+                      (_, l), = val
                       result = s(:masgn, s(:array, s(:splat).line(l)).line(l)).line l
                     }
                 | tSTAR tCOMMA mlhs_post
@@ -1271,7 +1271,7 @@ rule
             args: arg_value
                     {
                       arg, = val
-                      lineno = arg.line || lexer.lineno # HACK
+                      lineno = arg.line
 
                       result = s(:array, arg).line lineno
                     }
@@ -1280,6 +1280,13 @@ rule
                       _, arg = val
                       result = s(:array, s(:splat, arg).line(arg.line)).line arg.line
                     }
+#if V >= 32
+                | tSTAR
+                    {
+                      (_, line), = val
+                      result = s(:array, s(:splat).line(line)).line line
+                    }
+#endif
                 | args tCOMMA arg_value
                     {
                       args, _, id = val
@@ -1287,11 +1294,16 @@ rule
                     }
                 | args tCOMMA tSTAR arg_value
                     {
-                      # TODO: the line number from tSTAR has been dropped
-                      args, _, _, id = val
-                      line = lexer.lineno
+                      args, _, (_, line), id = val
                       result = self.list_append args, s(:splat, id).line(line)
                     }
+#if V >= 32
+                | args tCOMMA tSTAR
+                    {
+                      args, _, (_, line) = val
+                      result = self.list_append args, s(:splat).line(line)
+                    }
+#endif
 
         mrhs_arg: mrhs
                     {
@@ -1308,7 +1320,6 @@ rule
                     }
                 | args tCOMMA tSTAR arg_value
                     {
-                      # TODO: make all tXXXX terminals include lexer.lineno
                       arg, _, _, splat = val
                       result = self.arg_concat arg, splat
                     }
@@ -1337,7 +1348,6 @@ rule
                 | k_begin
                     {
                       lexer.cmdarg.push false
-                      result = self.lexer.lineno
                     }
                     bodystmt k_end
                     {
@@ -1347,11 +1357,10 @@ rule
                 | tLPAREN_ARG
                     {
                       lexer.lex_state = EXPR_ENDARG
-                      result = lexer.lineno
                     }
                     rparen
                     {
-                      _, line, _ = val
+                      (_, line), _, _ = val
                       result = s(:begin).line line
                     }
                 | tLPAREN_ARG
@@ -1367,9 +1376,8 @@ rule
                     }
                 | tLPAREN compstmt tRPAREN
                     {
-                      _, stmt, _ = val
-                      result = stmt
-                      result ||= s(:nil).line lexer.lineno
+                      (_, line), stmt, _ = val
+                      result = stmt || s(:nil).line(line)
                       result.paren = true
                     }
                 | primary_value tCOLON2 tCONSTANT
@@ -1382,9 +1390,9 @@ rule
                     {
                       result = wrap :colon3, val[1]
                     }
-                | tLBRACK { result = lexer.lineno } aref_args rbracket
+                | tLBRACK aref_args rbracket
                     {
-                      _, line, args, (_, line_max) = val
+                      (_, line), args, (_, line_max) = val
 
                       result = args || s(:array)
                       result.sexp_type = :array # aref_args is :args
@@ -1500,9 +1508,6 @@ rule
                       result = new_for iter, var, body
                     }
                 | k_class
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath superclass
                     {
                       if (self.in_def || self.in_single > 0) then
@@ -1517,9 +1522,6 @@ rule
                       self.lexer.ignore_body_comments
                     }
                 | k_class tLSHFT
-                    {
-                      result = self.lexer.lineno
-                    }
                     expr
                     {
                       result = self.in_def
@@ -1531,16 +1533,14 @@ rule
                       self.in_single = 0
                       self.env.extend
                     }
-                    bodystmt k_end
+                    bodystmt
+                    k_end
                     {
                       result = new_sclass val
                       self.env.unextend
                       self.lexer.ignore_body_comments
                     }
                 | k_module
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath
                     {
                       yyerror "module definition in method body" if
@@ -1682,20 +1682,33 @@ rule
                     }
 
           f_marg: f_norm_arg
+                    {
+                      (sym, line), = val
+
+                      result = s(:dummy, sym).line line
+                    }
                 | tLPAREN f_margs rparen
                     {
-                      result = val[1]
+                      _, args, _ = val
+                      result = args
                     }
 
      f_marg_list: f_marg
                     {
-                      sym, = val
+                      arg, = val
+                      line = arg.line
+
+                      arg = arg.last if arg.sexp_type == :dummy
 
-                      result = s(:array, sym).line lexer.lineno
+                      result = s(:array, arg).line line
                     }
                 | f_marg_list tCOMMA f_marg
                     {
-                      result = list_append val[0], val[2]
+                      args, _, arg = val
+
+                      arg = arg.last if arg.sexp_type == :dummy
+
+                      result = list_append args, arg
                     }
 
          f_margs: f_marg_list
@@ -1738,8 +1751,8 @@ rule
                     }
                 | tSTAR
                     {
-                      result = args [:*]
-                      result.line lexer.lineno # FIX: tSTAR -> line
+                      (_, line), = val
+                      result = args([:*]).line line
                     }
 
     f_any_kwrest: f_kwrest
@@ -1854,7 +1867,9 @@ opt_block_args_tail: tCOMMA block_args_tail
                     }
                 | tOROP
                     {
-                      result = s(:args).line lexer.lineno
+                      (_, line), = val
+
+                      result = s(:args).line line
                     }
                 | tPIPE block_param opt_bv_decl tPIPE
                     {
@@ -1886,7 +1901,7 @@ opt_block_args_tail: tCOMMA block_args_tail
           lambda: tLAMBDA
                     {
                       self.env.extend :dynamic
-                      result = [lexer.lineno, lexer.lpar_beg]
+                      result = lexer.lpar_beg
                       lexer.paren_nest += 1
                       lexer.lpar_beg = lexer.paren_nest
                     }
@@ -1896,7 +1911,7 @@ opt_block_args_tail: tCOMMA block_args_tail
                     }
                     lambda_body
                     {
-                      _, (line, lpar), args, _cmdarg, body = val
+                      (_, line), lpar, args, _cmdarg, body = val
                       lexer.lpar_beg = lpar
 
                       lexer.cmdarg.pop
@@ -2020,7 +2035,8 @@ opt_block_args_tail: tCOMMA block_args_tail
                     }
                 | kSUPER
                     {
-                      result = s(:zsuper).line lexer.lineno
+                      (_, line), = val
+                      result = s(:zsuper).line line
                     }
                 | primary_value tLBRACK2 opt_call_args rbracket
                     {
@@ -2030,11 +2046,11 @@ opt_block_args_tail: tCOMMA block_args_tail
      brace_block: tLCURLY
                     {
                       self.env.extend :dynamic
-                      result = self.lexer.lineno
                     }
-                    brace_body tRCURLY
+                    brace_body
+                    tRCURLY
                     {
-                      _, line, body, _ = val
+                      (_, line), _, body, _ = val
 
                       result = body
                       result.line line
@@ -2044,11 +2060,11 @@ opt_block_args_tail: tCOMMA block_args_tail
                 | k_do
                     {
                       self.env.extend :dynamic
-                      result = self.lexer.lineno
                     }
-                    do_body kEND
+                    do_body
+                    kEND
                     {
-                      _, line, body, _ = val
+                      (_, line), _, body, _ = val
 
                       result = body
                       result.line line
@@ -2106,14 +2122,13 @@ opt_block_args_tail: tCOMMA block_args_tail
                     }
 
        case_body: k_when
-                    {
-                      result = self.lexer.lineno
-                    }
                     case_args then compstmt cases
                     {
-                      result = new_when(val[2], val[4])
-                      result.line val[1]
-                      result << val[5] if val[5]
+                      (_, line), case_args, _then, body, cases = val
+
+                      result = new_when case_args, body
+                      result.line line
+                      result << cases if cases
                     }
 
            cases: opt_else | case_body
@@ -2352,6 +2367,7 @@ opt_block_args_tail: tCOMMA block_args_tail
                       result = new_array_pattern_tail both, nil, nil, nil
                       result.line head.line
                     }
+#if V < 32
                 | p_args_head tSTAR tIDENTIFIER
                     {
                       head, _, (id, _line) = val
@@ -2378,6 +2394,20 @@ opt_block_args_tail: tCOMMA block_args_tail
 
                       result = new_array_pattern_tail(head, true, nil, post).line head.line
                     }
+#else
+                | p_args_head p_rest
+                    {
+                      head, (rest, _) = val
+
+                      result = new_array_pattern_tail(head, true, rest, nil).line head.line
+                    }
+                | p_args_head p_rest tCOMMA p_args_post
+                    {
+                      head, (rest, _), _, post = val
+
+                      result = new_array_pattern_tail(head, true, rest, post).line head.line
+                    }
+#endif
                 | p_args_tail
 
      p_args_head: p_arg tCOMMA
@@ -2917,7 +2947,6 @@ regexp_contents: none
                                 lexer.brace_nest,
                                 lexer.string_nest, # TODO: remove
                                 lexer.lex_state,
-                                lexer.lineno,
                                ]
 
                       lexer.cmdarg.push false
@@ -2932,9 +2961,9 @@ regexp_contents: none
                     compstmt
                     tSTRING_DEND
                     {
-                      _, memo, stmt, _ = val
+                      (_, line), memo, stmt, _ = val
 
-                      lex_strterm, brace_nest, string_nest, oldlex_state, line = memo
+                      lex_strterm, brace_nest, string_nest, oldlex_state = memo
                       # TODO: heredoc_indent
 
                       lexer.lex_strterm = lex_strterm
@@ -2994,11 +3023,11 @@ regexp_contents: none
 
             dsym: tSYMBEG string_contents tSTRING_END
                     {
-                      _, result, _ = val
+                      (_, line), result, _ = val
 
                       lexer.lex_state = EXPR_END
 
-                      result ||= s(:str, "").line lexer.lineno
+                      result ||= s(:str, "").line line
 
                       case result.sexp_type
                       when :dstr then
@@ -3036,15 +3065,15 @@ regexp_contents: none
                 | tCONSTANT
                 | tCVAR
 
-keyword_variable: kNIL      { result = s(:nil).line lexer.lineno }
-                | kSELF     { result = s(:self).line lexer.lineno }
-                | kTRUE     { result = s(:true).line lexer.lineno }
-                | kFALSE    { result = s(:false).line lexer.lineno }
-                | k__FILE__ { result = s(:str, self.file).line lexer.lineno }
-                | k__LINE__ { result = s(:lit, lexer.lineno).line lexer.lineno }
+keyword_variable: kNIL      { (_, line), = val; result = s(:nil).line line }
+                | kSELF     { (_, line), = val; result = s(:self).line line }
+                | kTRUE     { (_, line), = val; result = s(:true).line line }
+                | kFALSE    { (_, line), = val; result = s(:false).line line }
+                | k__FILE__ { (_, line), = val; result = s(:str, self.file).line line }
+                | k__LINE__ { (_, line), = val; result = s(:lit, line).line line }
                 | k__ENCODING__
                     {
-                      l = lexer.lineno
+                      (_, l), = val
                       result =
                         if defined? Encoding then
                           s(:colon2, s(:const, :Encoding).line(l), :UTF_8).line l
@@ -3219,12 +3248,12 @@ f_opt_paren_args: f_paren_args
                 |
                     {
                       result = args val
-                      # result.line lexer.lineno
                     }
 
     args_forward: tBDOT3
                     {
-                      result = s(:forward_args).line lexer.lineno
+                      (_, line), = val
+                      result = s(:forward_args).line line
                     }
 
        f_bad_arg: tCONSTANT
@@ -3362,9 +3391,10 @@ f_opt_paren_args: f_paren_args
                     }
                 | kwrest_mark
                     {
+                      (_, line), = val
                       id = :"**"
-                      self.env[id] = :lvar # TODO: needed?!?
-                      result = [id, lexer.lineno] # TODO: tPOW/tDSTAR include lineno
+                      self.env[id] = :lvar
+                      result = [id, line]
                     }
 
            f_opt: f_arg_asgn
@@ -3430,9 +3460,10 @@ f_opt_paren_args: f_paren_args
                     }
                 | restarg_mark
                     {
+                      (_, line), = val
                       name = :"*"
                       self.env[name] = :lvar
-                      result = [name, lexer.lineno] # FIX: tSTAR to include lineno
+                      result = [name, line]
                     }
 
      blkarg_mark: tAMPER2 | tAMPER
@@ -3523,6 +3554,13 @@ f_opt_paren_args: f_paren_args
                       line = arg.line
                       result = s(:array, s(:kwsplat, arg).line(line)).line line
                     }
+#if V >= 32
+                | tDSTAR
+                    {
+                      (_, line), = val
+                      result = s(:array, s(:kwsplat).line(line)).line line
+                    }
+#endif
 
        operation: tIDENTIFIER | tCONSTANT | tFID
       operation2: tIDENTIFIER | tCONSTANT | tFID | op
@@ -3537,11 +3575,10 @@ f_opt_paren_args: f_paren_args
        opt_terms:  | terms
           opt_nl:  | tNL
           rparen: opt_nl tRPAREN
-                    # TODO:
-                    # {
-                    #   _, close = val
-                    #   result = [close, lexer.lineno]
-                    # }
+                    {
+                      _, close = val # TODO: include lineno in close?
+                      result = [close, lexer.lineno]
+                    }
         rbracket: opt_nl tRBRACK
                     {
                       _, close = val

data/lib/ruby_lexer.rb

@@ -271,6 +271,8 @@ class RubyLexer
     nil # TODO
   end
 
+  # TODO: make all tXXXX terminals include lexer.lineno ... enforce it somehow?
+
   def process_brace_close text
     case matched
     when "}" then

data/lib/ruby_lexer.rex.rb

@@ -2,7 +2,7 @@
 # encoding: UTF-8
 #--
 # This file is automatically generated. Do not modify it.
-# Generated by: oedipus_lex version 2.6.0.
+# Generated by: oedipus_lex version 2.6.1.
 # Source: lib/ruby_lexer.rex
 #++
 

data/lib/ruby_lexer_strings.rb

@@ -56,7 +56,7 @@ class RubyLexer
         return :tSTRING_DVAR, matched
       when scan(/#[{]/) then
         self.command_start = true
-        return :tSTRING_DBEG, matched
+        return :tSTRING_DBEG, [matched, lineno]
       when scan(/#/) then
         string_buffer << "#"
       end
@@ -415,7 +415,7 @@ class RubyLexer
       return :tSTRING_DVAR, matched
     when scan(/#[{]/) then
       self.command_start = true
-      return :tSTRING_DBEG, matched
+      return :tSTRING_DBEG, [matched, lineno]
     when scan(/#/) then
       # do nothing but swallow
     end

data/lib/ruby_parser.yy

@@ -1293,7 +1293,6 @@ rule
                 | k_begin
                     {
                       lexer.cmdarg.push false
-                      result = self.lexer.lineno
                     }
                     bodystmt k_end
                     {
@@ -1458,9 +1457,6 @@ rule
                       result = new_for iter, var, body
                     }
                 | k_class
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath superclass
                     {
                       if (self.in_def || self.in_single > 0) then
@@ -1475,9 +1471,6 @@ rule
                       self.lexer.ignore_body_comments
                     }
                 | k_class tLSHFT
-                    {
-                      result = self.lexer.lineno
-                    }
                     expr
                     {
                       result = self.in_def
@@ -1496,9 +1489,6 @@ rule
                       self.lexer.ignore_body_comments
                     }
                 | k_module
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath
                     {
                       yyerror "module definition in method body" if

data/lib/ruby_parser_extras.rb

@@ -30,7 +30,7 @@ class Sexp
 end
 
 module RubyParserStuff
-  VERSION = "3.20.1"
+  VERSION = "3.20.2"
 
   attr_accessor :lexer, :in_def, :in_single, :file
   attr_accessor :in_kwarg
@@ -824,10 +824,10 @@ module RubyParserStuff
   end
 
   def new_begin val
-    _, lineno, body, _ = val
+    (_, line), _, body, _ = val
 
     result = body ? s(:begin, body) : s(:nil)
-    result.line lineno
+    result.line line
 
     result
   end
@@ -928,8 +928,7 @@ module RubyParserStuff
   end
 
   def new_class val
-    # TODO: get line from class keyword
-    _, line, path, superclass, _, body, (_, line_max) = val
+    (_, line), path, superclass, _, body, (_, line_max) = val
 
     path = path.first if path.instance_of? Array
 
@@ -1209,7 +1208,7 @@ module RubyParserStuff
   end
 
   def new_module val
-    (_, line_min), _, path, _, body, (_, line_max) = val
+    (_, line_min), path, _, body, (_, line_max) = val
 
     path = path.first if path.instance_of? Array
 
@@ -1367,7 +1366,7 @@ module RubyParserStuff
   end
 
   def new_sclass val
-    recv, in_def, in_single, body = val[3], val[4], val[6], val[7]
+    (_, line), _, recv, in_def, _, in_single, body, _ = val
 
     result = s(:sclass, recv)
 
@@ -1379,7 +1378,7 @@ module RubyParserStuff
       end
     end
 
-    result.line = val[2]
+    result.line = line
     self.in_def = in_def
     self.in_single = in_single
     result

data/test/test_ruby_parser.rb

@@ -132,11 +132,13 @@ module TestRubyParserShared
     # for the array. Luckily, the arary elements all seemt to get the correct
     # line number.
     rb = "[\n'a',\n'b']\n1"
+
     pt = s(:block,
            s(:array,
              s(:str, "a").line(2),
-             s(:str, "b").line(3)),
+             s(:str, "b").line(3)).line(1),
            s(:lit, 1).line(4)).line 1
+
     assert_parse rb, pt
   end
 
@@ -5632,6 +5634,34 @@ end
 
 module TestRubyParserShared32Plus
   include TestRubyParserShared31Plus
+
+  def test_args_star__anon_solo
+    rb = "f(*)"
+    pt = s(:call, nil, :f, s(:splat))
+
+    assert_parse rb, pt
+  end
+
+  def test_args_star__anon_trailing
+    rb = "f(x, *)"
+    pt = s(:call, nil, :f, s(:call, nil, :x), s(:splat))
+
+    assert_parse rb, pt
+  end
+
+  def test_args_dstar__anon_solo
+    rb = "f(**)"
+    pt = s(:call, nil, :f, s(:hash, s(:kwsplat))) # TODO double check this
+
+    assert_parse rb, pt
+  end
+
+  def test_args_dstar__anon_trailing
+    rb = "f(x, **)"
+    pt = s(:call, nil, :f, s(:call, nil, :x), s(:hash, s(:kwsplat))) # TODO double check this
+
+    assert_parse rb, pt
+  end
 end
 
 class Minitest::Test

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_parser
 version: !ruby/object:Gem::Version
-  version: 3.20.1
+  version: 3.20.2
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   ROfWo9Uyp8ba/j9eVG14KkYRaLydAY1MNQk2yd3R5CGfeOpD1kttxjoypoUJ2dOG
   nsNBRuQJ1UfiCG97a6DNm+Fr
   -----END CERTIFICATE-----
-date: 2023-05-17 00:00:00.000000000 Z
+date: 2023-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor