ruby_parser 3.20.0 → 3.20.2

data/lib/ruby_parser.yy

@@ -253,6 +253,7 @@ rule
                 | lhs tEQL mrhs
                     {
                       lhs, _, rhs = val
+
                       result = new_assign lhs, s(:svalue, rhs).line(rhs.line)
                     }
 #if V == 20
@@ -1107,8 +1108,10 @@ rule
 
       paren_args: tLPAREN2 opt_call_args rparen
                     {
-                      _, args, _ = val
+                      _, args, (_, line_max) = val
+
                       result = args
+                      result.line_max = line_max if args
                     }
 #if V >= 27
                 | tLPAREN2 args tCOMMA args_forward rparen
@@ -1290,7 +1293,6 @@ rule
                 | k_begin
                     {
                       lexer.cmdarg.push false
-                      result = self.lexer.lineno
                     }
                     bodystmt k_end
                     {
@@ -1335,12 +1337,14 @@ rule
                     {
                       result = wrap :colon3, val[1]
                     }
-                | tLBRACK { result = lexer.lineno } aref_args tRBRACK
+                | tLBRACK { result = lexer.lineno } aref_args rbracket
                     {
-                      _, line, args, _ = val
+                      _, line, args, (_, line_max) = val
+
                       result = args || s(:array)
                       result.sexp_type = :array # aref_args is :args
                       result.line line
+                      result.line_max = line_max
                     }
                 | tLBRACE
                     {
@@ -1453,9 +1457,6 @@ rule
                       result = new_for iter, var, body
                     }
                 | k_class
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath superclass
                     {
                       if (self.in_def || self.in_single > 0) then
@@ -1470,9 +1471,6 @@ rule
                       self.lexer.ignore_body_comments
                     }
                 | k_class tLSHFT
-                    {
-                      result = self.lexer.lineno
-                    }
                     expr
                     {
                       result = self.in_def
@@ -1491,9 +1489,6 @@ rule
                       self.lexer.ignore_body_comments
                     }
                 | k_module
-                    {
-                      result = self.lexer.lineno
-                    }
                     cpath
                     {
                       yyerror "module definition in method body" if
@@ -1942,13 +1937,19 @@ opt_block_args_tail: tCOMMA block_args_tail
                     {
                       call, args = val
 
-                      result = call.concat args.sexp_body if args
+                      result = call
+
+                      if args then
+                        call.concat args.sexp_body
+                        result.line_max = args.line_max
+                      end
                     }
                 | primary_value call_op operation2 opt_paren_args
                     {
-                      recv, call_op, (op, _line), args = val
+                      recv, call_op, (op, op_line), args = val
 
                       result = new_call recv, op.to_sym, args, call_op
+                      result.line_max = op_line unless args
                     }
                 | primary_value tCOLON2 operation2 paren_args
                     {
@@ -2674,15 +2675,17 @@ opt_block_args_tail: tCOMMA block_args_tail
 
            words: tWORDS_BEG tSPACE tSTRING_END
                     {
-                      (_, line), _, _ = val
+                      (_, line), _, (_, line_max) = val
 
                       result = s(:array).line line
+                      result.line_max = line_max
                     }
                 | tWORDS_BEG word_list tSTRING_END
                     {
-                      (_, line), list, _ = val
+                      (_, line), list, (_, line_max) = val
 
                       result = list.line line
+                      result.line_max = line_max
                     }
 
        word_list: none
@@ -2702,15 +2705,17 @@ opt_block_args_tail: tCOMMA block_args_tail
 
          symbols: tSYMBOLS_BEG tSPACE tSTRING_END
                     {
-                      (_, line), _, _ = val
+                      (_, line), _, (_, line_max) = val
 
                       result = s(:array).line line
+                      result.line_max = line_max
                     }
                 | tSYMBOLS_BEG symbol_list tSTRING_END
                     {
-                      (_, line), list, _, = val
-                      list.line line
-                      result = list
+                      (_, line), list, (_, line_max), = val
+
+                      result = list.line line
+                      result.line_max = line_max
                     }
 
      symbol_list: none
@@ -2725,28 +2730,32 @@ opt_block_args_tail: tCOMMA block_args_tail
 
           qwords: tQWORDS_BEG tSPACE tSTRING_END
                     {
-                      (_, line), _, _ = val
+                      (_, line), _, (_, line_max) = val
 
                       result = s(:array).line line
+                      result.line_max = line_max
                     }
                 | tQWORDS_BEG qword_list tSTRING_END
                     {
-                      (_, line), list, _ = val
+                      (_, line), list, (_, line_max) = val
 
                       result = list.line line
+                      result.line_max = line_max
                     }
 
         qsymbols: tQSYMBOLS_BEG tSPACE tSTRING_END
                     {
-                      (_, line), _, _ = val
+                      (_, line), _, (_, line_max) = val
 
                       result = s(:array).line line
+                      result.line_max = line_max
                     }
                 | tQSYMBOLS_BEG qsym_list tSTRING_END
                     {
-                      (_, line), list, _ = val
+                      (_, line), list, (_, line_max) = val
 
                       result = list.line line
+                      result.line_max = line_max
                     }
 
       qword_list: none
@@ -3197,7 +3206,14 @@ keyword_variable: kNIL      { result = s(:nil).line lexer.lineno }
                         result = s(:args, list).line list.line
                       end
 
-                      result << (Sexp === item ? item : item.first)
+                      if Sexp === item then
+                        line_max = item.line_max
+                      else
+                        item, line_max = item
+                      end
+
+                      result << item
+                      result.line_max = line_max
                     }
 
 #if V == 20
@@ -3449,7 +3465,15 @@ keyword_variable: kNIL      { result = s(:nil).line lexer.lineno }
        opt_terms:  | terms
           opt_nl:  | tNL
           rparen: opt_nl tRPAREN
+                    {
+                      _, close = val
+                      result = [close, lexer.lineno]
+                    }
         rbracket: opt_nl tRBRACK
+                    {
+                      _, close = val
+                      result = [close, lexer.lineno]
+                    }
 #if V >= 27
           rbrace: opt_nl tRCURLY
 #endif

data/lib/ruby_parser_extras.rb

@@ -18,7 +18,7 @@ class Sexp
   end
 
   ##
-  # Returns the maximum line number of the children of self.
+  # Returns the minimum line number of the children of self.
 
   def line_min
     @line_min ||= [self.deep_each.map(&:line).min, self.line].compact.min
@@ -30,7 +30,7 @@ class Sexp
 end
 
 module RubyParserStuff
-  VERSION = "3.20.0"
+  VERSION = "3.20.2"
 
   attr_accessor :lexer, :in_def, :in_single, :file
   attr_accessor :in_kwarg
@@ -153,6 +153,7 @@ module RubyParserStuff
       result.line lexer.lineno
     else
       result.line ss.first.line
+      result.line_max = ss.first.line_max
     end
 
     args.each do |arg|
@@ -330,9 +331,8 @@ module RubyParserStuff
     end
 
     args.each do |arg|
-      if arg.instance_of? Array and arg.size == 2 and arg.last.is_a? Numeric then
-        arg = arg.first
-      end
+      # ruby 3.0+ TODO: next if arg in [String, Integer] # eg ["(", 1]
+      next if arg.class == Array && arg.map(&:class) == [String, Integer]
 
       case arg
       when Sexp then
@@ -794,6 +794,7 @@ module RubyParserStuff
     case lhs.sexp_type
     when :lasgn, :iasgn, :cdecl, :cvdecl, :gasgn, :cvasgn, :attrasgn, :safe_attrasgn then
       lhs << rhs
+      lhs.line_max = rhs.line_max
     when :const then
       lhs.sexp_type = :cdecl
       lhs << rhs
@@ -823,10 +824,10 @@ module RubyParserStuff
   end
 
   def new_begin val
-    _, lineno, body, _ = val
+    (_, line), _, body, _ = val
 
     result = body ? s(:begin, body) : s(:nil)
-    result.line lineno
+    result.line line
 
     result
   end
@@ -885,12 +886,13 @@ module RubyParserStuff
     # TODO: need a test with f(&b) to produce block_pass
     # TODO: need a test with f(&b) { } to produce warning
 
-    if args
+    if args then
       if ARG_TYPES[args.sexp_type] then
         result.concat args.sexp_body
       else
         result << args
       end
+      result.line_max = args.line_max
     end
 
     # line = result.grep(Sexp).map(&:line).compact.min
@@ -926,8 +928,7 @@ module RubyParserStuff
   end
 
   def new_class val
-    # TODO: get line from class keyword
-    line, path, superclass, body = val[1], val[2], val[3], val[5]
+    (_, line), path, superclass, _, body, (_, line_max) = val
 
     path = path.first if path.instance_of? Array
 
@@ -942,6 +943,7 @@ module RubyParserStuff
     end
 
     result.line = line
+    result.line_max = line_max
     result.comments = self.comments.pop
     result
   end
@@ -970,13 +972,14 @@ module RubyParserStuff
   end
 
   def new_defn val
-    _, (name, line), in_def, args, body, _ = val
+    _, (name, line), in_def, args, body, (_, line_max) = val
 
     body ||= s(:nil).line line
 
     args.line line
 
     result = s(:defn, name.to_sym, args).line line
+    result.line_max = line_max
 
     if body.sexp_type == :block then
       result.push(*body.sexp_body)
@@ -1033,13 +1036,14 @@ module RubyParserStuff
   end
 
   def new_defs val
-    _, recv, (name, line), in_def, args, body, _ = val
+    _, recv, (name, line), in_def, args, body, (_, line_max) = val
 
     body ||= s(:nil).line line
 
     args.line line
 
     result = s(:defs, recv, name.to_sym, args).line line
+    result.line_max = line_max
 
     # TODO: remove_begin
     # TODO: reduce_nodes
@@ -1204,12 +1208,12 @@ module RubyParserStuff
   end
 
   def new_module val
-    # TODO: get line from module keyword
-    line, path, body = val[1], val[2], val[4]
+    (_, line_min), path, _, body, (_, line_max) = val
 
     path = path.first if path.instance_of? Array
 
-    result = s(:module, path).line line
+    result = s(:module, path).line line_min
+    result.line_max = line_max
 
     if body then # REFACTOR?
       if body.sexp_type == :block then
@@ -1291,9 +1295,10 @@ module RubyParserStuff
   end
 
   def new_regexp val
-    (_, line), node, (options, _) = val
+    (_, line), node, (options, line_max) = val
 
     node ||= s(:str, "").line line
+    node.line_max = line_max
 
     o, k = 0, nil
     options.split(//).uniq.each do |c| # FIX: this has a better home
@@ -1361,7 +1366,7 @@ module RubyParserStuff
   end
 
   def new_sclass val
-    recv, in_def, in_single, body = val[3], val[4], val[6], val[7]
+    (_, line), _, recv, in_def, _, in_single, body, _ = val
 
     result = s(:sclass, recv)
 
@@ -1373,7 +1378,7 @@ module RubyParserStuff
       end
     end
 
-    result.line = val[2]
+    result.line = line
     self.in_def = in_def
     self.in_single = in_single
     result

data/test/test_ruby_parser.rb

@@ -15,11 +15,26 @@ class Sexp
   def == other # :nodoc:
     if other.class == self.class then
       super and
-        (line.nil? or other.line.nil? or line == other.line)
+        (line.nil?     or other.line.nil?     or line == other.line) and
+        (!defined?(@line_max) or @line_max.nil? or line_max == other.line_max)
+        # (line_max.nil? or other.line_max.nil? or line_max == other.line_max)
     else
       false
     end
   end
+
+  # convenience function just for testing
+  alias dead line_max
+  def line_max n = UNASSIGNED
+    if n != UNASSIGNED then
+      raise ArgumentError, "setting %p.line_max %p" % [self, n] unless Integer === n
+      @line_max = n
+      self
+    else
+      # raise "Accessing before @line_max defined" unless defined?(@line_max)
+      @line_max ||= self.deep_each.map(&:line).compact.max
+    end
+  end
 end
 
 module TestRubyParserShared
@@ -117,11 +132,13 @@ module TestRubyParserShared
     # for the array. Luckily, the arary elements all seemt to get the correct
     # line number.
     rb = "[\n'a',\n'b']\n1"
+
     pt = s(:block,
            s(:array,
              s(:str, "a").line(2),
-             s(:str, "b").line(3)),
+             s(:str, "b").line(3)).line(1),
            s(:lit, 1).line(4)).line 1
+
     assert_parse rb, pt
   end
 
@@ -965,7 +982,12 @@ module TestRubyParserShared
   end
 
   def test_heredoc_with_extra_carriage_horrible_mix?
-    rb = "<<'eot'\r\nbody\r\neot\n"
+    rb = <<~RUBY
+      <<'eot'\r
+      body\r
+      eot
+    RUBY
+
     pt = s(:str, "body\r\n")
 
     assert_parse rb, pt
@@ -1051,9 +1073,9 @@ module TestRubyParserShared
   end
 
   def test_i_fucking_hate_line_numbers2
-    rb = <<-EOM.gsub(/^ {6}/, "")
+    rb = <<~EOM
       if true then
-        p('a')
+        p("a")
         b = 1
         p b
         c =1
@@ -1074,6 +1096,138 @@ module TestRubyParserShared
     assert_parse rb, pt
   end
 
+  line_max_array = s(:array,
+                     s(:lit, :line2).line(2),
+                     s(:lit, :line3).line(3)).line(1).line_max(4)
+  line_max_array_empty = s(:array).line(1).line_max(4)
+  [
+    [:plain_array,
+     "[\n:line2,\n:line3\n]",
+     line_max_array,
+    ],
+    [:pct_i,
+     "%i[\nline2\nline3\n]",
+     line_max_array,
+    ],
+    [:pct_i_empty,
+     "%i[\n\n\n]",
+     line_max_array_empty,
+    ],
+    [:pct_I,
+     "%I[\nline2\nline3\n]",
+     line_max_array,
+    ],
+    [:pct_I_empty,
+     "%I[\n\n\n]",
+     line_max_array_empty,
+    ],
+    [:call_parens,
+     "x(\n:line2,\n:line3\n)",
+     s(:call, nil, :x, *line_max_array.sexp_body).line(1).line_max(4),
+    ],
+    [:pct_w,
+     "%w[\nline2\nline3\n]",
+     s(:array,
+       s(:str, "line2").line(2),
+       s(:str, "line3").line(3)).line(1).line_max(4),
+    ],
+    [:pct_w_empty,
+     "%w[\n\n\n]",
+     line_max_array_empty,
+    ],
+    [:pct_W,
+     "%W[\nline2\nline3\n]",
+     s(:array,
+       s(:str, "line2").line(2),
+       s(:str, "line3").line(3)).line(1).line_max(4),
+    ],
+    [:pct_W_empty,
+     "%W[\n\n\n]",
+     line_max_array_empty,
+    ],
+    [:regexp,
+     "%r[\n\n\n]", # double-quotes to have the \n counted as lines on input
+     s(:lit, %r[#{"\n\n\n"}]).line(1).line_max(4),
+    ],
+    [:module,
+     <<~"RUBY",
+       module X   # line 1
+         module Y # line 2
+           Z = 42 # line 3
+         end      # line 4
+       end        # line 5
+     RUBY
+     s(:module, :X,
+       s(:module, :Y,
+         s(:cdecl, :Z, s(:lit, 42).line(3)).line(3).line_max(3)
+        ).line(2).line_max(4)
+      ).line(1).line_max(5)],
+    [:class,
+     <<~"RUBY",
+       class X    # line 1
+         class Y  # line 2
+           Z = 42 # line 3
+         end      # line 4
+       end        # line 5
+     RUBY
+     s(:class, :X, nil,
+       s(:class, :Y, nil,
+         s(:cdecl, :Z, s(:lit, 42).line(3)).line(3).line_max(3)
+        ).line(2).line_max(4)
+      ).line(1).line_max(5)],
+    [:cdecl,
+     <<~"RUBY",
+       module X
+         X = [
+           :line3,
+           :line4,
+         ]
+       end
+     RUBY
+     s(:module, :X,
+       s(:cdecl, :X,
+         s(:array,
+           s(:lit, :line3).line(3),
+           s(:lit, :line4).line(4)).line(2).line_max(5),
+        ).line(2).line_max(5),
+      ).line(1).line_max(6)
+    ],
+    [:defn,
+     <<~"RUBY",
+       class X    # line 1
+         def y(a, # line 2
+               b) # line 3
+           a + b  # line 4
+         end      # line 5
+       end        # line 6
+     RUBY
+     s(:class, :X, nil,
+       s(:defn, :y, s(:args, :a, :b).line(2).line_max(3),
+         s(:call, s(:lvar, :a).line(4), :+, s(:lvar, :b).line(4)).line(4)
+        ).line(2).line_max(5),
+      ).line(1).line_max(6),
+    ],
+    [:defs,
+     <<~"RUBY",
+       class X         # line 1
+         def self.y(a, # line 2
+               b)      # line 3
+           a + b       # line 4
+         end           # line 5
+       end             # line 6
+     RUBY
+     s(:class, :X, nil,
+       s(:defs, s(:self).line(2), :y, s(:args, :a, :b).line(2).line_max(3),
+         s(:call, s(:lvar, :a).line(4), :+, s(:lvar, :b).line(4)).line(4)
+        ).line(2).line_max(5),
+      ).line(1).line_max(6),
+    ],
+  ].each do |(name, rb, pt)|
+    define_method "test_line_numbers__max_line__#{name}" do
+      assert_parse rb, pt
+    end
+  end
+
   def test_if_elsif
     rb = "if 1; elsif 2; end"
     pt = s(:if, s(:lit, 1), nil, s(:if, s(:lit, 2), nil, nil))
@@ -5480,6 +5634,34 @@ end
 
 module TestRubyParserShared32Plus
   include TestRubyParserShared31Plus
+
+  def test_args_star__anon_solo
+    rb = "f(*)"
+    pt = s(:call, nil, :f, s(:splat))
+
+    assert_parse rb, pt
+  end
+
+  def test_args_star__anon_trailing
+    rb = "f(x, *)"
+    pt = s(:call, nil, :f, s(:call, nil, :x), s(:splat))
+
+    assert_parse rb, pt
+  end
+
+  def test_args_dstar__anon_solo
+    rb = "f(**)"
+    pt = s(:call, nil, :f, s(:hash, s(:kwsplat))) # TODO double check this
+
+    assert_parse rb, pt
+  end
+
+  def test_args_dstar__anon_trailing
+    rb = "f(x, **)"
+    pt = s(:call, nil, :f, s(:call, nil, :x), s(:hash, s(:kwsplat))) # TODO double check this
+
+    assert_parse rb, pt
+  end
 end
 
 class Minitest::Test
@@ -5782,8 +5964,6 @@ class TestRubyParserV26 < RubyParserTestCase
 end
 
 class TestRubyParserV27 < RubyParserTestCase
-  make_my_diffs_pretty!
-
   include TestRubyParserShared27Plus
 
   def setup

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_parser
 version: !ruby/object:Gem::Version
-  version: 3.20.0
+  version: 3.20.2
 platform: ruby
 authors:
 - Ryan Davis
@@ -29,7 +29,7 @@ cert_chain:
   ROfWo9Uyp8ba/j9eVG14KkYRaLydAY1MNQk2yd3R5CGfeOpD1kttxjoypoUJ2dOG
   nsNBRuQJ1UfiCG97a6DNm+Fr
   -----END CERTIFICATE-----
-date: 2023-03-04 00:00:00.000000000 Z
+date: 2023-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
@@ -245,7 +245,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: ruby_parser (RP) is a ruby parser written in pure ruby (utilizing racc--which