ruby_native 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 354cc245f5601b5e39b3cbba720da1fe06edf675eb373e22eb1028b2c27056ce
-  data.tar.gz: 38080a8029fbffa2c920cd734196a88377f6b20967b83f9f947eab37835f46c6
+  metadata.gz: c596379ed0170d7784e8273e1ac3c10023ebc6115a7d8a7d1edb2633f7325449
+  data.tar.gz: b966e8aeb40899fa32ff8f34f85dffc031b073f0637cf1917083f43ce504e06a
 SHA512:
-  metadata.gz: 92f68b9731f743efd5aece5debb221c4963a93b373f9c76997dc688eba4f6da85b3eb3832efa457ebca0a0ed93d36a2b8417d0af5efa2fb23e8ce64734ac7002
-  data.tar.gz: 3142eea082eab9acc7f279173ca731452cd3e21f58a1d491470b61433204bed26a35f81f71ca6fad60ac7271fb776931872215867d6fbc574682605ee7b8286f
+  metadata.gz: fbddcd87a18dc14cd8eacdf1b4456c6cacc41c2f26c76e3dc0d6d2383b8c40a76de274901d3456d2ee40a79f56edd3b17d0a9510918e7a67adc9d6fa675f57d3
+  data.tar.gz: 1d9bbb26a648e42952fd11de6d63cb65286d8247e5c847fbd2007760de213ed371f5ff6a61372f582a9cfe75b26fb10f8b11f6c5187187f415af4c511021a748

data/lib/ruby_native/helper.rb

@@ -131,14 +131,43 @@ module RubyNative
     # form (`{ ios: "...", android: "..." }`). When both are given, a matching
     # `icons[platform]` wins; otherwise falls back to `icon`. Returns nil when
     # nothing resolves.
+    #
+    # A non-Hash `icons:` raises rather than falling through. `icons: [ios:
+    # "...", android: "..."]` is an easy slip in ERB and yields an Array holding
+    # one Hash, which used to skip the lookup and fall back to `icon` — usually
+    # nil, so the button rendered with no icon on either platform and nothing
+    # said why. That reads as "per-platform icons are broken" rather than "wrong
+    # bracket," and it is invisible on whichever platform you aren't testing.
     def self.resolve_icon(icon: nil, icons: nil, platform: nil)
+      if !icons.nil? && !icons.is_a?(Hash)
+        raise ArgumentError,
+          "icons: must be a Hash like { ios: \"square.and.arrow.up\", android: \"share\" }, " \
+          "got #{icons.class}. Check for square brackets instead of curly braces."
+      end
+
       if icons.is_a?(Hash) && platform
         key = platform.to_sym
         per_platform = icons[key] || icons[key.to_s]
         return per_platform if per_platform
       end
-      icon
+
+      # Nothing matched, which is every web render: `native_platform` is nil in
+      # a browser. Fall back to `icon:`, then to any name in `icons:`, the same
+      # order `RubyNative.backfill_tab_icons` uses for the YAML config.
+      #
+      # Returning nil here instead would make `icons:` alone unusable, because
+      # `native_fab_tag` raises on a nil icon and would 500 a page that renders
+      # fine inside the app. The signal element is hidden and only read by the
+      # native app, so which name survives on the web doesn't matter.
+      icon || fallback_icon(icons)
+    end
+
+    def self.fallback_icon(icons)
+      return nil unless icons.is_a?(Hash)
+
+      icons[:ios] || icons["ios"] || icons[:android] || icons["android"]
     end
+    private_class_method :fallback_icon
 
     class NavbarBuilder
       def initialize(context)

data/lib/ruby_native/version.rb

@@ -1,3 +1,3 @@
 module RubyNative
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_native
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Joe Masilotti