ruby_llm-mcp 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c8d0ab416033fcafeed6caa5146ab4c5599d0576eb3a17b2e0c04bb4bbb2234
-  data.tar.gz: 207026831043126a1e0dfac10fbbe9e8a396edbe8ab874c8af04d1230d57de5c
+  metadata.gz: b40509c28a60e1ae01ed83d47503d76f30d5f3bf9852ef4c30ca033d6ea149bc
+  data.tar.gz: f3393dc6423c6bcda143cb6b22e7042434ca1d7d385cc2adf97ba925efff6912
 SHA512:
-  metadata.gz: 4fbae5a8e05f3df2ee2ef81469a7ca8159b03cde998c5881e6e32ab0353cdb22a3b03a3cf63e3464f95e05f71ed87f861d793e944683c72c90660162fb6263e5
-  data.tar.gz: 9888713bcb543421c389954a36d235f024e271163096a82473c4bf1b1c2b16737602c0b608ff28d653cf1ab636909f0b9c6120e228b74ecdc794f2b0ebfc3dc4
+  metadata.gz: 86e6dd3009df055ad4fa6d088b6b1d9fb87cc8c6244b1436e4ef96ef1cbd822c321c779bd518557544a6c457d19270bf1a57c874cb6d80543141ecac7c370754
+  data.tar.gz: 5a76f9b2aaf2d3db38d97c9d66341458e25f3cdd89fdaf1768095a1bba20257154e128c9b60245f1f09f3e6f09b967daacd70748008c4edf90c3e836546bd6d6

data/lib/ruby_llm/mcp/transports/stdio.rb

@@ -78,51 +78,23 @@ module RubyLLM
           @running = true
         end
 
-        def close # rubocop:disable Metrics/MethodLength
+        def close
           @running = false
 
-          begin
-            @stdin&.close
-          rescue StandardError
-            nil
-          end
-
-          begin
-            @wait_thread&.join(1)
-          rescue StandardError
+          [@stdin, @stdout, @stderr].each do |stream|
+            stream&.close
+          rescue IOError, Errno::EBADF
             nil
           end
 
-          begin
-            @stdout&.close
-          rescue StandardError
-            nil
-          end
-
-          begin
-            @stderr&.close
+          [@wait_thread, @reader_thread, @stderr_thread].each do |thread|
+            thread&.join(1)
           rescue StandardError
             nil
           end
 
-          begin
-            @reader_thread&.join(1)
-          rescue StandardError
-            nil
-          end
-
-          begin
-            @stderr_thread&.join(1)
-          rescue StandardError
-            nil
-          end
-
-          @stdin = nil
-          @stdout = nil
-          @stderr = nil
-          @wait_thread = nil
-          @reader_thread = nil
-          @stderr_thread = nil
+          @stdin = @stdout = @stderr = nil
+          @wait_thread = @reader_thread = @stderr_thread = nil
         end
 
         def set_protocol_version(version)
@@ -151,58 +123,88 @@ module RubyLLM
 
         def start_reader_thread
           @reader_thread = Thread.new do
-            while @running
-              begin
-                if @stdout.closed? || @wait_thread.nil? || !@wait_thread.alive?
-                  sleep 1
-                  restart_process if @running
-                  next
-                end
-
-                line = @stdout.gets
-                next unless line && !line.strip.empty?
-
-                process_response(line.strip)
-              rescue IOError, Errno::EPIPE => e
-                RubyLLM::MCP.logger.error "Reader error: #{e.message}. Restarting in 1 second..."
-                sleep 1
-                restart_process if @running
-              rescue StandardError => e
-                RubyLLM::MCP.logger.error "Error in reader thread: #{e.message}, #{e.backtrace.join("\n")}"
-                sleep 1
-              end
-            end
+            read_stdout_loop
           end
 
           @reader_thread.abort_on_exception = true
         end
 
+        def read_stdout_loop
+          while @running
+            begin
+              handle_stdout_read
+            rescue IOError, Errno::EPIPE => e
+              handle_stream_error(e, "Reader")
+              break unless @running
+            rescue StandardError => e
+              RubyLLM::MCP.logger.error "Error in reader thread: #{e.message}, #{e.backtrace.join("\n")}"
+              sleep 1
+            end
+          end
+        end
+
+        def handle_stdout_read
+          if @stdout.closed? || @wait_thread.nil? || !@wait_thread.alive?
+            if @running
+              sleep 1
+              restart_process
+            end
+            return
+          end
+
+          line = @stdout.gets
+          return unless line && !line.strip.empty?
+
+          process_response(line.strip)
+        end
+
+        def handle_stream_error(error, stream_name)
+          # Check @running to distinguish graceful shutdown from unexpected errors.
+          # During shutdown, streams are closed intentionally and shouldn't trigger restarts.
+          if @running
+            RubyLLM::MCP.logger.error "#{stream_name} error: #{error.message}. Restarting in 1 second..."
+            sleep 1
+            restart_process
+          else
+            # Graceful shutdown in progress
+            RubyLLM::MCP.logger.debug "#{stream_name} thread exiting during shutdown"
+          end
+        end
+
         def start_stderr_thread
           @stderr_thread = Thread.new do
-            while @running
-              begin
-                if @stderr.closed? || @wait_thread.nil? || !@wait_thread.alive?
-                  sleep 1
-                  next
-                end
-
-                line = @stderr.gets
-                next unless line && !line.strip.empty?
-
-                RubyLLM::MCP.logger.info(line.strip)
-              rescue IOError, Errno::EPIPE => e
-                RubyLLM::MCP.logger.error "Stderr reader error: #{e.message}"
-                sleep 1
-              rescue StandardError => e
-                RubyLLM::MCP.logger.error "Error in stderr thread: #{e.message}"
-                sleep 1
-              end
-            end
+            read_stderr_loop
           end
 
           @stderr_thread.abort_on_exception = true
         end
 
+        def read_stderr_loop
+          while @running
+            begin
+              handle_stderr_read
+            rescue IOError, Errno::EPIPE => e
+              handle_stream_error(e, "Stderr reader")
+              break unless @running
+            rescue StandardError => e
+              RubyLLM::MCP.logger.error "Error in stderr thread: #{e.message}"
+              sleep 1
+            end
+          end
+        end
+
+        def handle_stderr_read
+          if @stderr.closed? || @wait_thread.nil? || !@wait_thread.alive?
+            sleep 1
+            return
+          end
+
+          line = @stderr.gets
+          return unless line && !line.strip.empty?
+
+          RubyLLM::MCP.logger.info(line.strip)
+        end
+
         def process_response(line)
           response = JSON.parse(line)
           request_id = response["id"]&.to_s

data/lib/ruby_llm/mcp/version.rb

@@ -2,6 +2,6 @@
 
 module RubyLLM
   module MCP
-    VERSION = "0.7.0"
+    VERSION = "0.7.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_llm-mcp
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Patrick Vice
@@ -145,7 +145,6 @@ metadata:
   homepage_uri: https://www.rubyllm-mcp.com
   source_code_uri: https://github.com/patvice/ruby_llm-mcp
   changelog_uri: https://github.com/patvice/ruby_llm-mcp/commits/main
-  documentation_uri: https://www.rubyllm-mcp.com
   bug_tracker_uri: https://github.com/patvice/ruby_llm-mcp/issues
   rubygems_mfa_required: 'true'
   allowed_push_host: https://rubygems.org