ruby_llm-agents 3.1.0 → 3.2.0

data/lib/ruby_llm/agents/infrastructure/budget/spend_recorder.rb

@@ -61,7 +61,7 @@ module RubyLLM
           # @return [Float] New total
           def increment_spend(scope, period, amount, agent_type: nil, tenant_id: nil)
             key = budget_cache_key(scope, period, agent_type: agent_type, tenant_id: tenant_id)
-            ttl = period == :daily ? 1.day : 31.days
+            ttl = (period == :daily) ? 1.day : 31.days
 
             # Read-modify-write for float values (cache increment is for integers)
             current = (SpendRecorder.cache_read(key) || 0).to_f
@@ -81,7 +81,7 @@ module RubyLLM
           def increment_tokens(scope, period, tokens, agent_type: nil, tenant_id: nil)
             # For now, we only track global token usage (not per-agent)
             key = token_cache_key(period, tenant_id: tenant_id)
-            ttl = period == :daily ? 1.day : 31.days
+            ttl = (period == :daily) ? 1.day : 31.days
 
             current = (SpendRecorder.cache_read(key) || 0).to_i
             new_total = current + tokens
@@ -102,7 +102,7 @@ module RubyLLM
           # @param period [Symbol] :daily or :monthly
           # @return [String] Date string
           def date_key_part(period)
-            period == :daily ? Date.current.to_s : Date.current.strftime("%Y-%m")
+            (period == :daily) ? Date.current.to_s : Date.current.strftime("%Y-%m")
           end
 
           # Generates an alert cache key
@@ -156,28 +156,28 @@ module RubyLLM
           def check_soft_cap_alerts(agent_type, tenant_id, budget_config)
             # Check global daily
             check_budget_alert(:global_daily, budget_config[:global_daily],
-                              BudgetQuery.current_spend(:global, :daily, tenant_id: tenant_id),
-                              agent_type, tenant_id, budget_config)
+              BudgetQuery.current_spend(:global, :daily, tenant_id: tenant_id),
+              agent_type, tenant_id, budget_config)
 
             # Check global monthly
             check_budget_alert(:global_monthly, budget_config[:global_monthly],
-                              BudgetQuery.current_spend(:global, :monthly, tenant_id: tenant_id),
-                              agent_type, tenant_id, budget_config)
+              BudgetQuery.current_spend(:global, :monthly, tenant_id: tenant_id),
+              agent_type, tenant_id, budget_config)
 
             # Check per-agent daily
             agent_daily_limit = budget_config[:per_agent_daily]&.dig(agent_type)
             if agent_daily_limit
               check_budget_alert(:per_agent_daily, agent_daily_limit,
-                                BudgetQuery.current_spend(:agent, :daily, agent_type: agent_type, tenant_id: tenant_id),
-                                agent_type, tenant_id, budget_config)
+                BudgetQuery.current_spend(:agent, :daily, agent_type: agent_type, tenant_id: tenant_id),
+                agent_type, tenant_id, budget_config)
             end
 
             # Check per-agent monthly
             agent_monthly_limit = budget_config[:per_agent_monthly]&.dig(agent_type)
             if agent_monthly_limit
               check_budget_alert(:per_agent_monthly, agent_monthly_limit,
-                                BudgetQuery.current_spend(:agent, :monthly, agent_type: agent_type, tenant_id: tenant_id),
-                                agent_type, tenant_id, budget_config)
+                BudgetQuery.current_spend(:agent, :monthly, agent_type: agent_type, tenant_id: tenant_id),
+                agent_type, tenant_id, budget_config)
             end
           end
 
@@ -194,7 +194,7 @@ module RubyLLM
             return unless limit
             return if current <= limit
 
-            event = budget_config[:enforcement] == :hard ? :budget_hard_cap : :budget_soft_cap
+            event = (budget_config[:enforcement] == :hard) ? :budget_hard_cap : :budget_soft_cap
 
             # Prevent duplicate alerts by using a cache key (include tenant for isolation)
             key = alert_cache_key("budget_alert", scope, tenant_id)
@@ -221,13 +221,13 @@ module RubyLLM
           def check_soft_token_alerts(agent_type, tenant_id, budget_config)
             # Check global daily tokens
             check_token_alert(:global_daily_tokens, budget_config[:global_daily_tokens],
-                             BudgetQuery.current_tokens(:daily, tenant_id: tenant_id),
-                             agent_type, tenant_id, budget_config)
+              BudgetQuery.current_tokens(:daily, tenant_id: tenant_id),
+              agent_type, tenant_id, budget_config)
 
             # Check global monthly tokens
             check_token_alert(:global_monthly_tokens, budget_config[:global_monthly_tokens],
-                             BudgetQuery.current_tokens(:monthly, tenant_id: tenant_id),
-                             agent_type, tenant_id, budget_config)
+              BudgetQuery.current_tokens(:monthly, tenant_id: tenant_id),
+              agent_type, tenant_id, budget_config)
           end
 
           # Checks if a token alert should be fired
@@ -243,7 +243,7 @@ module RubyLLM
             return unless limit
             return if current <= limit
 
-            event = budget_config[:enforcement] == :hard ? :token_hard_cap : :token_soft_cap
+            event = (budget_config[:enforcement] == :hard) ? :token_hard_cap : :token_soft_cap
 
             # Prevent duplicate alerts
             key = alert_cache_key("token_alert", scope, tenant_id)

data/lib/ruby_llm/agents/infrastructure/circuit_breaker.rb

@@ -30,6 +30,7 @@ module RubyLLM
     # @api public
     class CircuitBreaker
       include CacheHelper
+
       attr_reader :agent_type, :model_id, :tenant_id, :errors_threshold, :window_seconds, :cooldown_seconds
 
       # @param agent_type [String] The agent class name

data/lib/ruby_llm/agents/infrastructure/execution_logger_job.rb

@@ -33,7 +33,7 @@ module RubyLLM
         execution = Execution.create!(filtered_data)
 
         # Create detail record if present
-        if detail_data && detail_data.values.any? { |v| v.present? && v != {} && v != [] }
+        if detail_data&.values&.any? { |v| v.present? && v != {} && v != [] }
           execution.create_detail!(detail_data)
         end
 

data/lib/ruby_llm/agents/infrastructure/reliability.rb

@@ -108,11 +108,11 @@ module RubyLLM
 
           @attempts.filter_map do |attempt|
             if attempt["short_circuited"]
-              { model: attempt["model_id"], error_class: "CircuitBreakerOpen", error_message: "circuit breaker open",
-                error_backtrace: nil }
+              {model: attempt["model_id"], error_class: "CircuitBreakerOpen", error_message: "circuit breaker open",
+               error_backtrace: nil}
             elsif attempt["error_class"]
-              { model: attempt["model_id"], error_class: attempt["error_class"], error_message: attempt["error_message"],
-                error_backtrace: attempt["error_backtrace"] }
+              {model: attempt["model_id"], error_class: attempt["error_class"], error_message: attempt["error_message"],
+               error_backtrace: attempt["error_backtrace"]}
             end
           end
         end
@@ -125,11 +125,11 @@ module RubyLLM
               if attempt["short_circuited"]
                 parts << "  #{model}: circuit breaker open"
               elsif attempt["error_class"]
-                parts << "  #{model}: #{attempt['error_class']} - #{attempt['error_message']}"
+                parts << "  #{model}: #{attempt["error_class"]} - #{attempt["error_message"]}"
               end
             end
           else
-            parts << "  Models: #{@models_tried.join(', ')}"
+            parts << "  Models: #{@models_tried.join(", ")}"
             parts << "  Last error: #{@last_error.message}"
           end
           parts.join("\n")

data/lib/ruby_llm/agents/pipeline/builder.rb

@@ -164,7 +164,7 @@ module RubyLLM
           # @return [Boolean]
           def budgets_enabled?
             RubyLLM::Agents.configuration.budgets_enabled?
-          rescue StandardError
+          rescue
             false
           end
 
@@ -176,7 +176,7 @@ module RubyLLM
             return false unless agent_class
 
             agent_class.respond_to?(:cache_enabled?) && agent_class.cache_enabled?
-          rescue StandardError
+          rescue
             false
           end
 
@@ -192,20 +192,20 @@ module RubyLLM
             return false unless agent_class
 
             retries = if agent_class.respond_to?(:retries)
-                        agent_class.retries
-                      else
-                        0
-                      end
+              agent_class.retries
+            else
+              0
+            end
 
             fallbacks = if agent_class.respond_to?(:fallback_models)
-                          agent_class.fallback_models
-                        else
-                          []
-                        end
+              agent_class.fallback_models
+            else
+              []
+            end
 
             (retries.is_a?(Integer) && retries.positive?) ||
               (fallbacks.is_a?(Array) && fallbacks.any?)
-          rescue StandardError
+          rescue
             false
           end
         end

data/lib/ruby_llm/agents/pipeline/middleware/budget.rb

@@ -51,7 +51,7 @@ module RubyLLM
           # @return [Boolean]
           def budgets_enabled?
             global_config.budgets_enabled?
-          rescue StandardError
+          rescue
             false
           end
 
@@ -78,7 +78,7 @@ module RubyLLM
             )
           rescue RubyLLM::Agents::Reliability::BudgetExceededError
             raise
-          rescue StandardError => e
+          rescue => e
             error("Budget check failed: #{e.message}")
           end
 
@@ -117,7 +117,7 @@ module RubyLLM
                 tenant_id: context.tenant_id
               )
             end
-          rescue StandardError => e
+          rescue => e
             error("Failed to record spend: #{e.message}")
           end
         end

data/lib/ruby_llm/agents/pipeline/middleware/cache.rb

@@ -71,7 +71,7 @@ module RubyLLM
           # @return [ActiveSupport::Cache::Store, nil]
           def cache_store
             global_config.cache_store
-          rescue StandardError
+          rescue
             nil
           end
 
@@ -130,7 +130,7 @@ module RubyLLM
             else
               input.to_json
             end
-          rescue StandardError
+          rescue
             input.to_s
           end
 
@@ -140,7 +140,7 @@ module RubyLLM
           # @return [Object, nil] Cached value or nil
           def cache_read(key)
             cache_store.read(key)
-          rescue StandardError => e
+          rescue => e
             error("Cache read failed: #{e.message}")
             nil
           end
@@ -154,7 +154,7 @@ module RubyLLM
             options[:expires_in] = cache_ttl if cache_ttl
 
             cache_store.write(key, value, **options)
-          rescue StandardError => e
+          rescue => e
             error("Cache write failed: #{e.message}")
           end
         end

data/lib/ruby_llm/agents/pipeline/middleware/instrumentation.rb

@@ -52,10 +52,10 @@ module RubyLLM
               begin
                 complete_execution(execution, context, status: "success")
                 status_update_completed = true
-              rescue StandardError
+              rescue
                 # Let ensure block handle via mark_execution_failed!
               end
-            rescue StandardError => e
+            rescue => e
               context.completed_at = Time.current
               context.error = e
               raised_exception = e
@@ -63,7 +63,7 @@ module RubyLLM
               begin
                 complete_execution(execution, context, status: determine_error_status(e))
                 status_update_completed = true
-              rescue StandardError
+              rescue
                 # Let ensure block handle via mark_execution_failed!
               end
 
@@ -100,7 +100,7 @@ module RubyLLM
             end
 
             execution
-          rescue StandardError => e
+          rescue => e
             error("Failed to create running execution record: #{e.message}")
             nil
           end
@@ -131,7 +131,7 @@ module RubyLLM
 
             # Save detail data (prompts, responses, tool calls, etc.)
             save_execution_details(execution, context, status)
-          rescue StandardError => e
+          rescue => e
             error("Failed to complete execution record: #{e.message}")
             raise # Re-raise for ensure block to handle via mark_execution_failed!
           end
@@ -160,16 +160,16 @@ module RubyLLM
 
             # Store error_message in detail table (best-effort)
             begin
-              detail_attrs = { error_message: error_message }
+              detail_attrs = {error_message: error_message}
               if execution.detail
                 execution.detail.update_columns(detail_attrs)
               else
                 RubyLLM::Agents::ExecutionDetail.create!(detail_attrs.merge(execution_id: execution.id))
               end
-            rescue StandardError
+            rescue
               # Non-critical
             end
-          rescue StandardError => e
+          rescue => e
             error("CRITICAL: Failed emergency status update for execution #{execution&.id}: #{e.message}")
           end
 
@@ -223,7 +223,11 @@ module RubyLLM
             }
 
             # Store niche cache key in metadata
-            merged_metadata = context.metadata.dup rescue {}
+            merged_metadata = begin
+              context.metadata.dup
+            rescue
+              {}
+            end
             if context.cached? && context[:cache_key]
               merged_metadata["response_cache_key"] = context[:cache_key]
             end
@@ -284,7 +288,7 @@ module RubyLLM
             else
               execution.create_detail!(detail_data)
             end
-          rescue StandardError => e
+          rescue => e
             error("Failed to save execution details: #{e.message}")
           end
 
@@ -304,7 +308,7 @@ module RubyLLM
             else
               create_execution_record(data)
             end
-          rescue StandardError => e
+          rescue => e
             error("Failed to record execution: #{e.message}")
           end
 
@@ -314,7 +318,11 @@ module RubyLLM
           # @param status [String] "success" or "error"
           # @return [Hash] Execution data
           def build_execution_data(context, status)
-            merged_metadata = context.metadata.dup rescue {}
+            merged_metadata = begin
+              context.metadata.dup
+            rescue
+              {}
+            end
             if context.cached? && context[:cache_key]
               merged_metadata["response_cache_key"] = context[:cache_key]
             end
@@ -355,7 +363,7 @@ module RubyLLM
             end
 
             # Store detail data for separate creation
-            detail_data = { parameters: sanitize_parameters(context) }
+            detail_data = {parameters: sanitize_parameters(context)}
             if global_config.persist_prompts
               exec_opts = context.options[:options] || {}
               detail_data[:system_prompt] = exec_opts[:system_prompt]
@@ -396,7 +404,11 @@ module RubyLLM
           def sanitize_parameters(context)
             return {} unless context.agent_instance.respond_to?(:options, true)
 
-            params = context.agent_instance.send(:options) rescue {}
+            params = begin
+              context.agent_instance.send(:options)
+            rescue
+              {}
+            end
             params = params.dup
             params.transform_keys!(&:to_s)
 
@@ -421,7 +433,7 @@ module RubyLLM
             return "" if message.nil?
 
             message.to_s.truncate(1000)
-          rescue StandardError
+          rescue
             message.to_s[0, 1000]
           end
 
@@ -436,7 +448,7 @@ module RubyLLM
             return nil if content.nil?
 
             # Build response hash similar to core instrumentation
-            response_data = { content: content }
+            response_data = {content: content}
 
             # Add model_id if available
             response_data[:model_id] = context.model_used if context.model_used
@@ -446,7 +458,7 @@ module RubyLLM
             response_data[:output_tokens] = context.output_tokens if context.output_tokens
 
             response_data
-          rescue StandardError => e
+          rescue => e
             error("Failed to serialize response: #{e.message}")
             nil
           end
@@ -464,7 +476,7 @@ module RubyLLM
           def create_execution_record(data)
             detail_data = data.delete(:_detail_data)
             execution = Execution.create!(data)
-            if detail_data && detail_data.values.any? { |v| v.present? && v != {} && v != [] }
+            if detail_data&.values&.any? { |v| v.present? && v != {} && v != [] }
               execution.create_detail!(detail_data)
             end
             execution
@@ -487,7 +499,7 @@ module RubyLLM
             else
               cfg.track_executions
             end
-          rescue StandardError
+          rescue
             false
           end
 
@@ -496,7 +508,7 @@ module RubyLLM
           # @return [Boolean]
           def track_cache_hits?
             global_config.respond_to?(:track_cache_hits) && global_config.track_cache_hits
-          rescue StandardError
+          rescue
             false
           end
 
@@ -505,7 +517,7 @@ module RubyLLM
           # @return [Boolean]
           def async_logging?
             global_config.async_logging && defined?(Infrastructure::ExecutionLoggerJob)
-          rescue StandardError
+          rescue
             false
           end
 
@@ -520,7 +532,7 @@ module RubyLLM
             @_assistant_prompt_column_exists = begin
               defined?(RubyLLM::Agents::ExecutionDetail) &&
                 RubyLLM::Agents::ExecutionDetail.column_names.include?("assistant_prompt")
-            rescue StandardError
+            rescue
               false
             end
           end

data/lib/ruby_llm/agents/pipeline/middleware/reliability.rb

@@ -172,8 +172,7 @@ module RubyLLM
                 tracker.complete_attempt(attempt, success: true, response: context.output)
 
                 return context
-
-              rescue StandardError => e
+              rescue => e
                 context.error = e
                 breaker&.record_failure!
                 tracker.complete_attempt(attempt, success: false, error: e)
@@ -305,7 +304,7 @@ module RubyLLM
             else
               sleep(seconds)
             end
-          rescue StandardError
+          rescue
             # Fall back to regular sleep if async detection fails
             sleep(seconds)
           end

data/lib/ruby_llm/agents/pipeline/middleware/tenant.rb

@@ -79,8 +79,8 @@ module RubyLLM
                 context.tenant_config = extract_tenant_config(tenant_value)
               else
                 raise ArgumentError,
-                      "tenant must respond to :llm_tenant_id (use llm_tenant DSL), " \
-                      "or be a Hash with :id key, got #{tenant_value.class}"
+                  "tenant must respond to :llm_tenant_id (use llm_tenant DSL), " \
+                  "or be a Hash with :id key, got #{tenant_value.class}"
               end
             end
           end
@@ -106,7 +106,7 @@ module RubyLLM
               # For hash-based or string tenants, ensure a minimal record exists
               RubyLLM::Agents::Tenant.find_or_create_by!(tenant_id: context.tenant_id)
             end
-          rescue StandardError => e
+          rescue => e
             # Don't fail the execution if tenant record creation fails
             log_tenant_warning("ensure tenant record", e)
           end
@@ -117,7 +117,7 @@ module RubyLLM
           def ensure_tenant_for_model!(tenant_object)
             # Check polymorphic link first, then tenant_id
             existing = RubyLLM::Agents::Tenant.find_by(tenant_record: tenant_object) ||
-                       RubyLLM::Agents::Tenant.find_by(tenant_id: tenant_object.llm_tenant_id)
+              RubyLLM::Agents::Tenant.find_by(tenant_id: tenant_object.llm_tenant_id)
             return if existing
 
             options = tenant_object.class.try(:llm_tenant_options) || {}
@@ -146,7 +146,7 @@ module RubyLLM
             return @tenant_table_exists if defined?(@tenant_table_exists)
 
             @tenant_table_exists = ::ActiveRecord::Base.connection.table_exists?(:ruby_llm_agents_tenants)
-          rescue StandardError
+          rescue
             @tenant_table_exists = false
           end
 
@@ -181,7 +181,7 @@ module RubyLLM
             return if api_keys.blank?
 
             apply_api_keys_to_ruby_llm(api_keys)
-          rescue StandardError => e
+          rescue => e
             # Log but don't fail if API key extraction fails
             warn_api_key_error("tenant object", e)
           end
@@ -228,7 +228,7 @@ module RubyLLM
             return nil unless tenant.respond_to?(:llm_config)
 
             tenant.llm_config
-          rescue StandardError
+          rescue
             nil
           end
         end

data/lib/ruby_llm/agents/results/background_removal_result.rb

@@ -16,9 +16,9 @@ module RubyLLM
     #
     class BackgroundRemovalResult
       attr_reader :foreground, :mask, :source_image, :model_id, :output_format,
-                  :alpha_matting, :refine_edges,
-                  :started_at, :completed_at, :tenant_id, :remover_class,
-                  :error_class, :error_message
+        :alpha_matting, :refine_edges,
+        :started_at, :completed_at, :tenant_id, :remover_class,
+        :error_class, :error_message
 
       # Initialize a new result
       #
@@ -36,8 +36,8 @@ module RubyLLM
       # @param error_class [String, nil] Error class name if failed
       # @param error_message [String, nil] Error message if failed
       def initialize(foreground:, mask:, source_image:, model_id:, output_format:,
-                     alpha_matting:, refine_edges:, started_at:, completed_at:,
-                     tenant_id:, remover_class:, error_class: nil, error_message: nil)
+        alpha_matting:, refine_edges:, started_at:, completed_at:,
+        tenant_id:, remover_class:, error_class: nil, error_message: nil)
         @foreground = foreground
         @mask = mask
         @source_image = source_image
@@ -224,7 +224,7 @@ module RubyLLM
     # Lightweight result for cached removals
     class CachedBackgroundRemovalResult
       attr_reader :url, :data, :mask_url, :mask_data, :mime_type, :model_id,
-                  :output_format, :total_cost, :cached_at
+        :output_format, :total_cost, :cached_at
 
       def initialize(data)
         @url = data[:url]

data/lib/ruby_llm/agents/results/embedding_result.rb

@@ -156,13 +156,13 @@ module RubyLLM
         return nil if v1.nil?
 
         v2 = case other
-             when EmbeddingResult
-               other.vector
-             when Array
-               other
-             else
-               raise ArgumentError, "other must be EmbeddingResult or Array, got #{other.class}"
-             end
+        when EmbeddingResult
+          other.vector
+        when Array
+          other
+        else
+          raise ArgumentError, "other must be EmbeddingResult or Array, got #{other.class}"
+        end
 
         return nil if v2.nil?
 
@@ -183,17 +183,17 @@ module RubyLLM
 
         similarities = others.each_with_index.map do |other, idx|
           v2 = case other
-               when EmbeddingResult
-                 other.vector
-               when Array
-                 other
-               else
-                 next nil
-               end
+          when EmbeddingResult
+            other.vector
+          when Array
+            other
+          else
+            next nil
+          end
 
           next nil if v2.nil?
 
-          { index: idx, similarity: cosine_similarity(v1, v2) }
+          {index: idx, similarity: cosine_similarity(v1, v2)}
         end.compact
 
         similarities.sort_by { |s| -s[:similarity] }.first(limit)

data/lib/ruby_llm/agents/results/image_analysis_result.rb

@@ -18,9 +18,9 @@ module RubyLLM
     #
     class ImageAnalysisResult
       attr_reader :image, :model_id, :analysis_type,
-                  :caption, :description, :tags, :objects, :colors, :text,
-                  :raw_response, :started_at, :completed_at, :tenant_id, :analyzer_class,
-                  :error_class, :error_message
+        :caption, :description, :tags, :objects, :colors, :text,
+        :raw_response, :started_at, :completed_at, :tenant_id, :analyzer_class,
+        :error_class, :error_message
 
       # Initialize a new result
       #
@@ -41,8 +41,8 @@ module RubyLLM
       # @param error_class [String, nil] Error class name if failed
       # @param error_message [String, nil] Error message if failed
       def initialize(image:, model_id:, analysis_type:, caption:, description:, tags:,
-                     objects:, colors:, text:, raw_response:, started_at:, completed_at:,
-                     tenant_id:, analyzer_class:, error_class: nil, error_message: nil)
+        objects:, colors:, text:, raw_response:, started_at:, completed_at:,
+        tenant_id:, analyzer_class:, error_class: nil, error_message: nil)
         @image = image
         @model_id = model_id
         @analysis_type = analysis_type
@@ -235,8 +235,8 @@ module RubyLLM
     # Lightweight result for cached analyses
     class CachedImageAnalysisResult
       attr_reader :image, :model_id, :analysis_type,
-                  :caption, :description, :tags, :objects, :colors, :text,
-                  :total_cost, :cached_at
+        :caption, :description, :tags, :objects, :colors, :text,
+        :total_cost, :cached_at
 
       def initialize(data)
         @image = data[:image]

data/lib/ruby_llm/agents/results/image_edit_result.rb

@@ -18,8 +18,8 @@ module RubyLLM
     #
     class ImageEditResult
       attr_reader :images, :source_image, :mask, :prompt, :model_id, :size,
-                  :started_at, :completed_at, :tenant_id, :editor_class,
-                  :error_class, :error_message
+        :started_at, :completed_at, :tenant_id, :editor_class,
+        :error_class, :error_message
 
       # Initialize a new result
       #
@@ -36,8 +36,8 @@ module RubyLLM
       # @param error_class [String, nil] Error class name if failed
       # @param error_message [String, nil] Error message if failed
       def initialize(images:, source_image:, mask:, prompt:, model_id:, size:,
-                     started_at:, completed_at:, tenant_id:, editor_class:,
-                     error_class: nil, error_message: nil)
+        started_at:, completed_at:, tenant_id:, editor_class:,
+        error_class: nil, error_message: nil)
         @images = images
         @source_image = source_image
         @mask = mask