ruby_interface 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba848be8e36fb2a53a4c0a80f692d15cacb22771
-  data.tar.gz: 7ab704e3372b468c2303149c02ae46acd66a8809
+  metadata.gz: d9b8ffa291917e451bb903aef5276f566b7294f1
+  data.tar.gz: 87b777bdd6a33288a62a1e15675ea6e816fdf3f9
 SHA512:
-  metadata.gz: 815bf8051224c890dbf1b54a24746456eff1289a2b5107b44dadd8cfe33193740ab979b31497686f7f4416a34e6318ac4b486ed4dcc7d81de920cd88b57302c5
-  data.tar.gz: 10392958eaa591e652479e6684672b724f9e25328eefd14553e96afc4f178216c1aaa90b41933344e7d93353b16fb8c18bbc30a149320bdcbfdb48e786dc4da4
+  metadata.gz: 1ea17d4036a0ebd057ec6d9d632f8dbcc8f568e94db4ce5cbb152e0bb36ea4626a3cb2e597c260ee48489f99ed34370046b686a5bee762afac3611ff625cfdc7
+  data.tar.gz: 1ffdcb7225e371e5cf7300ef7b1e7e88ba50929962a8cfdca61ecde77f6b0be13489cca1dee61c3c7885556443d6ad9550be33ae454fc7fe032c762ab4d52f5e

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# 0.2.0
+- Update handling for anonymous classes:
+  - Fix tracepoint never being disabled
+  - Create an implementation that uses `class_eval`
+- Make sure that any existing inherited hooks don't get overriden.
+
+# 0.1.0
+- Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ruby_interface (0.1.0)
+    ruby_interface (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -3,7 +3,7 @@
 When a class is interpreted and does not have the required methods, it throws an error.
 
 Caveats:
-- creating anonymous classes will not work with this gem as they use an alternate mechanism.
+- Creating anonymous classes requires the user to use `class_eval` to define methods.
 
 ## Installation
 
@@ -23,6 +23,8 @@ Or install it yourself as:
 
 ## Usage
 
+### Named Classes
+
 ```ruby
 class SpaceShip
   include RubyInterface
@@ -35,15 +37,31 @@ end
 # => NotImplementedError, 'Expected Enterprise to define #engine, #computer'
 ```
 
+If a class is redefined, the presence of required methods will not be checked. 
+
+### Anonymous classes
+
+```ruby
+class SpaceShip
+  include RubyInterface
+
+  defines :engine, :computer
+end
+
+space_ship = Class.new(SpaceShip)
+space_ship.class_eval { }
+# => NotImplementedError, 'Expected Enterprise to define #engine, #computer'
+```
+
+After the first `class_eval`, the rest of the calls to it will not check whether methods are defined.
+Unfortunately, right now, `class_eval` has to be called to check whether the methods are defined,
+ pending resolution of https://bugs.ruby-lang.org/issues/12696.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies.
 You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`.
-To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`,
-which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/kklimuk/ruby_interface.

data/lib/ruby_interface/version.rb

@@ -1,3 +1,3 @@
 module RubyInterface
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/ruby_interface.rb

@@ -4,6 +4,15 @@ require 'awesome_print'
 module RubyInterface
   def self.included(klass)
     klass.extend ClassMethods
+
+    klass.class_eval do
+      singleton_class.send(:alias_method, :_old_inherited, :inherited) if respond_to?(:inherited)
+    end
+
+    def klass.inherited(child)
+      child.name.nil? ? anonymous_class_definition(child) : named_class_definition(child)
+      _old_inherited(child) if respond_to?(:_old_inherited)
+    end
   end
 
   module ClassMethods
@@ -12,17 +21,37 @@ module RubyInterface
       @methods_to_define += args
     end
 
-    def inherited(klass)
-      trace = TracePoint.new(:end) do |point|
-        next unless point.self == klass
-        missing_methods = @methods_to_define - klass.instance_methods(false)
-        trace.disable
+    def track_required_methods(child)
+      missing_methods = @methods_to_define - child.instance_methods(false)
 
-        next if missing_methods.empty?
+      return if missing_methods.empty?
+
+      message = "Expected #{child.name || 'anonymous class'} to define "
+      message << missing_methods.map { |method| "##{method}" }.join(', ')
+      raise NotImplementedError, message
+    end
 
-        message = "Expected #{klass.name} to define "
-        message << missing_methods.map { |method| "##{method}" }.join(', ')
-        raise NotImplementedError, message
+    private
+
+    def anonymous_class_definition(child)
+      klass = self
+      [:class_exec, :class_eval].each do |method|
+        old_method = "_old_#{method}".to_sym
+        child.singleton_class.send(:alias_method, old_method, method)
+
+        child.define_singleton_method method do |*args, &block|
+          send old_method, *args, &block
+          klass.track_required_methods(child)
+          child.singleton_class.send(:alias_method, method, old_method)
+        end
+      end
+    end
+
+    def named_class_definition(child)
+      trace = TracePoint.new(:end) do |point|
+        next unless point.self == child
+        trace.disable
+        track_required_methods child
       end
       trace.enable
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_interface
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Kirill Klimuk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-21 00:00:00.000000000 Z
+date: 2016-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -78,6 +78,7 @@ files:
 - ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt