ruby_gpg2 0.9.0.pre.6 → 0.9.0.pre.7

data/lib/ruby_gpg2/colon_record.rb

@@ -1,154 +1,129 @@
+# frozen_string_literal: true
+
 require 'date'
 
 module RubyGPG2
+  # rubocop:disable Metrics/ClassLength
   class ColonRecord
-    USER_ID_REGEX = /^(.*?) (?:\((.*)\) )?<(.*)>$/
+    USER_ID_REGEX = /^(.*?) (?:\((.*)\) )?<(.*)>$/.freeze
 
     TYPES = {
-        'pub' => :public_key,
-        'crt' => :x509_certificate,
-        'crs' => :x509_certificate_and_private_key,
-        'sub' => :sub_key,
-        'sec' => :secret_key,
-        'ssb' => :secret_sub_key,
-        'uid' => :user_id,
-        'uat' => :user_attribute,
-        'sig' => :signature,
-        'rev' => :revocation_signature,
-        'rvs' => :standalone_revocation_signature,
-        'fpr' => :fingerprint,
-        'pkd' => :public_key_data,
-        'grp' => :key_grip,
-        'rvk' => :revocation_key,
-        'tfs' => :tofu_statistics,
-        'tru' => :trust_database_information,
-        'spk' => :signature_sub_packet,
-        'cfg' => :configuration_data
-    }
+      'pub' => :public_key,
+      'crt' => :x509_certificate,
+      'crs' => :x509_certificate_and_private_key,
+      'sub' => :sub_key,
+      'sec' => :secret_key,
+      'ssb' => :secret_sub_key,
+      'uid' => :user_id,
+      'uat' => :user_attribute,
+      'sig' => :signature,
+      'rev' => :revocation_signature,
+      'rvs' => :standalone_revocation_signature,
+      'fpr' => :fingerprint,
+      'pkd' => :public_key_data,
+      'grp' => :key_grip,
+      'rvk' => :revocation_key,
+      'tfs' => :tofu_statistics,
+      'tru' => :trust_database_information,
+      'spk' => :signature_sub_packet,
+      'cfg' => :configuration_data
+    }.freeze
 
     TRUST_MODELS = {
-        '0' => :classic,
-        '1' => :pgp
-    }
+      '0' => :classic,
+      '1' => :pgp
+    }.freeze
 
     VALIDITIES = {
-        'o' => :unknown_new_key,
-        'i' => :invalid,
-        'd' => :disabled,
-        'r' => :revoked,
-        'e' => :expired,
-        '-' => :unknown,
-        'q' => :undefined,
-        'n' => :never,
-        'm' => :marginal,
-        'f' => :full,
-        'u' => :ultimate,
-        'w' => :well_known_private,
-        's' => :special
-    }
+      'o' => :unknown_new_key,
+      'i' => :invalid,
+      'd' => :disabled,
+      'r' => :revoked,
+      'e' => :expired,
+      '-' => :unknown,
+      'q' => :undefined,
+      'n' => :never,
+      'm' => :marginal,
+      'f' => :full,
+      'u' => :ultimate,
+      'w' => :well_known_private,
+      's' => :special
+    }.freeze
 
     KEY_ALGORITHMS = {
-        '1' => :rsa_encrypt_or_sign,
-        '2' => :rsa_encrypt_only,
-        '3' => :rsa_sign_only,
-        '16' => :elgamal_encrypt_only,
-        '17' => :dsa,
-        '18' => :ecdh,
-        '19' => :ecdsa,
-    }
+      '1' => :rsa_encrypt_or_sign,
+      '2' => :rsa_encrypt_only,
+      '3' => :rsa_sign_only,
+      '16' => :elgamal_encrypt_only,
+      '17' => :dsa,
+      '18' => :ecdh,
+      '19' => :ecdsa
+    }.freeze
 
     TRUSTS = {
-        '-' => :unknown,
-        'n' => :never,
-        'm' => :marginal,
-        'f' => :full,
-        'u' => :ultimate,
-    }
+      '-' => :unknown,
+      'n' => :never,
+      'm' => :marginal,
+      'f' => :full,
+      'u' => :ultimate
+    }.freeze
 
     KEY_CAPABILITIES = {
-        'e' => :encrypt,
-        's' => :sign,
-        'c' => :certify,
-        'a' => :authenticate,
-        'E' => :primary_encrypt,
-        'S' => :primary_sign,
-        'C' => :primary_certify,
-        'A' => :primary_authenticate,
-        '?' => :unknown
-    }
+      'e' => :encrypt,
+      's' => :sign,
+      'c' => :certify,
+      'a' => :authenticate,
+      'E' => :primary_encrypt,
+      'S' => :primary_sign,
+      'C' => :primary_certify,
+      'A' => :primary_authenticate,
+      '?' => :unknown
+    }.freeze
 
     COMPLIANCE_MODES = {
-        '8' => :rfc_4880bis,
-        '23' => :de_vs,
-        '6001' => :roca_screening_hit
-    }
+      '8' => :rfc_4880bis,
+      '23' => :de_vs,
+      '6001' => :roca_screening_hit
+    }.freeze
 
     def self.parse(record)
       fields = record.split(':', 22)
       type = type(fields[0])
-      case type
-      when :trust_database_information
-        new(
-            raw: record,
-            type: type,
-            trust_model: trust_model(fields[2]),
-            creation_date: creation_date(fields[3]),
-            expiration_date: expiration_date(fields[4]),
-            new_key_signer_marginal_count:
-                new_key_signer_marginal_count(fields[5]),
-            new_key_signer_complete_count:
-                new_key_signer_complete_count(fields[6]),
-            maximum_certificate_chain_depth:
-                maximum_certificate_chain_depth(fields[7]))
+      if trust_base_record?(type)
+        make_trust_base_record(record, type, fields)
       else
-        new(
-            raw: record,
-            type: type,
-            validity: validity(fields[1]),
-            key_length: key_length(fields[2]),
-            key_algorithm: key_algorithm(fields[3]),
-            key_id: key_id(fields[4]),
-            creation_date: creation_date(fields[5]),
-            expiration_date: expiration_date(fields[6]),
-            user_id_hash: user_id_hash(type, fields[7]),
-            owner_trust: owner_trust(fields[8]),
-            fingerprint: fingerprint(type, fields[9]),
-            key_grip: key_grip(type, fields[9]),
-            user_id: user_id(type, fields[9]),
-            signature_class: signature_class(fields[10]),
-            key_capabilities: key_capabilities(fields[11]),
-            serial_number: serial_number(fields[14]),
-            compliance_modes: compliance_modes(fields[17]),
-            last_update: last_update(fields[18]),
-            origin: origin(fields[19]))
+        make_standard_record(record, type, fields)
       end
     end
 
     attr_reader(
-        :raw,
-        :type,
-        :trust_model,
-        :validity,
-        :key_length,
-        :key_algorithm,
-        :key_id,
-        :creation_date,
-        :expiration_date,
-        :user_id_hash,
-        :owner_trust,
-        :fingerprint,
-        :key_grip,
-        :user_id,
-        :signature_class,
-        :key_capabilities,
-        :serial_number,
-        :compliance_modes,
-        :last_update,
-        :origin,
-        :new_key_signer_marginal_count,
-        :new_key_signer_complete_count,
-        :maximum_certificate_chain_depth)
-
+      :raw,
+      :type,
+      :trust_model,
+      :validity,
+      :key_length,
+      :key_algorithm,
+      :key_id,
+      :creation_date,
+      :expiration_date,
+      :user_id_hash,
+      :owner_trust,
+      :fingerprint,
+      :key_grip,
+      :user_id,
+      :signature_class,
+      :key_capabilities,
+      :serial_number,
+      :compliance_modes,
+      :last_update,
+      :origin,
+      :new_key_signer_marginal_count,
+      :new_key_signer_complete_count,
+      :maximum_certificate_chain_depth
+    )
+
+    # rubocop:disable Metrics/MethodLength
+    # rubocop:disable Metrics/AbcSize
     def initialize(opts)
       @raw = opts[:raw]
       @type = opts[:type]
@@ -174,6 +149,8 @@ module RubyGPG2
       @new_key_signer_complete_count = opts[:new_key_signer_complete_count]
       @maximum_certificate_chain_depth = opts[:maximum_certificate_chain_depth]
     end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/MethodLength
 
     def fingerprint_record?
       type == :fingerprint
@@ -184,21 +161,24 @@ module RubyGPG2
     end
 
     def user_name
-      if (match = user_id&.match(USER_ID_REGEX))
-        match[1]
-      end
+      match = user_id&.match(USER_ID_REGEX)
+      return unless match
+
+      match[1]
     end
 
     def user_comment
-      if (match = user_id&.match(USER_ID_REGEX))
-        match[2]
-      end
+      match = user_id&.match(USER_ID_REGEX)
+      return unless match
+
+      match[2]
     end
 
     def user_email
-      if (match = user_id&.match(USER_ID_REGEX))
-        match[3]
-      end
+      match = user_id&.match(USER_ID_REGEX)
+      return unless match
+
+      match[3]
     end
 
     def ==(other)
@@ -207,124 +187,179 @@ module RubyGPG2
 
     protected
 
+    # rubocop:disable Metrics/MethodLength
     def state
       [
-          @raw,
-          @type,
-          @trust_model,
-          @validity,
-          @key_length,
-          @key_algorithm,
-          @key_id,
-          @creation_date,
-          @expiration_date,
-          @user_id_hash,
-          @owner_trust,
-          @fingerprint,
-          @key_grip,
-          @user_id,
-          @signature_class,
-          @key_capabilities,
-          @serial_number,
-          @compliance_modes,
-          @last_update,
-          @origin,
-          @new_key_signer_marginal_count,
-          @new_key_signer_complete_count,
-          @maximum_certificate_chain_depth
+        @raw,
+        @type,
+        @trust_model,
+        @validity,
+        @key_length,
+        @key_algorithm,
+        @key_id,
+        @creation_date,
+        @expiration_date,
+        @user_id_hash,
+        @owner_trust,
+        @fingerprint,
+        @key_grip,
+        @user_id,
+        @signature_class,
+        @key_capabilities,
+        @serial_number,
+        @compliance_modes,
+        @last_update,
+        @origin,
+        @new_key_signer_marginal_count,
+        @new_key_signer_complete_count,
+        @maximum_certificate_chain_depth
       ]
     end
+    # rubocop:enable Metrics/MethodLength
 
-    private
+    class << self
+      protected
 
-    def self.type(value)
-      TYPES[value]
-    end
+      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/AbcSize
+      def make_standard_record(record, type, fields)
+        new(
+          raw: record,
+          type: type,
+          validity: validity(fields[1]),
+          key_length: key_length(fields[2]),
+          key_algorithm: key_algorithm(fields[3]),
+          key_id: key_id(fields[4]),
+          creation_date: creation_date(fields[5]),
+          expiration_date: expiration_date(fields[6]),
+          user_id_hash: user_id_hash(type, fields[7]),
+          owner_trust: owner_trust(fields[8]),
+          fingerprint: fingerprint(type, fields[9]),
+          key_grip: key_grip(type, fields[9]),
+          user_id: user_id(type, fields[9]),
+          signature_class: signature_class(fields[10]),
+          key_capabilities: key_capabilities(fields[11]),
+          serial_number: serial_number(fields[14]),
+          compliance_modes: compliance_modes(fields[17]),
+          last_update: last_update(fields[18]),
+          origin: origin(fields[19])
+        )
+      end
+      # rubocop:enable Metrics/AbcSize
+      # rubocop:enable Metrics/MethodLength
 
-    def self.trust_model(value)
-      TRUST_MODELS[value]
-    end
+      # rubocop:disable Metrics/MethodLength
+      def make_trust_base_record(record, type, fields)
+        new(
+          raw: record,
+          type: type,
+          trust_model: trust_model(fields[2]),
+          creation_date: creation_date(fields[3]),
+          expiration_date: expiration_date(fields[4]),
+          new_key_signer_marginal_count:
+            new_key_signer_marginal_count(fields[5]),
+          new_key_signer_complete_count:
+            new_key_signer_complete_count(fields[6]),
+          maximum_certificate_chain_depth:
+            maximum_certificate_chain_depth(fields[7])
+        )
+      end
+      # rubocop:enable Metrics/MethodLength
 
-    def self.validity(value)
-      VALIDITIES[value]
-    end
+      def trust_base_record?(type)
+        type == :trust_database_information
+      end
 
-    def self.key_length(value)
-      value =~ /\d+/ ? value.to_s.to_i : nil
-    end
+      def type(value)
+        TYPES[value]
+      end
 
-    def self.key_algorithm(value)
-      KEY_ALGORITHMS[value]
-    end
+      def trust_model(value)
+        TRUST_MODELS[value]
+      end
 
-    def self.key_id(value)
-      value =~ /.+/ ? value : nil
-    end
+      def validity(value)
+        VALIDITIES[value]
+      end
 
-    def self.creation_date(value)
-      value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
-    end
+      def key_length(value)
+        value =~ /\d+/ ? value.to_s.to_i : nil
+      end
 
-    def self.expiration_date(value)
-      value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
-    end
+      def key_algorithm(value)
+        KEY_ALGORITHMS[value]
+      end
 
-    def self.user_id_hash(type, value)
-      type == :user_id ? value : nil
-    end
+      def key_id(value)
+        value =~ /.+/ ? value : nil
+      end
 
-    def self.owner_trust(value)
-      TRUSTS[value]
-    end
+      def creation_date(value)
+        value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
+      end
 
-    def self.fingerprint(type, value)
-      type == :fingerprint ? value : nil
-    end
+      def expiration_date(value)
+        value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
+      end
 
-    def self.key_grip(type, value)
-      type == :key_grip ? value : nil
-    end
+      def user_id_hash(type, value)
+        type == :user_id ? value : nil
+      end
+
+      def owner_trust(value)
+        TRUSTS[value]
+      end
+
+      def fingerprint(type, value)
+        type == :fingerprint ? value : nil
+      end
+
+      def key_grip(type, value)
+        type == :key_grip ? value : nil
+      end
+
+      def user_id(type, value)
+        return if %i[fingerprint key_grip].include?(type)
 
-    def self.user_id(type, value)
-      unless [:fingerprint, :key_grip].include?(type)
         value =~ /.+/ ? value : nil
       end
-    end
 
-    def self.signature_class(value)
-      value =~ /.+/ ? value : nil
-    end
+      def signature_class(value)
+        value =~ /.+/ ? value : nil
+      end
 
-    def self.key_capabilities(value)
-      value =~ /.+/ ? value.chars.map { |c| KEY_CAPABILITIES[c] } : nil
-    end
+      def key_capabilities(value)
+        value =~ /.+/ ? value.chars.map { |c| KEY_CAPABILITIES[c] } : nil
+      end
 
-    def self.serial_number(value)
-      value =~ /.+/ ? value : nil
-    end
+      def serial_number(value)
+        value =~ /.+/ ? value : nil
+      end
 
-    def self.compliance_modes(value)
-      value =~ /.+/ ? value.split(' ').map { |m| COMPLIANCE_MODES[m] } : nil
-    end
+      def compliance_modes(value)
+        value =~ /.+/ ? value.split.map { |m| COMPLIANCE_MODES[m] } : nil
+      end
 
-    def self.last_update(value)
-      value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
-    end
+      def last_update(value)
+        value =~ /\d+/ ? DateTime.strptime(value, '%s') : nil
+      end
 
-    def self.origin(value)
-      value
-    end
+      def origin(value)
+        value
+      end
 
-    def self.new_key_signer_marginal_count(value)
-      value =~ /\d+/ ? value.to_i : nil
-    end
+      def new_key_signer_marginal_count(value)
+        value =~ /\d+/ ? value.to_i : nil
+      end
 
-    def self.new_key_signer_complete_count(value)
-      value =~ /\d+/ ? value.to_i : nil
-    end
+      def new_key_signer_complete_count(value)
+        value =~ /\d+/ ? value.to_i : nil
+      end
 
-    def self.maximum_certificate_chain_depth(value)
-      value =~ /\d+/ ? value.to_i : nil
+      def maximum_certificate_chain_depth(value)
+        value =~ /\d+/ ? value.to_i : nil
+      end
     end
   end
+  # rubocop:enable Metrics/ClassLength
 end

data/lib/ruby_gpg2/commands/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative './result'
@@ -13,17 +15,12 @@ module RubyGPG2
       end
 
       def execute(opts = {})
-        builder = instantiate_builder
-
         do_before(opts)
         do_around(opts) do |updated_opts|
-          builder = configure_command(builder, updated_opts)
+          builder = configure_command(instantiate_builder, updated_opts)
           builder
-              .build
-              .execute(
-                  stdin: stdin,
-                  stdout: stdout,
-                  stderr: stderr)
+            .build
+            .execute(stdin: stdin, stdout: stdout, stderr: stderr)
         end
         do_after(opts)
       end
@@ -34,13 +31,12 @@ module RubyGPG2
 
       def instantiate_builder
         Lino::CommandLineBuilder
-            .for_command(binary)
+          .for_command(binary)
       end
 
-      def do_before(opts)
-      end
+      def do_before(_); end
 
-      def configure_command(builder, opts)
+      def configure_command(builder, _opts)
         builder
       end
 
@@ -48,7 +44,7 @@ module RubyGPG2
         yield opts
       end
 
-      def do_after(opts)
+      def do_after(_)
         Result.new
       end
     end

data/lib/ruby_gpg2/commands/decrypt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative 'base'
@@ -24,8 +26,7 @@ module RubyGPG2
 
       def configure_command(builder, opts)
         builder = super(builder, opts)
-        builder = builder.with_subcommand('--decrypt')
-        builder
+        builder.with_subcommand('--decrypt')
       end
     end
   end

data/lib/ruby_gpg2/commands/encrypt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative 'base'
@@ -22,8 +24,7 @@ module RubyGPG2
 
       def configure_command(builder, opts)
         builder = super(builder, opts)
-        builder = builder.with_subcommand('--encrypt')
-        builder
+        builder.with_subcommand('--encrypt')
       end
     end
   end

data/lib/ruby_gpg2/commands/export.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative 'base'

data/lib/ruby_gpg2/commands/export_secret_keys.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative 'base'

data/lib/ruby_gpg2/commands/generate_key.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'lino'
 
 require_relative 'base'
@@ -27,7 +29,9 @@ module RubyGPG2
 
         builder = builder.with_subcommand('--generate-key')
         builder = super(builder, opts)
-        builder = builder.with_argument(parameter_file_path) if parameter_file_path
+        if parameter_file_path
+          builder = builder.with_argument(parameter_file_path)
+        end
         builder
       end
     end