ruby_garmin_connect 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b18f0c8f89a53ffc4f5f823c156aa14efcdcdd4fdcbcc11bfcf2c96ad8026fa
-  data.tar.gz: b041d02818b7e1cc499bfce5b24982b73d3b616a2e2f41eb6599b6f0bb9b70c1
+  metadata.gz: 9e992aa41910f85ae0a2f2b656e09d28c529a82c44a0118a09a53765826d49ce
+  data.tar.gz: ee0d8526867d3f7d85c2742cfaa3ad36a73102d43be6eba2149b687719365885
 SHA512:
-  metadata.gz: a1975143fb61ac5c6af8ca844416415946babf90240eb6cb6ac52ec40a4a37f606c233d2d60304609066303b4a472026cc2942c7a4b6e2cd750b36c8fa900185
-  data.tar.gz: 500020861e427e9795a78bc242cb80a7755a9e714f6f341c0141496a6292abca62a1fdfbae9420f0d894bc1049e5c11f3c371aa1e95d9cd5cc3eaba1d5eb3fe4
+  metadata.gz: d20db74f11c8102571dd3c08a3ffeec7e095075de9562035adbb7255d7d75a134d879e075010897557e143a2f28ab6392da82ecbedd2e86ffbebced25ae3e0ca
+  data.tar.gz: 8baf66019a7832c3d1579c9b164f01beef5a3271b91357120572b345cf7da0b71f331b7f295533bfcb8342b641794d6dc6cc63ae4ece8159d8efe9814a34c4b9

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## 0.2.1 (2026-02-11)
+
+### Fixed
+
+- `training_readiness` raising `TypeError: no implicit conversion of String into Integer` when Garmin returns a response with a UTF-8 BOM or unparseable JSON body
+- `display_name` and `full_name` returning `nil` on login when the profile endpoint nests data under `socialProfile` or uses `userName` instead of `displayName`
+
+### Added
+
+- `ParseError` exception class — raised when a response claims `application/json` content-type but the body can't be parsed (instead of silently returning a raw string)
+- UTF-8 BOM stripping in response parsing
+- Fallback profile extraction: tries `displayName` → `socialProfile.displayName` → `userName`
+
+### Improved
+
+- Test coverage increased to 205 examples (up from 199)
+
 ## 0.2.0 (2026-02-11)
 
 ### Added

data/README.md

@@ -24,10 +24,12 @@ gem install garmin_connect
 require "garmin_connect"
 
 # Login with credentials (tokens are saved to ~/.garminconnect automatically)
-client = GarminConnect.login(email: "you@example.com", password: "your-password")
+client = GarminConnect::Client.new(email: "you@example.com", password: "your-password")
+client.login
 
 # Subsequent sessions resume from saved tokens (no re-login for ~1 year)
-client = GarminConnect.login
+client = GarminConnect::Client.new
+client.login
 
 # Get today's stats
 puts client.daily_summary

data/lib/garmin_connect/api/metrics.rb

@@ -23,7 +23,7 @@ module GarminConnect
         data = training_readiness(date)
         return data unless data.is_a?(Array)
 
-        data.select { |entry| entry["calendarDate"] == format_date(date) }
+        data.select { |entry| entry.is_a?(Hash) && entry["calendarDate"] == format_date(date) }
       end
 
       # Get aggregated training status.

data/lib/garmin_connect/client.rb

@@ -162,13 +162,32 @@ module GarminConnect
       @unit_system = settings&.dig("userData", "measurementSystem")
 
       profile = connection.get("/userprofile-service/userprofile/profile")
-      @display_name = profile&.dig("displayName")
-      @full_name = profile&.dig("fullName")
-      @user_profile_pk = profile&.dig("profileId") || settings&.dig("id")
+      extract_profile_info(profile)
+
+      @user_profile_pk = extract_profile_pk(profile, settings)
     rescue HTTPError
       # Non-fatal: display_name may not be available
     end
 
+    def extract_profile_info(profile)
+      return unless profile.is_a?(Hash)
+
+      @display_name = profile.dig("displayName") ||
+                      profile.dig("socialProfile", "displayName") ||
+                      profile.dig("userName")
+
+      @full_name = profile.dig("fullName") ||
+                   profile.dig("socialProfile", "fullName")
+    end
+
+    def extract_profile_pk(profile, settings)
+      return nil unless profile.is_a?(Hash) || settings.is_a?(Hash)
+
+      profile&.dig("profileId") ||
+        profile&.dig("socialProfile", "profileId") ||
+        settings&.dig("id")
+    end
+
     # Exposed for API modules that need it.
     def user_profile_pk
       @user_profile_pk

data/lib/garmin_connect/connection.rb

@@ -124,11 +124,23 @@ module GarminConnect
 
     def parse_response(resp)
       return nil if resp.status == 204
-      return resp.body if resp.body.nil? || resp.body.empty?
 
-      JSON.parse(resp.body)
+      body = resp.body
+      return body if body.nil? || body.empty?
+
+      # Strip UTF-8 BOM if present (some Garmin endpoints include it)
+      body = body.b.sub(/\A\xEF\xBB\xBF/n, "").force_encoding("UTF-8")
+
+      JSON.parse(body)
     rescue JSON::ParserError
-      resp.body
+      content_type = resp.headers["content-type"].to_s
+      # If the server said it was JSON but we can't parse it, raise rather than
+      # returning a raw string that callers will misuse.
+      if content_type.include?("application/json")
+        raise ParseError, "Failed to parse JSON response: #{body[0..200]}"
+      end
+
+      body
     end
 
     def handle_errors!(resp)

data/lib/garmin_connect/errors.rb

@@ -35,6 +35,9 @@ module GarminConnect
   class TooManyRequestsError < HTTPError; end
   class ServerError < HTTPError; end
 
+  # Response parsing errors
+  class ParseError < Error; end
+
   # Maps HTTP status codes to error classes
   HTTP_ERRORS = {
     400 => BadRequestError,

data/lib/garmin_connect/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GarminConnect
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_garmin_connect
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - DRBragg