ruby_event_store 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b76da76feedfe6a7a47b7580ae2ef14bb64785a7
-  data.tar.gz: 970d9fa6c06ad47649e1bb5f35db967d76508ba8
+  metadata.gz: 7d71ec6a5d4c85e551b036dda5abca24e8bddc1c
+  data.tar.gz: 65666ce24c97b6818a2881a8ce543c4571b88192
 SHA512:
-  metadata.gz: 8d952639196c9a5d24b06d985074dbcaf21c494c20c427c3e3af622f6ae096d4bbd36571f203c2eb2c7ed925aea49ea6262f445b50286eafb8ff22bb96366036
-  data.tar.gz: e594bb468b2ea6497c365d5c68709bc0688093331654fe3ef6b41740b331ba21225cdf13ae44c4650446a9d49ae1a2c74998adbf25b71367cccbe9989674a9ac
+  metadata.gz: cf14a4789d7f4194598b39a8a09ad91f3baca78f6976792499a02476186b76c40a1059e12f926254e1075acc34da7b7a2f1147bea7d8a8f069f9c97e897146ba
+  data.tar.gz: f3014bb612918f1e39a68d719705faf4a9a6227c901883978ea5414135f2fc47c30e33afebaab07b7e718a0394bb5cdeeda3d6165b94d0679aebead526c9ceac

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
-- 2.1.10
-- 2.2.5
-- 2.3.1
+- 2.2.7
+- 2.3.4
+- 2.4.1
 before_install: gem install bundler
 gemfile: Gemfile
 script: make mutate

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 0.14.0 (21.08.2017)
+
+* Change: Add lint for 3rd party implementations of dispatcher
+* Change: Deprecated MethodNotDefined error, use InvalidHandler instead
+
 ### 0.13.0 (15.10.2016)
 
 * Change: Dropped ClosedStruct event (meta)data wrapping PR #34

data/Makefile

@@ -10,7 +10,7 @@ test: ## Run tests
 
 mutate: test  ## Run mutation tests
 	@echo "Running mutation tests - only 100% free mutation will be accepted"
-	@bundle exec mutant --include lib --require ruby_event_store --use rspec "RubyEventStore*"
+	@bundle exec mutant --include lib --require ruby_event_store --use rspec --ignore-subject "RubyEventStore.const_missing" "RubyEventStore*"
 
 .PHONY: help
 

data/README.md

@@ -28,8 +28,23 @@ Whenever you fix a bug or add a new feature, we require that the coverage doesn'
 
 ## About
 
-<img src="http://arkency.com/images/arkency.png" alt="Arkency" width="20%" align="left" />
+<img src="http://arkency.com/images/arkency.png" alt="Arkency" width="60px" align="left" />
 
 This repository is funded and maintained by Arkency. Check out our other [open-source projects](https://github.com/arkency).
 
 You can also [hire us](http://arkency.com) or [read our blog](http://blog.arkency.com).
+
+
+## Learn more about DDD & Event Sourcing
+
+Check our **Rails + Domain Driven Design Workshop** [more details](http://blog.arkency.com/ddd-training/).
+
+Why You should attend? Robert has explained this in [this blogpost](http://blog.arkency.com/2016/12/why-would-you-even-want-to-listen-about-ddd/).
+
+
+Next edition will be held on **21-22th September 2017** in Berlin, Germany.
+Another edition is also planned for November in London.
+
+You may also consider buying the [Domain-Driven Rails book](http://blog.arkency.com/domain-driven-rails/).
+Workshop will be held in English.
+

data/lib/ruby_event_store.rb

@@ -1,3 +1,4 @@
+require 'ruby_event_store/pub_sub/dispatcher'
 require 'ruby_event_store/pub_sub/broker'
 require 'ruby_event_store/in_memory_repository'
 require 'ruby_event_store/projection'
@@ -5,4 +6,5 @@ require 'ruby_event_store/errors'
 require 'ruby_event_store/constants'
 require 'ruby_event_store/client'
 require 'ruby_event_store/event'
+require 'ruby_event_store/deprecations'
 require 'ruby_event_store/version'

data/lib/ruby_event_store/client.rb

@@ -3,11 +3,13 @@ module RubyEventStore
     def initialize(repository:,
                    event_broker:  PubSub::Broker.new,
                    page_size: PAGE_SIZE,
-                   metadata_proc: nil)
+                   metadata_proc: nil,
+                   clock: ->{ Time.now.utc })
       @repository     = repository
       @event_broker   = event_broker
       @page_size      = page_size
       @metadata_proc  = metadata_proc
+      @clock          = clock
     end
 
     def publish_event(event, stream_name: GLOBAL_STREAM, expected_version: :any)
@@ -74,11 +76,11 @@ module RubyEventStore
     end
 
     private
-    attr_reader :repository, :page_size, :event_broker, :metadata_proc
+    attr_reader :repository, :page_size, :event_broker, :metadata_proc, :clock
 
     def enrich_event_metadata(event)
       metadata = event.metadata
-      metadata[:timestamp] ||= Time.now.utc
+      metadata[:timestamp] ||= clock.()
       metadata.merge!(metadata_proc.call || {}) if metadata_proc
 
       event.class.new(event_id: event.event_id, metadata: metadata, data: event.data)

data/lib/ruby_event_store/deprecations.rb

@@ -0,0 +1,7 @@
+module RubyEventStore
+  def self.const_missing(const_name)
+    super unless const_name == :MethodNotDefined
+    warn "`RubyEventStore::MethodNotDefined` has been deprecated. Use `RubyEventStore::InvalidHandler` instead."
+    InvalidHandler
+  end
+end

data/lib/ruby_event_store/errors.rb

@@ -4,7 +4,12 @@ module RubyEventStore
   IncorrectStreamData        = Class.new(StandardError)
   EventNotFound              = Class.new(StandardError)
   SubscriberNotExist         = Class.new(StandardError)
-  MethodNotDefined           = Class.new(StandardError)
   InvalidPageStart           = Class.new(ArgumentError)
   InvalidPageSize            = Class.new(ArgumentError)
+
+  class InvalidHandler < StandardError
+    def initialize(subscriber)
+      super("#call method not found in #{subscriber.class} subscriber. Are you sure it is a valid subscriber?")
+    end
+  end
 end

data/lib/ruby_event_store/pub_sub/broker.rb

@@ -1,25 +1,6 @@
 module RubyEventStore
   module PubSub
     class Broker
-      class Dispatcher
-        def call(subscriber, event)
-          ensure_method_defined(subscriber)
-          subscriber.call(event)
-        end
-
-        private
-        def ensure_method_defined(subscriber)
-          unless subscriber.respond_to?(:call)
-            raise MethodNotDefined.new(method_not_defined_message(subscriber))
-          end
-        end
-
-        def method_not_defined_message(subscriber)
-          "#call method not found in #{subscriber.class} subscriber. Are you sure it is a valid subscriber?"
-        end
-      end
-      private_constant :Dispatcher
-
       DEFAULT_DISPATCHER = Dispatcher.new
 
       def initialize(dispatcher: DEFAULT_DISPATCHER)

data/lib/ruby_event_store/pub_sub/dispatcher.rb

@@ -0,0 +1,10 @@
+module RubyEventStore
+  module PubSub
+    class Dispatcher
+      def call(subscriber, event)
+        raise InvalidHandler.new(subscriber) unless subscriber.respond_to?(:call)
+        subscriber.call(event)
+      end
+    end
+  end
+end

data/lib/ruby_event_store/spec/dispatcher_lint.rb

@@ -0,0 +1,17 @@
+RSpec.shared_examples :dispatcher do |dispatcher|
+  specify "calls subscribed handler" do
+    handler = double(:handler)
+    event   = instance_double(::RubyEventStore::Event)
+
+    expect(handler).to receive(:call).with(event)
+    dispatcher.(handler, event)
+  end
+
+  specify "error when invalid subscriber passed" do
+    handler = double(:handler)
+    event   = instance_double(::RubyEventStore::Event)
+
+    expect { dispatcher.(handler, event) }.to raise_error(::RubyEventStore::InvalidHandler,
+      "#call method not found in RSpec::Mocks::Double subscriber. Are you sure it is a valid subscriber?")
+  end
+end

data/lib/ruby_event_store/spec/event_broker_lint.rb

@@ -63,7 +63,7 @@ RSpec.shared_examples :event_broker do |broker_class|
               " Are you sure it is a valid subscriber?"
     subscriber = InvalidTestHandler.new
     broker.add_subscriber(subscriber, [Test1DomainEvent])
-    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::MethodNotDefined, message)
+    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::InvalidHandler, message)
   end
 
   it 'raises error when no valid method on global handler' do
@@ -72,7 +72,7 @@ RSpec.shared_examples :event_broker do |broker_class|
               " Are you sure it is a valid subscriber?"
     subscriber = InvalidTestHandler.new
     broker.add_global_subscriber(subscriber)
-    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::MethodNotDefined, message)
+    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::InvalidHandler, message)
   end
 
   it 'returns lambda as an output of global subscribe methods' do

data/lib/ruby_event_store/version.rb

@@ -1,3 +1,3 @@
 module RubyEventStore
-  VERSION = '0.13.0'
+  VERSION = '0.14.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_event_store
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Arkency
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-10-15 00:00:00.000000000 Z
+date: 2017-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -99,11 +99,14 @@ files:
 - lib/ruby_event_store.rb
 - lib/ruby_event_store/client.rb
 - lib/ruby_event_store/constants.rb
+- lib/ruby_event_store/deprecations.rb
 - lib/ruby_event_store/errors.rb
 - lib/ruby_event_store/event.rb
 - lib/ruby_event_store/in_memory_repository.rb
 - lib/ruby_event_store/projection.rb
 - lib/ruby_event_store/pub_sub/broker.rb
+- lib/ruby_event_store/pub_sub/dispatcher.rb
+- lib/ruby_event_store/spec/dispatcher_lint.rb
 - lib/ruby_event_store/spec/event_broker_lint.rb
 - lib/ruby_event_store/spec/event_repository_lint.rb
 - lib/ruby_event_store/version.rb
@@ -128,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Event Store in Ruby