ruby_event_store-outbox 0.0.3 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89f971d2c4366655940f73a71fd28822d7b07351b3365b8b7fcef56c1f667c38
-  data.tar.gz: 4cf6356f1b559d277b5ef17a39ef4158eea7e6e35ec2eba0705e985fd1555c56
+  metadata.gz: 9457e402dabad2f00ec38ce0a6aecb12dcfdd303614b0ed6c8e391214e2eece1
+  data.tar.gz: 8545183b1d4720f5674cfdd5cf385666f2cfcd38ed2cc9fdd4bf8aa79c750835
 SHA512:
-  metadata.gz: f25f09627e62a3a856709c8dd331b43d48ca8d7001690704e91de7d488291765f013986785131fd8bb24c383b2cd207802a4b34f960d09375287388c27ddd29b
-  data.tar.gz: 788200eaba625da46a762304071fe6a24699f23cc6da179069672afbb7ad1ab57e22c391308ca04e90e21a872b5b373abdb83d188c797cb8bd6463c513788171
+  metadata.gz: dc5d885558ac2c2d3b446cc1499a9ceb8aaa541b29c1b85e8019cd832ca2572d883c4fa165abbcedc9470f36f29667becc0b7b937c49fc00b3a3aed2714699db
+  data.tar.gz: 4371dcb52922553adebe91a4fb36472c27bb0a4df0a76ec6782aaf4c48b57e424d55e7f8ba262b5f694d8d5c32e6062bbc504f8ca5e2edfb04767d0278cccc95

data/lib/ruby_event_store/outbox/cli.rb

@@ -1,15 +1,16 @@
 require "optparse"
 require "ruby_event_store/outbox/version"
 require "ruby_event_store/outbox/consumer"
+require "ruby_event_store/outbox/metrics"
 
 module RubyEventStore
   module Outbox
     class CLI
-      Options = Struct.new(:database_url, :redis_url, :log_level, :split_keys, :message_format)
+      Options = Struct.new(:database_url, :redis_url, :log_level, :split_keys, :message_format, :batch_size, :metrics_url)
 
       class Parser
         def self.parse(argv)
-          options = Options.new(nil, nil, :warn, nil, nil)
+          options = Options.new(nil, nil, :warn, nil, nil, 100)
           OptionParser.new do |option_parser|
             option_parser.banner = "Usage: res_outbox [options]"
 
@@ -33,6 +34,14 @@ module RubyEventStore
               options.split_keys = split_keys if !split_keys.empty?
             end
 
+            option_parser.on("--batch-size BATCH_SIZE", Integer, "Amount of records fetched in one fetch. Bigger value means more duplicated messages when network problems occur.") do |batch_size|
+              options.batch_size = batch_size
+            end
+
+            option_parser.on("--metrics-url METRICS_URL", "URI to metrics collector") do |metrics_url|
+              options.metrics_url = metrics_url
+            end
+
             option_parser.on_tail("--version", "Show version") do
               puts VERSION
               exit
@@ -44,16 +53,28 @@ module RubyEventStore
 
       def run(argv)
         options = Parser.parse(argv)
+        outbox_consumer = build_consumer(options)
+        outbox_consumer.init
+        outbox_consumer.run
+      end
+
+      def build_consumer(options)
         logger = Logger.new(STDOUT, level: options.log_level, progname: "RES-Outbox")
-        outbox_consumer = RubyEventStore::Outbox::Consumer.new(
-          options.message_format,
-          options.split_keys,
+        # ActiveRecord::Base.logger = logger if options.log_level == :debug
+        # ActiveSupport::LogSubscriber.colorize_logging = false
+        consumer_configuration = Consumer::Configuration.new(
+          split_keys: options.split_keys,
+          message_format: options.message_format,
+          batch_size: options.batch_size,
           database_url: options.database_url,
           redis_url: options.redis_url,
+        )
+        metrics = Metrics.from_url(options.metrics_url)
+        outbox_consumer = RubyEventStore::Outbox::Consumer.new(
+          options,
           logger: logger,
+          metrics: metrics,
         )
-        outbox_consumer.init
-        outbox_consumer.run
       end
     end
   end

data/lib/ruby_event_store/outbox/consumer.rb

@@ -9,14 +9,46 @@ module RubyEventStore
     class Consumer
       SLEEP_TIME_WHEN_NOTHING_TO_DO = 0.1
 
-      def initialize(format, split_keys, database_url:, redis_url:, clock: Time, logger:)
-        @split_keys = split_keys
+      class Configuration
+        def initialize(
+          split_keys:,
+          message_format:,
+          batch_size:,
+          database_url:,
+          redis_url:
+        )
+          @split_keys = split_keys
+          @message_format = message_format
+          @batch_size = batch_size || 100
+          @database_url = database_url
+          @redis_url = redis_url
+          freeze
+        end
+
+        def with(overriden_options)
+          self.class.new(
+            split_keys: overriden_options.fetch(:split_keys, split_keys),
+            message_format: overriden_options.fetch(:message_format, message_format),
+            batch_size: overriden_options.fetch(:batch_size, batch_size),
+            database_url: overriden_options.fetch(:database_url, database_url),
+            redis_url: overriden_options.fetch(:redis_url, redis_url),
+          )
+        end
+
+        attr_reader :split_keys, :message_format, :batch_size, :database_url, :redis_url
+      end
+
+      def initialize(configuration, clock: Time, logger:, metrics:)
+        @split_keys = configuration.split_keys
         @clock = clock
-        @redis = Redis.new(url: redis_url)
+        @redis = Redis.new(url: configuration.redis_url)
         @logger = logger
-        ActiveRecord::Base.establish_connection(database_url) unless ActiveRecord::Base.connected?
+        @metrics = metrics
+        @batch_size = configuration.batch_size
+        ActiveRecord::Base.establish_connection(configuration.database_url) unless ActiveRecord::Base.connected?
+        ActiveRecord::Base.connection.execute("SET SESSION TRANSACTION ISOLATION LEVEL READ COMMITTED;")
 
-        raise "Unknown format" if format != SIDEKIQ5_FORMAT
+        raise "Unknown format" if configuration.message_format != SIDEKIQ5_FORMAT
         @message_format = SIDEKIQ5_FORMAT
 
         @gracefully_shutting_down = false
@@ -44,8 +76,11 @@ module RubyEventStore
         Record.transaction do
           records_scope = Record.lock.where(format: message_format, enqueued_at: nil)
           records_scope = records_scope.where(split_key: split_keys) if !split_keys.nil?
-          records = records_scope.order("id ASC").limit(100)
-          return false if records.empty?
+          records = records_scope.order("id ASC").limit(batch_size).to_a
+          if records.empty?
+            metrics.write_point_queue(status: "ok")
+            return false
+          end
 
           now = @clock.now.utc
           failed_record_ids = []
@@ -58,23 +93,25 @@ module RubyEventStore
             end
           end
 
-          update_scope = if failed_record_ids.empty?
-            records
-          else
-            records.where("id NOT IN (?)", failed_record_ids)
-          end
-          update_scope.update_all(enqueued_at: now)
+          updated_record_ids = records.map(&:id) - failed_record_ids
+          Record.where(id: updated_record_ids).update_all(enqueued_at: now)
+          metrics.write_point_queue(status: "ok", enqueued: updated_record_ids.size, failed: failed_record_ids.size)
 
           logger.info "Sent #{records.size} messages from outbox table"
-          return true
+          true
         end
       rescue ActiveRecord::Deadlocked
         logger.warn "Outbox fetch deadlocked"
+        metrics.write_point_queue(status: "deadlocked")
+        false
+      rescue ActiveRecord::LockWaitTimeout
+        logger.warn "Outbox fetch lock timeout"
+        metrics.write_point_queue(status: "lock_timeout")
         false
       end
 
       private
-      attr_reader :split_keys, :logger, :message_format
+      attr_reader :split_keys, :logger, :message_format, :batch_size, :metrics
 
       def handle_one_record(now, record)
         hash_payload = JSON.parse(record.payload)

data/lib/ruby_event_store/outbox/metrics.rb

@@ -0,0 +1,16 @@
+require "ruby_event_store/outbox/metrics/null"
+require "ruby_event_store/outbox/metrics/influx"
+
+module RubyEventStore
+  module Outbox
+    module Metrics
+      def self.from_url(metrics_url)
+        if metrics_url.nil?
+          Null.new
+        else
+          Influx.new(metrics_url)
+        end
+      end
+    end
+  end
+end

data/lib/ruby_event_store/outbox/metrics/influx.rb

@@ -0,0 +1,41 @@
+require 'influxdb'
+
+module RubyEventStore
+  module Outbox
+    module Metrics
+      class Influx
+        def initialize(url)
+          uri = URI.parse(url)
+          params = CGI.parse(uri.query || "")
+          options = {
+            url: url,
+            async: true,
+            time_precision: 'ns',
+          }
+          options[:username] = params["username"]&.first if params["username"].present?
+          options[:password] = params["password"]&.first if params["password"].present?
+          @influxdb_client = InfluxDB::Client.new(**options)
+        end
+
+        def write_point_queue(status:, enqueued: 0, failed: 0)
+          write_point("ruby_event_store.outbox.queue", {
+            values: {
+              enqueued: enqueued,
+              failed: failed,
+            },
+            tags: {
+              status: status,
+            }
+          })
+        end
+
+        def write_point(series, data)
+          data[:timestamp] ||= Process.clock_gettime(Process::CLOCK_REALTIME, :nanosecond).to_i
+          @influxdb_client.write_point(series, data)
+        end
+
+        attr_reader :influxdb_client
+      end
+    end
+  end
+end

data/lib/ruby_event_store/outbox/metrics/null.rb

@@ -0,0 +1,10 @@
+module RubyEventStore
+  module Outbox
+    module Metrics
+      class Null
+        def write_point_queue(status:, enqueued: 0, failed: 0)
+        end
+      end
+    end
+  end
+end

data/lib/ruby_event_store/outbox/version.rb

@@ -2,6 +2,6 @@
 
 module RubyEventStore
   module Outbox
-    VERSION = "0.0.3"
+    VERSION = "0.0.8"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_event_store-outbox
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.8
 platform: ruby
 authors:
 - Arkency
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-24 00:00:00.000000000 Z
+date: 2020-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_event_store
@@ -53,6 +53,9 @@ files:
 - lib/ruby_event_store/outbox.rb
 - lib/ruby_event_store/outbox/cli.rb
 - lib/ruby_event_store/outbox/consumer.rb
+- lib/ruby_event_store/outbox/metrics.rb
+- lib/ruby_event_store/outbox/metrics/influx.rb
+- lib/ruby_event_store/outbox/metrics/null.rb
 - lib/ruby_event_store/outbox/record.rb
 - lib/ruby_event_store/outbox/sidekiq5_format.rb
 - lib/ruby_event_store/outbox/sidekiq_message_handler.rb