ruby_core_extensions 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73d409278a49f15845c54d39663e24a0942bd004
-  data.tar.gz: 61a669479de59c7b8e9105d674cc44d28824151a
+  metadata.gz: 702cb94d4f6195649a0c4ed456219c865a4883db
+  data.tar.gz: b03377cd78457c6949efc0278ae875d3a243074d
 SHA512:
-  metadata.gz: addb261d51cdd07ced187a5efefa83d474d712875133108585a255be62168add46445b532a7816292466110c8766720394f91012c2b38db2e584a70830b700de
-  data.tar.gz: 3e37676250b767f9d97808b353e25e187c386de97f99ec457ff8a6823a7c25fbb8c74195e3488e0ed367de7db71aabb5b18ed9e600d10b558b5d839a908cbe47
+  metadata.gz: 24b92150e349a329f51e9f88b7f5e6ff491f583e2e26d93b394605debc86274171e1a7f339b1cd27dde2e197987ee668f14cba88c194c5c77c532948ea7a624a
+  data.tar.gz: c22a0acd4cea5b4cc86afbd035203ee7a87c4742ccc6b8c68cc810f2d848fcb25bb320d6ab01c7cdb09138b98efa1284507a215f160b23398550a532d73ae6d5

data/.rubocop.yml

@@ -0,0 +1,21 @@
+inherit_gem:
+  rubocop-rails:
+    - config/rails.yml
+
+AllCops:
+  TargetRubyVersion: 2.4
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/StringLiterals:
+  Enabled: false
+
+Layout/IndentationWidth:
+  IgnoredPatterns: ['^\s*private$']
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 100

data/CHANGELOG.md

@@ -0,0 +1,22 @@
+# Change Log
+All notable changes to this project will be documented in this file.  
+This project adheres to [Semantic Versioning](http://semver.org/).  
+This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).  
+
+## Unreleased
+
+## 0.1.0
+
+### Added
+- [TT-4020] Implemented Rubocop
+
+### Removed
+- Remove no longer supported Array methods #to_param/#show_name
+
+### Changed
+- stringify_values_recursively now just works on to_s for all objects
+
+## 0.0.1
+
+### Added
+- [TT-1392] Changelog file

data/Rakefile

@@ -1,7 +1,7 @@
 require "bundler/gem_tasks"
 
 desc 'Default: run specs.'
-task :default => :spec
+task default: :spec
 
 require 'rspec/core/rake_task'
 

data/gemfiles/rails3.gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-gemspec :path => '../'
+gemspec path: '../'
 
 group :development, :test do
   gem 'rake'

data/gemfiles/rails4.gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
-gemspec :path => '../'
+gemspec path: '../'
 
 group :development, :test do
   gem 'rake'

data/lib/ruby_core_extensions/array.rb

@@ -1,13 +1,4 @@
 class Array
-
-  def to_param
-    self.collect { |element| element.respond_to?(:to_param) ? element.to_param : element }
-  end
-
-  def show_name
-    first.titleize
-  end
-
   # Key should be unique, or latest element with that key will override previous ones.
   def hash_by(key = nil, method = nil, &block)
     self.inject({}) do |h, element|
@@ -31,7 +22,7 @@ class Array
   end
 
   def intersects?(other)
-    self.any?{|i| other.include?(i)}
+    self.any? { |i| other.include?(i) }
   end
 
   # Same effect as Array.wrap(object).first

data/lib/ruby_core_extensions/class.rb

@@ -1,8 +1,5 @@
 class Class
-  
   def downcase_symbol
     self.to_s.downcase.to_sym
   end
-  
 end
-

data/lib/ruby_core_extensions/compact/array.rb

@@ -1,6 +1,6 @@
 class Array
   def compact_blank!
-    delete_if{|v| v.blank?}
+    delete_if { |v| v.blank? }
   end
 
   def recursive_compact_blank!
@@ -17,4 +17,3 @@ class Array
     end
   end
 end
-

data/lib/ruby_core_extensions/compact/hash.rb

@@ -6,7 +6,7 @@ class Hash
 
   # Remove nil values - !desctructively!
   def compact!
-    delete_if{|k,v| v.nil?}
+    delete_if { |k, v| v.nil? }
   end
 
   def compact_blank
@@ -14,11 +14,11 @@ class Hash
   end
 
   def compact_blank!
-    delete_if{|k,v| v.blank?}
+    delete_if { |k, v| v.blank? }
   end
 
   def recursive_compact_blank!
-    delete_if do |k,v|
+    delete_if do |k, v|
       if v.is_a?(Hash)
         v.recursive_compact_blank!
         v.recursive_blank?
@@ -31,4 +31,3 @@ class Hash
     end
   end
 end
-

data/lib/ruby_core_extensions/enumerable.rb

@@ -1,5 +1,4 @@
 module Enumerable
-
   def map_methods(*methods)
     map do |object|
       methods.inject({}) do |h, method|
@@ -34,6 +33,4 @@ module Enumerable
       obj
     end
   end
-
 end
-

data/lib/ruby_core_extensions/file.rb

@@ -9,4 +9,3 @@ class File
       gsub(/\-+/, '-') # limit - character to once
   end
 end
-

data/lib/ruby_core_extensions/hash.rb

@@ -1,7 +1,6 @@
 class Hash
-
   unless self.method_defined?(:extract!)
-    #Imported from Rails 3
+    # Imported from Rails 3
     def extract!(*keys)
       result = {}
       keys.each { |key| result[key] = delete(key) }
@@ -12,23 +11,22 @@ class Hash
 
   def map_key_value(key_method, value_method = nil)
     value_method ||= key_method
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k.send(key_method)] = v.send(value_method)
     end
   end
 
 
   def map_key(method)
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k.send(method)] = v
     end
   end
 
 
   def map_value(method)
-    each.with_object({}) do |(k,v), new_hash|
+    each.with_object({}) do |(k, v), new_hash|
       new_hash[k] = v.send(method)
     end
   end
-
 end

data/lib/ruby_core_extensions/kernel.rb

@@ -1,5 +1,4 @@
 module Kernel
-
   def require_dirs(dirs)
     Array.wrap(dirs).each do |load_path|
       Dir.glob("#{load_path}/**/*.rb").each do |file|
@@ -7,5 +6,4 @@ module Kernel
       end
     end
   end
-  
 end

data/lib/ruby_core_extensions/numeric.rb

@@ -1,7 +1,5 @@
 class Numeric
-  
   def to_bool
     !zero?
   end
-  
 end

data/lib/ruby_core_extensions/object.rb

@@ -3,16 +3,16 @@ class Object
   def sounds_like?(other)
     self.phonetic_code == other.phonetic_code
   end
-  
+
   # Convert this object into a string, then convert that to phonetic code
   def phonetic_code
     self.to_s.phonetic_code
   end
-  
+
   def to_long_s
     to_s
   end
-  
+
   def virtual_belongs_to(*associations)
     options = associations.extract_options!
 
@@ -62,11 +62,9 @@ class Object
       end
     EVAL
   end
-  
-  
+
+
   def to_bool
     self.to_s.to_bool
   end
-  
 end
-

data/lib/ruby_core_extensions/recursive/array.rb

@@ -1,45 +1,43 @@
- class Array 
-   
-  def convert
-    self
-  end
+ class Array
+   def convert
+     self
+   end
 
-  def convert_keys_recursively(&converter)
-    map { |v| v.convert_keys_recursively(&converter) }
-  end
-  
-  def convert_values_recursively(&converter)
-    map { |v| v.convert_values_recursively(&converter) }
-  end
-  
-  def symbolize_keys_recursively
-    map(&:symbolize_keys_recursively)
-  end
-  
-  def stringify_values_recursively
-    map(&:stringify_values_recursively)
-  end
-  
-  def make_indifferent_access_recursively
-    map(&:make_indifferent_access_recursively)
-  end
-  
-  def recursive_blank?
-    each do |v|
-      if v.respond_to?(:recursive_blank?)
-        return false unless v.recursive_blank?
-      else
-        return false unless v.blank?
-      end
-    end
-    true
-  end
-  
-  def recursively(&block)
-    each do |element|
-      block.call(element)
-      element.recursively(&block) if element.respond_to?(:recursively)
-    end
-  end
-  
-end
+   def convert_keys_recursively(&converter)
+     map { |v| v.convert_keys_recursively(&converter) }
+   end
+
+   def convert_values_recursively(&converter)
+     map { |v| v.convert_values_recursively(&converter) }
+   end
+
+   def symbolize_keys_recursively
+     map(&:symbolize_keys_recursively)
+   end
+
+   def stringify_values_recursively
+     map(&:stringify_values_recursively)
+   end
+
+   def make_indifferent_access_recursively
+     map(&:make_indifferent_access_recursively)
+   end
+
+   def recursive_blank?
+     each do |v|
+       if v.respond_to?(:recursive_blank?)
+         return false unless v.recursive_blank?
+       else
+         return false unless v.blank?
+       end
+     end
+     true
+   end
+
+   def recursively(&block)
+     each do |element|
+       block.call(element)
+       element.recursively(&block) if element.respond_to?(:recursively)
+     end
+   end
+ end

data/lib/ruby_core_extensions/recursive/hash.rb

@@ -1,5 +1,4 @@
 class Hash
-
   def recursive_blank?
     each do |k, v|
       if v.respond_to?(:recursive_blank?)
@@ -10,18 +9,18 @@ class Hash
     end
     true
   end
-  
+
   def convert
     self
   end
-  
+
   def convert_keys(&converter)
     inject({}) do |hash, (key, value)|
       hash[converter.call(key)] = value
       hash
     end
   end
-  
+
   def convert_values(*keys, &converter)
     inject(clone) do |hash, (key, value)|
       hash[key] = value.convert(&converter) if keys.blank? || keys.include?(key)
@@ -33,54 +32,52 @@ class Hash
     Hash[map do |key, value|
           k = converter.call(key)
           v = value.convert_keys_recursively(&converter)
-          [k,v]
+          [k, v]
         end]
   end
-  
+
   def convert_values_recursively(&converter)
     inject({}) do |hash, (key, value)|
       hash[key] = value.convert_values_recursively(&converter)
       hash
     end
   end
-  
+
   def symbolize_keys_recursively
     Hash[map do |key, value|
           k = key.is_a?(String) ? key.to_sym : key
           v = value.symbolize_keys_recursively
-          [k,v]
+          [k, v]
         end]
   end
-  
+
   def stringify_values_recursively
     inject({}) do |options, (key, value)|
       options[key] = value.stringify_values_recursively
       options
     end
   end
-  
+
   def make_indifferent_access_recursively
     HashWithIndifferentAccess.new(inject({}) do |options, (key, value)|
         options[key] = value.make_indifferent_access_recursively
         options
       end)
   end
-  
+
   def deep_dup
     duplicate = self.dup
-    duplicate.each_pair do |k,v|
+    duplicate.each_pair do |k, v|
       tv = duplicate[k]
       duplicate[k] = tv.is_a?(Hash) && v.is_a?(Hash) ? tv.deep_dup : v
     end
     duplicate
   end
-  
+
   def recursively(&block)
-    each do |key,value|
-      block.call(key,value)
+    each do |key, value|
+      block.call(key, value)
       value.recursively(&block) if value.respond_to?(:recursively)
     end
   end
-  
 end
-

data/lib/ruby_core_extensions/recursive/object.rb

@@ -2,16 +2,20 @@ class Object
   def convert(&converter)
     converter.call(self)
   end
-  
+
   def return_self
     self
   end
-  
+
+  def return_to_s
+    to_s
+  end
+
   alias_method :convert_values_recursively, :convert
   alias_method :convert_recursively, :convert
-  
+
   alias_method :convert_keys_recursively, :return_self
   alias_method :symbolize_keys_recursively, :return_self
-  alias_method :stringify_values_recursively, :return_self
+  alias_method :stringify_values_recursively, :return_to_s
   alias_method :make_indifferent_access_recursively, :return_self
 end

data/lib/ruby_core_extensions/recursive.rb

@@ -1,8 +1,3 @@
 require 'ruby_core_extensions/recursive/array'
-require 'ruby_core_extensions/recursive/big_decimal'
-require 'ruby_core_extensions/recursive/date'
-require 'ruby_core_extensions/recursive/date_time'
-require 'ruby_core_extensions/recursive/fixnum'
 require 'ruby_core_extensions/recursive/hash'
 require 'ruby_core_extensions/recursive/object'
-require 'ruby_core_extensions/recursive/time'

data/lib/ruby_core_extensions/string.rb

@@ -1,8 +1,8 @@
 class String
   def proper_underscore
-    self.titleize.gsub(" ","").underscore
+    self.titleize.gsub(" ", "").underscore
   end
-  
+
   # Generate a phonetic code - which is the same for similar sounding names
   def phonetic_code
     # Currently using 'metaphone' which is more accurate than soundex
@@ -11,7 +11,7 @@ class String
 
   # Solr requires numbers and letters to be separated
   def separate_numbers_and_letters
-    gsub(/[a-z][0-9]|[0-9][a-z]/i){ |s| s[0].chr + ' ' + s[1].chr }
+    gsub(/[a-z][0-9]|[0-9][a-z]/i) { |s| s[0].chr + ' ' + s[1].chr }
   end
 
   # convert newlines to breaks
@@ -42,13 +42,13 @@ class String
     words = split(' ')
 
     # Return first letter of <limit> words
-    return words.first(limit).map{|w| w.chars.first}.join if (words.size * 2 - 1) >= limit
+    return words.first(limit).map { |w| w.chars.first }.join if (words.size * 2 - 1) >= limit
 
     spaces = words.size - 1
     word_char_min = (limit - spaces) / words.size
     word_char_max = word_char_min + 1
 
-    words = words.map{|word| word[0..(word_char_max - 1)]}
+    words = words.map { |word| word[0..(word_char_max - 1)] }
 
     words.reverse.each.with_index do |word, index|
       letters_to_remove = words.join(' ').size - limit
@@ -60,19 +60,18 @@ class String
       end
 
       # Replace word
-      words[words.size -  index - 1] = word[0..(letters_to_keep - 1)]
+      words[words.size - index - 1] = word[0..(letters_to_keep - 1)]
 
       break if last_case
     end
 
     words.join(' ')
   end
-  
-  
+
+
   def to_bool
     return true if self == true || self =~ (/(true|t|yes|y|1)$/i)
     return false if self == false || self.blank? || self =~ (/(false|f|no|n|0)$/i)
     raise ArgumentError.new("invalid value for Boolean: \"#{self}\"")
   end
 end
-

data/lib/ruby_core_extensions/version.rb

@@ -1,3 +1,3 @@
 module RubyCoreExtensions
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 end

data/ruby_core_extensions.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ruby_core_extensions/version'
@@ -25,8 +26,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'coverage-kit'
   spec.add_development_dependency 'simplecov-rcov'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'travis'
+  spec.add_development_dependency 'rubocop-rails'
 end

data/spec/array_spec.rb

@@ -1,10 +1,21 @@
 require 'spec_helper'
 
 describe Array do
-
   it "should allow converting all values to strings recursively" do
-    @now = Time.now
-    expect([1, 2, @now, [3, 4]].stringify_values_recursively).to eq ['1', '2', @now.to_s, ['3', '4']]
+    to_s_class = Class.new do
+      def to_s
+        'Myself'
+      end
+    end
+    stringify_values_recursively_class = Class.new do
+      def stringify_values_recursively
+        'Special'
+      end
+    end
+    now = Time.now
+    array = [1, 2, now, [3, 4], to_s_class.new, stringify_values_recursively_class.new]
+    output = ['1', '2', now.to_s, %w[3 4], 'Myself', 'Special']
+    expect(array.stringify_values_recursively).to eq output
   end
 
   it "should allow removing all blank values" do
@@ -14,30 +25,40 @@ describe Array do
   end
 
   it "should allow removing all blank values recursively" do
-    a = [1, 2, [" Kan", {}], nil, {:a => "", :b => {}}, ["garoos", " "]]
+    a = [1, 2, [" Kan", {}], nil, { a: "", b: {} }, ["garoos", " "]]
     a.recursive_compact_blank!
     expect(a.join).to eq "12 Kangaroos"
   end
 
   it "should allow verifying if all elements are blank recursively" do
-    expect(['',nil,[nil,['']]]).to be_recursive_blank
-    expect(['',nil,[nil,['',1]]]).to_not be_recursive_blank
+    expect(['', nil, [nil, ['']]]).to be_recursive_blank
+    expect(['', nil, [nil, ['', 1]]]).to_not be_recursive_blank
   end
 
   it "should allow converting to hash given a key" do
-    expect([1,2,3].hash_by(:ordinalize)).to eq({'1st' => 1, "2nd" => 2, "3rd" => 3})
-    expect([1,2,3].hash_by(:ordinalize, :to_s)).to eq({'1st' => '1', "2nd" => '2', "3rd" => '3'})
-    expect([1,2,3].hash_by(:ordinalize){ |v| v + 1 }).to eq({'1st' => 2, "2nd" => 3, "3rd" => 4})
-    expect([1,2,3].hash_by{|k| k * 2}).to eq({2 => 1, 4 => 2, 6 => 3})
+    expect([1, 2, 3].hash_by(:ordinalize)).to eq({ '1st' => 1, "2nd" => 2, "3rd" => 3 })
+    expect([1, 2, 3].hash_by(:ordinalize, :to_s)).to eq(
+      { '1st' => '1', "2nd" => '2', "3rd" => '3' }
+    )
+    expect([1, 2, 3].hash_by(:ordinalize) { |v| v + 1 }).to eq(
+      { '1st' => 2, "2nd" => 3, "3rd" => 4 }
+    )
+    expect([1, 2, 3].hash_by { |k| k * 2 }).to eq({ 2 => 1, 4 => 2, 6 => 3 })
+  end
+
+  it "#hash_by_id" do
+    one = double(id: 1, name: 'One')
+    two = double(id: 2, name: 'Two')
+    expect([one, two].hash_by_id).to eq(1 => one, 2 => two)
   end
 
   it "should allow executing blocks recursively" do
-    array = [1,[2,3],[4,[5,6],7,[8]],9,[[10]]]
+    array = [1, [2, 3], [4, [5, 6], 7, [8]], 9, [[10]]]
     result = []
     array.recursively do |e|
       result << e unless e.is_a?(Array)
     end
-    expect(result).to eq [1,2,3,4,5,6,7,8,9,10]
+    expect(result).to eq [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
   end
 
   it '#intersects?' do

data/spec/compact_spec.rb

@@ -6,11 +6,11 @@ describe Array, 'compact' do
   end
 
   it 'should recursive compact blank' do
-    a = [1, nil, {:a => nil, :b => 2}]
+    a = [1, nil, { a: nil, b: 2 }]
     a.recursive_compact_blank!
-    expect(a).to eq [1, {:b => 2}]
+    expect(a).to eq [1, { b: 2 }]
 
-    b = [1, nil, {:a => nil}]
+    b = [1, nil, { a: nil }]
     b.recursive_compact_blank!
     expect(b).to eq [1]
   end
@@ -18,32 +18,32 @@ end
 
 describe Hash, 'compact' do
   it 'should compact' do
-    expect({:a => 1, :b => nil}.compact).to eq({:a => 1})
+    expect({ a: 1, b: nil }.compact).to eq({ a: 1 })
   end
 
   it 'should compact!' do
-    a = {:a => 1, :b => nil}
+    a = { a: 1, b: nil }
     a.compact!
-    expect(a).to eq({:a => 1})
+    expect(a).to eq({ a: 1 })
   end
 
   it 'should compact blank' do
-    expect({:a => 1, :b => ''}.compact_blank).to eq({:a => 1})
+    expect({ a: 1, b: '' }.compact_blank).to eq({ a: 1 })
   end
 
   it 'should compact blank!' do
-    a = {:a => 1, :b => ''}
+    a = { a: 1, b: '' }
     a.compact_blank!
-    expect(a).to eq({:a => 1})
+    expect(a).to eq({ a: 1 })
   end
 
   it 'should recursive compact blank!' do
-    a = {:a => 1, :b => {:c => 1, :d => ''}}
+    a = { a: 1, b: { c: 1, d: '' } }
     a.recursive_compact_blank!
-    expect(a).to eq({:a => 1, :b => {:c => 1}})
+    expect(a).to eq({ a: 1, b: { c: 1 } })
 
-    a = {:a => 1, :b => {:c => [], :d => ''}}
+    a = { a: 1, b: { c: [], d: '' } }
     a.recursive_compact_blank!
-    expect(a).to eq({:a => 1})
+    expect(a).to eq({ a: 1 })
   end
 end

data/spec/enumerable_spec.rb

@@ -1,24 +1,28 @@
 require 'spec_helper'
 
 describe Enumerable do
-  
-  it 'should allow mapping elements of the collection to hashes associating method names to the returned values for each method' do
-    expect([1,2,3].map_methods(:to_s,:to_f)).to eq [{:to_s => '1', :to_f => 1.0}, {:to_s => '2', :to_f => 2.0}, {:to_s => '3', :to_f => 3.0}]
+
+  it 'allow mapping elements to hashes with method names of the returned values for each method' do
+    expect([1, 2, 3].map_methods(:to_s, :to_f)).to eq(
+      [{ to_s: '1', to_f: 1.0 }, { to_s: '2', to_f: 2.0 }, { to_s: '3', to_f: 3.0 }]
+    )
   end
 
 
   context 'when detecting and returning the block value' do
-    it { expect([1,2,3].detect_and_return { |number| number.even? && number * number }).to eq 4 }
-    it { expect([1,3,5].detect_and_return { |number| number.even? && number * number }).to be nil }
+    it { expect([1, 2, 3].detect_and_return { |number| number.even? && number * number }).to eq 4 }
+    it { expect([1, 3, 5].detect_and_return { |number|
+      number.even? && number * number }).to be nil
+    }
   end
 
 
   it 'should allow selecting by attribute' do
-    one = double(:name => 'one', :type => 'odd')
-    two = double(:name => 'two', :type => 'even')
-    thr = double(:name => 'thr', :type => 'odd')
+    one = double(name: 'one', type: 'odd')
+    two = double(name: 'two', type: 'even')
+    thr = double(name: 'thr', type: 'odd')
     expect([one, two, thr].select_by_attr(:type, 'odd')).to eq [one, thr]
     expect([one, two, thr].select_by_attr(:type, 'even')).to eq [two]
   end
-  
+
 end

data/spec/filename_spec.rb

@@ -14,4 +14,3 @@ describe File do
     File.safe_name(from)
   end
 end
-

data/spec/hash_spec.rb

@@ -3,14 +3,21 @@ require 'spec_helper'
 describe Hash do
 
   before do
-    @sub_array1 = [3, BigDecimal('4'), Date.new(2000, 1, 1), DateTime.new(2000, 1, 1, 0, 0, 0), {:f  => 5}]
-    @sub_array2 = [3, BigDecimal('4'), Date.new(2000, 1, 1), DateTime.new(2000, 1, 1, 0, 0, 0), {'f'  => 5}]
-    @hash1 = {:a  => 1, :b  => {:c  => 2}, :d => 'test', :e  => @sub_array1}
-    @hash2 = {'a' => 1, 'b' => {'c' => 2}, :d => 'test', 'e' => @sub_array2}
+    @sub_array1 = [3, BigDecimal('4'), Date.new(2000, 1, 1),
+                   DateTime.new(2000, 1, 1, 0, 0, 0), { f: 5 }]
+    @sub_array2 = [3, BigDecimal('4'), Date.new(2000, 1, 1),
+                   DateTime.new(2000, 1, 1, 0, 0, 0), { 'f' => 5 }]
+    @hash1 = { a: 1, b: { c: 2 }, d: 'test', e: @sub_array1 }
+    @hash2 = { 'a' => 1, 'b' => { 'c' => 2 }, :d => 'test', 'e' => @sub_array2 }
   end
 
   it "should allow converting all values to strings recursively" do
-    expect(@hash1.stringify_values_recursively).to eq({:a => "1", :b => {:c => "2"}, :d => "test", :e => ["3", '4.0', "2000-01-01", '2000-01-01T00:00:00+00:00', {:f => "5"}]})
+    expect(@hash1.stringify_values_recursively).to eq(
+      {
+        a: "1", b: { c: "2" }, d: "test",
+        e: ["3", '4.0', "2000-01-01", '2000-01-01T00:00:00+00:00', { f: "5" }]
+      }
+    )
   end
 
   it "should allow converting all keys to symbols recursively" do
@@ -18,29 +25,33 @@ describe Hash do
   end
 
   it "should allow converting keys" do
-    expect(@hash1.convert_keys(&:to_s)).to eq({"a" => 1, "b" => {:c => 2}, "d" => "test", "e" => @sub_array1})
+    expect(@hash1.convert_keys(&:to_s)).to eq(
+      { "a" => 1, "b" => { c: 2 }, "d" => "test", "e" => @sub_array1 }
+    )
   end
 
   it "should allow converting values" do
-    expect(@hash1.convert_values(&:to_s)).to eq({:a => "1", :b => {:c => 2}, :d => "test", :e => @sub_array1})
+    expect(@hash1.convert_values(&:to_s)).to eq({ a: "1", b: { c: 2 }, d: "test", e: @sub_array1 })
   end
-  
+
   it "should allow converting values only for specific keys" do
-    expect(@hash1.convert_values(:d, :e, &:to_s)).to eq({:a => 1, :b => {:c => 2}, :d => "test", :e => @sub_array1})
+    expect(@hash1.convert_values(:d, :e, &:to_s)).to eq(
+      { a: 1, b: { c: 2 }, d: "test", e: @sub_array1 }
+    )
   end
 
   it "should allow making indifferent access recursively" do
     expect(@hash1.make_indifferent_access_recursively['b']['c']).to eq 2
     expect(@hash1.make_indifferent_access_recursively['e'][4]['f']).to eq 5
   end
-  
+
   it "should allow executing blocks recursively" do
-    hash = {:a => 1, :b => {:a => 2}, :c => {:a => 3, :b => 4, :c => {:a => 5}}}
+    hash = { a: 1, b: { a: 2 }, c: { a: 3, b: 4, c: { a: 5 } } }
     result = []
-    hash.recursively do |k,v|
+    hash.recursively do |k, v|
       result << v unless v.is_a?(Hash)
-    end 
-    expect(result.sort).to eq [1,2,3,4,5] # Ruby 1.8.7 doesn't order hash keys
+    end
+    expect(result.sort).to eq [1, 2, 3, 4, 5] # Ruby 1.8.7 doesn't order hash keys
   end
 
 end
@@ -49,36 +60,36 @@ end
 describe Hash do
 
   it 'should allow removing all nil values and return a new hash' do
-    expect({:a => 1, :b => nil}.compact).to eq({:a => 1})
+    expect({ a: 1, b: nil }.compact).to eq({ a: 1 })
   end
 
   it 'should allow removing all nil values' do
-    a = {:a => 1, :b => nil}
+    a = { a: 1, b: nil }
     a.compact!
-    expect(a).to eq({:a => 1})
+    expect(a).to eq({ a: 1 })
   end
 
   it 'should allow removing all nil values and return a new hash' do
-    expect({:a => 1, :b => ''}.compact_blank).to eq({:a => 1})
+    expect({ a: 1, b: '' }.compact_blank).to eq({ a: 1 })
   end
 
   it 'should allow removing all blank values' do
-    a = {:a => 1, :b => ''}
+    a = { a: 1, b: '' }
     a.compact_blank!
-    expect(a).to eq({:a => 1})
+    expect(a).to eq({ a: 1 })
   end
 
   it 'should allow removing all blank values recursively' do
-    a = {:a => 1, :b => {:c => 1, :d => '', :e => []}}
+    a = { a: 1, b: { c: 1, d: '', e: [] } }
     a.recursive_compact_blank!
-    expect(a).to eq({:a => 1, :b => {:c => 1}})
+    expect(a).to eq({ a: 1, b: { c: 1 } })
   end
 
   it 'should allow extracting subsets' do
-    a = {:a => 1, :b => 2, :c => 3}
+    a = { a: 1, b: 2, c: 3 }
     b = a.extract!(:a, :c)
-    expect(b).to eq({:a => 1, :c => 3})
-    expect(a).to eq({:b => 2})
+    expect(b).to eq({ a: 1, c: 3 })
+    expect(a).to eq({ b: 2 })
   end
 
 end
@@ -86,22 +97,22 @@ end
 
 describe Hash, '#map_key_value' do
 
-  subject { {'1' => '2', 3 => 4} }
+  subject { { '1' => '2', 3 => 4 } }
 
   it 'should map key' do
-    expect(subject.map_key(:to_i)).to eq({1 => '2', 3 => 4})
+    expect(subject.map_key(:to_i)).to eq({ 1 => '2', 3 => 4 })
   end
 
   it 'should map value' do
-    expect(subject.map_value(:to_i)).to eq({'1' => 2, 3 => 4})
+    expect(subject.map_value(:to_i)).to eq({ '1' => 2, 3 => 4 })
   end
 
   it 'should map key and value' do
-    expect(subject.map_key_value(:to_i, :to_i)).to eq({1 => 2, 3 => 4})
+    expect(subject.map_key_value(:to_i, :to_i)).to eq({ 1 => 2, 3 => 4 })
   end
 
   it 'should map key and value if value not specified' do
-    expect(subject.map_key_value(:to_i)).to eq({1 => 2, 3 => 4})
+    expect(subject.map_key_value(:to_i)).to eq({ 1 => 2, 3 => 4 })
   end
 
 end

data/spec/object_spec.rb

@@ -26,14 +26,13 @@ describe Object do
   class ReadyError < StandardError; end
 
   class BooleanizeTest
-
     attr_accessor :ready
 
     def verify!
-      fail ArgumentError, "Ready should be a boolean" unless ready.is_a?(TrueClass) || ready.is_a?(FalseClass)
+      fail ArgumentError, "Ready should be a boolean" unless ready.is_a?(TrueClass) ||
+        ready.is_a?(FalseClass)
       fail ReadyError, "Not ready" unless ready
     end
-
   end
 
 
@@ -42,8 +41,8 @@ describe Object do
   end
 
 
-  it "should allow defining methods that will return boolean depending on the execution of another method" do
-    expect { @object.booleanize(:verify!, :rescue => ReadyError) }.to_not raise_error
+  it "allows defining methods that return boolean depending on the execution of another method" do
+    expect { @object.booleanize(:verify!, rescue: ReadyError) }.to_not raise_error
     expect { @object.verify? }.to raise_error(ArgumentError, 'Ready should be a boolean')
     @object.ready = false
     expect { @object.verify? }.to_not raise_error

data/spec/string_spec.rb

@@ -1,7 +1,9 @@
 describe String do
 
   it "should convert to underscore replacing spaces with underscores" do
-    expect("CamelCase UPPERCASE to be_Converted".proper_underscore).to eq "camel_case_uppercase_to_be_converted"
+    expect("CamelCase UPPERCASE to be_Converted".proper_underscore).to eq(
+      "camel_case_uppercase_to_be_converted"
+    )
   end
 
   it 'should separate numbers and letters' do

data/spec/support/coverage.rb

@@ -1,29 +1,4 @@
-MINIMUM_COVERAGE = 87
-
-unless ENV['COVERAGE'] == 'off'
-  require 'simplecov'
-  require 'simplecov-rcov'
-  require 'coveralls'
-  Coveralls.wear!
-
-  SimpleCov.formatters = [
-    SimpleCov::Formatter::RcovFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-  SimpleCov.start do
-    add_filter '/vendor/'
-    add_filter '/spec/'
-    add_filter '/lib/error_handling/'
-    add_group 'lib', 'lib'
-  end
-  SimpleCov.at_exit do
-    SimpleCov.result.format!
-    percent = SimpleCov.result.covered_percent
-    unless percent >= MINIMUM_COVERAGE
-      puts '*' * 80
-      puts "Coverage must be above #{MINIMUM_COVERAGE}%. It is #{format('%.2f', percent)}%"
-      puts '*' * 80
-      Kernel.exit(1)
-    end
-  end
-end
+require 'simplecov-rcov'
+require 'coveralls'
+require 'coverage/kit'
+Coverage::Kit.setup(minimum_coverage: 87.2)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_core_extensions
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Michael Noack
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-17 00:00:00.000000000 Z
+date: 2018-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -82,7 +82,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coverage-kit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,6 +137,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: These are extensions from core ruby classes.
 email: development@travellink.com.au
 executables: []
@@ -145,7 +159,9 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -166,13 +182,8 @@ files:
 - lib/ruby_core_extensions/object.rb
 - lib/ruby_core_extensions/recursive.rb
 - lib/ruby_core_extensions/recursive/array.rb
-- lib/ruby_core_extensions/recursive/big_decimal.rb
-- lib/ruby_core_extensions/recursive/date.rb
-- lib/ruby_core_extensions/recursive/date_time.rb
-- lib/ruby_core_extensions/recursive/fixnum.rb
 - lib/ruby_core_extensions/recursive/hash.rb
 - lib/ruby_core_extensions/recursive/object.rb
-- lib/ruby_core_extensions/recursive/time.rb
 - lib/ruby_core_extensions/string.rb
 - lib/ruby_core_extensions/version.rb
 - ruby_core_extensions.gemspec
@@ -207,7 +218,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.14.1
 signing_key: 
 specification_version: 4
 summary: Set of extensions to core ruby libraries used by TravelLink Technology.

data/lib/ruby_core_extensions/recursive/big_decimal.rb

@@ -1,5 +0,0 @@
-class BigDecimal
-  def stringify_values_recursively
-    self.to_s
-  end
-end

data/lib/ruby_core_extensions/recursive/date.rb

@@ -1,8 +0,0 @@
-class Date
-  
-  def stringify_values_recursively
-    self.to_s
-  end
-  
-end
-

data/lib/ruby_core_extensions/recursive/date_time.rb

@@ -1,8 +0,0 @@
-class DateTime
-  
-  def stringify_values_recursively
-    self.to_s
-  end
-  
-end
-

data/lib/ruby_core_extensions/recursive/fixnum.rb

@@ -1,7 +0,0 @@
-class Fixnum
-
-  def stringify_values_recursively
-    to_s
-  end
-
-end

data/lib/ruby_core_extensions/recursive/time.rb

@@ -1,8 +0,0 @@
-class Time
-  
-  def stringify_values_recursively
-    self.to_s
-  end
-  
-end
-