ruby_bugzilla 0.2.0 → 0.3.0

data/lib/ruby_bugzilla/version.rb

@@ -1,3 +1,3 @@
 class RubyBugzilla
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/ruby_bugzilla.rb

@@ -126,6 +126,65 @@ class RubyBugzilla
     [self.string_command(CMD, params), query_cmd_result.output]
   end
 
+
+  #
+  # Example Usage:
+  #
+  #  bugids can be an Array of bug ids, a String or Fixnum
+  #  containing a single bug id 
+  #
+  #  options are a hash of options supported by python-bugzilla
+  #
+  #  Set the status of multiple bugs to RELEASE_PENDING:
+  #  RubyBugzilla.modify([948970, 948971], :status => "RELEASE_PENDING")
+  #
+  #  Add a comment
+  #  RubyBugzilla.modify("948972", :comment => "whatevs")
+  #
+  #  Set the status to POST and add a comment
+  #  RubyBugzilla.modify(948970, :status => "POST", :comment => "Fixed in shabla")
+  #
+  def self.modify(bugids_arg, options)
+
+    raise "Please install python-bugzilla" unless File.exists?(File.expand_path(CMD))
+
+    bugids = Array(bugids_arg)
+    if bugids.empty? || options.empty? || bugids_arg.to_s.empty?
+      raise ArgumentError, "bugids and options must be specified"
+    end
+
+    uri_opt, debug_opt = self.options
+    params = {}
+
+    params["--bugzilla="]     = "#{uri_opt}/xmlrpc.cgi" unless uri_opt.nil?
+    params["modify"]          = nil
+
+    self.set_params_bugids(params, bugids)
+    self.set_params_options(params, options)
+
+    begin 
+      modify_cmd_result = LinuxAdmin.run!(CMD, :params => params)
+    rescue => error
+      raise "#{self.string_command(CMD, params)} Failed.\n#{error}"
+    end
+
+    self.string_command(CMD, params)
+  end
+
+  private
+  def self.set_params_options(params, options)
+    options.each do |key,value|
+      params["--#{key}="] = value
+    end
+  end
+
+  private
+  def self.set_params_bugids(params, bugids)
+    bugids.each do |bugid|
+      params[bugid] = nil
+    end
+  end
+
   private
   def self.string_command(cmd, params = {}, password=nil)
     scrubbed_str = str = ""
@@ -134,7 +193,11 @@ class RubyBugzilla
       if value.kind_of?(Array)
         str << " #{param} \"#{value.join(" ")}\" "
       else
-        str << " #{param}\"#{value}\" "
+        if value.to_s.length == 0
+          str << " #{param} "
+        else
+          str << " #{param}\"#{value}\" "
+        end
       end
     end
     scrubbed_str = str.sub(password, "********") unless password.nil?

data/spec/ruby_bugzilla_spec.rb

@@ -59,12 +59,11 @@ describe RubyBugzilla do
   end
 
   context "#login!" do
-
     it "when the bugzilla command is not found" do
       ignore_warnings do
         RubyBugzilla::CMD = '/This/cmd/does/not/exist'
       end
-      expect{RubyBugzilla.login!}.to raise_exception
+      expect { RubyBugzilla.login! }.to raise_exception
     end
 
     it "when the bugzilla login command produces output" do
@@ -90,19 +89,18 @@ describe RubyBugzilla do
   end
 
   context "#query" do
-
     it "when the bugzilla command is not found" do
       ignore_warnings do
         RubyBugzilla::CMD = '/This/cmd/does/not/exist'
       end
-      expect{RubyBugzilla.query}.to raise_exception
+      expect { RubyBugzilla.query }.to raise_exception
     end
 
     it "when no product is specified" do
       ignore_warnings do
         RubyBugzilla::CMD = '/bin/echo'
       end
-      expect{RubyBugzilla.query}.to raise_error(ArgumentError)
+      expect { RubyBugzilla.query }.to raise_error(ArgumentError)
     end
 
     it "when the bugzilla query command produces output" do
@@ -123,7 +121,102 @@ describe RubyBugzilla do
         output.should include("STATUS:")
         output.should include("SUMMARY:")
     end
+  end
+
+  context "#modify" do
+    it "when the bugzilla command is not found" do
+      ignore_warnings do
+        RubyBugzilla::CMD = '/This/cmd/does/not/exist'
+      end
+      expect { RubyBugzilla.modify }.to raise_exception
+    end
+
+    it "when no arguments are specified" do
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+      end
+      expect { RubyBugzilla.modify }.to raise_error(ArgumentError)
+    end
+
+    it "when no bugids are are specified" do
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+      end
+      expect { RubyBugzilla.modify("", :status => "POST") }.to raise_error(ArgumentError)
+    end
+
+    it "when no options are specified" do
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+      end
+      expect { RubyBugzilla.modify(9, {}) }.to raise_error(ArgumentError)
+    end
+
+    it "when the bugzilla modify command succeeds for one option and multiple BZs" do
+      # Fake the command and cookies file.
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+        RubyBugzilla::COOKIES_FILE = '/This/file/does/not/exist'
+      end
+
+      cmd, output = RubyBugzilla.login!("calvin", "hobbes")
+      cmd = RubyBugzilla.modify(["948970", "948971", "948972", "948973"],
+        :status => "RELEASE_PENDING")
 
+      cmd.should include("modify")
+      cmd.should include("--status=\"RELEASE_PENDING\"")
+      cmd.should include("948970")
+      cmd.should include("948971")
+      cmd.should include("948972")
+      cmd.should include("948973")
+    end
+
+    it "when the bugzilla modify command succeeds for multiple options and a Array BZ" do
+      # Fake the command and cookies file.
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+        RubyBugzilla::COOKIES_FILE = '/This/file/does/not/exist'
+      end
+
+      cmd, output = RubyBugzilla.login!("calvin", "hobbes")
+      cmd = RubyBugzilla.modify(bugids = ["948972"],
+        options = { :status => "POST", :comment => "Fixed in shabla" } )
+
+      cmd.should include("modify")
+      cmd.should include("--status=\"POST\"")
+      cmd.should include("948972")
+      cmd.should include("Fixed in shabla")
+    end
+
+    it "when the bugzilla modify command succeeds for a Fixnum BZ" do
+      # Fake the command and cookies file.
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+        RubyBugzilla::COOKIES_FILE = '/This/file/does/not/exist'
+      end
+
+      cmd, output = RubyBugzilla.login!("calvin", "hobbes")
+      cmd = RubyBugzilla.modify(948972, :status => "POST")
+
+      cmd.should include("modify")
+      cmd.should include("--status=\"POST\"")
+      cmd.should include("948972")
+    end
+
+    it "when the bugzilla modify command succeeds for a String BZ" do
+      # Fake the command and cookies file.
+      ignore_warnings do
+        RubyBugzilla::CMD = '/bin/echo'
+        RubyBugzilla::COOKIES_FILE = '/This/file/does/not/exist'
+      end
+
+      cmd, output = RubyBugzilla.login!("calvin", "hobbes")
+      cmd = RubyBugzilla.modify("948972", :status => "POST")
+
+      cmd.should include("modify")
+      cmd.should include("--status=\"POST\"")
+      cmd.should include("948972")
+    end
   end
 
   context "#credentials_from_file" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby_bugzilla
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-18 00:00:00.000000000 Z
+date: 2013-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -131,7 +131,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -64370731141864933
+      hash: -142661522033235115
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -64370731141864933
+      hash: -142661522033235115
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25