rubyXL 3.4.25 → 3.4.38

data/lib/rubyXL/objects/ooxml_object.rb

@@ -13,15 +13,17 @@ module RubyXL
     # the setter/getter method addresses it in the context of descendant class,
     # which is what we need.
     def obtain_class_variable(var_name, default = nil)
-      self.class_variable_get(var_name)
-    rescue NameError
-      self.class_variable_set(var_name, default || {})
+      if self.class_variable_defined? var_name
+        self.class_variable_get(var_name)
+      else
+        self.class_variable_set(var_name, default || {})
+      end
     end
 
     # Defines an attribute of OOXML object.
     # === Parameters
     # * +attribute_name+ - Name of the element attribute as seen in the source XML. Can be either <tt>"String"</tt> or <tt>:Symbol</tt>
-    #   * Special attibute name <tt>'_'</tt> (underscore) denotes the value of the element rather than attribute.
+    #   * Special attribute name <tt>'_'</tt> (underscore) denotes the value of the element rather than attribute.
     # * +attribute_type+ - Specifies the conversion type for the attribute when parsing. Available options are:
     #   * +:int+ - <tt>Integer</tt>
     #   * +:uint+ - Unsigned <tt>Integer</tt>
@@ -123,7 +125,9 @@ module RubyXL
       end
 
       obj = self.new
-      obj.local_namespaces = node.namespace_definitions
+      hsh = {}
+      node.namespace_definitions.each { |ns| hsh[ns.href] = ns.prefix }
+      obj.local_namespaces = hsh
 
       known_attributes = obtain_class_variable(:@@ooxml_attributes)
 
@@ -149,8 +153,9 @@ module RubyXL
 
         node.element_children.each { |child_node|
           ns = child_node.namespace
-          prefix = if known_namespaces.has_key?(ns.href) then known_namespaces[ns.href]
-                   else ns.prefix
+
+          prefix = if known_namespaces.has_key?(ns&.href) then known_namespaces[ns&.href]
+                   else ns&.prefix
                    end
 
           child_node_name = case prefix
@@ -254,8 +259,8 @@ module RubyXL
 
     def ==(other)
       other.is_a?(self.class) &&
-        obtain_class_variable(:@@ooxml_attributes).all? { |k, v| self.send(v[:accessor]) == other.send(v[:accessor]) } &&
-        obtain_class_variable(:@@ooxml_child_nodes).all? { |k, v| self.send(v[:accessor]) == other.send(v[:accessor]) }
+        obtain_class_variable(:@@ooxml_attributes).all? { |_k, v| self.send(v[:accessor]) == other.send(v[:accessor]) } &&
+        obtain_class_variable(:@@ooxml_child_nodes).all? { |_k, v| self.send(v[:accessor]) == other.send(v[:accessor]) }
     end
 
     # Recursively write the OOXML object and all its children out as Nokogiri::XML. Immediately before the actual
@@ -312,12 +317,11 @@ module RubyXL
       element_text = attrs.delete('_')
       elem = xml.create_element(node_name_override || obtain_class_variable(:@@ooxml_tag_name), attrs, element_text)
 
-      if @local_namespaces.nil? || @local_namespaces.empty? then # If no local namespaces provided in the original document,
-        # use the defaults
-        obtain_class_variable(:@@ooxml_namespaces).each_pair { |k, v| elem.add_namespace_definition(v, k) }
-      else # otherwise preserve the original ones
-        @local_namespaces.each { |ns| elem.add_namespace_definition(ns.prefix, ns.href) }
-      end
+      # First, populate namespaces from the original document
+      @local_namespaces&.each_pair { |href, prefix| elem.add_namespace_definition(prefix, href) }
+
+      # Then, add defaults. Note that if some namespace prefix was already set, Nokogiri will NOT change that namespace.
+      obtain_class_variable(:@@ooxml_namespaces).each_pair { |href, prefix| elem.add_namespace_definition(prefix, href) }
 
       child_nodes = obtain_class_variable(:@@ooxml_child_nodes)
       child_nodes.each_pair { |child_node_name, child_node_params|
@@ -355,7 +359,7 @@ module RubyXL
     def before_write_xml
       #TODO# This will go away once containers are fully implemented.
       child_nodes = obtain_class_variable(:@@ooxml_child_nodes)
-      child_nodes.each_pair { |child_node_name, child_node_params|
+      child_nodes.each_pair { |_child_node_name, child_node_params|
         self.count = self.send(child_node_params[:accessor]).size if child_node_params[:is_array] == :with_count
       }
       true
@@ -369,7 +373,7 @@ module RubyXL
     include OOXMLObjectInstanceMethods
   end
 
-  # Parent class for OOXML conainer objects (for example,
+  # Parent class for OOXML container objects (for example,
   # <tt>&lt;fonts&gt;&lt;font&gt;...&lt;/font&gt;&lt;font&gt;...&lt;/font&gt;&lt;/fonts&gt;</tt>
   # that obscures the top-level container, allowing direct access to the contents as +Array+.
   class OOXMLContainerObject < Array

data/lib/rubyXL/objects/query_table.rb

@@ -25,7 +25,8 @@ module RubyXL
 
   # http://www.datypic.com/sc/ooxml/e-ssml_queryTableFields-1.html
   class QueryTableFields < OOXMLObject
-    define_child_node(RubyXL::QueryTableField, :collection => :with_count, :accessor => :fields, :node_name => :queryTableField)
+    define_child_node(RubyXL::QueryTableField, :collection => :with_count,
+                      :accessor => :fields, :node_name => :queryTableField)
     define_element_name 'queryTableFields'
   end
 
@@ -38,7 +39,8 @@ module RubyXL
 
   # http://www.datypic.com/sc/ooxml/e-ssml_queryTableDeletedFields-1.html
   class QueryTableDeletedFields < OOXMLObject
-    define_child_node(RubyXL::QueryTableDeletedField, :collection => :with_count, :accessor => :deleted_fields, :node_name => :deletedField)
+    define_child_node(RubyXL::QueryTableDeletedField, :collection => :with_count,
+                      :accessor => :deleted_fields, :node_name => :deletedField)
     define_element_name 'queryTableDeletedFields'
   end
 

data/lib/rubyXL/objects/reference.rb

@@ -1,24 +1,40 @@
 module RubyXL
   class Reference
-    ROW_MAX = 1024*1024
+    ROW_MAX = 1024 * 1024
     COL_MAX = 16393
 
-    attr_reader :row_range, :col_range
+    attr_reader :row_range, :col_range, :sheet_name
+    attr_reader :row_from_absolute, :row_to_absolute, :col_from_absolute, :col_to_absolute
 
     # RubyXL::Reference.new(row, col)
     # RubyXL::Reference.new(row_from, row_to, col_from, col_to)
     # RubyXL::Reference.new(reference_string)
+    # RubyXL::Reference.new(row_from:, row_to:, col_from:, col_to:)
     def initialize(*params)
       row_from = row_to = col_from = col_to = nil
+      @row_from_absolute = @row_to_absolute = @col_from_absolute = @col_to_absolute = false
 
       case params.size
       when 4 then row_from, row_to, col_from, col_to = params
       when 2 then row_from, col_from = params
       when 1 then
-        raise ArgumentError.new("invalid value for #{self.class}: #{params[0].inspect}") unless params[0].is_a?(String)
-        from, to = params[0].split(':')
-        row_from, col_from = self.class.ref2ind(from)
-        row_to, col_to = self.class.ref2ind(to) unless to.nil?
+        case params.first
+        when Hash then
+          row_from, row_to, col_from, col_to = params.first.fetch_values(:row_from, :row_to, :col_from, :col_to)
+        when String then
+          str = params.first
+          match_data = str.match(/^('(?<sheet_name1>[^']+)'|(?<sheet_name2>[^']+))!/)
+          if match_data then
+            @sheet_name = match_data['sheet_name1'] || match_data['sheet_name2']
+            str = str[match_data[0].size..-1]
+          end
+
+          from, to = str.split(':')
+          row_from, col_from, @row_from_absolute, @col_from_absolute = self.class.ref2ind(from)
+          row_to, col_to, @row_to_absolute, @col_to_absolute = self.class.ref2ind(to) unless to.nil?
+        else
+          raise ArgumentError.new("invalid value for #{self.class}: #{params[0].inspect}") unless params[0].is_a?(String)
+        end
       end
 
       @row_range = Range.new(row_from || 0, row_to || row_from || ROW_MAX)
@@ -50,49 +66,69 @@ module RubyXL
     end
 
     def ==(other)
-      !other.nil? && (@row_range == other.row_range) && (@col_range == other.col_range)
+      !other.nil? && (@sheet_name == other.sheet_name) &&
+        (@row_range == other.row_range) && (@col_range == other.col_range)
     end
 
     def cover?(other)
-      !other.nil? && (@row_range.cover?(other.row_range.begin) && @row_range.cover?(other.row_range.end) &&
-                      @col_range.cover?(other.col_range.begin) && @col_range.cover?(other.col_range.end))
+      !other.nil? && (@row_range.cover?(other.row_range.begin) &&
+                      @row_range.cover?(other.row_range.end) &&
+                      @col_range.cover?(other.col_range.begin) &&
+                      @col_range.cover?(other.col_range.end))
     end
 
     def to_s
+      result = +''
+
+      if @sheet_name then
+        if @sheet_name.index(' ') then
+          result << "'#{@sheet_name}'"
+        else
+          result << @sheet_name
+        end
+        result << '!'
+      end
+
       if single_cell? then
-        self.class.ind2ref(@row_range.begin, @col_range.begin)
+        result << self.class.ind2ref(@row_range.begin, @col_range.begin, @row_from_absolute, @col_from_absolute)
       else
-        self.class.ind2ref(@row_range.begin, @col_range.begin) + ':' + self.class.ind2ref(@row_range.end, @col_range.end)
+        result << self.class.ind2ref(@row_range.begin, @col_range.begin, @row_from_absolute, @col_from_absolute)
+        result << ':'
+        result << self.class.ind2ref(@row_range.end, @col_range.end, @row_to_absolute, @col_to_absolute)
       end
     end
 
     def inspect
       if single_cell? then
-        "#<#{self.class} @row=#{@row_range.begin} @col=#{@col_range.begin}>"
+        "#<#{self.class} @sheet_name=#{@sheet_name} @row=#{@row_range.begin} @col=#{@col_range.begin}>"
       else
-        "#<#{self.class} @row_range=#{@row_range} @col_range=#{@col_range}>"
+        "#<#{self.class} @sheet_name=#{@sheet_name} @row_range=#{@row_range} @col_range=#{@col_range}>"
       end
     end
 
     # Converts +row+ and +col+ zero-based indices to Excel-style cell reference
     # <0> A...Z, AA...AZ, BA... ...ZZ, AAA... ...AZZ, BAA... ...XFD <16383>
-    def self.ind2ref(row = 0, col = 0)
-      str = ''
+    def self.ind2ref(row = 0, col = 0, row_abs = false, col_abs = false)
+      col_ref = ''
 
       loop do
         x = col % 26
-        str = ('A'.ord + x).chr + str
+        col_ref = ('A'.ord + x).chr + col_ref
         col = (col / 26).floor - 1
         break if col < 0
       end
 
-      str += (row + 1).to_s
+      "#{col_abs ? '$' : ''}#{col_ref}#{row_abs ? '$' : ''}#{row + 1}"
     end
 
     # Converts Excel-style cell reference to +row+ and +col+ zero-based indices.
     def self.ref2ind(str)
-      return [ -1, -1 ] unless str =~ /\A([A-Z]+)(\d+)\Z/
-      [ Regexp.last_match(2).to_i - 1, Regexp.last_match(1).each_byte.inject(0) { |col, chr| col * 26 + (chr - 64) } - 1 ]
+      matchdata = str.match(/\A(?<cabs>\$?)(?<col>[A-Z]+)(?<rabs>\$?)(?<row>\d+)\Z/)
+      return [ -1, -1 ] unless matchdata
+      [  matchdata['row'].to_i - 1,
+         matchdata['col'].each_byte.inject(0) { |col, chr| (col * 26) + (chr - 64) } - 1,
+         !matchdata['rabs'].empty?,
+         !matchdata['cabs'].empty? ]
     end
   end
 
@@ -102,7 +138,7 @@ module RubyXL
     end
 
     def to_s
-      self.collect{ |ref| ref.to_s }.join(' ')
+      self.collect(&:to_s).join(' ')
     end
   end
 end

data/lib/rubyXL/objects/relationships.rb

@@ -95,7 +95,7 @@ module RubyXL
         self.related_files[rel.id] = obj
       }
 
-      @@debug_indent -=2 if @@debug_indent
+      @@debug_indent -= 2 if @@debug_indent
 
       related_files
     end

data/lib/rubyXL/objects/root.rb

@@ -33,7 +33,7 @@ module RubyXL
 
     # Write <tt>.xlsx</tt> to a stream (useful for sending over HTTP)
     def stream
-      stream = Zip::OutputStream.write_buffer { |zipstream|
+      stream = Zip::OutputStream.write_buffer(suppress_extra_fields: true) { |zipstream|
         self.rels_hash = {}
         self.relationship_container.owner = self
         collect_related_objects.compact.each { |obj|

data/lib/rubyXL/objects/shared_strings.rb

@@ -20,7 +20,7 @@ module RubyXL
       super
       # So far, going by the structure that the original creator had in mind. However,
       # since the actual implementation is now extracted into a separate class,
-      # we will be able to transparrently change it later if needs be.
+      # we will be able to transparently change it later if needs be.
       @index_by_content = {}
     end
 

data/lib/rubyXL/objects/sheet_data.rb

@@ -50,7 +50,7 @@ module RubyXL
     end
 
     def row
-      r && r.first_row
+      r&.first_row
     end
 
     def row=(v)
@@ -58,7 +58,7 @@ module RubyXL
     end
 
     def column
-      r && r.first_col
+      r&.first_col
     end
 
     def column=(v)
@@ -66,7 +66,7 @@ module RubyXL
     end
 
     def raw_value
-      value_container && value_container.value
+      value_container&.value
     end
 
     def raw_value=(v)
@@ -98,8 +98,7 @@ module RubyXL
         else false
         end
 
-      num_fmt = self.number_format
-      num_fmt && num_fmt.is_date_format?
+      self.number_format&.is_date_format?
     end
 
     # Gets massaged value of the cell, converting datatypes to those known to Ruby (that includes
@@ -111,6 +110,8 @@ module RubyXL
       when RubyXL::DataType::SHARED_STRING then workbook.shared_strings_container[r.to_i].to_s
       when RubyXL::DataType::INLINE_STRING then is.to_s
       when RubyXL::DataType::RAW_STRING    then raw_value
+      when RubyXL::DataType::DATE          then raw_value && DateTime.parse(raw_value)
+      when RubyXL::DataType::ERROR         then nil
       else
         if is then is.to_s
         elsif is_date? then workbook.num_to_date(r.to_f)
@@ -123,6 +124,10 @@ module RubyXL
       end
     end
 
+    def error?
+      datatype == RubyXL::DataType::ERROR
+    end
+
     def inspect
       str = "#<#{self.class}(#{row},#{column}): #{raw_value.inspect}"
       str << " =#{self.formula.expression}" if self.formula
@@ -133,7 +138,7 @@ module RubyXL
     include LegacyCell
   end
 
-#TODO#<row r="1" spans="1:1" x14ac:dyDescent="0.25">
+#TODO# <row r="1" spans="1:1" x14ac:dyDescent="0.25">
 
   # http://www.datypic.com/sc/ooxml/e-ssml_row-1.html
   class Row < OOXMLObject

data/lib/rubyXL/objects/storage.rb

@@ -11,7 +11,7 @@ module RubyXL
     end
 
     def self.parse_file(zip_file, file_path)
-      (entry = zip_file.find_entry(RubyXL::from_root(file_path))) && self.new(file_path, entry.get_input_stream { |f| f.read })
+      (entry = zip_file.find_entry(RubyXL::from_root(file_path))) && self.new(file_path, entry.get_input_stream(&:read))
     end
 
     def add_to_zip(zip_stream)
@@ -169,6 +169,11 @@ module RubyXL
     REL_TYPE     = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/sheetMetadata'.freeze
   end
 
+  class PersonMetadata < GenericStorageObject
+    CONTENT_TYPE = 'application/vnd.ms-excel.person+xml'.freeze
+    REL_TYPE     = 'http://schemas.microsoft.com/office/2017/10/relationships/person'.freeze
+  end
+
   class ActiveX < GenericStorageObject
     REL_TYPE     = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/control'.freeze
 

data/lib/rubyXL/objects/stylesheet.rb

@@ -79,9 +79,8 @@ module RubyXL
     define_element_name 'cellXfs'
 
     def self.default
-      self.new(:_ => [
-                 RubyXL::XF.new(:num_fmt_id => 0, :font_id => 0, :fill_id => 0, :border_id => 0, :xfId => 0)
-               ])
+      self.new(:_ => [ RubyXL::XF.new(:num_fmt_id => 0, :font_id => 0, :fill_id => 0,
+                                      :border_id => 0, :xfId => 0) ])
     end
   end
 

data/lib/rubyXL/objects/text.rb

@@ -18,7 +18,7 @@ module RubyXL
 
     def before_write_xml
       preserve_whitespace
-      self.value.gsub!(INVALID_XML10_CHARS) { |c| '_x%04x_' % c.ord }
+      self.value.gsub(INVALID_XML10_CHARS) { |bad_char| format('_x%04x_', bad_char.ord) }
       true
     end
 
@@ -84,8 +84,8 @@ module RubyXL
 
     def to_s
       # `dup` here unfreezes the string since it's not a constant but initial value
-      str = if t.nil? then ''.dup else t.to_s end
-      r && r.each { |rtr| str << rtr.to_s if rtr }
+      str = t.nil? ? ''.dup : t.to_s
+      r&.each { |rtr| str << rtr.to_s if rtr }
       str
     end
   end

data/lib/rubyXL/objects/theme.rb

@@ -1,5 +1,3 @@
-# encoding: UTF-8  <-- magic comment, need this because of sime fancy fonts in the default scheme below. See http://stackoverflow.com/questions/6444826/ruby-utf-8-file-encoding
-
 require 'rubyXL/objects/ooxml_object'
 require 'rubyXL/objects/extensions'
 
@@ -1391,21 +1389,21 @@ module RubyXL
     end
 
     def get_theme_color(idx)
-      color_scheme = a_theme_elements && a_theme_elements.a_clr_scheme
-
-      if color_scheme then
-        case idx
-        when 0 then color_scheme.a_lt1
-        when 1 then color_scheme.a_dk1
-        when 2 then color_scheme.a_lt2
-        when 3 then color_scheme.a_dk2
-        when 4 then color_scheme.a_accent1
-        when 5 then color_scheme.a_accent2
-        when 6 then color_scheme.a_accent3
-        when 7 then color_scheme.a_accent4
-        when 8 then color_scheme.a_accent5
-        when 9 then color_scheme.a_accent6
-        end
+      color_scheme = a_theme_elements&.a_clr_scheme
+
+      return unless color_scheme
+
+      case idx
+      when 0 then color_scheme.a_lt1
+      when 1 then color_scheme.a_dk1
+      when 2 then color_scheme.a_lt2
+      when 3 then color_scheme.a_dk2
+      when 4 then color_scheme.a_accent1
+      when 5 then color_scheme.a_accent2
+      when 6 then color_scheme.a_accent3
+      when 7 then color_scheme.a_accent4
+      when 8 then color_scheme.a_accent5
+      when 9 then color_scheme.a_accent6
       end
     end
 

data/lib/rubyXL/objects/workbook.rb

@@ -146,6 +146,13 @@ module RubyXL
   class DefinedNames < OOXMLContainerObject
     define_child_node(RubyXL::DefinedName, :collection => true)
     define_element_name 'definedNames'
+
+    def [](key)
+      case key
+      when Integer then super
+      when String then self.find { |n| n.name.eql?(key) }
+      end
+    end
   end
 
   # http://www.datypic.com/sc/ooxml/e-ssml_pivotCache-1.html
@@ -303,7 +310,7 @@ module RubyXL
     REL_TYPE = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument'.freeze
 
     # http://www.accountingweb.com/technology/excel/seven-characters-you-cant-use-in-worksheet-names
-    SHEET_NAME_FORBIDDEN_CHARS = /[\/\\*\[\]:?]/
+    SHEET_NAME_FORBIDDEN_CHARS = %r{[/\\*\[\]:?]}
 
     # https://answers.microsoft.com/en-us/msoffice/forum/all/excel-history-is-a-reserved-name-help/f8a398a4-b72c-48e3-82da-4f132c305e91
     SHEET_NAME_FORBIDDEN_NAMES = [ 'History' ]
@@ -334,6 +341,7 @@ module RubyXL
     define_relationship(RubyXL::CustomXMLFile)
     define_relationship(RubyXL::MacrosFile, :macros)
     define_relationship(RubyXL::SlicerCacheFile)
+    define_relationship(RubyXL::PersonMetadata)
 
     define_child_node(RubyXL::FileVersion)
     define_child_node(RubyXL::FileSharing)
@@ -410,12 +418,12 @@ module RubyXL
     alias_method :write, :save
 
     DATE1904 = DateTime.new(1904, 1, 1)
-    # Subtracting one day to accomodate for erroneous 1900 leap year compatibility only for 1900 based dates
+    # Subtracting one day to accommodate for erroneous 1900 leap year compatibility only for 1900 based dates
     DATE1899 = DateTime.new(1899, 12, 31) - 1
     MARCH_1_1900 = 61
 
     def base_date
-      (workbook_properties && workbook_properties.date1904) ? DATE1904 : DATE1899
+      workbook_properties&.date1904 ? DATE1904 : DATE1899
     end
     private :base_date
 
@@ -431,11 +439,11 @@ module RubyXL
 
       # Bug-for-bug Excel compatibility (https://support.microsoft.com/kb/214058/)
       if num < MARCH_1_1900 then
-        num += 1 unless workbook_properties && workbook_properties.date1904
+        num += 1 unless workbook_properties&.date1904
       end
 
       dateparts = num.divmod(1)
-      base_date + (dateparts[0] + (dateparts[1] * 86400).round(6) / 86400)
+      base_date + (dateparts[0] + ((dateparts[1] * 86400).round(6) / 86400))
     end
 
     include Enumerable
@@ -517,7 +525,7 @@ module RubyXL
     end
 
     def company
-      root.document_properties.company && root.document_properties.company.value
+      root.document_properties.company&.value
     end
 
     def company=(v)
@@ -526,7 +534,7 @@ module RubyXL
     end
 
     def application
-      root.document_properties.application && root.document_properties.application.value
+      root.document_properties.application&.value
     end
 
     def application=(v)
@@ -535,7 +543,7 @@ module RubyXL
     end
 
     def appversion
-      root.document_properties.app_version && root.document_properties.app_version.value
+      root.document_properties.app_version&.value
     end
 
     def appversion=(v)
@@ -560,7 +568,7 @@ module RubyXL
     end
 
     def date1904
-      workbook_properties && workbook_properties.date1904
+      workbook_properties&.date1904
     end
 
     def date1904=(v)

data/lib/rubyXL/objects/worksheet.rb

@@ -173,7 +173,7 @@ module RubyXL
   # http://www.datypic.com/sc/ooxml/e-ssml_colorScale-1.html
   class ColorScale < OOXMLObject
     define_child_node(RubyXL::ConditionalFormatValue, :collection => true, :accessor => :cfvo)
-    define_child_node(RubyXL::Color)
+    define_child_node(RubyXL::Color, :collection => true)
     define_element_name 'colorScale'
   end
 
@@ -183,7 +183,7 @@ module RubyXL
     define_attribute(:maxLength, :int,  :default => 90)
     define_attribute(:showValue, :bool, :default => true)
     define_child_node(RubyXL::ConditionalFormatValue, :collection => true, :accessor => :cfvo)
-    define_child_node(RubyXL::Color)
+    define_child_node(RubyXL::Color, :collection => true)
     define_element_name 'dataBar'
   end
 

data/lib/rubyXL/worksheet.rb

@@ -1,5 +1,7 @@
 module RubyXL
   module LegacyWorksheet
+    TEXT_LENGTH_LIMIT_IN_CELL = 32767 # 2 ** 15 - 1
+
     include Enumerable
 
     def initialize(params = {})
@@ -50,9 +52,15 @@ module RubyXL
           case data
           when Numeric          then c.raw_value = data
           when String           then
+            if data.length > TEXT_LENGTH_LIMIT_IN_CELL
+              raise ArgumentError, "The maximum length of cell contents (text) is #{TEXT_LENGTH_LIMIT_IN_CELL} characters"
+            end
             c.raw_value = data
             c.datatype = RubyXL::DataType::RAW_STRING
           when RubyXL::RichText then
+            if data.to_s.length > TEXT_LENGTH_LIMIT_IN_CELL
+              raise ArgumentError, "The maximum length of cell contents (text) is #{TEXT_LENGTH_LIMIT_IN_CELL} characters"
+            end
             c.is = data
             c.datatype = RubyXL::DataType::INLINE_STRING
           when Time, Date, DateTime then
@@ -61,8 +69,8 @@ module RubyXL
           end
         end
 
-        range = cols && cols.locate_range(column_index)
-        c.style_index = row.style_index || (range && range.style_index) || 0
+        range = cols&.locate_range(column_index)
+        c.style_index = row.style_index || range&.style_index || 0
         row.cells[column_index] = c
       end
 
@@ -93,5 +101,5 @@ module RubyXL
       raise 'Row and Column arguments must be nonnegative' if row_or_col < 0
     end
     private :validate_nonnegative
-  end # end class
+  end
 end