rubyXL 3.4.14 → 3.4.33

data/spec/lib/rgb_color_spec.rb

@@ -1,16 +1,29 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubyXL/convenience_methods/color'
 
 describe RubyXL::RgbColor do
   describe '.to_s' do
-    it 'should properly translate the color to string' do
+    it 'should properly translate RGB color to string' do
       rgb_color = RubyXL::RgbColor.new
 
       rgb_color.r = 1
       rgb_color.g = 2
       rgb_color.b = 255
 
-      expect(rgb_color.to_s).to eq("0102ff")
+      expect(rgb_color.to_s).to eq('0102ff')
+    end
+
+    it 'should properly translate RGB color with alpha value to string' do
+      rgb_color = RubyXL::RgbColor.new
+
+      rgb_color.r = 11
+      rgb_color.g = 22
+      rgb_color.b = 33
+      rgb_color.a = 255
+
+      expect(rgb_color.to_s).to eq('0b1621ff')
     end
   end
-end
+end

data/spec/lib/stylesheet_spec.rb

@@ -1,28 +1,27 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RubyXL::NumberFormat do
-
   describe '.is_date_format?' do
     it 'should return true if number format = dd// yy// mm' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?).to eq(true)
+    end
 
     it 'should return true if number format = DD// YY// MM (uppercase)' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?).to eq(true)
+    end
 
     it 'should return false if number format = @' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?()).to eq(false)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?).to eq(false)
+    end
 
     it 'should properly detect date formats amongst default ones' do
       all_formats = RubyXL::NumberFormats::DEFAULT_NUMBER_FORMATS
       id_list = all_formats.collect { |fmt| fmt.num_fmt_id if fmt.is_date_format? }.compact.sort
       expect(id_list).to eq([14, 15, 16, 17, 18, 19, 20, 21, 22, 45, 46, 47])
     end
-
   end
-
 end

data/spec/lib/text_spec.rb

@@ -1,15 +1,15 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe RubyXL::Text do
-
   describe '.to_s' do
-
     it 'should not crash processing UNICODE data' do
       bytes = [ 114, 39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115,
                 32, 103, 105, 114, 108, 102, 114, 105, 101, 110, 100,
                 39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115, 32, 104, 111]
 
-      t = RubyXL::Text.new(:value => bytes.pack("c*").force_encoding('UTF-8'))
+      t = RubyXL::Text.new(:value => bytes.pack('c*').force_encoding('UTF-8'))
 
       str = t.to_s
 
@@ -19,11 +19,9 @@ describe RubyXL::Text do
     it 'should not escape valid XML extended UNICODE characters' do
       t = RubyXL::Text.new(:value => "\u{10000}\u{10FFFF}")
 
-      xml = t.write_xml[/<t>[^<]+<\/t>/]
+      xml = t.write_xml[%r{<t>[^<]+</t>}]
 
       expect(xml).to eq("<t>\u{10000}\u{10FFFF}</t>")
     end
-
   end
-
 end

data/spec/lib/workbook_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'rubyXL/convenience_methods/workbook'
 
@@ -6,8 +8,8 @@ describe RubyXL::Workbook do
     @workbook  = RubyXL::Workbook.new
     @worksheet = @workbook.add_worksheet('Test Worksheet')
 
-    (0..10).each do |i|
-      (0..10).each do |j|
+    11.times do |i|
+      11.times do |j|
         @worksheet.add_cell(i, j, "#{i}:#{j}")
       end
     end
@@ -133,8 +135,19 @@ describe RubyXL::Workbook do
     end
   end
 
+  describe '.title' do
+    it 'should contain default title' do
+      expect(@workbook.title).to be_nil
+    end
+
+    it 'should set title properly' do
+      @workbook.title = 'TITLE'
+      expect(@workbook.title).to eq('TITLE')
+    end
+  end
+
   describe '.stream' do
-    it "It should not be confused by missing sheet_id" do
+    it 'It should not be confused by missing sheet_id' do
       workbook = RubyXL::Workbook.new
       workbook[0].sheet_id = 1
       workbook.add_worksheet('Sheet2')
@@ -144,12 +157,12 @@ describe RubyXL::Workbook do
     it 'should raise error if bad characters are present in worksheet name' do
       workbook = RubyXL::Workbook.new
       workbook[0].sheet_name = 'Sheet007'
-      expect{workbook.stream}.to_not raise_error
+      expect{ workbook.stream }.to_not raise_error
 
       '\\/*[]:?'.each_char { |char|
         workbook = RubyXL::Workbook.new
         workbook[0].sheet_name = "Sheet#{char}007"
-        expect{workbook.stream}.to raise_error(RuntimeError)
+        expect{ workbook.stream }.to raise_error(RuntimeError)
       }
     end
   end
@@ -157,13 +170,13 @@ describe RubyXL::Workbook do
   describe '.collect_related_objects' do
     it 'should not save shared strings if there are none' do
       wb = RubyXL::Workbook.new
-      expect(wb.root.collect_related_objects.map{ |x| x.class }.include?(::RubyXL::SharedStringsTable)).to be false
+      expect(wb.root.collect_related_objects.map(&:class).include?(::RubyXL::SharedStringsTable)).to be false
       Zip::File.open_buffer(wb.stream) { |zf|
         expect(zf.entries.any? { |e| e.name =~ /sharedstrings/i }).to be false
       }
 
       wb.shared_strings_container.add('test')
-      expect(wb.root.collect_related_objects.map{ |x| x.class }.include?(::RubyXL::SharedStringsTable)).to be true
+      expect(wb.root.collect_related_objects.map(&:class).include?(::RubyXL::SharedStringsTable)).to be true
       Zip::File.open_buffer(wb.stream) { |zf|
         expect(zf.entries.any? { |e| e.name =~ /sharedstrings/i }).to be true
       }
@@ -181,5 +194,4 @@ describe RubyXL::Workbook do
       expect(wb2.get_defined_name('TEST2')).to be_nil
     end
   end
-
 end