rubyXL 3.4.10 → 3.4.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6fe23b654603dd0ddf300a80ddd9cadbedacacbe2c17bec142d2b02fb34e282
-  data.tar.gz: d950f5c59d36d41cf566fb40b40f527b1f147173585c8b1c642176b1c93452d0
+  metadata.gz: 4a9327bd67cd3fe0e2cdd599929207e83fbeee4b2125e7f45d5b1c8c8145e8a9
+  data.tar.gz: 12b4e09b2a6502679c81b95909e3fd59d287880cc9d4cf0fd0705968e68d858d
 SHA512:
-  metadata.gz: a7c3c7659e9883e35f7646ca92de7bce3050b26626cfc12ed513f62699d9fd85759c3bb41011f879e67cdaf28bac2ac6e3275c7ee912140c7c46be15cb4aa2a2
-  data.tar.gz: a26a4250e5136b177b638b001c56f6e14d03794af0f6c790ee85cc34c2a0403ba69c397ad6c4bf4ac71ba18a66592e478e94c3688473d04c244cea29cd54bc1d
+  metadata.gz: 5e74cdd0607641eb9b17a5cc60410de79da04a6cef796f1e31a96673176e740c2fc76bd26fd229a2d06e150b1adf8105a13516fb192787892ae895c3251b6500
+  data.tar.gz: 06036705f47f89cee9b769d5eb642d44741f714db4c53caedc0fbac7822d3e24968291a2dea2dba908955c798ca6d729d9101157b854266640202bf3e6504499

data/.circleci/config.yml

@@ -7,7 +7,7 @@ jobs:
   build:
     docker:
       # specify the version you desire here
-      - image: circleci/ruby:2.4.1-node-browsers
+      - image: circleci/ruby:2.6.6-buster
 
       # Specify service dependencies here if necessary
       # CircleCI maintains a library of pre-built images
@@ -29,6 +29,7 @@ jobs:
       - run:
           name: install dependencies
           command: |
+            gem install bundler
             bundle install --jobs=4 --retry=3 --path vendor/bundle
 
       - save_cache:

data/Gemfile

@@ -1,7 +1,7 @@
 source "http://rubygems.org"
 
 # Dependencies required to run this gem.
-gem "nokogiri", ">= 1.4.4"
+gem "nokogiri", ">= 1.10.8"
 gem "rubyzip", ">= 1.3.0" , :require => 'zip'
 
 # Development dependencies.

data/Gemfile.lock

@@ -5,11 +5,12 @@ GEM
     builder (3.2.4)
     descendants_tracker (0.0.4)
       thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.3)
+    diff-lcs (1.4.4)
     docile (1.3.2)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)
-    git (1.5.0)
+    git (1.7.0)
+      rchardet (~> 1.8)
     github_api (0.16.0)
       addressable (~> 2.4.0)
       descendants_tracker (~> 0.0.4)
@@ -17,7 +18,7 @@ GEM
       hashie (>= 3.4)
       mime-types (>= 1.16, < 3.0)
       oauth2 (~> 1.0)
-    hashie (4.0.0)
+    hashie (4.1.0)
     highline (2.0.3)
     jeweler (2.3.9)
       builder
@@ -30,48 +31,47 @@ GEM
       rake
       rdoc
       semver2
-    json (2.3.0)
     jwt (2.2.1)
     mime-types (2.99.3)
     mini_portile2 (2.4.0)
-    multi_json (1.14.1)
+    multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
-    nokogiri (1.10.7)
+    nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
-    oauth2 (1.4.2)
+    oauth2 (1.4.4)
       faraday (>= 0.8, < 2.0)
       jwt (>= 1.0, < 3.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    psych (3.1.0)
-    rack (2.0.8)
+    psych (3.2.0)
+    rack (2.2.3)
     rake (13.0.1)
-    rdoc (6.2.0)
+    rchardet (1.8.0)
+    rdoc (6.2.1)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
-    rspec-expectations (3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
+    rspec-support (3.9.3)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    ruby-prof (1.1.0)
-    rubyzip (2.0.0)
+    ruby-prof (1.4.1)
+    rubyzip (2.3.0)
     semver2 (3.4.2)
-    simplecov (0.17.1)
+    simplecov (0.18.5)
       docile (~> 1.1)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
     thread_safe (0.3.6)
 
 PLATFORMS
@@ -80,7 +80,7 @@ PLATFORMS
 DEPENDENCIES
   bundler
   jeweler
-  nokogiri (>= 1.4.4)
+  nokogiri (>= 1.10.8)
   rake
   rspec
   rspec_junit_formatter
@@ -89,4 +89,4 @@ DEPENDENCIES
   simplecov
 
 BUNDLED WITH
-   1.17.3
+   2.1.4

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2011 Vivek Bhagwat, 2013-2014 Wesha
+Copyright (c) 2011 Vivek Bhagwat, 2013-2020 Wesha
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -229,6 +229,11 @@ It can also operate on +StringIO+ objects, thus eliminating the need to save the
 
   RubyXL.class_variable_set(:@@suppress_warnings, true)
 
+== Data validation ("dropdown list")
+
+  worksheet.add_validation_list("A1", [ "value1", "value2" ])
+
+
 == For more information
 Take a look at the files in spec/lib/ for rspecs on most methods
 
@@ -244,5 +249,5 @@ Take a look at the files in spec/lib/ for rspecs on most methods
 
 == Copyright
 
-Copyright (c) 2011 Vivek Bhagwat, 2013-2016 Wesha.
+Copyright (c) 2011 Vivek Bhagwat, 2013-2020 Wesha.
 See LICENSE.txt for further details.

data/VERSION

@@ -1 +1 @@
-3.4.10
+3.4.16

data/lib/rubyXL/convenience_methods/cell.rb

@@ -253,7 +253,7 @@ module RubyXL
     def add_hyperlink(l)
       worksheet.hyperlinks ||= RubyXL::Hyperlinks.new
       worksheet.hyperlinks << RubyXL::Hyperlink.new(:ref => self.r, :location => l)
-#    define_attribute(:'r:id',   :string)
+#    define_relationship
 #    define_attribute(:location, :string)
 #    define_attribute(:tooltip,  :string)
 #    define_attribute(:display,  :string)

data/lib/rubyXL/convenience_methods/color.rb

@@ -72,9 +72,11 @@ module RubyXL
       end
 
       def to_s
-        str = r.to_s(16) + g.to_s(16) + b.to_s(16)
-        str += a.to_s(16) if a && a != 0
-        str
+        if a && a != 0 then
+          "%02x%02x%02x%02x" % [ r, g, b, a ]
+        else
+          "%02x%02x%02x" % [ r, g, b ]
+        end
       end
 
     end

data/lib/rubyXL/convenience_methods/worksheet.rb

@@ -632,6 +632,18 @@ module RubyXL
       # TODO: add validation to make sure ranges are not intersecting with existing ones
       merged_cells << RubyXL::MergedCell.new(:ref => RubyXL::Reference.new(start_row, end_row, start_col, end_col))
     end
+
+    def add_validation_list(ref, list_arr)
+      # "Any double quote characters in the value should be escaped with another double quote.
+      # If the value does not contain a comma, newline or double quote, then the String value should be returned unchanged.
+      # If the value contains a comma, newline or double quote, then the String value should be returned enclosed in double quotes."
+      expr = '"' + list_arr.collect{|str| str.gsub('"', '""')}.join(',') + '"'
+      self.data_validations ||= RubyXL::DataValidations.new
+      self.data_validations <<
+        RubyXL::DataValidation.new({:sqref => RubyXL::Reference.new(ref),
+                                    :formula1 => RubyXL::Formula.new(:expression => expr),
+                                    :type => 'list'})
+    end
   end
 
   RubyXL::Worksheet.send(:include, RubyXL::WorksheetConvenienceMethods) # ruby 2.1 compat

data/lib/rubyXL/objects/chartsheet.rb

@@ -34,7 +34,7 @@ module RubyXL
     define_attribute(:horizontalDpi,      :int,    :default => 600)
     define_attribute(:verticalDpi,        :int,    :default => 600)
     define_attribute(:copies,             :int,    :default => 1)
-    define_attribute(:'r:id',             :string)
+    define_relationship
     define_element_name 'pageSetup'
   end
 

data/lib/rubyXL/objects/data_validation.rb

@@ -11,6 +11,8 @@ module RubyXL
     define_attribute(:imeMode,          RubyXL::ST_DataValidationImeMode,    :default => 'noControl')
     define_attribute(:operator,         RubyXL::ST_DataValidationOperator,   :default => 'between')
     define_attribute(:allowBlank,       :bool, :default => false)
+    # Documentation lies. This property should have been called "HIDE dropdown",
+    #   since that's what happens when it is set to true.
     define_attribute(:showDropDown,     :bool, :default => false)
     define_attribute(:showInputMessage, :bool, :default => false)
     define_attribute(:showErrorMessage, :bool, :default => false)

data/lib/rubyXL/objects/document_properties.rb

@@ -127,7 +127,7 @@ module RubyXL
     end
 
     def creator=(v)
-      self.dc_creator = v && RubyXL::StringNodeW3C.new(:value => v)
+      self.dc_creator = v && RubyXL::StringNode.new(:value => v)
     end
 
     def modifier
@@ -135,7 +135,7 @@ module RubyXL
     end
 
     def modifier=(v)
-      self.cp_last_modified_by = v && RubyXL::StringNodeW3C.new(:value => v)
+      self.cp_last_modified_by = v && RubyXL::StringNode.new(:value => v)
     end
 
     def created_at

data/lib/rubyXL/objects/external_links.rb

@@ -61,16 +61,40 @@ module RubyXL
     define_child_node(RubyXL::SheetNames)
     define_child_node(RubyXL::DefinedNamesExt)
     define_child_node(RubyXL::SheetDataSet)
-    define_attribute(:'r:id', :string, :required => true)
+    define_relationship(:required => true)
     define_element_name 'externalBook'
   end
 
+  # http://www.datypic.com/sc/ooxml/e-ssml_oleItem-1.html
+  class OleItem < OOXMLObject
+    define_attribute(:name,      :string, :required => true)
+    define_attribute(:icon,      :bool)
+    define_attribute(:advise,    :bool)
+    define_attribute(:preferPic, :bool)
+    define_element_name 'oleItem'
+  end
+
+  # http://www.datypic.com/sc/ooxml/e-ssml_oleItems-1.html
+  class OleItems < OOXMLContainerObject
+    define_child_node(RubyXL::OleItem)
+    define_element_name 'oleItems'
+  end
+
+  # http://www.datypic.com/sc/ooxml/t-ssml_CT_OleLink.html
+  class OleLink < OOXMLObject
+    define_child_node(RubyXL::OleItems, :collection => true)
+    define_relationship(:required => true)
+    define_attribute(:progId, :string, :required => true)
+    define_element_name 'oleLink'
+  end
+
   class ExternalLinksFile < OOXMLTopLevelObject
     CONTENT_TYPE = 'application/vnd.openxmlformats-officedocument.spreadsheetml.externalLink+xml'
     REL_TYPE     = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/externalLink'
 
     include RubyXL::RelationshipSupport
     define_child_node(RubyXL::ExternalBook)
+    define_child_node(RubyXL::OleLink)
 
     define_element_name 'externalLink'
     set_namespaces('http://schemas.openxmlformats.org/spreadsheetml/2006/main' => nil,

data/lib/rubyXL/objects/ooxml_object.rb

@@ -53,6 +53,11 @@ module RubyXL
       self.send(:attr_accessor, attr_hash[:accessor]) unless attr_hash[:computed]
     end
 
+    # Defines a `r:id` attribute
+    def define_relationship(extra_params = {})
+      define_attribute(:'r:id', :string, extra_params)
+    end
+
     # Defines a child node of OOXML object.
     # === Parameters
     # * +klass+ - Class (descendant of RubyXL::OOXMLObject) of the child nodes. Child node objects will be produced by calling +parse+ method of that class.
@@ -272,6 +277,11 @@ module RubyXL
       if xml.nil? then
         seed_xml = Nokogiri::XML('<?xml version = "1.0" standalone ="yes"?>')
         seed_xml.encoding = 'UTF-8'
+
+        if Nokogiri.jruby? then # Issue 188 workaround for JRuby
+          seed_xml.to_java.strict_error_checking = false
+        end
+
         result = self.write_xml(seed_xml)
         return result if result == ''
         seed_xml << result

data/lib/rubyXL/objects/relationships.rb

@@ -4,7 +4,7 @@ require 'rubyXL/objects/ooxml_object'
 module RubyXL
 
   class RID < OOXMLObject
-    define_attribute(:'r:id', :string, :required => true)
+    define_relationship(:required => true)
   end
 
   class Relationship < OOXMLObject

data/lib/rubyXL/objects/sheet_data.rb

@@ -125,8 +125,8 @@ module RubyXL
 
     def inspect
       str = "#<#{self.class}(#{row},#{column}): #{raw_value.inspect}"
-      str += " =#{self.formula.expression}" if self.formula
-      str += ", datatype=#{self.datatype.inspect}, style_index=#{self.style_index.inspect}>"
+      str << " =#{self.formula.expression}" if self.formula
+      str << ", datatype=#{self.datatype.inspect}, style_index=#{self.style_index.inspect}>"
       return str
     end
 

data/lib/rubyXL/objects/storage.rb

@@ -97,6 +97,7 @@ module RubyXL
   end
 
   class ControlPropertiesFile < GenericStorageObject
+    CONTENT_TYPE = 'application/vnd.ms-excel.controlproperties+xml'
     REL_TYPE     = 'http://schemas.openxmlformats.org/officeDocument/2006/relationships/ctrlProp'
   end
 

data/lib/rubyXL/objects/text.rb

@@ -85,7 +85,7 @@ module RubyXL
     define_element_name 'is'
 
     def to_s
-      str = t.to_s
+      str = if t.nil? then '' else t.to_s end
       r && r.each { |rtr| str << rtr.to_s if rtr }
       str
     end

data/lib/rubyXL/objects/theme.rb

@@ -1164,7 +1164,7 @@ module RubyXL
   class CT_Hyperlink < OOXMLObject
     define_child_node(RubyXL::CT_EmbeddedWAVAudioFile)
     define_child_node(RubyXL::AExtensionStorageArea)
-    define_attribute(:'r:id',         :string)
+    define_relationship
     define_attribute(:invalidUrl,     :string, :default => '')
     define_attribute(:action,         :string, :default => '')
     define_attribute(:tgtFrame,       :string, :default => '')

data/lib/rubyXL/objects/workbook.rb

@@ -98,7 +98,7 @@ module RubyXL
     define_attribute(:name,            :string, :required => true)
     define_attribute(:sheetId,         :int,    :required => true)
     define_attribute(:state,           RubyXL::ST_Visibility, :default => 'visible')
-    define_attribute(:'r:id',          :string, :required => true)
+    define_relationship(:required => true)
     define_element_name 'sheet'
   end
 
@@ -110,7 +110,7 @@ module RubyXL
 
   # http://www.datypic.com/sc/ooxml/e-ssml_externalReference-1.html
   class ExternalReference < OOXMLObject
-    define_attribute(:'r:id', :string, :required => true)
+    define_relationship(:required => true)
     define_element_name 'externalReference'
   end
 
@@ -153,7 +153,7 @@ module RubyXL
   # http://www.datypic.com/sc/ooxml/e-ssml_pivotCache-1.html
   class PivotCache < OOXMLObject
     define_attribute(:cacheId, :int,    :required => true)
-    define_attribute(:'r:id',  :string, :required => true)
+    define_relationship(:required => true)
     define_element_name 'pivotCache'
   end
 
@@ -420,16 +420,22 @@ module RubyXL
     private :base_date
 
     def date_to_num(date)
-      date && (date.ajd - base_date().ajd).to_f
+      case date
+      when Date, DateTime then (date.ajd - base_date().ajd).to_f
+      when Time then ((date.to_r - base_date().to_time.to_r) / 86400).to_f
+      end
     end
 
     def num_to_date(num)
+      return nil if num.nil?
+
       # Bug-for-bug Excel compatibility (https://support.microsoft.com/kb/214058/)
-      if num && num < MARCH_1_1900 then
+      if num < MARCH_1_1900 then
         num += 1 unless workbook_properties && workbook_properties.date1904
       end
 
-      num && (base_date + num)
+      dateparts = num.divmod(1)
+      base_date + (dateparts[0] + (dateparts[1] * 86400).round(6) / 86400)
     end
 
     include Enumerable

data/lib/rubyXL/objects/worksheet.rb

@@ -88,7 +88,7 @@ module RubyXL
     define_attribute(:horizontalDpi,      :int,    :default => 600)
     define_attribute(:verticalDpi,        :int,    :default => 600)
     define_attribute(:copies,             :int,    :default => 1)
-    define_attribute(:'r:id',             :string)
+    define_relationship
     define_element_name 'pageSetup'
   end
 
@@ -302,7 +302,7 @@ module RubyXL
   # http://www.datypic.com/sc/ooxml/e-ssml_hyperlink-1.html
   class Hyperlink < OOXMLObject
     define_attribute(:ref,      :ref,    :required => true)
-    define_attribute(:'r:id',   :string)
+    define_relationship
     define_attribute(:location, :string)
     define_attribute(:tooltip,  :string)
     define_attribute(:display,  :string)
@@ -323,7 +323,7 @@ module RubyXL
     define_attribute(:oleUpdate, RubyXL::ST_OleUpdate)
     define_attribute(:autoLoad,  :bool, :default => false)
     define_attribute(:shapeId,   :int,  :required => true)
-    define_attribute(:'r:id',    :string)
+    define_relationship
     define_element_name 'oleObject'
   end
 
@@ -339,7 +339,7 @@ module RubyXL
     define_attribute(:ref,    :ref)
     define_attribute(:name,   :string)
     define_attribute(:sheet,  :string)
-    define_attribute(:'r:id', :string)
+    define_relationship
     define_element_name 'dataRef'
   end
 
@@ -434,7 +434,7 @@ module RubyXL
   # http://www.datypic.com/sc/ooxml/e-ssml_control-1.html
   class EmbeddedControl < OOXMLObject
     define_attribute(:shapeId, :int,    :required => true)
-    define_attribute(:'r:id',  :string, :required => true)
+    define_relationship(:required => true)
     define_attribute(:name,    :string)
     define_element_name 'control'
   end
@@ -490,7 +490,7 @@ module RubyXL
   # http://www.datypic.com/sc/ooxml/e-ssml_customPr-1.html
   class CustomProperty < OOXMLObject
     define_attribute(:name,   :string, :required => true)
-    define_attribute(:'r:id', :string, :required => true)
+    define_relationship(:required => true)
     define_element_name 'customPr'
   end
 
@@ -572,7 +572,7 @@ module RubyXL
     define_attribute(:previousRow, :uint, :default => 0)
     define_attribute(:previousCol, :uint, :default => 0)
     define_attribute(:click,       :uint, :default => 0)
-    define_attribute(:'r:id',      :string)
+    define_relationship
     define_child_node(RubyXL::PivotArea)
     define_element_name 'pivotSelection'
   end