rubyXL 3.3.33 → 3.4.25

data/rubyXL.gemspec

@@ -1,17 +1,17 @@
-# Generated by jeweler
+# Generated by juwelier
 # DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rubyXL 3.3.33 ruby lib
+# stub: rubyXL 3.4.25 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rubyXL".freeze
-  s.version = "3.3.33"
+  s.version = "3.4.25"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Vivek Bhagwat".freeze, "Wesha".freeze]
-  s.date = "2019-01-17"
+  s.date = "2022-05-19"
   s.description = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents".freeze
   s.email = "bhagwat.vivek@gmail.com".freeze
   s.extra_rdoc_files = [
@@ -19,8 +19,10 @@ Gem::Specification.new do |s|
     "README.rdoc"
   ]
   s.files = [
+    ".circleci/config.yml",
     ".codeclimate.yml",
     "Gemfile",
+    "Gemfile.lock",
     "LICENSE.txt",
     "README.rdoc",
     "Rakefile",
@@ -28,6 +30,11 @@ Gem::Specification.new do |s|
     "lib/rubyXL.rb",
     "lib/rubyXL/cell.rb",
     "lib/rubyXL/convenience_methods.rb",
+    "lib/rubyXL/convenience_methods/cell.rb",
+    "lib/rubyXL/convenience_methods/color.rb",
+    "lib/rubyXL/convenience_methods/font.rb",
+    "lib/rubyXL/convenience_methods/workbook.rb",
+    "lib/rubyXL/convenience_methods/worksheet.rb",
     "lib/rubyXL/objects/border.rb",
     "lib/rubyXL/objects/calculation_chain.rb",
     "lib/rubyXL/objects/cell_style.rb",
@@ -35,6 +42,7 @@ Gem::Specification.new do |s|
     "lib/rubyXL/objects/color.rb",
     "lib/rubyXL/objects/column_range.rb",
     "lib/rubyXL/objects/comments.rb",
+    "lib/rubyXL/objects/connection.rb",
     "lib/rubyXL/objects/container_nodes.rb",
     "lib/rubyXL/objects/content_types.rb",
     "lib/rubyXL/objects/data_validation.rb",
@@ -46,6 +54,7 @@ Gem::Specification.new do |s|
     "lib/rubyXL/objects/font.rb",
     "lib/rubyXL/objects/formula.rb",
     "lib/rubyXL/objects/ooxml_object.rb",
+    "lib/rubyXL/objects/query_table.rb",
     "lib/rubyXL/objects/reference.rb",
     "lib/rubyXL/objects/relationships.rb",
     "lib/rubyXL/objects/root.rb",
@@ -227,6 +236,12 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/ConditionalFormatValue.html",
     "rdoc/RubyXL/ConditionalFormatting.html",
     "rdoc/RubyXL/ConditionalFormattingRule.html",
+    "rdoc/RubyXL/Connection.html",
+    "rdoc/RubyXL/ConnectionTable.html",
+    "rdoc/RubyXL/ConnectionTables.html",
+    "rdoc/RubyXL/ConnectionTextField.html",
+    "rdoc/RubyXL/ConnectionTextFields.html",
+    "rdoc/RubyXL/Connections.html",
     "rdoc/RubyXL/ContentTypeDefault.html",
     "rdoc/RubyXL/ContentTypeOverride.html",
     "rdoc/RubyXL/ContentTypes.html",
@@ -323,7 +338,12 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/OOXMLObjectInstanceMethods.html",
     "rdoc/RubyXL/OOXMLRelationshipsFile.html",
     "rdoc/RubyXL/OOXMLTopLevelObject.html",
+    "rdoc/RubyXL/OdbcOleDbProperties.html",
     "rdoc/RubyXL/Offset.html",
+    "rdoc/RubyXL/OlapProperties.html",
+    "rdoc/RubyXL/OleItem.html",
+    "rdoc/RubyXL/OleItems.html",
+    "rdoc/RubyXL/OleLink.html",
     "rdoc/RubyXL/OutlineProperties.html",
     "rdoc/RubyXL/PageMargins.html",
     "rdoc/RubyXL/PageSetup.html",
@@ -348,6 +368,14 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/ProtectedRange.html",
     "rdoc/RubyXL/ProtectedRanges.html",
     "rdoc/RubyXL/Protection.html",
+    "rdoc/RubyXL/QueryParameter.html",
+    "rdoc/RubyXL/QueryParameters.html",
+    "rdoc/RubyXL/QueryTable.html",
+    "rdoc/RubyXL/QueryTableDeletedField.html",
+    "rdoc/RubyXL/QueryTableDeletedFields.html",
+    "rdoc/RubyXL/QueryTableField.html",
+    "rdoc/RubyXL/QueryTableFields.html",
+    "rdoc/RubyXL/QueryTableRefresh.html",
     "rdoc/RubyXL/RID.html",
     "rdoc/RubyXL/RawOOXML.html",
     "rdoc/RubyXL/Reference.html",
@@ -371,6 +399,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/SheetData.html",
     "rdoc/RubyXL/SheetDataExt.html",
     "rdoc/RubyXL/SheetDataSet.html",
+    "rdoc/RubyXL/SheetMetadata.html",
     "rdoc/RubyXL/SheetName.html",
     "rdoc/RubyXL/SheetNames.html",
     "rdoc/RubyXL/Sheets.html",
@@ -393,6 +422,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/TableStyle.html",
     "rdoc/RubyXL/TableStyles.html",
     "rdoc/RubyXL/Text.html",
+    "rdoc/RubyXL/TextImportSettings.html",
     "rdoc/RubyXL/Theme.html",
     "rdoc/RubyXL/ThemeElements.html",
     "rdoc/RubyXL/ThumbnailFile.html",
@@ -407,6 +437,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/WebPublishingItem.html",
     "rdoc/RubyXL/WebPublishingItems.html",
     "rdoc/RubyXL/WebPublishingProperties.html",
+    "rdoc/RubyXL/WebQueryProperties.html",
     "rdoc/RubyXL/Workbook.html",
     "rdoc/RubyXL/WorkbookConvenienceMethods.html",
     "rdoc/RubyXL/WorkbookProperties.html",
@@ -459,7 +490,6 @@ Gem::Specification.new do |s|
     "rdoc/images/zoom.png",
     "rdoc/index.html",
     "rdoc/js/darkfish.js",
-    "rdoc/js/jquery.js",
     "rdoc/js/navigation.js",
     "rdoc/js/navigation.js.gz",
     "rdoc/js/search.js",
@@ -473,6 +503,7 @@ Gem::Specification.new do |s|
     "spec/lib/color_spec.rb",
     "spec/lib/parser_spec.rb",
     "spec/lib/reference_spec.rb",
+    "spec/lib/rgb_color_spec.rb",
     "spec/lib/stylesheet_spec.rb",
     "spec/lib/text_spec.rb",
     "spec/lib/workbook_spec.rb",
@@ -485,40 +516,33 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/gilt/rubyXL".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "2.7.8".freeze
+  s.rubygems_version = "3.3.12".freeze
   s.summary = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
+  end
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<nokogiri>.freeze, [">= 1.4.4"])
-      s.add_runtime_dependency(%q<rubyzip>.freeze, [">= 1.1.6"])
-      s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
-      s.add_development_dependency(%q<rake>.freeze, [">= 0"])
-      s.add_development_dependency(%q<jeweler>.freeze, [">= 0"])
-      s.add_development_dependency(%q<rspec>.freeze, [">= 0"])
-      s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_development_dependency(%q<ruby-prof>.freeze, [">= 0"])
-    else
-      s.add_dependency(%q<nokogiri>.freeze, [">= 1.4.4"])
-      s.add_dependency(%q<rubyzip>.freeze, [">= 1.1.6"])
-      s.add_dependency(%q<bundler>.freeze, [">= 0"])
-      s.add_dependency(%q<rake>.freeze, [">= 0"])
-      s.add_dependency(%q<jeweler>.freeze, [">= 0"])
-      s.add_dependency(%q<rspec>.freeze, [">= 0"])
-      s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_dependency(%q<ruby-prof>.freeze, [">= 0"])
-    end
+  if s.respond_to? :add_runtime_dependency then
+    s.add_runtime_dependency(%q<nokogiri>.freeze, [">= 1.10.8"])
+    s.add_runtime_dependency(%q<rubyzip>.freeze, [">= 1.3.0"])
+    s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_development_dependency(%q<juwelier>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_development_dependency(%q<ruby-prof>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
   else
-    s.add_dependency(%q<nokogiri>.freeze, [">= 1.4.4"])
-    s.add_dependency(%q<rubyzip>.freeze, [">= 1.1.6"])
+    s.add_dependency(%q<nokogiri>.freeze, [">= 1.10.8"])
+    s.add_dependency(%q<rubyzip>.freeze, [">= 1.3.0"])
     s.add_dependency(%q<bundler>.freeze, [">= 0"])
     s.add_dependency(%q<rake>.freeze, [">= 0"])
-    s.add_dependency(%q<jeweler>.freeze, [">= 0"])
+    s.add_dependency(%q<juwelier>.freeze, [">= 0"])
     s.add_dependency(%q<rspec>.freeze, [">= 0"])
     s.add_dependency(%q<simplecov>.freeze, [">= 0"])
     s.add_dependency(%q<ruby-prof>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
   end
 end
 

data/spec/lib/cell_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 require 'bigdecimal'
+require 'rubyXL/convenience_methods/font'
+require 'rubyXL/convenience_methods/cell'
 
 describe RubyXL::Cell do
-
   before do
     @workbook  = RubyXL::Workbook.new
     @worksheet = @workbook.add_worksheet('Test Worksheet')
@@ -29,6 +30,42 @@ describe RubyXL::Cell do
       cell = @worksheet.add_cell(r, c, RubyXL::RichText.new(:t => RubyXL::Text.new(:value => 'Hello')))
       expect(cell.datatype).to eq(RubyXL::DataType::INLINE_STRING)
     end
+
+    it 'should properly handle dates' do
+      r = 3
+      c = 3
+
+      dt = Date.today
+      cell = @worksheet.add_cell(r, c, dt)
+      cell.set_number_format('ddd mmm dd, yyyy')
+      expect(cell.value).to eq(dt)
+
+      tm = DateTime.now
+      cell = @worksheet.add_cell(r, c, tm)
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # Due to rounding errors, we allow microsecond precision on DateTime.
+      expect((cell.value - tm).to_f).to be_within(1.0/86400e6).of(0)
+
+      tm = Time.now
+      cell = @worksheet.add_cell(r, c, tm)
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # Due to rounding errors, we allow microsecond precision on Time.
+      expect(cell.value - tm.to_datetime).to be_within(1.0/86400e6).of(0)
+
+      expected_date = '2020-10-15T14:00:00Z'
+      expected_datetime = Time.parse(expected_date).utc
+      raw_value = '44119.583333333328' # Obtained from parsing a xlsx file with the expected date
+      cell = @worksheet.add_cell(r, c, Time.now) # Force a date cell type
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+      cell.raw_value = raw_value
+      expect(cell.raw_value).to eq(raw_value), 'Wrong raw value'
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # We expect exactly the same date
+      expect(cell.value.to_time.utc.iso8601).to eq(expected_datetime.iso8601)
+    end
   end
 
   describe '.change_fill' do
@@ -152,7 +189,7 @@ describe RubyXL::Cell do
       expect(@cell.text_indent).to eq(2)
     end
 
-    it "should not cause other cells with the same style to have text indent" do
+    it 'should not cause other cells with the same style to have text indent' do
       another_cell = @worksheet[1][0]
       another_cell.style_index = @cell.style_index
       expect(another_cell.text_indent).to be_nil
@@ -247,7 +284,7 @@ describe RubyXL::Cell do
       expect(cell.value).to eq('Hello')
     end
 
-    it "should properly handle numeric values" do
+    it 'should properly handle numeric values' do
       @cell.datatype = nil
       @cell.raw_value = '1'
       expect(@cell.value).to eq(1)
@@ -338,6 +375,12 @@ describe RubyXL::Cell do
       end
     end
 
+    context 'with RichText' do
+      it 'returns the value of the RichText' do
+        cell = RubyXL::Cell.new(is: RubyXL::RichText.new(t: RubyXL::Text.new(value: 'test')))
+        expect(cell.value).to eq('test')
+      end
+    end
   end
 
   describe '.change_contents' do
@@ -356,6 +399,15 @@ describe RubyXL::Cell do
       expect(@cell.formula).to be_nil
     end
 
+    it 'should cause cell value to match a time that is passed in' do
+      time = Time.parse('January 1, 2011')
+      @cell.change_contents(time)
+      expect(@cell).to receive(:is_date?).at_least(1).and_return(true)
+      expect(@cell.value).to eq(time.to_datetime)
+      expect(@cell.datatype).to be_nil
+      expect(@cell.formula).to be_nil
+    end
+
     it 'should case cell value to match a Float that is passed in' do
       number = 1.25
       @cell.change_contents(number)
@@ -372,8 +424,8 @@ describe RubyXL::Cell do
       expect(@cell.formula).to be_nil
     end
 
-    it 'should case cell value to match an BigDecimal that is passed in' do
-      number = BigDecimal.new('1234.5678')
+    it 'should cause cell value to match a BigDecimal that is passed in' do
+      number = BigDecimal('1234.5678')
       @cell.change_contents(number)
       expect(@cell.value).to eq(number)
       expect(@cell.datatype).to be_nil
@@ -547,5 +599,4 @@ describe RubyXL::Cell do
       expect(@cell.text_rotation).to eq(45)
     end
   end
-
 end

data/spec/lib/color_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'rubyXL/convenience_methods/color'
 
 describe RubyXL::Color do
   describe '.validate_color' do
@@ -7,7 +8,7 @@ describe RubyXL::Color do
     end
 
     it 'should cause an error if an invalid hex color code or one with a # is passed' do
-      expect {RubyXL::Color.validate_color('#G')}.to raise_error(RuntimeError)
+      expect { RubyXL::Color.validate_color('#G') }.to raise_error(RuntimeError)
     end
   end
 end

data/spec/lib/parser_spec.rb

@@ -1,25 +1,25 @@
+require 'English'
 require 'spec_helper'
 require 'tmpdir'
 
 describe RubyXL::Parser do
-
   before do
-    @test_sheet_name = "This is a very long sheet name that should be trimmed to 31 characters for compatibility with MS Excel"
+    @test_sheet_name = 'This is a very long sheet name that should be trimmed to 31 characters for compatibility with MS Excel'
     @workbook = RubyXL::Workbook.new
-    @workbook.add_worksheet("Test Worksheet")
+    @workbook.add_worksheet('Test Worksheet')
     @time = Time.at(Time.now.to_i) # Excel only saves times with 1-second precision.
     @time2 = @time + 123456
 
-    ws = @workbook.add_worksheet("Escape Test")
-    ws.add_cell(0, 0, "&")
-    ws.add_cell(0, 1, "<")
-    ws.add_cell(0, 2, ">")
-    ws.add_cell(0, 3, "")
+    ws = @workbook.add_worksheet('Escape Test')
+    ws.add_cell(0, 0, '&')
+    ws.add_cell(0, 1, '<')
+    ws.add_cell(0, 2, '>')
+    ws.add_cell(0, 3, '')
 
-    ws.add_cell(1, 0, "&")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 1, "<")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 2, ">")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 3, "")
+    ws.add_cell(1, 0, '&')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 1, '<')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 2, '>')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 3, '')
 
     ws.add_cell(2, 0, 0)
     ws.add_cell(2, 1, 12345)
@@ -35,13 +35,13 @@ describe RubyXL::Parser do
 
     @workbook.add_worksheet(@test_sheet_name)
 
-    @workbook.creator = "test creator"
-    @workbook.modifier = "test modifier"
+    @workbook.creator = 'test creator'
+    @workbook.modifier = 'test modifier'
     @workbook.created_at = @time
     @workbook.modified_at = @time2
 
     @time_str = Time.now.to_s
-    @file = "rubyXL-#{$$}-#{DateTime.now.strftime('%Q')}.xlsx"
+    @file = "rubyXL-#{$PROCESS_ID}-#{DateTime.now.strftime('%Q')}.xlsx"
     @workbook.write(@file)
   end
 
@@ -58,7 +58,7 @@ describe RubyXL::Parser do
     end
 
     it 'should cause an error if an xlsx or xlsm workbook is not passed' do
-      expect {@workbook2 = RubyXL::Parser.parse("nonexistent_file.tmp")}.to raise_error(Zip::Error)
+      expect { @workbook2 = RubyXL::Parser.parse('nonexistent_file.tmp') }.to raise_error(Zip::Error)
     end
 
     it 'should construct consistent number formats' do
@@ -69,19 +69,19 @@ describe RubyXL::Parser do
 
     it 'should unescape HTML entities properly' do
       @workbook2 = RubyXL::Parser.parse(@file)
-      expect(@workbook2["Escape Test"][0][0].value).to eq("&")
-      expect(@workbook2["Escape Test"][0][1].value).to eq("<")
-      expect(@workbook2["Escape Test"][0][2].value).to eq(">")
+      expect(@workbook2['Escape Test'][0][0].value).to eq('&')
+      expect(@workbook2['Escape Test'][0][1].value).to eq('<')
+      expect(@workbook2['Escape Test'][0][2].value).to eq('>')
 
-      expect(@workbook2["Escape Test"][1][0].value).to eq("&")
-      expect(@workbook2["Escape Test"][1][1].value).to eq("<")
-      expect(@workbook2["Escape Test"][1][2].value).to eq(">")
+      expect(@workbook2['Escape Test'][1][0].value).to eq('&')
+      expect(@workbook2['Escape Test'][1][1].value).to eq('<')
+      expect(@workbook2['Escape Test'][1][2].value).to eq('>')
     end
 
     it 'should parse Core properties correctly' do
       @workbook2 = RubyXL::Parser.parse(@file)
-      expect(@workbook2.creator).to eq("test creator")
-      expect(@workbook2.modifier).to eq("test modifier")
+      expect(@workbook2.creator).to eq('test creator')
+      expect(@workbook2.modifier).to eq('test modifier')
       expect(@workbook2.created_at).to eq(@time)
       expect(@workbook2.modified_at).to eq(@time2)
     end
@@ -91,11 +91,9 @@ describe RubyXL::Parser do
       expect(@workbook2[@test_sheet_name]).to be_nil
       expect(@workbook2[@test_sheet_name[0..30]]).not_to be_nil
     end
-
   end
 
   describe 'parse_buffer' do
-
     it 'should parse string buffer correctly' do
       buffer = File.read(@file)
       expect(buffer).to be_instance_of(String)
@@ -109,7 +107,6 @@ describe RubyXL::Parser do
       f = RubyXL::Parser.parse_buffer(io)
       expect(f).to be_instance_of(RubyXL::Workbook)
     end
-
   end
 
   after do

data/spec/lib/reference_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe RubyXL::Reference do
-
   describe '.ind2ref + .ref2ind' do
     it 'should correctly return the "Excel Style" description of cells when given a row/column number' do
       expect(RubyXL::Reference.ind2ref(0, 26)).to eq('AA1')
@@ -20,9 +19,16 @@ describe RubyXL::Reference do
       end
     end
 
+    it 'valid? should be true on valid references' do
+      expect(RubyXL::Reference.new('C23').valid?).to be true
+    end
+
+    it 'valid? should be false on invalid references' do
+      expect(RubyXL::Reference.new('C2A').valid?).to be false
+    end
+
     it 'should return [-1, -1] if the Excel index is not well-formed' do
       expect(RubyXL::Reference.ref2ind('A1B')).to eq([-1, -1])
     end
   end
-
-end
+end

data/spec/lib/rgb_color_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'rubyXL/convenience_methods/color'
+
+describe RubyXL::RgbColor do
+  describe '.to_s' do
+    it 'should properly translate RGB color to string' do
+      rgb_color = RubyXL::RgbColor.new
+
+      rgb_color.r = 1
+      rgb_color.g = 2
+      rgb_color.b = 255
+
+      expect(rgb_color.to_s).to eq('0102ff')
+    end
+
+    it 'should properly translate RGB color with alpha value to string' do
+      rgb_color = RubyXL::RgbColor.new
+
+      rgb_color.r = 11
+      rgb_color.g = 22
+      rgb_color.b = 33
+      rgb_color.a = 255
+
+      expect(rgb_color.to_s).to eq('0b1621ff')
+    end
+  end
+end

data/spec/lib/stylesheet_spec.rb

@@ -1,28 +1,25 @@
 require 'spec_helper'
 
 describe RubyXL::NumberFormat do
-
   describe '.is_date_format?' do
     it 'should return true if number format = dd// yy// mm' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?).to eq(true)
+    end
 
     it 'should return true if number format = DD// YY// MM (uppercase)' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?).to eq(true)
+    end
 
     it 'should return false if number format = @' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?()).to eq(false)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?).to eq(false)
+    end
 
     it 'should properly detect date formats amongst default ones' do
       all_formats = RubyXL::NumberFormats::DEFAULT_NUMBER_FORMATS
       id_list = all_formats.collect { |fmt| fmt.num_fmt_id if fmt.is_date_format? }.compact.sort
       expect(id_list).to eq([14, 15, 16, 17, 18, 19, 20, 21, 22, 45, 46, 47])
     end
-
   end
-
 end

data/spec/lib/text_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
 
 describe RubyXL::Text do
-
   describe '.to_s' do
-
     it 'should not crash processing UNICODE data' do
       bytes = [ 114, 39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115,
                 32, 103, 105, 114, 108, 102, 114, 105, 101, 110, 100,
                 39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115, 32, 104, 111]
 
-      t = RubyXL::Text.new(:value => bytes.pack("c*").force_encoding('UTF-8'))
+      t = RubyXL::Text.new(:value => bytes.pack('c*').force_encoding('UTF-8'))
 
       str = t.to_s
 
@@ -23,7 +21,5 @@ describe RubyXL::Text do
 
       expect(xml).to eq("<t>\u{10000}\u{10FFFF}</t>")
     end
-
   end
-
 end

data/spec/lib/workbook_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'rubyXL/convenience_methods/workbook'
 
 describe RubyXL::Workbook do
   before do
@@ -132,8 +133,19 @@ describe RubyXL::Workbook do
     end
   end
 
+  describe '.title' do
+    it 'should contain default title' do
+      expect(@workbook.title).to be_nil
+    end
+
+    it 'should set title properly' do
+      @workbook.title = 'TITLE'
+      expect(@workbook.title).to eq('TITLE')
+    end
+  end
+
   describe '.stream' do
-    it "It should not be confused by missing sheet_id" do
+    it 'It should not be confused by missing sheet_id' do
       workbook = RubyXL::Workbook.new
       workbook[0].sheet_id = 1
       workbook.add_worksheet('Sheet2')
@@ -143,12 +155,12 @@ describe RubyXL::Workbook do
     it 'should raise error if bad characters are present in worksheet name' do
       workbook = RubyXL::Workbook.new
       workbook[0].sheet_name = 'Sheet007'
-      expect{workbook.stream}.to_not raise_error
+      expect{ workbook.stream }.to_not raise_error
 
       '\\/*[]:?'.each_char { |char|
         workbook = RubyXL::Workbook.new
         workbook[0].sheet_name = "Sheet#{char}007"
-        expect{workbook.stream}.to raise_error(RuntimeError)
+        expect{ workbook.stream }.to raise_error(RuntimeError)
       }
     end
   end
@@ -169,6 +181,15 @@ describe RubyXL::Workbook do
     end
   end
 
+  describe 'defined names' do
+    it 'should add and access defined names properly' do
+      wb = RubyXL::Workbook.new
+      wb.define_new_name('TEST', 'Sheet1!$A$2')
 
-
+      wb2 = RubyXL::Parser.parse_buffer(wb.stream)
+      expect(wb2.get_defined_name('TEST')).to_not be_nil
+      expect(wb2.get_defined_name('TEST').reference).to eq('Sheet1!$A$2')
+      expect(wb2.get_defined_name('TEST2')).to be_nil
+    end
+  end
 end