rubyXL 3.3.22 → 3.4.25

data/rubyXL.gemspec

@@ -1,25 +1,28 @@
-# Generated by jeweler
+# Generated by juwelier
 # DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rubyXL 3.3.22 ruby lib
+# stub: rubyXL 3.4.25 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "rubyXL"
-  s.version = "3.3.22"
+  s.name = "rubyXL".freeze
+  s.version = "3.4.25"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Vivek Bhagwat", "Wesha"]
-  s.date = "2016-10-06"
-  s.description = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents"
-  s.email = "bhagwat.vivek@gmail.com"
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Vivek Bhagwat".freeze, "Wesha".freeze]
+  s.date = "2022-05-19"
+  s.description = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents".freeze
+  s.email = "bhagwat.vivek@gmail.com".freeze
   s.extra_rdoc_files = [
     "LICENSE.txt",
     "README.rdoc"
   ]
   s.files = [
+    ".circleci/config.yml",
+    ".codeclimate.yml",
     "Gemfile",
+    "Gemfile.lock",
     "LICENSE.txt",
     "README.rdoc",
     "Rakefile",
@@ -27,6 +30,11 @@ Gem::Specification.new do |s|
     "lib/rubyXL.rb",
     "lib/rubyXL/cell.rb",
     "lib/rubyXL/convenience_methods.rb",
+    "lib/rubyXL/convenience_methods/cell.rb",
+    "lib/rubyXL/convenience_methods/color.rb",
+    "lib/rubyXL/convenience_methods/font.rb",
+    "lib/rubyXL/convenience_methods/workbook.rb",
+    "lib/rubyXL/convenience_methods/worksheet.rb",
     "lib/rubyXL/objects/border.rb",
     "lib/rubyXL/objects/calculation_chain.rb",
     "lib/rubyXL/objects/cell_style.rb",
@@ -34,6 +42,7 @@ Gem::Specification.new do |s|
     "lib/rubyXL/objects/color.rb",
     "lib/rubyXL/objects/column_range.rb",
     "lib/rubyXL/objects/comments.rb",
+    "lib/rubyXL/objects/connection.rb",
     "lib/rubyXL/objects/container_nodes.rb",
     "lib/rubyXL/objects/content_types.rb",
     "lib/rubyXL/objects/data_validation.rb",
@@ -45,6 +54,7 @@ Gem::Specification.new do |s|
     "lib/rubyXL/objects/font.rb",
     "lib/rubyXL/objects/formula.rb",
     "lib/rubyXL/objects/ooxml_object.rb",
+    "lib/rubyXL/objects/query_table.rb",
     "lib/rubyXL/objects/reference.rb",
     "lib/rubyXL/objects/relationships.rb",
     "lib/rubyXL/objects/root.rb",
@@ -64,6 +74,8 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL.html",
     "rdoc/RubyXL/AExtension.html",
     "rdoc/RubyXL/AExtensionStorageArea.html",
+    "rdoc/RubyXL/ActiveX.html",
+    "rdoc/RubyXL/ActiveXBinary.html",
     "rdoc/RubyXL/AdjustHandleList.html",
     "rdoc/RubyXL/Alignment.html",
     "rdoc/RubyXL/AlternateContent.html",
@@ -208,6 +220,10 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/ChartsheetView.html",
     "rdoc/RubyXL/ChartsheetViews.html",
     "rdoc/RubyXL/Color.html",
+    "rdoc/RubyXL/ColorConvenienceClasses.html",
+    "rdoc/RubyXL/ColorConvenienceClasses/HlsColor.html",
+    "rdoc/RubyXL/ColorConvenienceClasses/RgbColor.html",
+    "rdoc/RubyXL/ColorConvenienceMethods.html",
     "rdoc/RubyXL/ColorFilter.html",
     "rdoc/RubyXL/ColorScale.html",
     "rdoc/RubyXL/ColorSet.html",
@@ -220,6 +236,12 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/ConditionalFormatValue.html",
     "rdoc/RubyXL/ConditionalFormatting.html",
     "rdoc/RubyXL/ConditionalFormattingRule.html",
+    "rdoc/RubyXL/Connection.html",
+    "rdoc/RubyXL/ConnectionTable.html",
+    "rdoc/RubyXL/ConnectionTables.html",
+    "rdoc/RubyXL/ConnectionTextField.html",
+    "rdoc/RubyXL/ConnectionTextFields.html",
+    "rdoc/RubyXL/Connections.html",
     "rdoc/RubyXL/ContentTypeDefault.html",
     "rdoc/RubyXL/ContentTypeOverride.html",
     "rdoc/RubyXL/ContentTypes.html",
@@ -233,6 +255,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/CustomProperties.html",
     "rdoc/RubyXL/CustomPropertiesFile.html",
     "rdoc/RubyXL/CustomProperty.html",
+    "rdoc/RubyXL/CustomPropertyFile.html",
     "rdoc/RubyXL/CustomSheetView.html",
     "rdoc/RubyXL/CustomSheetViews.html",
     "rdoc/RubyXL/CustomWorkbookView.html",
@@ -275,6 +298,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/FloatNode.html",
     "rdoc/RubyXL/FloatValue.html",
     "rdoc/RubyXL/Font.html",
+    "rdoc/RubyXL/FontConvenienceMethods.html",
     "rdoc/RubyXL/FontScheme.html",
     "rdoc/RubyXL/Fonts.html",
     "rdoc/RubyXL/Formula.html",
@@ -308,12 +332,18 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/OLEObjects.html",
     "rdoc/RubyXL/OLESize.html",
     "rdoc/RubyXL/OOXMLContainerObject.html",
+    "rdoc/RubyXL/OOXMLIgnored.html",
     "rdoc/RubyXL/OOXMLObject.html",
     "rdoc/RubyXL/OOXMLObjectClassMethods.html",
     "rdoc/RubyXL/OOXMLObjectInstanceMethods.html",
     "rdoc/RubyXL/OOXMLRelationshipsFile.html",
     "rdoc/RubyXL/OOXMLTopLevelObject.html",
+    "rdoc/RubyXL/OdbcOleDbProperties.html",
     "rdoc/RubyXL/Offset.html",
+    "rdoc/RubyXL/OlapProperties.html",
+    "rdoc/RubyXL/OleItem.html",
+    "rdoc/RubyXL/OleItems.html",
+    "rdoc/RubyXL/OleLink.html",
     "rdoc/RubyXL/OutlineProperties.html",
     "rdoc/RubyXL/PageMargins.html",
     "rdoc/RubyXL/PageSetup.html",
@@ -338,12 +368,21 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/ProtectedRange.html",
     "rdoc/RubyXL/ProtectedRanges.html",
     "rdoc/RubyXL/Protection.html",
+    "rdoc/RubyXL/QueryParameter.html",
+    "rdoc/RubyXL/QueryParameters.html",
+    "rdoc/RubyXL/QueryTable.html",
+    "rdoc/RubyXL/QueryTableDeletedField.html",
+    "rdoc/RubyXL/QueryTableDeletedFields.html",
+    "rdoc/RubyXL/QueryTableField.html",
+    "rdoc/RubyXL/QueryTableFields.html",
+    "rdoc/RubyXL/QueryTableRefresh.html",
     "rdoc/RubyXL/RID.html",
     "rdoc/RubyXL/RawOOXML.html",
     "rdoc/RubyXL/Reference.html",
     "rdoc/RubyXL/Relationship.html",
     "rdoc/RubyXL/RelationshipSupport.html",
     "rdoc/RubyXL/RelationshipSupport/ClassMehods.html",
+    "rdoc/RubyXL/RevisionPointer.html",
     "rdoc/RubyXL/RichText.html",
     "rdoc/RubyXL/RichTextRun.html",
     "rdoc/RubyXL/Row.html",
@@ -360,6 +399,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/SheetData.html",
     "rdoc/RubyXL/SheetDataExt.html",
     "rdoc/RubyXL/SheetDataSet.html",
+    "rdoc/RubyXL/SheetMetadata.html",
     "rdoc/RubyXL/SheetName.html",
     "rdoc/RubyXL/SheetNames.html",
     "rdoc/RubyXL/Sheets.html",
@@ -382,6 +422,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/TableStyle.html",
     "rdoc/RubyXL/TableStyles.html",
     "rdoc/RubyXL/Text.html",
+    "rdoc/RubyXL/TextImportSettings.html",
     "rdoc/RubyXL/Theme.html",
     "rdoc/RubyXL/ThemeElements.html",
     "rdoc/RubyXL/ThumbnailFile.html",
@@ -396,6 +437,7 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/WebPublishingItem.html",
     "rdoc/RubyXL/WebPublishingItems.html",
     "rdoc/RubyXL/WebPublishingProperties.html",
+    "rdoc/RubyXL/WebQueryProperties.html",
     "rdoc/RubyXL/Workbook.html",
     "rdoc/RubyXL/WorkbookConvenienceMethods.html",
     "rdoc/RubyXL/WorkbookProperties.html",
@@ -448,7 +490,6 @@ Gem::Specification.new do |s|
     "rdoc/images/zoom.png",
     "rdoc/index.html",
     "rdoc/js/darkfish.js",
-    "rdoc/js/jquery.js",
     "rdoc/js/navigation.js",
     "rdoc/js/navigation.js.gz",
     "rdoc/js/search.js",
@@ -462,6 +503,7 @@ Gem::Specification.new do |s|
     "spec/lib/color_spec.rb",
     "spec/lib/parser_spec.rb",
     "spec/lib/reference_spec.rb",
+    "spec/lib/rgb_color_spec.rb",
     "spec/lib/stylesheet_spec.rb",
     "spec/lib/text_spec.rb",
     "spec/lib/workbook_spec.rb",
@@ -472,42 +514,35 @@ Gem::Specification.new do |s|
     "test/test_parse_write.rb",
     "tmp/.gitignore"
   ]
-  s.homepage = "http://github.com/gilt/rubyXL"
-  s.licenses = ["MIT"]
-  s.rubygems_version = "2.5.1"
-  s.summary = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents"
+  s.homepage = "http://github.com/gilt/rubyXL".freeze
+  s.licenses = ["MIT".freeze]
+  s.rubygems_version = "3.3.12".freeze
+  s.summary = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
+  end
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<nokogiri>, [">= 1.4.4"])
-      s.add_runtime_dependency(%q<rubyzip>, [">= 1.1.6"])
-      s.add_development_dependency(%q<bundler>, [">= 0"])
-      s.add_development_dependency(%q<rake>, [">= 0"])
-      s.add_development_dependency(%q<jeweler>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, [">= 0"])
-      s.add_development_dependency(%q<simplecov>, [">= 0"])
-      s.add_development_dependency(%q<ruby-prof>, [">= 0"])
-    else
-      s.add_dependency(%q<nokogiri>, [">= 1.4.4"])
-      s.add_dependency(%q<rubyzip>, [">= 1.1.6"])
-      s.add_dependency(%q<bundler>, [">= 0"])
-      s.add_dependency(%q<rake>, [">= 0"])
-      s.add_dependency(%q<jeweler>, [">= 0"])
-      s.add_dependency(%q<rspec>, [">= 0"])
-      s.add_dependency(%q<simplecov>, [">= 0"])
-      s.add_dependency(%q<ruby-prof>, [">= 0"])
-    end
+  if s.respond_to? :add_runtime_dependency then
+    s.add_runtime_dependency(%q<nokogiri>.freeze, [">= 1.10.8"])
+    s.add_runtime_dependency(%q<rubyzip>.freeze, [">= 1.3.0"])
+    s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_development_dependency(%q<juwelier>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_development_dependency(%q<ruby-prof>.freeze, [">= 0"])
+    s.add_development_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
   else
-    s.add_dependency(%q<nokogiri>, [">= 1.4.4"])
-    s.add_dependency(%q<rubyzip>, [">= 1.1.6"])
-    s.add_dependency(%q<bundler>, [">= 0"])
-    s.add_dependency(%q<rake>, [">= 0"])
-    s.add_dependency(%q<jeweler>, [">= 0"])
-    s.add_dependency(%q<rspec>, [">= 0"])
-    s.add_dependency(%q<simplecov>, [">= 0"])
-    s.add_dependency(%q<ruby-prof>, [">= 0"])
+    s.add_dependency(%q<nokogiri>.freeze, [">= 1.10.8"])
+    s.add_dependency(%q<rubyzip>.freeze, [">= 1.3.0"])
+    s.add_dependency(%q<bundler>.freeze, [">= 0"])
+    s.add_dependency(%q<rake>.freeze, [">= 0"])
+    s.add_dependency(%q<juwelier>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
+    s.add_dependency(%q<ruby-prof>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
   end
 end
 

data/spec/lib/cell_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 require 'bigdecimal'
+require 'rubyXL/convenience_methods/font'
+require 'rubyXL/convenience_methods/cell'
 
 describe RubyXL::Cell do
-
   before do
     @workbook  = RubyXL::Workbook.new
     @worksheet = @workbook.add_worksheet('Test Worksheet')
@@ -26,6 +27,44 @@ describe RubyXL::Cell do
       cell = @worksheet.add_cell(r, c, "#{r}:#{c}")
       expect(cell.datatype).to eq(RubyXL::DataType::RAW_STRING)
 
+      cell = @worksheet.add_cell(r, c, RubyXL::RichText.new(:t => RubyXL::Text.new(:value => 'Hello')))
+      expect(cell.datatype).to eq(RubyXL::DataType::INLINE_STRING)
+    end
+
+    it 'should properly handle dates' do
+      r = 3
+      c = 3
+
+      dt = Date.today
+      cell = @worksheet.add_cell(r, c, dt)
+      cell.set_number_format('ddd mmm dd, yyyy')
+      expect(cell.value).to eq(dt)
+
+      tm = DateTime.now
+      cell = @worksheet.add_cell(r, c, tm)
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # Due to rounding errors, we allow microsecond precision on DateTime.
+      expect((cell.value - tm).to_f).to be_within(1.0/86400e6).of(0)
+
+      tm = Time.now
+      cell = @worksheet.add_cell(r, c, tm)
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # Due to rounding errors, we allow microsecond precision on Time.
+      expect(cell.value - tm.to_datetime).to be_within(1.0/86400e6).of(0)
+
+      expected_date = '2020-10-15T14:00:00Z'
+      expected_datetime = Time.parse(expected_date).utc
+      raw_value = '44119.583333333328' # Obtained from parsing a xlsx file with the expected date
+      cell = @worksheet.add_cell(r, c, Time.now) # Force a date cell type
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+      cell.raw_value = raw_value
+      expect(cell.raw_value).to eq(raw_value), 'Wrong raw value'
+      cell.set_number_format('ddd mmm dd, yyyy HH:MM:SS')
+
+      # We expect exactly the same date
+      expect(cell.value.to_time.utc.iso8601).to eq(expected_datetime.iso8601)
     end
   end
 
@@ -143,6 +182,22 @@ describe RubyXL::Cell do
     end
   end
 
+  describe '.change_text_indent' do
+    it 'should cause the cell to have the corresponding text indent' do
+      expect(@cell.text_indent).to be_nil
+      @cell.change_text_indent(2)
+      expect(@cell.text_indent).to eq(2)
+    end
+
+    it 'should not cause other cells with the same style to have text indent' do
+      another_cell = @worksheet[1][0]
+      another_cell.style_index = @cell.style_index
+      expect(another_cell.text_indent).to be_nil
+      @cell.change_text_indent(2)
+      expect(another_cell.text_indent).to be_nil
+    end
+  end
+
   describe '.change_border_color' do
     it 'should cause cell to have a colored top border' do
       expect(@cell.get_border_color(:top)).to be_nil
@@ -224,7 +279,12 @@ describe RubyXL::Cell do
       expect(@cell.value).to eq(date)
     end
 
-    it "should properly handle numeric values" do
+    it 'should properly return value of inlineStr' do
+      cell = @worksheet.add_cell(5, 5, RubyXL::RichText.new(:t => RubyXL::Text.new(:value => 'Hello')))
+      expect(cell.value).to eq('Hello')
+    end
+
+    it 'should properly handle numeric values' do
       @cell.datatype = nil
       @cell.raw_value = '1'
       expect(@cell.value).to eq(1)
@@ -275,6 +335,8 @@ describe RubyXL::Cell do
         expect(@cell.value).to eq(Date.parse('April 20, 2012'))
         @cell.change_contents(35981)
         expect(@cell.value).to eq(Date.parse('July 5, 1998'))
+        @cell.change_contents(0.019467592592592595)
+        expect(@cell.value).to eq(DateTime.parse('1899-12-31T00:28:02+00:00'))
         @cell.change_contents(1)
         expect(@cell.value).to eq(Date.parse('January 1, 1900'))
         @cell.change_contents(59)
@@ -298,6 +360,27 @@ describe RubyXL::Cell do
         expect(@cell.value).to eq(Date.parse('July 5, 1998'))
       end
     end
+
+    context 'date before January 1, 1900' do
+      it 'should parse as date' do
+        @cell.set_number_format('h:mm:ss')
+        @cell.datatype = nil
+
+        @cell.raw_value = '0.97726851851851848'
+        expect(@cell.is_date?).to be(true)
+        expect(@cell.value).to eq(DateTime.parse('1899-12-31 23:27:16'))
+        @cell.raw_value = '1.9467592592592595E-2'
+        expect(@cell.is_date?).to be(true)
+        expect(@cell.value).to eq(DateTime.parse('1899-12-31 00:28:02'))
+      end
+    end
+
+    context 'with RichText' do
+      it 'returns the value of the RichText' do
+        cell = RubyXL::Cell.new(is: RubyXL::RichText.new(t: RubyXL::Text.new(value: 'test')))
+        expect(cell.value).to eq('test')
+      end
+    end
   end
 
   describe '.change_contents' do
@@ -316,6 +399,15 @@ describe RubyXL::Cell do
       expect(@cell.formula).to be_nil
     end
 
+    it 'should cause cell value to match a time that is passed in' do
+      time = Time.parse('January 1, 2011')
+      @cell.change_contents(time)
+      expect(@cell).to receive(:is_date?).at_least(1).and_return(true)
+      expect(@cell.value).to eq(time.to_datetime)
+      expect(@cell.datatype).to be_nil
+      expect(@cell.formula).to be_nil
+    end
+
     it 'should case cell value to match a Float that is passed in' do
       number = 1.25
       @cell.change_contents(number)
@@ -332,8 +424,8 @@ describe RubyXL::Cell do
       expect(@cell.formula).to be_nil
     end
 
-    it 'should case cell value to match an BigDecimal that is passed in' do
-      number = BigDecimal.new('1234.5678')
+    it 'should cause cell value to match a BigDecimal that is passed in' do
+      number = BigDecimal('1234.5678')
       @cell.change_contents(number)
       expect(@cell.value).to eq(number)
       expect(@cell.datatype).to be_nil
@@ -420,6 +512,18 @@ describe RubyXL::Cell do
     it 'should return nil if no horizontal alignment has been specified for this cell' do
       expect(@cell.horizontal_alignment).to be_nil
     end
+
+    it 'should not create new XFs when changing alignment to already existing values' do
+      @cell.change_horizontal_alignment('left')
+      style_xf1 = @cell.style_index
+      @cell.change_horizontal_alignment('right')
+      expect(@cell.style_index).not_to eq(style_xf1)
+      style_xf2 = @cell.style_index
+      @cell.change_horizontal_alignment('left')
+      expect(@cell.style_index).to eq(style_xf1)
+      @cell.change_horizontal_alignment('right')
+      expect(@cell.style_index).to eq(style_xf2)
+    end
   end
 
   describe '.vertical_alignment' do
@@ -488,4 +592,11 @@ describe RubyXL::Cell do
     end
   end
 
+  describe '.text_rotation' do
+    it 'should correctly return the rotation for this cell' do
+      expect(@cell.text_rotation).to be_nil
+      @cell.change_text_rotation(45)
+      expect(@cell.text_rotation).to eq(45)
+    end
+  end
 end

data/spec/lib/color_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'rubyXL/convenience_methods/color'
 
 describe RubyXL::Color do
   describe '.validate_color' do
@@ -7,7 +8,7 @@ describe RubyXL::Color do
     end
 
     it 'should cause an error if an invalid hex color code or one with a # is passed' do
-      expect {RubyXL::Color.validate_color('#G')}.to raise_error(RuntimeError)
+      expect { RubyXL::Color.validate_color('#G') }.to raise_error(RuntimeError)
     end
   end
 end

data/spec/lib/parser_spec.rb

@@ -1,25 +1,25 @@
+require 'English'
 require 'spec_helper'
 require 'tmpdir'
 
 describe RubyXL::Parser do
-
   before do
-    @test_sheet_name = "This is a very long sheet name that should be trimmed to 31 characters for compatibility with MS Excel"
+    @test_sheet_name = 'This is a very long sheet name that should be trimmed to 31 characters for compatibility with MS Excel'
     @workbook = RubyXL::Workbook.new
-    @workbook.add_worksheet("Test Worksheet")
+    @workbook.add_worksheet('Test Worksheet')
     @time = Time.at(Time.now.to_i) # Excel only saves times with 1-second precision.
     @time2 = @time + 123456
 
-    ws = @workbook.add_worksheet("Escape Test")
-    ws.add_cell(0, 0, "&")
-    ws.add_cell(0, 1, "<")
-    ws.add_cell(0, 2, ">")
-    ws.add_cell(0, 3, "")
+    ws = @workbook.add_worksheet('Escape Test')
+    ws.add_cell(0, 0, '&')
+    ws.add_cell(0, 1, '<')
+    ws.add_cell(0, 2, '>')
+    ws.add_cell(0, 3, '')
 
-    ws.add_cell(1, 0, "&")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 1, "<")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 2, ">")#TODO#.datatype = RubyXL::Cell::SHARED_STRING
-    ws.add_cell(1, 3, "")
+    ws.add_cell(1, 0, '&')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 1, '<')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 2, '>')#TODO#.datatype = RubyXL::Cell::SHARED_STRING
+    ws.add_cell(1, 3, '')
 
     ws.add_cell(2, 0, 0)
     ws.add_cell(2, 1, 12345)
@@ -35,13 +35,13 @@ describe RubyXL::Parser do
 
     @workbook.add_worksheet(@test_sheet_name)
 
-    @workbook.creator = "test creator"
-    @workbook.modifier = "test modifier"
+    @workbook.creator = 'test creator'
+    @workbook.modifier = 'test modifier'
     @workbook.created_at = @time
     @workbook.modified_at = @time2
 
     @time_str = Time.now.to_s
-    @file = Dir::Tmpname.make_tmpname(['rubyXL', '.xlsx'], nil)
+    @file = "rubyXL-#{$PROCESS_ID}-#{DateTime.now.strftime('%Q')}.xlsx"
     @workbook.write(@file)
   end
 
@@ -58,7 +58,7 @@ describe RubyXL::Parser do
     end
 
     it 'should cause an error if an xlsx or xlsm workbook is not passed' do
-      expect {@workbook2 = RubyXL::Parser.parse("nonexistent_file.tmp")}.to raise_error(Zip::Error)
+      expect { @workbook2 = RubyXL::Parser.parse('nonexistent_file.tmp') }.to raise_error(Zip::Error)
     end
 
     it 'should construct consistent number formats' do
@@ -69,19 +69,19 @@ describe RubyXL::Parser do
 
     it 'should unescape HTML entities properly' do
       @workbook2 = RubyXL::Parser.parse(@file)
-      expect(@workbook2["Escape Test"][0][0].value).to eq("&")
-      expect(@workbook2["Escape Test"][0][1].value).to eq("<")
-      expect(@workbook2["Escape Test"][0][2].value).to eq(">")
+      expect(@workbook2['Escape Test'][0][0].value).to eq('&')
+      expect(@workbook2['Escape Test'][0][1].value).to eq('<')
+      expect(@workbook2['Escape Test'][0][2].value).to eq('>')
 
-      expect(@workbook2["Escape Test"][1][0].value).to eq("&")
-      expect(@workbook2["Escape Test"][1][1].value).to eq("<")
-      expect(@workbook2["Escape Test"][1][2].value).to eq(">")
+      expect(@workbook2['Escape Test'][1][0].value).to eq('&')
+      expect(@workbook2['Escape Test'][1][1].value).to eq('<')
+      expect(@workbook2['Escape Test'][1][2].value).to eq('>')
     end
 
     it 'should parse Core properties correctly' do
       @workbook2 = RubyXL::Parser.parse(@file)
-      expect(@workbook2.creator).to eq("test creator")
-      expect(@workbook2.modifier).to eq("test modifier")
+      expect(@workbook2.creator).to eq('test creator')
+      expect(@workbook2.modifier).to eq('test modifier')
       expect(@workbook2.created_at).to eq(@time)
       expect(@workbook2.modified_at).to eq(@time2)
     end
@@ -91,11 +91,9 @@ describe RubyXL::Parser do
       expect(@workbook2[@test_sheet_name]).to be_nil
       expect(@workbook2[@test_sheet_name[0..30]]).not_to be_nil
     end
-
   end
 
   describe 'parse_buffer' do
-
     it 'should parse string buffer correctly' do
       buffer = File.read(@file)
       expect(buffer).to be_instance_of(String)
@@ -109,7 +107,6 @@ describe RubyXL::Parser do
       f = RubyXL::Parser.parse_buffer(io)
       expect(f).to be_instance_of(RubyXL::Workbook)
     end
-
   end
 
   after do

data/spec/lib/reference_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe RubyXL::Reference do
-
   describe '.ind2ref + .ref2ind' do
     it 'should correctly return the "Excel Style" description of cells when given a row/column number' do
       expect(RubyXL::Reference.ind2ref(0, 26)).to eq('AA1')
@@ -20,9 +19,16 @@ describe RubyXL::Reference do
       end
     end
 
+    it 'valid? should be true on valid references' do
+      expect(RubyXL::Reference.new('C23').valid?).to be true
+    end
+
+    it 'valid? should be false on invalid references' do
+      expect(RubyXL::Reference.new('C2A').valid?).to be false
+    end
+
     it 'should return [-1, -1] if the Excel index is not well-formed' do
       expect(RubyXL::Reference.ref2ind('A1B')).to eq([-1, -1])
     end
   end
-
-end
+end

data/spec/lib/rgb_color_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+require 'rubyXL/convenience_methods/color'
+
+describe RubyXL::RgbColor do
+  describe '.to_s' do
+    it 'should properly translate RGB color to string' do
+      rgb_color = RubyXL::RgbColor.new
+
+      rgb_color.r = 1
+      rgb_color.g = 2
+      rgb_color.b = 255
+
+      expect(rgb_color.to_s).to eq('0102ff')
+    end
+
+    it 'should properly translate RGB color with alpha value to string' do
+      rgb_color = RubyXL::RgbColor.new
+
+      rgb_color.r = 11
+      rgb_color.g = 22
+      rgb_color.b = 33
+      rgb_color.a = 255
+
+      expect(rgb_color.to_s).to eq('0b1621ff')
+    end
+  end
+end

data/spec/lib/stylesheet_spec.rb

@@ -1,28 +1,25 @@
 require 'spec_helper'
 
 describe RubyXL::NumberFormat do
-
   describe '.is_date_format?' do
     it 'should return true if number format = dd// yy// mm' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'dd// yy// mm').is_date_format?).to eq(true)
+    end
 
     it 'should return true if number format = DD// YY// MM (uppercase)' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?()).to eq(true)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'DD// YY// MM').is_date_format?).to eq(true)
+    end
 
     it 'should return false if number format = @' do
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?()).to eq(false)
-      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?()).to eq(false)
-    end  
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '@').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => 'general').is_date_format?).to eq(false)
+      expect(RubyXL::NumberFormat.new(:num_fmt_id => 1, :format_code => '0.00e+00').is_date_format?).to eq(false)
+    end
 
     it 'should properly detect date formats amongst default ones' do
       all_formats = RubyXL::NumberFormats::DEFAULT_NUMBER_FORMATS
       id_list = all_formats.collect { |fmt| fmt.num_fmt_id if fmt.is_date_format? }.compact.sort
       expect(id_list).to eq([14, 15, 16, 17, 18, 19, 20, 21, 22, 45, 46, 47])
     end
-
   end
-
 end