rubyXL 3.3.10 → 3.3.11

data/rubyXL.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rubyXL 3.3.10 ruby lib
+# stub: rubyXL 3.3.11 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rubyXL"
-  s.version = "3.3.10"
+  s.version = "3.3.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Vivek Bhagwat", "Wesha"]
-  s.date = "2015-07-02"
+  s.date = "2015-08-07"
   s.description = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents"
   s.email = "bhagwat.vivek@gmail.com"
   s.extra_rdoc_files = [
@@ -463,6 +463,7 @@ Gem::Specification.new do |s|
     "spec/lib/parser_spec.rb",
     "spec/lib/reference_spec.rb",
     "spec/lib/stylesheet_spec.rb",
+    "spec/lib/text_spec.rb",
     "spec/lib/workbook_spec.rb",
     "spec/lib/worksheet_spec.rb",
     "test/input/.gitkeep",

data/spec/lib/cell_spec.rb

@@ -34,7 +34,7 @@ describe RubyXL::Cell do
     it 'should cause an error if hex color code not passed' do
       expect {
         @cell.change_fill('G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should make cell fill color equal to hex color code passed' do
@@ -45,7 +45,7 @@ describe RubyXL::Cell do
     it 'should cause an error if hex color code includes # character' do
       expect {
         @cell.change_fill('#0f0f0f')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -65,7 +65,7 @@ describe RubyXL::Cell do
     it 'should cause an error if a string passed' do
       expect {
         @cell.change_font_size('20')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -73,7 +73,7 @@ describe RubyXL::Cell do
     it 'should cause an error if hex color code not passed' do
       expect {
         @cell.change_font_color('G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should make cell font color equal to hex color code passed' do
@@ -84,7 +84,7 @@ describe RubyXL::Cell do
     it 'should cause an error if hex color code includes # character' do
       expect {
         @cell.change_font_color('#0f0f0f')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 

data/spec/lib/color_spec.rb

@@ -8,7 +8,7 @@ describe RubyXL::Color do
     end
 
     it 'should cause an error if an invalid hex color code or one with a # is passed' do
-      expect {RubyXL::Color.validate_color('#G')}.to raise_error
+      expect {RubyXL::Color.validate_color('#G')}.to raise_error(RuntimeError)
     end
   end
 end

data/spec/lib/parser_spec.rb

@@ -55,7 +55,7 @@ describe RubyXL::Parser do
     end
 
     it 'should cause an error if an xlsx or xlsm workbook is not passed' do
-      expect {@workbook2 = RubyXL::Parser.parse("nonexistent_file.tmp")}.to raise_error
+      expect {@workbook2 = RubyXL::Parser.parse("nonexistent_file.tmp")}.to raise_error(Zip::Error)
     end
 
 =begin

data/spec/lib/text_spec.rb

@@ -0,0 +1,21 @@
+require 'rubyXL'
+
+describe RubyXL::Text do
+
+  describe '.to_s' do
+
+    it 'should not crash processing UNICODE data' do
+      bytes = [ 114, 39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115,
+                32, 103, 105, 114, 108, 102, 114, 105, 101, 110, 100,
+                39, 95, 120, 48, 48, 56, 48, 95, 226, 132, 162, 115, 32, 104, 111]
+
+      t = RubyXL::Text.new(:value => bytes.pack("c*").force_encoding('UTF-8'))
+
+      str = t.to_s
+
+      expect(str).to be
+    end
+
+  end
+
+end

data/spec/lib/worksheet_spec.rb

@@ -50,13 +50,13 @@ describe RubyXL::Worksheet do
     it 'should raise error if hex color code not passed' do
       expect {
         @worksheet.change_row_fill(0, 'G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should raise error if hex color code includes # character' do
       expect {
         @worksheet.change_row_fill(3,'#FFF000')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should make row and cell fill colors equal hex color code passed' do
@@ -68,7 +68,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_fill(-1,'111111')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -89,7 +89,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_font_name(-1,'Arial')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -110,13 +110,13 @@ describe RubyXL::Worksheet do
     it 'should cause an error if a string passed' do
       expect {
         @worksheet.change_row_font_size(0, '20')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_font_size(-1,20)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -137,19 +137,19 @@ describe RubyXL::Worksheet do
     it 'should raise error if hex color code not passed' do
       expect {
         @worksheet.change_row_font_color(0, 'G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should raise error if hex color code includes # character' do
       expect {
         @worksheet.change_row_font_color(3,'#FFF000')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_font_color(-1,'0f0f0f')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -170,7 +170,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_italics(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -191,7 +191,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_bold(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -212,7 +212,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_underline(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -233,7 +233,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_strikethrough(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -258,7 +258,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_height(-1, 30)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -279,7 +279,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_horizontal_alignment(-1,'center')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -300,7 +300,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_vertical_alignment(-1,'center')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -316,7 +316,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_row_border(-1, :left, 'thin')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should create a new row if it did not exist before' do
@@ -367,7 +367,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_font_name(-1, 'Arial')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -381,13 +381,13 @@ describe RubyXL::Worksheet do
     it 'should cause an error if a string passed' do
       expect {
         @worksheet.change_column_font_size(0, '20')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_font_size(-1, 20)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -401,19 +401,19 @@ describe RubyXL::Worksheet do
     it 'should raise error if hex color code not passed' do
       expect {
         @worksheet.change_column_font_color(0, 'G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should raise error if hex color code includes # character' do
       expect {
         @worksheet.change_column_font_color(0,'#FFF000')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_font_color(-1,'0f0f0f')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -426,8 +426,8 @@ describe RubyXL::Worksheet do
 
     it 'should cause error if a negative argument is passed in' do
       expect {
-        @worksheet.change_column_italicized(-1, false)
-      }.to raise_error
+        @worksheet.change_column_italics(-1, false)
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -441,7 +441,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_bold(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -455,7 +455,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_underline(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -469,7 +469,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_strikethrough(-1, false)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -482,7 +482,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_width_raw(-1, 10)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -490,13 +490,13 @@ describe RubyXL::Worksheet do
     it 'should raise error if hex color code not passed' do
       expect {
         @worksheet.change_column_fill(0, 'G')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should raise error if hex color code includes # character' do
       expect {
         @worksheet.change_column_fill(3,'#FFF000')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should make column and cell fill colors equal hex color code passed' do
@@ -508,7 +508,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_fill(-1,'111111')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -522,7 +522,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_horizontal_alignment(-1,'center')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -536,7 +536,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_vertical_alignment(-1, 'center')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should set column width if column alignment is changed' do
@@ -555,7 +555,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.change_column_border(-1, :top, 'thin')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause column and cells within to have border at top of specified weight' do
@@ -632,7 +632,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.add_cell(-1,-1,'')
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -660,7 +660,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.delete_row(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -697,7 +697,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.insert_row(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should expand matrix to fit argument if nonnegative'  do
@@ -737,7 +737,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if negative argument is passed in' do
       expect {
         @worksheet.delete_column(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -778,7 +778,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.insert_column(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -814,13 +814,13 @@ describe RubyXL::Worksheet do
     it 'should cause error if shift argument is specified whcih is not :right or :down' do
       expect {
         @worksheet.insert_cell(0,0,'test',nil,:up)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.insert_cell(-1,-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -838,7 +838,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.delete_cell(-1,-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should shift cells to the right of the deleted cell left if :left is specified' do
@@ -861,7 +861,7 @@ describe RubyXL::Worksheet do
     it 'should cause en error if an argument other than :left, :up, or nil is specified for shift' do
       expect {
         @worksheet.delete_cell(0,0,:down)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -974,7 +974,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_row_height(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -982,7 +982,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_row_alignment(-1, true)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if no horizontal alignment specified for row' do
@@ -1025,7 +1025,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_row_border(-1, :top)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a row which does not exist is passed in' do
@@ -1042,7 +1042,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_font_name(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return default font if a (nonnegative) column which does not exist is passed in' do
@@ -1059,7 +1059,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_font_size(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return default font size if a column which does not exist is passed in' do
@@ -1076,7 +1076,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_font_color(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return default color (000000) if a (nonnegative) column which does not exist is passed in' do
@@ -1097,7 +1097,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.is_column_italicized(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a (nonnegative) column which does not exist is passed in' do
@@ -1114,7 +1114,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.is_column_bolded(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a (nonnegative) column which does not exist is passed in' do
@@ -1131,7 +1131,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.is_column_underlined(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a (nonnegative) column which does not exist is passed in' do
@@ -1148,7 +1148,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.is_column_struckthrough(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a (nonnegative) column which does not exist is passed in' do
@@ -1173,7 +1173,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_width_raw(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -1194,7 +1194,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_width(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -1215,7 +1215,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_fill(-1)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -1231,7 +1231,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_alignment(-1, :horizontal)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return correct horizontal alignment if it is set for that column' do
@@ -1252,7 +1252,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_alignment(-1, :vertical)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return correct vertical alignment if it is set for that column' do
@@ -1274,7 +1274,7 @@ describe RubyXL::Worksheet do
     it 'should cause error if a negative argument is passed in' do
       expect {
         @worksheet.get_column_border(-1, :diagonal)
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
 
     it 'should return nil if a column which does not exist is passed in' do