ruby-xz 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c92bf36556e0297676ad48820dc2ba25243e897ac3d4401d4a8ec89d695e77e4
-  data.tar.gz: 77a1b46d9158f80b6ad28c68483a02835fcecb9ae5fa85f9dcda296630238ea2
+  metadata.gz: efe7c4ed9a4c30ce23e8328060b458e36a29b7b31d17528a4acb842c461a6b11
+  data.tar.gz: f8c55ee6bf356b87d8511ff45bfcc481b17bc8475477a7dd9df56b69c7185a6b
 SHA512:
-  metadata.gz: 7830929d9fea616430f554cb2a2ae2ef95095b8cf5d90c19e70e5bba697f301a059071c9da83a926ed7654506ccbe317009147c11d444822a47f78f3592dbfbc
-  data.tar.gz: fea094736b25633859b303a17402a59cd673c3fafa80614dd096f5053c92d09604a2e06fbf3a1d75e11e04a34b336a54ffe4bb8ae4231f4766417a49d4cec5c7
+  metadata.gz: b61b2e26837ce216cdc03286e3c52d4fd38a01f95d158556d0ed9ed4f347d289e575f6bdd5da236265ba4a37ee9c779f98db37f663edce2308a874e6cedd9a16
+  data.tar.gz: a93055f9f309a7adf464b392cd9e5ac2bce97ae9f97bf37fec16d5f537ac2cd6d590d88a9ab6e6786be586eed841137bba29946de90bbf601124c695556af003

data/HISTORY.rdoc

@@ -1,11 +1,17 @@
 = Version history
 
+== 1.0.3 (2022-03-28)
+* *Fix* a number of memory leaks by freeing allocated liblzma data structures
+  (Issue Quintus#20 reported by xTRiM, PR win93#7 by Alex Gittemeier)
+
 == 1.0.2 (2021-11-28)
-* Fix a deprecation warning and some other gemspec concerns (PR win93#6 by Alex Gittemeier)
+* *Fix* a deprecation warning and some other gemspec concerns
+  (Issue win93#5, PR win93#6 by Alex Gittemeier)
 
 == 1.0.1 (2021-11-13)
-* Fix a buffer overflow error in XZ::Stream (PR Quintus#17 by genail)
-* Fix an issue with transcode_options that was introduced by Ruby 3 (PR win93#1 by Alex Gittemeier)
+* *Fix* a buffer overflow error in XZ::Stream (PR Quintus#17 by genail)
+* *Fix* an issue with transcode_options that was introduced by Ruby 3
+  (PR win93#1 by Alex Gittemeier)
 * Update project README, gemspec, and other metadata to reflect a change in
   maintainership. All prior releases were released by Marvin Gülker.
 

data/README.md

@@ -110,7 +110,7 @@ To release a new version:
 - Switch to the `development` branch.
 - Bump `lib/xz/version.rb`, run `bundle install`, then commit the result.
 - Switch to the `stable` branch.
-- Run `git merge --no-ff development`
+- Run `git merge development`
 - Run `rake release`, which will create/push a git tag and publish the `.gem`
   file to [rubygems.org].
 

data/lib/xz/stream.rb

@@ -155,9 +155,9 @@ class XZ::Stream
     # Reset internal state
     @pos = @lineno = 0
     @finished = false
-
-    # Allocate a new lzma stream (subclasses will configure it).
     @lzma_stream = XZ::LibLZMA::LZMAStream.malloc
+    @input_buffer_p  = Fiddle::Pointer.malloc(XZ::CHUNK_SIZE)
+    @output_buffer_p = Fiddle::Pointer.malloc(XZ::CHUNK_SIZE)
     XZ::LibLZMA::LZMA_STREAM_INIT(@lzma_stream)
 
     0 # Mimic IO#rewind's return value
@@ -211,6 +211,9 @@ class XZ::Stream
     # Clean up the lzma_stream structure's internal memory.
     # This would belong into a destructor if Ruby had that.
     XZ::LibLZMA.lzma_end(@lzma_stream)
+    Fiddle.free @lzma_stream.to_ptr
+    Fiddle.free @input_buffer_p
+    Fiddle.free @output_buffer_p
     @finished = true
 
     @delegate_io

data/lib/xz/version.rb

@@ -28,5 +28,5 @@
 
 module XZ
   # The version of this library.
-  VERSION = '1.0.2'
+  VERSION = '1.0.3'
 end

data/lib/xz.rb

@@ -218,8 +218,10 @@ module XZ
       end
 
       LibLZMA.lzma_end(stream.to_ptr)
+      res = stream.total_out if block_given?
 
-      block_given? ? stream.total_out : res
+      Fiddle.free stream.to_ptr
+      res
     end
     alias decode_stream decompress_stream
 
@@ -317,8 +319,10 @@ module XZ
       end
 
       LibLZMA.lzma_end(stream.to_ptr)
+      res = stream.total_out if block_given?
 
-      block_given? ? stream.total_out : res
+      Fiddle.free stream.to_ptr
+      res
     end
     alias encode_stream compress_stream
 
@@ -458,8 +462,8 @@ module XZ
     # time--this is needed to allow (de-)compressing of very large
     # files that can't be loaded fully into memory.
     def lzma_code(io, stream)
-      input_buffer_p  = Fiddle::Pointer.malloc(CHUNK_SIZE) # automatically freed by fiddle on GC
-      output_buffer_p = Fiddle::Pointer.malloc(CHUNK_SIZE) # automatically freed by fiddle on GC
+      input_buffer_p  = Fiddle::Pointer.malloc(CHUNK_SIZE)
+      output_buffer_p = Fiddle::Pointer.malloc(CHUNK_SIZE)
 
       while str = io.read(CHUNK_SIZE)
         input_buffer_p[0, str.bytesize] = str
@@ -502,6 +506,9 @@ module XZ
           break unless stream.avail_out == 0
         end #loop
       end #while
+
+      Fiddle.free input_buffer_p
+      Fiddle.free output_buffer_p
     end #lzma_code
 
     # Checks for errors and warnings that can be derived from the

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-xz
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Marvin Gülker
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-11-29 00:00:00.000000000 Z
+date: 2022-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitar
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: XZ compression via liblzma for Ruby, using fiddle.