ruby-trello 1.0.4 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c4d52816b20573e0e428d30639952518f52c303e
+  data.tar.gz: ba52ccc7483b34f53d018cdef8be47565959c1b0
+SHA512:
+  metadata.gz: 64d9ab9659f109dca082bf07764aa695c6487e294c6b5fd9e3e951ffc8492d24ab26e80a676648a2dd3f877f7d2c2b3c00e4bf7b8fab742d7caae67f1e1a4511
+  data.tar.gz: 06941e4963b76afb942927c2657e07544fa44e698655bb1d4a6d74c6457b53fec9aa695615076ff3b544bafe9a7e679918f510111358bf5c690f246254530bf4

data/lib/trello/association.rb

@@ -7,8 +7,8 @@ module Trello
       @target = target
       @options = {}
       if target.is_a?(Array)
-        target.each{|array_element| array_element.client = owner.client}
+        target.each { |array_element| array_element.client = owner.client }
       end
     end
   end
-end
+end

data/lib/trello/authorization.rb

@@ -115,10 +115,21 @@ module Trello
         @token ||= build_token
       end
 
-      def consumer_key; consumer_credential.key; end
-      def consumer_secret; consumer_credential.secret; end
-      def oauth_token; token.key; end
-      def oauth_token_secret; token.secret; end
+      def consumer_key
+        consumer_credential.key
+      end
+
+      def consumer_secret
+        consumer_credential.secret
+      end
+
+      def oauth_token
+        token.key
+      end
+
+      def oauth_token_secret
+        token.secret
+      end
 
       private
 

data/lib/trello/basic_data.rb

@@ -47,7 +47,7 @@ module Trello
       # Defines the attribute getter and setters.
       class_eval do
         define_method :attributes do
-          @attributes ||= names.inject({}) { |hash,k| hash.merge(k.to_sym => nil) }
+          @attributes ||= names.reduce({}) { |hash, k| hash.merge(k.to_sym => nil) }
         end
 
         names.each do |key|

data/lib/trello/card.rb

@@ -90,7 +90,7 @@ module Trello
     def update!
       @previously_changed = changes
       # extract only new values to build payload
-      payload = Hash[changes.map { |key, values| [key.to_sym, values[1]] }]
+      payload = Hash[changes.map { |key, values| [key.to_sym.eql?(:list_id) ? :idList : key.to_sym, values[1]] }]
       @changed_attributes.clear
 
       client.put("/cards/#{id}", payload)
@@ -134,9 +134,10 @@ module Trello
 
     # Move this card to the given list
     def move_to_list(list)
-      unless list_id == list.id
+      list_number = list.is_a?(String) ? list : list.id
+      unless list_id == list_number
         client.put("/cards/#{id}/idList", {
-          :value => list.id
+          value: list_number
         })
       end
     end

data/spec/action_spec.rb

@@ -8,73 +8,73 @@ module Trello
     let(:client) { Client.new }
 
     before(:each) do
-      client.stub(:get).with("/actions/4ee2482134a81a757a08af47", {}).
+      client.stub(:get).with('/actions/4ee2482134a81a757a08af47', {}).
         and_return JSON.generate(actions_details.first)
     end
 
-    context "finding" do
+    context 'finding' do
       let(:client) { Trello.client }
 
-      it "delegates to Trello.client#find" do
+      it 'delegates to Trello.client#find' do
         client.should_receive(:find).with(:action, '4ee2482134a81a757a08af47', {})
         Action.find('4ee2482134a81a757a08af47')
       end
 
-      it "is equivalent to client#find" do
+      it 'is equivalent to client#find' do
         Action.find('4ee2482134a81a757a08af47').should eq(action)
       end
     end
 
-    context "fields" do
+    context 'fields' do
       let(:detail) { actions_details.first }
 
-      it "gets its id" do
+      it 'gets its id' do
         action.id.should == detail['id']
       end
 
-      it "gets its type" do
+      it 'gets its type' do
         action.type.should == detail['type']
       end
 
-      it "has the same data" do
+      it 'has the same data' do
         action.data.should == detail['data']
       end
 
-      it "gets the date" do
+      it 'gets the date' do
         action.date.utc.iso8601.should == detail['date']
       end
     end
 
-    context "boards" do
-      it "has a board" do
-        client.stub(:get).with("/actions/4ee2482134a81a757a08af47/board").
+    context 'boards' do
+      it 'has a board' do
+        client.stub(:get).with('/actions/4ee2482134a81a757a08af47/board').
           and_return JSON.generate(boards_details.first)
 
         action.board.should_not be_nil
       end
     end
 
-    context "card" do
-      it "has a card" do
-        client.stub(:get).with("/actions/4ee2482134a81a757a08af47/card").
+    context 'card' do
+      it 'has a card' do
+        client.stub(:get).with('/actions/4ee2482134a81a757a08af47/card').
           and_return JSON.generate(cards_details.first)
 
         action.card.should_not be_nil
       end
     end
 
-    context "list" do
-      it "has a list of lists" do
-        client.stub(:get).with("/actions/4ee2482134a81a757a08af47/list").
+    context 'list' do
+      it 'has a list of lists' do
+        client.stub(:get).with('/actions/4ee2482134a81a757a08af47/list').
           and_return JSON.generate(lists_details.first)
 
         action.list.should_not be_nil
       end
     end
 
-    context "member creator" do
-      it "knows its member creator" do
-        client.stub(:get).with("/members/abcdef123456789123456789", {}).and_return user_payload
+    context 'member creator' do
+      it 'knows its member creator' do
+        client.stub(:get).with('/members/abcdef123456789123456789', {}).and_return user_payload
 
         action.member_creator.should_not be_nil
       end

data/spec/association_spec.rb

@@ -4,18 +4,18 @@ module Trello
   describe Association do
     include Helpers
     
-    let(:organization) { client.find(:organization, "4ee7e59ae582acdec8000291") }
-    let(:client) { Client.new(:consumer_key => "xxx") }
+    let(:organization) { client.find(:organization, '4ee7e59ae582acdec8000291') }
+    let(:client) { Client.new(:consumer_key => 'xxx') }
 
     before(:each) do
-      client.stub(:get).with("/organizations/4ee7e59ae582acdec8000291", {}).
+      client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291', {}).
         and_return organization_payload
-      client.stub(:get).with("/organizations/4ee7e59ae582acdec8000291/boards/all").
+      client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291/boards/all').
         and_return boards_payload        
     end
     
-    it "should set the proper client for all associated boards of the organization" do
-      organization.boards.first.client.consumer_key.should == "xxx"
+    it 'should set the proper client for all associated boards of the organization' do
+      organization.boards.first.client.consumer_key.should == 'xxx'
     end
     
   end

data/spec/basic_auth_policy_spec.rb

@@ -1,19 +1,19 @@
-require "spec_helper"
+require 'spec_helper'
 
 include Trello
 include Trello::Authorization
 
 describe BasicAuthPolicy do
   before do
-    BasicAuthPolicy.developer_public_key = "xxx"
-    BasicAuthPolicy.member_token = "xxx"
+    BasicAuthPolicy.developer_public_key = 'xxx'
+    BasicAuthPolicy.member_token = 'xxx'
   end
 
-  it "adds key and token query parameters" do
-    BasicAuthPolicy.developer_public_key = "xxx_developer_public_key_xxx"
-    BasicAuthPolicy.member_token = "xxx_member_token_xxx"
+  it 'adds key and token query parameters' do
+    BasicAuthPolicy.developer_public_key = 'xxx_developer_public_key_xxx'
+    BasicAuthPolicy.member_token = 'xxx_member_token_xxx'
 
-    uri = Addressable::URI.parse("https://xxx/")
+    uri = Addressable::URI.parse('https://xxx/')
 
     request = Request.new :get, uri
 
@@ -21,31 +21,31 @@ describe BasicAuthPolicy do
 
     the_query_parameters = Addressable::URI.parse(authorized_request.uri).query_values
 
-    the_query_parameters["key"].should === "xxx_developer_public_key_xxx"
-    the_query_parameters["token"].should === "xxx_member_token_xxx"
+    the_query_parameters['key'].should === 'xxx_developer_public_key_xxx'
+    the_query_parameters['token'].should === 'xxx_member_token_xxx'
   end
 
-  it "preserves other query parameters" do
-    uri = Addressable::URI.parse("https://xxx/?name=Phil")
+  it 'preserves other query parameters' do
+    uri = Addressable::URI.parse('https://xxx/?name=Phil')
 
-    request = Request.new :get, uri, {:example_header => "example_value"}
+    request = Request.new :get, uri, {:example_header => 'example_value'}
 
     authorized_request = BasicAuthPolicy.authorize request
 
     the_query_parameters = Addressable::URI.parse(authorized_request.uri).query_values
 
-    the_query_parameters["name"].should == "Phil"
+    the_query_parameters['name'].should == 'Phil'
   end
 
-  it "preserves headers" do
-    uri = Addressable::URI.parse("https://xxx/")
+  it 'preserves headers' do
+    uri = Addressable::URI.parse('https://xxx/')
 
-    request = Request.new :get, uri, {:example_header => "example_value"}
+    request = Request.new :get, uri, {:example_header => 'example_value'}
 
     authorized_request = BasicAuthPolicy.authorize request
 
     authorized_request.headers.should === request.headers
   end
 
-  it "does what when a query parameter already exists called key or token?"
+  it 'does what when a query parameter already exists called key or token?'
 end

data/spec/board_spec.rb

@@ -165,11 +165,11 @@ module Trello
         client.should_not_receive :put
 
         the_new_board = Board.new
-        lambda{the_new_board.save}.should raise_error
+        -> { the_new_board.save }.should raise_error
       end
 
       it "puts all fields except id" do
-        expected_fields = %w{name description closed}.map{|s| s.to_sym}
+        expected_fields = %w{ name description closed }.map { |s| s.to_sym }
 
         client.should_receive(:put) do |anything, body|
           body.keys.should =~ expected_fields

data/spec/card_spec.rb

@@ -146,36 +146,42 @@ module Trello
       end
 
       it 'can be moved to another list' do
-        other_list = stub(:id => '987654321987654321fedcba')
+        other_list = double(:id => '987654321987654321fedcba')
         payload = {:value => other_list.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idList", payload)
         card.move_to_list(other_list)
       end
 
       it 'should not be moved if new list is identical to old list' do
-        other_list = stub(:id => 'abcdef123456789123456789')
-        payload = {:value => other_list.id}
+        other_list = double(:id => 'abcdef123456789123456789')
+        payload = { :value => other_list.id }
         client.should_not_receive(:put)
         card.move_to_list(other_list)
       end
 
+      it "should accept a string for moving a card to list" do
+        payload = { value: "12345678"}
+        client.should_receive(:put).with("/cards/abcdef123456789123456789/idList", payload)
+        card.move_to_list("12345678")
+      end
+
       it 'can be moved to another board' do
-        other_board = stub(:id => '987654321987654321fedcba')
+        other_board = double(:id => '987654321987654321fedcba')
         payload = {:value => other_board.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idBoard", payload)
         card.move_to_board(other_board)
       end
 
       it 'can be moved to a list on another board' do
-        other_board = stub(:id => '987654321987654321fedcba')
-        other_list = stub(:id => '987654321987654321aalist')
+        other_board = double(:id => '987654321987654321fedcba')
+        other_list = double(:id => '987654321987654321aalist')
         payload = {:value => other_board.id, :idList => other_list.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idBoard", payload)
         card.move_to_board(other_board, other_list)
       end
 
       it 'should not be moved if new board is identical with old board', :focus => true do
-        other_board = stub(:id => 'abcdef123456789123456789')
+        other_board = double(:id => 'abcdef123456789123456789')
         client.should_not_receive(:put)
         card.move_to_board(other_board)
       end
@@ -191,7 +197,7 @@ module Trello
       end
 
       it "allows a member to be added to a card" do
-        new_member = stub(:id => '4ee7df3ce582acdec80000b2')
+        new_member = double(:id => '4ee7df3ce582acdec80000b2')
         payload = {
           :value => new_member.id
         }
@@ -200,7 +206,7 @@ module Trello
       end
 
       it "allows a member to be removed from a card" do
-        existing_member = stub(:id => '4ee7df3ce582acdec80000b2')
+        existing_member = double(:id => '4ee7df3ce582acdec80000b2')
         client.should_receive(:delete).with("/cards/abcdef123456789123456789/members/#{existing_member.id}")
         card.remove_member(existing_member)
       end

data/spec/checklist_spec.rb

@@ -70,7 +70,7 @@ module Trello
         }
 
         result = JSON.generate(checklists_details.first)
-        client.should_receive(:put).once.with("/checklists/abcdef123456789123456789", payload).and_return result
+        client.should_receive(:put).once.with(expected_resource, payload).and_return result
 
         checklist.name = expected_new_name
         checklist.save
@@ -80,7 +80,6 @@ module Trello
         expected_item_name = "item1"
         expected_checked = true
         expected_pos = 9999
-        expected_resource = "/checklists/abcdef123456789123456789"
         payload = {
             :name => expected_item_name,
             :checked => expected_checked,

data/spec/client_spec.rb

@@ -4,13 +4,13 @@ include Trello
 include Trello::Authorization
 
 describe Client, "and how it handles authorization" do
-  let (:fake_ok_response) {
-    stub "A fake OK response",
+  let (:fake_ok_response) do
+    double "A fake OK response",
       :code => 200,
       :body => "A fake response body"
-  }
+  end
   let(:client) { Client.new }
-  let(:auth_policy) { stub }
+  let(:auth_policy) { double }
 
   before do
     TInternet.stub(:execute).and_return fake_ok_response
@@ -47,13 +47,13 @@ describe Client, "and how it handles authorization" do
 
   it "raises an error when response has non-200 status" do
     expected_error_message = "An error response"
-    response_with_non_200_status = stub "A fake OK response",
+    response_with_non_200_status = double "A fake OK response",
       :code => 404,
       :body => expected_error_message
 
     TInternet.stub(:execute).and_return response_with_non_200_status
 
-    lambda{client.get "/xxx"}.should raise_error expected_error_message
+    -> { client.get "/xxx" }.should raise_error expected_error_message
   end
 
   it "uses version 1 of the API" do
@@ -103,8 +103,6 @@ describe Client, "and how it handles authorization" do
   end
 
   it "supports put" do
-    expected_path = "/xxx"
-
     TInternet.should_receive(:execute).once.and_return fake_ok_response
 
     client.put "/xxx", { :phil => "T' north" }
@@ -133,14 +131,14 @@ describe Client, "and how it handles authorization" do
   end
 
   context "initialize" do
-    let(:client) {
+    let(:client) do
       Client.new(
         :consumer_key => 'consumer_key',
         :consumer_secret => 'consumer_secret',
         :oauth_token => 'oauth_token',
         :oauth_token_secret => 'oauth_token_secret'
       )
-    }
+    end
 
     it "is configurable" do
       client.consumer_key.should eq('consumer_key')

data/spec/configuration_spec.rb

@@ -1,51 +1,51 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Trello::Configuration do
   let(:configuration) { Trello::Configuration.new }
 
-  it "has a consumer_key attribute" do
+  it 'has a consumer_key attribute' do
     configuration.consumer_key = 'consumer_key'
     configuration.consumer_key.should eq('consumer_key')
   end
 
-  it "has a consumer_secret attribute" do
+  it 'has a consumer_secret attribute' do
     configuration.consumer_secret = 'consumer_secret'
     configuration.consumer_secret.should eq('consumer_secret')
   end
 
-  it "has a oauth_token attribute" do
+  it 'has a oauth_token attribute' do
     configuration.oauth_token = 'oauth_token'
     configuration.oauth_token.should eq('oauth_token')
   end
 
-  it "has a oauth_token_secret attribute" do
+  it 'has a oauth_token_secret attribute' do
     configuration.oauth_token_secret = 'oauth_token_secret'
     configuration.oauth_token_secret.should eq('oauth_token_secret')
   end
 
-  it "has a developer public key attribute" do
+  it 'has a developer public key attribute' do
     configuration.developer_public_key = 'developer_public_key'
     configuration.developer_public_key.should eq('developer_public_key')
   end
 
-  it "has a member token attribute" do
+  it 'has a member token attribute' do
     configuration.member_token = 'member_token'
     configuration.member_token.should eq('member_token')
   end
 
-  it "has a callback (for oauth)" do
-    callback = lambda { 'foobar' }
+  it 'has a callback (for oauth)' do
+    callback = -> { 'foobar' }
     configuration.callback = callback
     configuration.callback.call.should eq('foobar')
   end
 
-  it "has a return_url" do
-    configuration.return_url = "http://www.example.com/callback"
-    configuration.return_url.should eq("http://www.example.com/callback")
+  it 'has a return_url' do
+    configuration.return_url = 'http://www.example.com/callback'
+    configuration.return_url.should eq('http://www.example.com/callback')
   end
 
-  describe "initialize" do
-    it "sets key attributes provided as a hash" do
+  describe 'initialize' do
+    it 'sets key attributes provided as a hash' do
       configuration = Trello::Configuration.new(
         :consumer_key => 'consumer_key',
         :consumer_secret => 'consumer_secret',
@@ -59,14 +59,14 @@ describe Trello::Configuration do
     end
   end
 
-  describe "#credentials" do
+  describe '#credentials' do
     let(:configuration) { Trello::Configuration.new(attributes) }
 
-    it "returns an empty if no attributes specified" do
+    it 'returns an empty if no attributes specified' do
       Trello::Configuration.new({}).credentials.should eq({})
     end
 
-    it "returns an empty if attributes incomplete" do
+    it 'returns an empty if attributes incomplete' do
       Trello::Configuration.new(:consumer_key => 'consumer_key').credentials.should eq({})
     end
 
@@ -100,7 +100,7 @@ describe Trello::Configuration do
       )
     end
 
-    it "returns a hash of basic auth policy attributes" do
+    it 'returns a hash of basic auth policy attributes' do
       configuration = Trello::Configuration.new(
         :developer_public_key => 'developer_public_key',
         :member_token => 'member_token'