ruby-trello 1.0.4 → 1.1.0

data/spec/integration/how_to_authorize_spec.rb

@@ -47,7 +47,7 @@ describe "OAuth", :broken => true do
     OAuthPolicy.token = OAuthCredential.new @access_token_key, nil
 
     pending "I would expect this to fail because I have signed with nil secrets" do
-      lambda{Client.get("/boards/#{@welcome_board}/")}.should raise_error
+      -> { Client.get("/boards/#{@welcome_board}/") }.should raise_error
     end
   end
 end

data/spec/item_spec.rb

@@ -4,34 +4,34 @@ module Trello
   describe Item do
     before(:all) do
       @detail = {
-        'id'   => "abcdef123456789123456789",
-        'name' => "test item",
-        'type' => "check",
-        'state' => "complete",
+        'id'   => 'abcdef123456789123456789',
+        'name' => 'test item',
+        'type' => 'check',
+        'state' => 'complete',
         'pos' => 0
       }
 
       @item = Item.new(@detail)
     end
 
-    it "gets its id" do
+    it 'gets its id' do
       @item.id.should == @detail['id']
     end
 
-    it "gets its name" do
+    it 'gets its name' do
       @item.name.should == @detail['name']
     end
 
-    it "knows its type" do
+    it 'knows its type' do
       @item.type.should == @detail['type']
     end
 
-    it "knows its state" do
+    it 'knows its state' do
       @item.state.should == @detail['state']
     end
 
-    it "knows its pos" do
+    it 'knows its pos' do
       @item.pos.should == @detail['pos']
     end
   end
-end
+end

data/spec/list_spec.rb

@@ -4,31 +4,31 @@ module Trello
   describe List do
     include Helpers
 
-    let(:list) { client.find(:list, "abcdef123456789123456789") }
+    let(:list) { client.find(:list, 'abcdef123456789123456789') }
     let(:client) { Client.new }
 
     before(:each) do
-      client.stub(:get).with("/lists/abcdef123456789123456789", {}).and_return JSON.generate(lists_details.first)
-      client.stub(:get).with("/boards/abcdef123456789123456789", {}).and_return JSON.generate(boards_details.first)
+      client.stub(:get).with('/lists/abcdef123456789123456789', {}).and_return JSON.generate(lists_details.first)
+      client.stub(:get).with('/boards/abcdef123456789123456789', {}).and_return JSON.generate(boards_details.first)
     end
 
-    context "finding" do
+    context 'finding' do
       let(:client) { Trello.client }
 
-      it "delegates to client#find" do
+      it 'delegates to client#find' do
         client.should_receive(:find).with(:list, 'abcdef123456789123456789', {})
         List.find('abcdef123456789123456789')
       end
 
-      it "is equivalent to client#find" do
+      it 'is equivalent to client#find' do
         List.find('abcdef123456789123456789').should eq(list)
       end
     end
 
-    context "creating" do
+    context 'creating' do
       let(:client) { Trello.client }
 
-      it "creates a new record" do
+      it 'creates a new record' do
         list = List.new(lists_details.first)
         list.should be_valid
       end
@@ -51,9 +51,9 @@ module Trello
 
         result = JSON.generate(payload)
 
-        expected_payload = {:name => "Test List", :closed => false, :idBoard => "abcdef123456789123456789"}
+        expected_payload = {:name => 'Test List', :closed => false, :idBoard => 'abcdef123456789123456789'}
 
-        client.should_receive(:post).with("/lists", expected_payload).and_return result
+        client.should_receive(:post).with('/lists', expected_payload).and_return result
 
         list = List.create(payload)
 
@@ -61,73 +61,73 @@ module Trello
       end
     end
 
-    context "updating" do
-      it "updating name does a put on the correct resource with the correct value" do
-        expected_new_name = "xxx"
+    context 'updating' do
+      it 'updating name does a put on the correct resource with the correct value' do
+        expected_new_name = 'xxx'
 
         payload = {
           :name      => expected_new_name,
           :closed    => false
         }
 
-        client.should_receive(:put).once.with("/lists/abcdef123456789123456789", payload)
+        client.should_receive(:put).once.with('/lists/abcdef123456789123456789', payload)
         list.name = expected_new_name
         list.save
       end
     end
 
-    context "fields" do
-      it "gets its id" do
+    context 'fields' do
+      it 'gets its id' do
         list.id.should == lists_details.first['id']
       end
 
-      it "gets its name" do
+      it 'gets its name' do
         list.name.should == lists_details.first['name']
       end
 
-      it "knows if it is open or closed" do
+      it 'knows if it is open or closed' do
         list.closed.should == lists_details.first['closed']
       end
 
-      it "has a board" do
+      it 'has a board' do
         list.board.should == Board.new(boards_details.first)
       end
 
-      it "gets its position" do
+      it 'gets its position' do
         list.pos.should == lists_details.first['pos']
       end
     end
 
-    context "actions" do
-      it "has a list of actions" do
-        client.stub(:get).with("/lists/abcdef123456789123456789/actions", { :filter => :all }).and_return actions_payload
+    context 'actions' do
+      it 'has a list of actions' do
+        client.stub(:get).with('/lists/abcdef123456789123456789/actions', { :filter => :all }).and_return actions_payload
         list.actions.count.should be > 0
       end
     end
 
-    context "cards" do
-      it "has a list of cards" do
-        client.stub(:get).with("/lists/abcdef123456789123456789/cards", { :filter => :open }).and_return cards_payload
+    context 'cards' do
+      it 'has a list of cards' do
+        client.stub(:get).with('/lists/abcdef123456789123456789/cards', { :filter => :open }).and_return cards_payload
         list.cards.count.should be > 0
       end
     end
 
-    describe "#closed?" do
-      it "returns the closed attribute" do
+    describe '#closed?' do
+      it 'returns the closed attribute' do
         list.closed?.should_not be_true
       end
     end
 
-    describe "#close" do
-      it "updates the close attribute to true" do
+    describe '#close' do
+      it 'updates the close attribute to true' do
         list.close
         list.closed.should be_true
       end
     end
 
-    describe "#close!" do
-      it "updates the close attribute to true and saves the list" do
-        client.should_receive(:put).once.with("/lists/abcdef123456789123456789", {
+    describe '#close!' do
+      it 'updates the close attribute to true and saves the list' do
+        client.should_receive(:put).once.with('/lists/abcdef123456789123456789', {
           :name   => list.name,
           :closed => true
         })

data/spec/member_spec.rb

@@ -10,104 +10,104 @@ module Trello
     let(:client) { Client.new }
 
     before(:each) do
-      client.stub(:get).with("/members/abcdef123456789012345678", {}).and_return user_payload
+      client.stub(:get).with('/members/abcdef123456789012345678', {}).and_return user_payload
     end
 
-    context "finding" do
+    context 'finding' do
       let(:client) { Trello.client }
 
-      it "delegates to Trello.client#find" do
+      it 'delegates to Trello.client#find' do
         client.should_receive(:find).with(:member, 'abcdef123456789012345678', {})
         Member.find('abcdef123456789012345678')
       end
 
-      it "is equivalent to client#find" do
+      it 'is equivalent to client#find' do
         Member.find('abcdef123456789012345678').should eq(member)
       end
     end
 
-    context "actions" do
-      it "retrieves a list of actions", :refactor => true do
-        client.stub(:get).with("/members/abcdef123456789012345678/actions", { :filter => :all }).and_return actions_payload
+    context 'actions' do
+      it 'retrieves a list of actions', :refactor => true do
+        client.stub(:get).with('/members/abcdef123456789012345678/actions', { :filter => :all }).and_return actions_payload
         member.actions.count.should be > 0
       end
     end
 
-    context "boards" do
-      it "has a list of boards" do
-        client.stub(:get).with("/members/abcdef123456789012345678/boards", { :filter => :all }).and_return boards_payload
+    context 'boards' do
+      it 'has a list of boards' do
+        client.stub(:get).with('/members/abcdef123456789012345678/boards', { :filter => :all }).and_return boards_payload
         boards = member.boards
         boards.count.should be > 0
       end
     end
 
-    context "cards" do
-      it "has a list of cards" do
-        client.stub(:get).with("/members/abcdef123456789012345678/cards", { :filter => :open }).and_return cards_payload
+    context 'cards' do
+      it 'has a list of cards' do
+        client.stub(:get).with('/members/abcdef123456789012345678/cards', { :filter => :open }).and_return cards_payload
         cards = member.cards
         cards.count.should be > 0
       end
     end
 
-    context "organizations" do
-      it "has a list of organizations" do
-        client.stub(:get).with("/members/abcdef123456789012345678/organizations", { :filter => :all }).and_return orgs_payload
+    context 'organizations' do
+      it 'has a list of organizations' do
+        client.stub(:get).with('/members/abcdef123456789012345678/organizations', { :filter => :all }).and_return orgs_payload
         orgs = member.organizations
         orgs.count.should be > 0
       end
     end
 
-    context "notifications" do
-      it "has a list of notifications" do
-        client.stub(:get).with("/members/abcdef123456789012345678/notifications", {}).and_return "[" << notification_payload << "]"
+    context 'notifications' do
+      it 'has a list of notifications' do
+        client.stub(:get).with('/members/abcdef123456789012345678/notifications', {}).and_return '[' << notification_payload << ']'
         member.notifications.count.should be 1
       end
     end
 
-    context "personal" do
-      it "gets the members bio" do
+    context 'personal' do
+      it 'gets the members bio' do
         member.bio.should == user_details['bio']
       end
 
-      it "gets the full name" do
+      it 'gets the full name' do
         member.full_name.should == user_details['fullName']
       end
 
-      it "gets the avatar id" do
+      it 'gets the avatar id' do
         member.avatar_id.should == user_details['avatarHash']
       end
 
-      it "returns a valid url for the avatar" do
-        member.avatar_url(:size => :large).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png"
-        member.avatar_url(:size => :small).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png"
+      it 'returns a valid url for the avatar' do
+        member.avatar_url(:size => :large).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png'
+        member.avatar_url(:size => :small).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png'
       end
 
-      it "gets the url" do
+      it 'gets the url' do
         member.url.should == user_details['url']
       end
 
-      it "gets the username" do
+      it 'gets the username' do
         member.username.should == user_details['username']
       end
 
-      it "gets the email" do
+      it 'gets the email' do
         member.email.should == user_details['email']
       end
 
-      it "gets the initials" do
+      it 'gets the initials' do
         member.initials.should == user_details['initials']
       end
     end
 
-    context "modification" do
-      it "lets us know a field has changed without committing it" do
+    context 'modification' do
+      it 'lets us know a field has changed without committing it' do
         member.changed?.should be_false
-        member.bio = "New and amazing"
+        member.bio = 'New and amazing'
         member.changed?.should be_true
       end
 
-      it "doesn't understand the #id= method" do
-        lambda { member.id = "42" }.should raise_error NoMethodError
+      it 'does not understand the #id= method' do
+        -> { member.id = '42' }.should raise_error NoMethodError
       end
     end
   end

data/spec/oauth_policy_spec.rb

@@ -1,22 +1,22 @@
-require "spec_helper"
+require 'spec_helper'
 
 include Trello
 include Trello::Authorization
 
 describe OAuthPolicy do
   before do
-    OAuthPolicy.consumer_credential = OAuthCredential.new "xxx", "xxx"
+    OAuthPolicy.consumer_credential = OAuthCredential.new 'xxx', 'xxx'
     OAuthPolicy.token = nil
   end
 
-  describe "#consumer_credential" do
-    it "uses class setting if available" do
+  describe '#consumer_credential' do
+    it 'uses class setting if available' do
       policy = OAuthPolicy.new
       policy.consumer_credential.key.should eq('xxx')
       policy.consumer_credential.secret.should eq('xxx')
     end
 
-    it "is built from given consumer_key and consumer_secret" do
+    it 'is built from given consumer_key and consumer_secret' do
       policy = OAuthPolicy.new(
         :consumer_key => 'consumer_key',
         :consumer_secret => 'consumer_secret'
@@ -25,22 +25,22 @@ describe OAuthPolicy do
       policy.consumer_credential.secret.should eq('consumer_secret')
     end
 
-    it "is nil if none supplied to class" do
+    it 'is nil if none supplied to class' do
       OAuthPolicy.consumer_credential = nil
       policy = OAuthPolicy.new
       policy.consumer_credential.should be_nil
     end
   end
 
-  describe "#token" do
-    it "uses class setting if available" do
-      OAuthPolicy.token = OAuthCredential.new "xxx", "xxx"
+  describe '#token' do
+    it 'uses class setting if available' do
+      OAuthPolicy.token = OAuthCredential.new 'xxx', 'xxx'
       policy = OAuthPolicy.new
       policy.token.key.should eq('xxx')
       policy.token.secret.should eq('xxx')
     end
 
-    it "is built from given oauth_token and oauth_token_secret" do
+    it 'is built from given oauth_token and oauth_token_secret' do
       policy = OAuthPolicy.new(
         :oauth_token => 'oauth_token',
         :oauth_token_secret => 'oauth_token_secret'
@@ -49,91 +49,91 @@ describe OAuthPolicy do
       policy.token.secret.should eq('oauth_token_secret')
     end
 
-    it "is an empty token if no oauth credentials supplied" do
+    it 'is an empty token if no oauth credentials supplied' do
       policy = OAuthPolicy.new
       policy.token.should be_nil
     end
   end
 
-  context "2-legged" do
-    it "adds an authorization header" do
-      uri = Addressable::URI.parse("https://xxx/")
+  context '2-legged' do
+    it 'adds an authorization header' do
+      uri = Addressable::URI.parse('https://xxx/')
 
       request = Request.new :get, uri
 
-      OAuthPolicy.token = OAuthCredential.new "token", nil
+      OAuthPolicy.token = OAuthCredential.new 'token', nil
 
       authorized_request = OAuthPolicy.authorize request
 
-      authorized_request.headers.keys.should include "Authorization"
+      authorized_request.headers.keys.should include 'Authorization'
     end
 
-    it "preserves query parameters" do
-      uri = Addressable::URI.parse("https://xxx/?name=Riccardo")
+    it 'preserves query parameters' do
+      uri = Addressable::URI.parse('https://xxx/?name=Riccardo')
       request = Request.new :get, uri
 
-      Clock.stub(:timestamp).and_return "1327048592"
-      Nonce.stub(:next).and_return "b94ff2bf7f0a5e87a326064ae1dbb18f"
-      OAuthPolicy.consumer_credential = OAuthCredential.new "consumer_key", "consumer_secret"
-      OAuthPolicy.token               = OAuthCredential.new "token", nil
+      Clock.stub(:timestamp).and_return '1327048592'
+      Nonce.stub(:next).and_return 'b94ff2bf7f0a5e87a326064ae1dbb18f'
+      OAuthPolicy.consumer_credential = OAuthCredential.new 'consumer_key', 'consumer_secret'
+      OAuthPolicy.token               = OAuthCredential.new 'token', nil
 
       authorized_request = OAuthPolicy.authorize request
 
       the_query_parameters = Addressable::URI.parse(authorized_request.uri).query_values
-      the_query_parameters.should == {"name" => "Riccardo"}
+      the_query_parameters.should == {'name' => 'Riccardo'}
     end
 
-    it "adds the correct signature as part of authorization header" do
-      Clock.stub(:timestamp).and_return "1327048592"
-      Nonce.stub(:next).and_return "b94ff2bf7f0a5e87a326064ae1dbb18f"
+    it 'adds the correct signature as part of authorization header' do
+      Clock.stub(:timestamp).and_return '1327048592'
+      Nonce.stub(:next).and_return 'b94ff2bf7f0a5e87a326064ae1dbb18f'
 
-      OAuthPolicy.consumer_credential = OAuthCredential.new "consumer_key", "consumer_secret"
-      OAuthPolicy.token               = OAuthCredential.new "token", nil
+      OAuthPolicy.consumer_credential = OAuthCredential.new 'consumer_key', 'consumer_secret'
+      OAuthPolicy.token               = OAuthCredential.new 'token', nil
 
-      request = Request.new :get, Addressable::URI.parse("http://xxx/")
+      request = Request.new :get, Addressable::URI.parse('http://xxx/')
 
       authorized_request = OAuthPolicy.authorize request
 
-      authorized_request.headers["Authorization"].should =~ /oauth_signature="TVNk%2FCs03FHqutDUqn05%2FDkvVek%3D"/
+      authorized_request.headers['Authorization'].should =~ /oauth_signature="TVNk%2FCs03FHqutDUqn05%2FDkvVek%3D"/
     end
 
-    it "adds correct signature for uri with parameters" do
-      Clock.stub(:timestamp).and_return "1327351010"
-      Nonce.stub(:next).and_return "f5474aaf44ca84df0b09870044f91c69"
+    it 'adds correct signature for uri with parameters' do
+      Clock.stub(:timestamp).and_return '1327351010'
+      Nonce.stub(:next).and_return 'f5474aaf44ca84df0b09870044f91c69'
 
-      OAuthPolicy.consumer_credential = OAuthCredential.new "consumer_key", "consumer_secret"
-      OAuthPolicy.token               = OAuthCredential.new "token", nil
+      OAuthPolicy.consumer_credential = OAuthCredential.new 'consumer_key', 'consumer_secret'
+      OAuthPolicy.token               = OAuthCredential.new 'token', nil
 
-      request = Request.new :get, Addressable::URI.parse("http://xxx/?a=b")
+      request = Request.new :get, Addressable::URI.parse('http://xxx/?a=b')
 
       authorized_request = OAuthPolicy.authorize request
 
-      authorized_request.headers["Authorization"].should =~ /oauth_signature="DprU1bdbNdJQ40UhD4n7wRR9jts%3D"/
+      authorized_request.headers['Authorization'].should =~ /oauth_signature="DprU1bdbNdJQ40UhD4n7wRR9jts%3D"/
     end
 
-    it "fails if consumer_credential is unset" do
+    it 'fails if consumer_credential is unset' do
       OAuthPolicy.consumer_credential = nil
 
-      request = Request.new :get, Addressable::URI.parse("http://xxx/")
+      request = Request.new :get, Addressable::URI.parse('http://xxx/')
 
-      lambda{OAuthPolicy.authorize request}.should raise_error "The consumer_credential has not been supplied."
+      -> { OAuthPolicy.authorize request }.should raise_error 'The consumer_credential has not been supplied.'
     end
 
-    it "can sign with token" do
-      Clock.stub(:timestamp).and_return "1327360530"
-      Nonce.stub(:next).and_return "4f610cb28e7aa8711558de5234af1f0e"
+    it 'can sign with token' do
+      Clock.stub(:timestamp).and_return '1327360530'
+      Nonce.stub(:next).and_return '4f610cb28e7aa8711558de5234af1f0e'
 
-      OAuthPolicy.consumer_credential = OAuthCredential.new "consumer_key", "consumer_secret"
-      OAuthPolicy.token  = OAuthCredential.new "token_key", "token_secret"
+      OAuthPolicy.consumer_credential = OAuthCredential.new 'consumer_key', 'consumer_secret'
+      OAuthPolicy.token  = OAuthCredential.new 'token_key', 'token_secret'
 
-      request = Request.new :get, Addressable::URI.parse("http://xxx/")
+      request = Request.new :get, Addressable::URI.parse('http://xxx/')
 
       authorized_request = OAuthPolicy.authorize request
 
-      authorized_request.headers["Authorization"].should =~ /oauth_signature="1Boj4fo6KiXA4xGD%2BKF5QOD36PI%3D"/
+      authorized_request.headers['Authorization'].should =~ /oauth_signature="1Boj4fo6KiXA4xGD%2BKF5QOD36PI%3D"/
     end
 
-    it "adds correct signature for https uri"
-    it "adds correct signature for verbs other than get"
+    it 'adds correct signature for https uri'
+    it 'adds correct signature for verbs other than get'
   end
 end