ruby-trello 2.2.0 → 3.1.0

data/spec/label_spec.rb

@@ -20,7 +20,7 @@ module Trello
       it "delegates to Trello.client#find" do
         expect(client)
           .to receive(:find)
-          .with(:label, 'abcdef123456789123456789', {})
+          .with('label', 'abcdef123456789123456789', {})
 
         Label.find('abcdef123456789123456789')
       end
@@ -43,7 +43,6 @@ module Trello
         expect(label.color).to    eq details['color']
         expect(label.name).to     eq details['name']
         expect(label.id).to       eq details['id']
-        expect(label.uses).to     eq details['uses']
         expect(label.board_id).to eq details['idBoard']
       end
 
@@ -71,14 +70,16 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idBoard: boards_details.first['id'])))
 
-        expected_payload = {name: "Test Label", color: nil, idBoard: "abcdef123456789123456789" }
+        expected_payload = {'name' => 'Test Label', 'color' => 'yellow', 'idBoard' => 'abcdef123456789123456789' }
 
-        expect(client)
+        expect(Label.client)
           .to receive(:post)
-          .with("/labels", expected_payload)
+          .with('/labels', expected_payload)
           .and_return result
 
-        label = Label.create(label_details.first.merge(payload.merge(board_id: boards_details.first['id'])))
+        params = label_details.first.merge(payload.merge(board_id: boards_details.first['id']))
+        params.delete('id')
+        label = Label.create params
 
         expect(label).to be_a Label
       end
@@ -89,13 +90,19 @@ module Trello
         expected_new_name = "xxx"
 
         payload = {
-          name: expected_new_name,
+          'name' => expected_new_name,
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with("/labels/abcdef123456789123456789", payload)
+          .and_return({
+            "id" => "abcdef123456789123456789",
+            "idBoard" => "5e70f5bed3f34a49e2f11409",
+            "name" => "xxx",
+            "color" => "purple"
+          }.to_json)
 
         label.name = expected_new_name
         label.save
@@ -105,13 +112,19 @@ module Trello
         expected_new_color = "purple"
 
         payload = {
-          color: expected_new_color,
+          'color' => expected_new_color
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with("/labels/abcdef123456789123456789", payload)
+          .and_return({
+            "id" => "abcdef123456789123456789",
+            "idBoard" => "5e70f5bed3f34a49e2f11409",
+            "name" => "",
+            "color" => "purple"
+          }.to_json)
 
         label.color = expected_new_color
         label.save
@@ -121,26 +134,19 @@ module Trello
         %w(green yellow orange red purple blue sky lime pink black).each do |color|
           allow(client)
             .to receive(:put)
-            .with("/labels/abcdef123456789123456789", {color: color})
-            .and_return "not important"
+            .with("/labels/abcdef123456789123456789", {'color' => color})
+            .and_return({
+              "id" => "abcdef123456789123456789",
+              "idBoard" => "5e70f5bed3f34a49e2f11409",
+              "name" => "",
+              "color" => color
+            }.to_json)
 
           label.color = color
           label.save
           expect(label.errors).to be_empty
         end
       end
-
-      it "throws an error when trying to update a label with an unknown colour" do
-        allow(client)
-          .to receive(:put)
-          .with("/labels/abcdef123456789123456789", {})
-          .and_return "not important"
-
-        label.color = 'mauve'
-        label.save
-
-        expect(label.errors.full_messages.to_sentence).to eq("Label color 'mauve' does not exist")
-      end
     end
 
     context "deleting" do
@@ -162,10 +168,6 @@ module Trello
         expect(label.name).to_not be_nil
       end
 
-      it "gets its usage" do
-        expect(label.uses).to_not be_nil
-      end
-
       it "gets its color" do
         expect(label.color).to_not be_nil
       end
@@ -188,8 +190,7 @@ module Trello
           'id' => 'id',
           'name' => 'name',
           'color' => 'color',
-          'idBoard' => 'board_id',
-          'uses' => 'uses'
+          'idBoard' => 'board_id'
         }
 
         label = Label.new(expected)
@@ -201,5 +202,81 @@ module Trello
         end
       end
     end
+
+    describe '#update_fields' do
+      let(:label_detail) {{
+        'id' => 'id',
+        'name' => 'name',
+        'color' => 'color',
+        'idBoard' => 'board_id'
+      }}
+      let(:label) { Label.new(label_detail) }
+
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
+
+        it 'card does not set any fields' do
+          label.update_fields(fields)
+
+          expect(label.id).to eq label_detail['id']
+          expect(label.name).to eq label_detail['name']
+          expect(label.color).to eq label_detail['color']
+          expect(label.board_id).to eq label_detail['idBoard']
+        end
+      end
+
+      context 'when the fields argument has at least one field' do
+        context 'and the field does changed' do
+          let(:fields) { { name: 'Awesome Name' } }
+
+          it 'label does set the changed fields' do
+            label.update_fields(fields)
+
+            expect(label.name).to eq('Awesome Name')
+          end
+
+          it 'label has been mark as changed' do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { name: label_detail['name'] } }
+
+          it "label attributes doesn't changed" do
+            label.update_fields(fields)
+
+            expect(label.name).to eq(label_detail['name'])
+          end
+
+          it "label hasn't been mark as changed" do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_falsy
+          end
+        end
+
+        context "and the field isn't a correct attributes of the label" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "label attributes doesn't changed" do
+            label.update_fields(fields)
+
+            expect(label.id).to eq label_detail['id']
+            expect(label.name).to eq label_detail['name']
+            expect(label.color).to eq label_detail['color']
+            expect(label.board_id).to eq label_detail['idBoard']
+          end
+
+          it "label hasn't been mark as changed" do
+            label.update_fields(fields)
+
+            expect(label.changed?).to be_falsy
+          end
+        end
+      end
+    end
   end
 end

data/spec/list_spec.rb

@@ -84,11 +84,10 @@ module Trello
         result = JSON.generate(payload)
 
         expected_payload = {
-          name: 'Test List',
-          closed: false,
-          idBoard: 'abcdef123456789123456789',
-          pos: 42,
-          idListSource: 'abcdef123456789'
+          'name' => 'Test List',
+          'pos' => 42,
+          'idBoard' => 'abcdef123456789123456789',
+          'idListSource' => 'abcdef123456789'
         }
 
         expect(client)
@@ -105,15 +104,14 @@ module Trello
         expected_new_name = 'xxx'
 
         payload = {
-          name: expected_new_name,
-          closed: false,
-          pos: list.pos
+          'name' => expected_new_name
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with('/lists/abcdef123456789123456789', payload)
+          .and_return({}.to_s)
 
         list.name = expected_new_name
         list.save
@@ -122,15 +120,14 @@ module Trello
       it 'updates position' do
         new_position = 42
         payload = {
-          name: list.name,
-          closed: list.closed,
-          pos: new_position
+          'pos' => new_position
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with('/lists/abcdef123456789123456789', payload)
+          .and_return({}.to_s)
 
         list.pos = new_position
         list.save
@@ -220,10 +217,9 @@ module Trello
           .to receive(:put)
           .once
           .with('/lists/abcdef123456789123456789', {
-            name: list.name,
-            closed: true,
-            pos: list.pos
+            'closed' => true
           })
+          .and_return({}.to_s)
 
         list.close!
       end
@@ -249,5 +245,27 @@ module Trello
         end
       end
     end
+
+    describe '#move_to_board' do
+      let(:board) { Trello::Board.new(id: 'someid') }
+      context 'given the destination board parameter is a Trello::Board instance' do
+        it 'moves to the destination board' do
+          expect(client)
+            .to receive(:put)
+            .with("/lists/#{list.id}/idBoard", value: 'someid')
+
+          list.move_to_board(board)
+        end
+      end
+      context 'given the destination board parameter is an id string' do
+        it 'moves to the destination board' do
+          expect(client)
+            .to receive(:put)
+            .with("/lists/#{list.id}/idBoard", value: 'someid')
+
+          list.move_to_board(board.id)
+        end
+      end
+    end
   end
 end

data/spec/notification_spec.rb

@@ -82,7 +82,7 @@ module Trello
           .with("/members/#{user_details['id']}", {})
           .and_return user_payload
 
-        expect(notification.member_creator.id).to eq user_details['id']
+        expect(notification.creator.id).to eq user_details['id']
       end
     end
 
@@ -115,7 +115,7 @@ module Trello
       end
 
       it "gets the member creator id" do
-        expect(notification.member_creator_id).to eq notification_details['idMemberCreator']
+        expect(notification.creator_id).to eq notification_details['idMemberCreator']
       end
     end
 
@@ -127,7 +127,7 @@ module Trello
           'type' => 'type',
           'date' => 'date',
           'data' => 'data',
-          'idMemberCreator' => 'member_creator_id'
+          'idMemberCreator' => 'creator_id'
         }
 
         notification = Notification.new(expected)

data/spec/organization_spec.rb

@@ -47,14 +47,15 @@ module Trello
           'id' => 'id',
           'name' => 'name',
           'displayName' => 'display_name',
+          'descData' => 'desc_data',
+          'website' => 'website',
+          'teamType' => 'team_type',
           'desc' => 'description',
           'url' => 'url',
-          'invited' => 'invited',
-          'website' => 'website',
           'logoHash' => 'logo_hash',
-          'billableMemberCount' => 'billable_member_count',
-          'activeBillableMemberCount' => 'active_billable_member_count',
-          'memberships' => 'memberships'
+          'logoUrl' => 'logo_url',
+          'products' => 'products',
+          'powerUps' => 'power_ups'
         }
 
         organization = Organization.new(expected)

data/spec/spec_helper.rb

@@ -1,36 +1,47 @@
-require 'rubygems'
+require 'bundler/setup'
+require 'dotenv/load'
+require 'trello'
+require 'webmock/rspec'
+require 'stringio'
+require 'vcr'
 
-unless defined? Rubinius
-  require 'simplecov'
-  SimpleCov.start
-end
+require 'pry-byebug' if RUBY_ENGINE != 'jruby'
 
-begin
-  require 'pry-byebug'
-rescue LoadError
-end
+VCR.configure do |config|
+  config.default_cassette_options = { match_requests_on: %i[uri method body] }
+  config.cassette_library_dir = 'spec/cassettes'
+  config.hook_into :webmock
 
-# Set up gems listed in the Gemfile.
-begin
-  ENV['BUNDLE_GEMFILE'] = File.expand_path('../Gemfile', File.dirname(__FILE__))
-  require 'bundler'
-  Bundler.setup
-rescue Bundler::GemNotFound => e
-  STDERR.puts e.message
-  STDERR.puts 'Try running `bundle install`.'
-  exit!
-end
+  config.filter_sensitive_data('DEVELOPER_PUBLIC_KEY') do |interaction|
+    CGI.parse(URI.parse(interaction.request.uri).query)['key'].first
+  end
+  config.filter_sensitive_data('MEMBER_TOKEN') do |interaction|
+    CGI.parse(URI.parse(interaction.request.uri).query)['token'].first
+  end
+  config.filter_sensitive_data('set_cookie_dsc') do |interaction|
+    set_cookie_headers = interaction.response.headers['Set-Cookie']
 
-Bundler.require(:spec)
+    if set_cookie_headers
+      set_cookie_headers.first.scan(/dsc=(\w+)/).flatten.first
+    end
+  end
 
-require 'trello'
-require 'webmock/rspec'
-require 'stringio'
+  uri_without_credentials_matcher = lambda do |match_request, coming_request|
+    without_public_key = -> (uri) { uri.sub(/key=\w+/, 'key=DEVELOPER_PUBLIC_KEY') }
+    without_member_token = -> (uri) { uri.sub(/token=\w+/, 'token=MEMBER_TOKEN') }
+    without_credentials = -> (request) { without_public_key.call(without_member_token.call(request.uri)) }
+
+    without_credentials.call(match_request) == without_credentials.call(coming_request)
+  end
+
+  config.default_cassette_options[:match_requests_on] = [:method, uri_without_credentials_matcher]
+end
 
 Trello.logger = Logger.new(StringIO.new)
 
 RSpec.configure do |rspec|
   rspec.filter_run_excluding broken: true
+  rspec.filter_run_when_matching focus: true
 
   rspec.before :each do
     Trello.reset!
@@ -42,6 +53,41 @@ RSpec.configure do |rspec|
     example.run
     $VERBOSE = verbose
   end
+
+  rspec.failure_color = :magenta
+  rspec.tty = true
+  rspec.color = true
+end
+
+RSpec::Expectations.configuration.on_potential_false_positives = :nothing
+
+module IntegrationHelpers
+  def setup_trello
+    Trello.configure do |config|
+      config.developer_public_key = ENV['TRELLO_DEVELOPER_PUBLIC_KEY'] || 'developerpublickey'
+      config.member_token = ENV['TRELLO_MEMBER_TOKEN'] || 'membertoken'
+    end
+  end
+end
+
+RSpec::Matchers.define :match_hash_with_indifferent_access do |expected|
+  match do |actual|
+    actual.with_indifferent_access == expected.with_indifferent_access
+  end
+
+  failure_message do |actual|
+    <<~EOF
+    expected: #{expected}
+         got: #{actual}
+    EOF
+  end
+
+  failure_message_when_negated do |actual|
+    <<~EOF
+    expected: value != #{expected}
+         got:          #{actual}
+    EOF
+  end
 end
 
 module Helpers
@@ -319,20 +365,7 @@ module Helpers
     {
         'id' => '4ee7e59ae582acdec8000291',
         'name' => 'publicorg',
-        'desc' => 'This is a test organization',
-        'members' => [{
-            'id' => '4ee7df3ce582acdec80000b2',
-            'username' => 'alicetester',
-            'fullName' => 'Alice Tester'
-        }, {
-            'id' => '4ee7df74e582acdec80000b6',
-            'username' => 'davidtester',
-            'fullName' => 'David Tester'
-        }, {
-            'id' => '4ee7e2e1e582acdec8000112',
-            'username' => 'edtester',
-            'fullName' => 'Ed Tester'
-        }]
+        'desc' => 'This is a test organization'
     }
   end
 

data/spec/token_spec.rb

@@ -69,20 +69,19 @@ module Trello
 
     describe "#update_fields" do
       it "does not set any fields when the fields argument is empty" do
-        expected = {
-          'id' => 'id',
-          'idMember' => 'member_id',
-          'permissions' => 'permissions',
-          'webhooks' => 'webhooks'
-        }
-
-        token = Token.new(expected)
+        token = Token.new({
+          'id' => 'aaa',
+          'idMember' => 'ccc',
+          'permissions' => {},
+          'webhooks' => []
+        })
 
         token.update_fields({})
 
-        expected.each do |key, value|
-          expect(token.send(value)).to eq expected[key]
-        end
+        expect(token.id).to eq('aaa')
+        expect(token.member_id).to eq('ccc')
+        expect(token.permissions).to eq({})
+        expect(token.webhooks).to eq([])
       end
     end
   end

data/spec/unit/trello/association_builder/has_many_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationBuilder::HasMany do
+
+  describe '.build' do
+    around do |example|
+      class FakeBoard; end
+
+      example.run
+
+      Object.send(:remove_const, 'FakeBoard')
+    end
+
+    it 'build has many finder method' do
+      Trello::AssociationBuilder::HasMany.build(FakeBoard, 'boards', {})
+
+      expect(FakeBoard.new.respond_to?(:boards)).to eq(true)
+    end
+
+    it 'the finder method return result from Trello::AssociationFetcher' do
+      fake_board = FakeBoard.new
+      has_many_fetcher = instance_double(Trello::AssociationFetcher::HasMany)
+      allow(Trello::AssociationFetcher::HasMany)
+        .to receive(:new)
+        .with(fake_board, 'boards', {})
+        .and_return(has_many_fetcher)
+
+      result = double('result')
+      allow(has_many_fetcher).to receive(:fetch).with(a: 1, b: 2).and_return(result)
+
+      Trello::AssociationBuilder::HasMany.build(FakeBoard, 'boards', {})
+      expect(fake_board.boards(a: 1, b: 2)).to eq(result)
+    end
+  end
+
+end

data/spec/unit/trello/association_builder/has_one_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationBuilder::HasOne do
+
+  describe '.build' do
+    around do |example|
+      class FakeBoard; end
+
+      example.run
+
+      Object.send(:remove_const, 'FakeBoard')
+    end
+
+    it 'build has one finder method' do
+      Trello::AssociationBuilder::HasOne.build(FakeBoard, 'organization', {})
+
+      expect(FakeBoard.new.respond_to?(:organization)).to eq(true)
+    end
+
+    it 'the finder method return result from Trello::AssociationFetcher' do
+      fake_board = FakeBoard.new
+      has_one_fetcher = instance_double(Trello::AssociationFetcher::HasOne)
+      allow(Trello::AssociationFetcher::HasOne)
+        .to receive(:new)
+        .with(fake_board, 'organization', {})
+        .and_return(has_one_fetcher)
+
+      result = double('result')
+      allow(has_one_fetcher).to receive(:fetch).and_return(result)
+
+      Trello::AssociationBuilder::HasOne.build(FakeBoard, 'organization', {})
+      expect(fake_board.organization).to eq(result)
+    end
+  end
+
+end

data/spec/unit/trello/association_fetcher/has_many/fetch_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe Trello::AssociationFetcher::HasMany::Fetch do
+
+  describe '.execute' do
+    let(:client) { instance_double(Trello::Client) }
+    let(:association_class) { double('Association Class') }
+    let(:association_owner) { double('association_owner', client: client) }
+    let(:fetch_path) { '/test' }
+    let(:filter_params) { { a: 1 } }
+    let(:resources) { double('resources') }
+    let(:result) { double('result') }
+
+    let(:params) { instance_double('params',
+      association_class: association_class,
+      association_owner: association_owner,
+      fetch_path: fetch_path,
+      filter_params: filter_params
+    ) }
+
+    before do
+      allow(Trello).to receive(:client).and_return(client)
+      allow(client)
+        .to receive(:find_many)
+        .with(association_class, fetch_path, filter_params)
+        .and_return(resources)
+      allow(Trello::MultiAssociation)
+        .to receive(:new)
+        .with(association_owner, resources)
+        .and_return(double('multi-association', proxy: result))
+    end
+
+    it 'return the result from Trello.client and MultiAssociation' do
+      expect(Trello::AssociationFetcher::HasMany::Fetch.execute(params)).to eq(result)
+    end
+  end
+
+end