ruby-trello 1.2.1 → 1.3.0

data/spec/organization_spec.rb

@@ -1,4 +1,3 @@
-
 require 'spec_helper'
 
 module Trello
@@ -8,28 +7,37 @@ module Trello
     let(:organization) { client.find(:organization, '4ee7e59ae582acdec8000291') }
     let(:client) { Client.new }
 
-    before(:each) do
-      client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291', {}).
-        and_return organization_payload
+    before do
+      allow(client)
+        .to receive(:get)
+        .with('/organizations/4ee7e59ae582acdec8000291', {})
+        .and_return organization_payload
     end
 
     context 'finding' do
       let(:client) { Trello.client }
 
       it 'delegates to Trello.client#find' do
-        client.should_receive(:find).with(:organization, '4ee7e59ae582acdec8000291', {})
+        expect(client)
+          .to receive(:find)
+          .with(:organization, '4ee7e59ae582acdec8000291', {})
+
         Organization.find('4ee7e59ae582acdec8000291')
       end
 
       it 'is equivalent to client#find' do
-        Organization.find('4ee7e59ae582acdec8000291').should eq(organization)
+        expect(Organization.find('4ee7e59ae582acdec8000291')).to eq(organization)
       end
     end
 
     context 'actions' do
       it 'retrieves actions' do
-        client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291/actions', { filter: :all }).and_return actions_payload
-        organization.actions.count.should be > 0
+        allow(client)
+          .to receive(:get)
+          .with('/organizations/4ee7e59ae582acdec8000291/actions', { filter: :all })
+          .and_return actions_payload
+
+        expect(organization.actions.count).to be > 0
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,9 +1,15 @@
 require 'rubygems'
+
 unless defined? Rubinius
   require 'simplecov'
   SimpleCov.start
 end
 
+begin
+  require 'pry-byebug'
+rescue LoadError
+end
+
 # Set up gems listed in the Gemfile.
 begin
   ENV['BUNDLE_GEMFILE'] = File.expand_path('../Gemfile', File.dirname(__FILE__))
@@ -23,10 +29,10 @@ require 'stringio'
 
 Trello.logger = Logger.new(StringIO.new)
 
-RSpec.configure do |c|
-  c.filter_run_excluding broken: true
+RSpec.configure do |rspec|
+  rspec.filter_run_excluding broken: true
 
-  c.before :each do
+  rspec.before :each do
     Trello.reset!
   end
 end
@@ -84,6 +90,25 @@ module Helpers
     JSON.generate(checklists_details)
   end
 
+  def copied_checklists_details
+    [{
+      'id'         => 'uvwxyz987654321987654321',
+      'name'       => 'Test Checklist',
+      'desc'       => '',
+      'closed'     => nil,
+      'position'   => 99999,
+      'url'        => nil,
+      'idBoard'    => 'abcdef123456789123456789',
+      'idList'     => nil,
+      'idMembers'  => nil,
+      'checkItems' => []
+    }]
+  end
+
+  def copied_checklists_payload
+    JSON.generate(copied_checklists_details)
+  end
+
   def lists_details
     [{
       'id'      => 'abcdef123456789123456789',

data/spec/string_spec.rb

@@ -16,14 +16,17 @@ describe String, '#json_into' do
   end
 
   it 'converts json into an instance of a class' do
-    '{}'.json_into(example_class).should be_an_instance_of example_class
+    expect('{}'.json_into(example_class)).to be_a example_class
   end
 
   it 'supplies the parsed json to the class ctor as a hash' do
-    example_class.should_receive(:new).once.with({
-      "name"        => "Jazz Kang",
-      "description" => "Plonker"
-    })
+    expect(example_class)
+      .to receive(:new)
+      .once
+      .with({
+        "name"        => "Jazz Kang",
+        "description" => "Plonker"
+      })
 
     json_text = '{"name" : "Jazz Kang", "description": "Plonker"}'
 
@@ -40,10 +43,10 @@ describe String, '#json_into' do
 
     result = json_text.json_into example_class
 
-    result.should be_an Array
-    result.size.should == 2
+    expect(result).to be_an Array
+    expect(result.size).to eq 2
     result.each do |parsed|
-      parsed.should be_an_instance_of example_class
+      expect(parsed).to be_a example_class
     end
   end
 end

data/spec/token_spec.rb

@@ -7,43 +7,63 @@ module Trello
     let(:token) { client.find(:token, '1234') }
     let(:client) { Client.new }
 
-    before(:each) do
-      client.stub(:get).with('/tokens/1234', {}).and_return token_payload
+    before do
+      allow(client)
+        .to receive(:get)
+        .with('/tokens/1234', {})
+        .and_return token_payload
     end
 
     context 'finding' do
       let(:client) { Trello.client }
 
       it 'delegates to Trello.client#find' do
-        client.should_receive(:find).with(:token, '1234', {webhooks: true})
+        expect(client)
+          .to receive(:find)
+          .with(:token, '1234', {webhooks: true})
+
         Token.find('1234')
       end
 
       it 'is equivalent to client#find' do
-        Token.find('1234', {}).should eq(token)
+        expect(Token.find('1234', {})).to eq(token)
       end
     end
 
     context 'attributes' do
       it 'has an id' do
-        token.id.should == '4f2c10c7b3eb95a45b294cd5'
+        expect(token.id).to eq '4f2c10c7b3eb95a45b294cd5'
       end
 
       it 'gets its created_at date' do
-        token.created_at.should == Time.iso8601('2012-02-03T16:52:23.661Z')
+        expect(token.created_at).to eq Time.iso8601('2012-02-03T16:52:23.661Z')
       end
 
       it 'has a permission grant' do
-        token.permissions.count.should be 3
+        expect(token.permissions.count).to eq 3
       end
     end
 
     context 'members' do
+      before do
+        allow(client)
+          .to receive(:get)
+          .with('/members/abcdef123456789123456789', {})
+          .and_return user_payload
+
+        allow(Trello.client)
+          .to receive(:get)
+          .with('/members/abcdef123456789123456789', {})
+          .and_return user_payload
+
+        allow(client)
+          .to receive(:get)
+          .with('/tokens/1234', {})
+          .and_return token_payload
+      end
+
       it 'retrieves the member who authorized the token' do
-        client.stub(:get).with('/members/abcdef123456789123456789', {}).and_return user_payload
-        Trello.client.stub(:get).with('/members/abcdef123456789123456789', {}).and_return user_payload
-        client.stub(:get).with('/tokens/1234', {}).and_return token_payload
-        token.member.should == Member.find('abcdef123456789123456789')
+        expect(token.member).to eq Member.find('abcdef123456789123456789')
       end
     end
   end

data/spec/trello_spec.rb

@@ -6,27 +6,24 @@ include Trello::Authorization
 describe Trello do
 
   describe 'self.configure' do
-    it 'builds auth policy client uses to make requests' do
+    before do
       Trello.configure do |config|
         config.developer_public_key = 'developer_public_key'
         config.member_token         = 'member_token'
       end
+    end
 
-      TInternet.stub(:execute)
-      Trello.auth_policy.should_receive(:authorize)
+    it 'builds auth policy client uses to make requests' do
+      allow(TInternet).to receive(:execute)
+      expect(Trello.auth_policy).to receive(:authorize)
       Trello.client.get(:member, params = {})
     end
 
     it 'configures basic auth policy' do
-      Trello.configure do |config|
-        config.developer_public_key = 'developer_public_key'
-        config.member_token         = 'member_token'
-      end
-
       auth_policy = Trello.auth_policy
-      auth_policy.should be_a(BasicAuthPolicy)
-      auth_policy.developer_public_key.should eq('developer_public_key')
-      auth_policy.member_token.should eq('member_token')
+      expect(auth_policy).to be_a(BasicAuthPolicy)
+      expect(auth_policy.developer_public_key).to eq('developer_public_key')
+      expect(auth_policy.member_token).to eq('member_token')
     end
 
     context 'oauth' do
@@ -42,16 +39,16 @@ describe Trello do
       it 'configures oauth policy' do
         auth_policy = Trello.auth_policy
 
-        auth_policy.should be_a(OAuthPolicy)
-        auth_policy.consumer_key.should eq('consumer_key')
-        auth_policy.consumer_secret.should eq('consumer_secret')
-        auth_policy.oauth_token.should eq('oauth_token')
-        auth_policy.oauth_token_secret.should eq('oauth_token_secret')
+        expect(auth_policy).to be_a(OAuthPolicy)
+        expect(auth_policy.consumer_key).to eq('consumer_key')
+        expect(auth_policy.consumer_secret).to eq('consumer_secret')
+        expect(auth_policy.oauth_token).to eq('oauth_token')
+        expect(auth_policy.oauth_token_secret).to eq('oauth_token_secret')
       end
 
       it 'updates auth policy configuration' do
         auth_policy = Trello.auth_policy
-        auth_policy.consumer_key.should eq('consumer_key')
+        expect(auth_policy.consumer_key).to eq('consumer_key')
 
         Trello.configure do |config|
           config.consumer_key     = 'new_consumer_key'
@@ -62,11 +59,11 @@ describe Trello do
 
         auth_policy = Trello.auth_policy
 
-        auth_policy.should be_a(OAuthPolicy)
-        auth_policy.consumer_key.should eq('new_consumer_key')
-        auth_policy.consumer_secret.should eq('new_consumer_secret')
-        auth_policy.oauth_token.should eq('new_oauth_token')
-        auth_policy.oauth_token_secret.should be_nil
+        expect(auth_policy).to be_a(OAuthPolicy)
+        expect(auth_policy.consumer_key).to eq('new_consumer_key')
+        expect(auth_policy.consumer_secret).to eq('new_consumer_secret')
+        expect(auth_policy.oauth_token).to eq('new_oauth_token')
+        expect(auth_policy.oauth_token_secret).to be_nil
       end
     end
 
@@ -75,7 +72,7 @@ describe Trello do
         Trello.configure
       end
 
-      it { Trello.auth_policy.should be_a(AuthPolicy) }
+      it { expect(Trello.auth_policy).to be_a(AuthPolicy) }
       it { expect { Trello.client.get(:member) }.to raise_error(Trello::ConfigurationError) }
     end
 

data/spec/webhook_spec.rb

@@ -8,19 +8,25 @@ module Trello
     let(:client) { Client.new }
 
     before(:each) do
-      client.stub(:get).with("/webhooks/1234", {}).and_return webhook_payload
+      allow(client)
+        .to receive(:get)
+        .with("/webhooks/1234", {})
+        .and_return webhook_payload
     end
 
     context "finding" do
       let(:client) { Trello.client }
 
       it "delegates to Trello.client#find" do
-        client.should_receive(:find).with(:webhook, '1234', {})
+        expect(client)
+          .to receive(:find)
+          .with(:webhook, '1234', {})
+
         Webhook.find('1234')
       end
 
       it "is equivalent to client#find" do
-        Webhook.find('1234').should eq(webhook)
+        expect(Webhook.find('1234')).to eq(webhook)
       end
     end
 
@@ -29,7 +35,7 @@ module Trello
 
       it "creates a new webhook" do
         webhook = Webhook.new(webhooks_details.first)
-        webhook.should be_valid
+        expect(webhook).to be_valid
       end
 
       it 'creates a new webhook and saves it on Trello', refactor: true do
@@ -40,11 +46,14 @@ module Trello
 
         expected_payload = {description: webhook[:description], idModel: webhook[:idModel], callbackURL: webhook[:callbackURL]}
 
-        client.should_receive(:post).with("/webhooks", expected_payload).and_return result
+        expect(client)
+          .to receive(:post)
+          .with("/webhooks", expected_payload)
+          .and_return result
 
         webhook = Webhook.create(webhooks_details.first)
 
-        webhook.class.should be Webhook
+        expect(webhook.class).to be Webhook
       end
     end
 
@@ -54,7 +63,10 @@ module Trello
 
         expected_payload = {description: expected_new_description, idModel: webhook.id_model, callbackURL: webhook.callback_url, active: webhook.active}
 
-        client.should_receive(:put).once.with("/webhooks/#{webhook.id}", expected_payload)
+        expect(client)
+          .to receive(:put)
+          .once
+          .with("/webhooks/#{webhook.id}", expected_payload)
 
         webhook.description = expected_new_description
         webhook.save
@@ -63,14 +75,17 @@ module Trello
 
     context "deleting" do
       it "deletes the webhook" do
-        client.should_receive(:delete).with("/webhooks/#{webhook.id}")
+        expect(client)
+          .to receive(:delete)
+          .with("/webhooks/#{webhook.id}")
+
         webhook.delete
       end
     end
 
     context "activated?" do
       it "returns the active attribute" do
-        expect(webhook.activated?).to be(true)
+        expect(webhook).to be_activated
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-trello
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Jeremy Tregunna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-24 00:00:00.000000000 Z
+date: 2015-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.2
+        version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.7.2
+        version: 1.8.0
 description: A wrapper around the trello.com API.
 email: jeremy@tregunna.ca
 executables: []
@@ -131,7 +131,6 @@ files:
 - spec/integration/how_to_use_boards_spec.rb
 - spec/integration/integration_test.rb
 - spec/item_spec.rb
-- spec/item_state_spec.rb
 - spec/label_spec.rb
 - spec/list_spec.rb
 - spec/member_spec.rb
@@ -183,7 +182,6 @@ test_files:
 - spec/integration/how_to_use_boards_spec.rb
 - spec/integration/integration_test.rb
 - spec/item_spec.rb
-- spec/item_state_spec.rb
 - spec/label_spec.rb
 - spec/list_spec.rb
 - spec/member_spec.rb