ruby-trello 0.4.4.3 → 0.5.0

data/spec/configuration_spec.rb

@@ -0,0 +1,114 @@
+require "spec_helper"
+
+describe Trello::Configuration do
+  let(:configuration) { Trello::Configuration.new }
+
+  it "has a consumer_key attribute" do
+    configuration.consumer_key = 'consumer_key'
+    configuration.consumer_key.should eq('consumer_key')
+  end
+
+  it "has a consumer_secret attribute" do
+    configuration.consumer_secret = 'consumer_secret'
+    configuration.consumer_secret.should eq('consumer_secret')
+  end
+
+  it "has a oauth_token attribute" do
+    configuration.oauth_token = 'oauth_token'
+    configuration.oauth_token.should eq('oauth_token')
+  end
+
+  it "has a oauth_token_secret attribute" do
+    configuration.oauth_token_secret = 'oauth_token_secret'
+    configuration.oauth_token_secret.should eq('oauth_token_secret')
+  end
+
+  it "has a developer public key attribute" do
+    configuration.developer_public_key = 'developer_public_key'
+    configuration.developer_public_key.should eq('developer_public_key')
+  end
+
+  it "has a member token attribute" do
+    configuration.member_token = 'member_token'
+    configuration.member_token.should eq('member_token')
+  end
+
+  it "has a callback (for oauth)" do
+    callback = lambda { 'foobar' }
+    configuration.callback = callback
+    configuration.callback.call.should eq('foobar')
+  end
+
+  it "has a return_url" do
+    configuration.return_url = "http://www.example.com/callback"
+    configuration.return_url.should eq("http://www.example.com/callback")
+  end
+
+  describe "initialize" do
+    it "sets key attributes provided as a hash" do
+      configuration = Trello::Configuration.new(
+        :consumer_key => 'consumer_key',
+        :consumer_secret => 'consumer_secret',
+        :oauth_token => 'oauth_token',
+        :oauth_token_secret => 'oauth_token_secret'
+      )
+      configuration.consumer_key.should eq('consumer_key')
+      configuration.consumer_secret.should eq('consumer_secret')
+      configuration.oauth_token.should eq('oauth_token')
+      configuration.oauth_token_secret.should eq('oauth_token_secret')
+    end
+  end
+
+  describe "#credentials" do
+    let(:configuration) { Trello::Configuration.new(attributes) }
+
+    it "returns an empty if no attributes specified" do
+      Trello::Configuration.new({}).credentials.should eq({})
+    end
+
+    it "returns an empty if attributes incomplete" do
+      Trello::Configuration.new(:consumer_key => 'consumer_key').credentials.should eq({})
+    end
+
+    it 'returns a hash of oauth attributes' do
+      configuration = Trello::Configuration.new(
+        :consumer_key => 'consumer_key',
+        :consumer_secret => 'consumer_secret',
+        :oauth_token => 'oauth_token',
+        :oauth_token_secret => 'oauth_token_secret'
+      )
+      configuration.credentials.should eq(
+        :consumer_key => 'consumer_key',
+        :consumer_secret => 'consumer_secret',
+        :oauth_token => 'oauth_token',
+        :oauth_token_secret => 'oauth_token_secret'
+      )
+    end
+
+    it 'includes callback and return url if given' do
+      configuration = Trello::Configuration.new(
+        :consumer_key => 'consumer_key',
+        :consumer_secret => 'consumer_secret',
+        :return_url => 'http://example.com',
+        :callback => 'callback'
+      )
+      configuration.credentials.should eq(
+        :consumer_key => 'consumer_key',
+        :consumer_secret => 'consumer_secret',
+        :return_url => 'http://example.com',
+        :callback => 'callback'
+      )
+    end
+
+    it "returns a hash of basic auth policy attributes" do
+      configuration = Trello::Configuration.new(
+        :developer_public_key => 'developer_public_key',
+        :member_token => 'member_token'
+      )
+      configuration.credentials.should eq(
+        :developer_public_key => 'developer_public_key',
+        :member_token => 'member_token'
+      )
+    end
+  end
+end

data/spec/integration/how_to_authorize_spec.rb

@@ -45,7 +45,7 @@ describe "OAuth", :broken => true do
   it "[!] actually does not enforce signature at all, only the keys are required" do
     OAuthPolicy.consumer_credential = OAuthCredential.new @developer_public_key, nil
     OAuthPolicy.token = OAuthCredential.new @access_token_key, nil
-    
+
     pending "I would expect this to fail because I have signed with nil secrets" do
       lambda{Client.get("/boards/#{@welcome_board}/")}.should raise_error
     end

data/spec/list_spec.rb

@@ -4,11 +4,61 @@ module Trello
   describe List do
     include Helpers
 
+    let(:list) { client.find(:list, "abcdef123456789123456789") }
+    let(:client) { Client.new }
+
     before(:each) do
-      Client.stub(:get).with("/lists/abcdef123456789123456789").and_return JSON.generate(lists_details.first)
-      Client.stub(:get).with("/boards/abcdef123456789123456789").and_return JSON.generate(boards_details.first)
+      client.stub(:get).with("/lists/abcdef123456789123456789").and_return JSON.generate(lists_details.first)
+      client.stub(:get).with("/boards/abcdef123456789123456789").and_return JSON.generate(boards_details.first)
+    end
 
-      @list = List.find("abcdef123456789123456789")
+    context "finding" do
+      let(:client) { Trello.client }
+
+      it "delegates to client#find" do
+        client.should_receive(:find).with(:list, 'abcdef123456789123456789')
+        List.find('abcdef123456789123456789')
+      end
+
+      it "is equivalent to client#find" do
+        List.find('abcdef123456789123456789').should eq(list)
+      end
+    end
+
+    context "creating" do
+      let(:client) { Trello.client }
+
+      it "creates a new record" do
+        list = List.new(lists_details.first)
+        list.should be_valid
+      end
+
+      it 'must not be valid if not given a name' do
+        list = List.new(lists_details.first.except('name'))
+        list.should_not be_valid
+      end
+
+      it 'must not be valid if not given a list id' do
+        list = List.new(lists_details.first.except('id'))
+        list.should_not be_valid
+      end
+
+      it 'creates a new record and saves it on Trello', :refactor => true do
+        payload = {
+          :name       => 'Test List',
+          :board_id   => 'abcdef123456789123456789'
+        }
+
+        result = JSON.generate(payload)
+
+        expected_payload = {:name => "Test List", :closed => false, :idBoard => "abcdef123456789123456789"}
+
+        client.should_receive(:post).with("/lists", expected_payload).and_return result
+
+        list = List.create(payload)
+
+        list.class.should be List
+      end
     end
 
     context "updating" do
@@ -20,65 +70,69 @@ module Trello
           :closed    => false
         }
 
-        Client.should_receive(:put).once.with("/lists/abcdef123456789123456789", payload)
-        @list.name = expected_new_name
-        @list.save
+        client.should_receive(:put).once.with("/lists/abcdef123456789123456789", payload)
+        list.name = expected_new_name
+        list.save
       end
     end
 
     context "fields" do
       it "gets its id" do
-        @list.id.should == lists_details.first['id']
+        list.id.should == lists_details.first['id']
       end
 
       it "gets its name" do
-        @list.name.should == lists_details.first['name']
+        list.name.should == lists_details.first['name']
       end
 
       it "knows if it is open or closed" do
-        @list.closed.should == lists_details.first['closed']
+        list.closed.should == lists_details.first['closed']
       end
 
       it "has a board" do
-        @list.board.should == Board.new(boards_details.first)
+        list.board.should == Board.new(boards_details.first)
+      end
+
+      it "gets its position" do
+        list.pos.should == lists_details.first['pos']
       end
     end
 
     context "actions" do
       it "has a list of actions" do
-        Client.stub(:get).with("/lists/abcdef123456789123456789/actions", { :filter => :all }).and_return actions_payload
-        @list.actions.count.should be > 0
+        client.stub(:get).with("/lists/abcdef123456789123456789/actions", { :filter => :all }).and_return actions_payload
+        list.actions.count.should be > 0
       end
     end
 
     context "cards" do
       it "has a list of cards" do
-        Client.stub(:get).with("/lists/abcdef123456789123456789/cards", { :filter => :open }).and_return cards_payload
-        @list.cards.count.should be > 0
+        client.stub(:get).with("/lists/abcdef123456789123456789/cards", { :filter => :open }).and_return cards_payload
+        list.cards.count.should be > 0
       end
     end
 
     describe "#closed?" do
       it "returns the closed attribute" do
-        @list.closed?.should_not be_true
+        list.closed?.should_not be_true
       end
     end
 
     describe "#close" do
       it "updates the close attribute to true" do
-        @list.close
-        @list.closed.should be_true
+        list.close
+        list.closed.should be_true
       end
     end
 
     describe "#close!" do
       it "updates the close attribute to true and saves the list" do
-        Client.should_receive(:put).once.with("/lists/abcdef123456789123456789", {
-          :name   => @list.name,
+        client.should_receive(:put).once.with("/lists/abcdef123456789123456789", {
+          :name   => list.name,
           :closed => true
         })
 
-        @list.close!
+        list.close!
       end
     end
   end

data/spec/member_spec.rb

@@ -6,86 +6,100 @@ module Trello
   describe Member do
     include Helpers
 
+    let(:member) { client.find(:member, 'abcdef123456789012345678') }
+    let(:client) { Client.new }
+
     before(:each) do
-      Client.stub(:get).with("/members/abcdef123456789012345678").and_return user_payload
+      client.stub(:get).with("/members/abcdef123456789012345678").and_return user_payload
+    end
+
+    context "finding" do
+      let(:client) { Trello.client }
 
-      @member = Member.find('abcdef123456789012345678')
+      it "delegates to Trello.client#find" do
+        client.should_receive(:find).with(:member, 'abcdef123456789012345678')
+        Member.find('abcdef123456789012345678')
+      end
+
+      it "is equivalent to client#find" do
+        Member.find('abcdef123456789012345678').should eq(member)
+      end
     end
 
     context "actions" do
       it "retrieves a list of actions", :refactor => true do
-        Client.stub(:get).with("/members/abcdef123456789012345678/actions", { :filter => :all }).and_return actions_payload
-        @member.actions.count.should be > 0
+        client.stub(:get).with("/members/abcdef123456789012345678/actions", { :filter => :all }).and_return actions_payload
+        member.actions.count.should be > 0
       end
     end
 
     context "boards" do
       it "has a list of boards" do
-        Client.stub(:get).with("/members/abcdef123456789012345678/boards", { :filter => :all }).and_return boards_payload
-        boards = @member.boards
+        client.stub(:get).with("/members/abcdef123456789012345678/boards", { :filter => :all }).and_return boards_payload
+        boards = member.boards
         boards.count.should be > 0
       end
     end
 
     context "cards" do
       it "has a list of cards" do
-        Client.stub(:get).with("/members/abcdef123456789012345678/cards", { :filter => :open }).and_return cards_payload
-        cards = @member.cards
+        client.stub(:get).with("/members/abcdef123456789012345678/cards", { :filter => :open }).and_return cards_payload
+        cards = member.cards
         cards.count.should be > 0
       end
     end
 
     context "organizations" do
       it "has a list of organizations" do
-        Client.stub(:get).with("/members/abcdef123456789012345678/organizations", { :filter => :all }).and_return orgs_payload
-        orgs = @member.organizations
+        client.stub(:get).with("/members/abcdef123456789012345678/organizations", { :filter => :all }).and_return orgs_payload
+        orgs = member.organizations
         orgs.count.should be > 0
       end
     end
 
     context "notifications" do
       it "has a list of notifications" do
-        Client.stub(:get).with("/members/abcdef123456789012345678/notifications", {}).and_return "[" << notification_payload << "]"
-        @member.notifications.count.should be 1
+        client.stub(:get).with("/members/abcdef123456789012345678/notifications", {}).and_return "[" << notification_payload << "]"
+        member.notifications.count.should be 1
       end
     end
 
     context "personal" do
       it "gets the members bio" do
-        @member.bio.should == user_details['bio']
+        member.bio.should == user_details['bio']
       end
 
       it "gets the full name" do
-        @member.full_name.should == user_details['fullName']
+        member.full_name.should == user_details['fullName']
       end
 
       it "gets the avatar id" do
-        @member.avatar_id.should == user_details['avatarHash']
+        member.avatar_id.should == user_details['avatarHash']
       end
 
       it "returns a valid url for the avatar" do
-        @member.avatar_url(:size => :large).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png"
-        @member.avatar_url(:size => :small).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png"
+        member.avatar_url(:size => :large).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png"
+        member.avatar_url(:size => :small).should == "https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png"
       end
 
       it "gets the url" do
-        @member.url.should == user_details['url']
+        member.url.should == user_details['url']
       end
 
       it "gets the username" do
-        @member.username.should == user_details['username']
+        member.username.should == user_details['username']
       end
     end
 
     context "modification" do
       it "lets us know a field has changed without committing it" do
-        @member.changed?.should be_false
-        @member.bio = "New and amazing"
-        @member.changed?.should be_true
+        member.changed?.should be_false
+        member.bio = "New and amazing"
+        member.changed?.should be_true
       end
 
       it "doesn't understand the #id= method" do
-        lambda { @member.id = "42" }.should raise_error NoMethodError
+        lambda { member.id = "42" }.should raise_error NoMethodError
       end
     end
   end

data/spec/notification_spec.rb

@@ -4,80 +4,84 @@ module Trello
   describe Notification do
     include Helpers
 
+    let(:notification) { member.notifications.first }
+    let(:member) { client.find(:member, "abcdef123456789012345678") }
+    let(:client) { Client.new }
+
     before(:each) do
-      Client.stub(:get).with("/members/abcdef123456789012345678").and_return user_payload
-      member = Member.find("abcdef123456789012345678")
-      Client.stub(:get).with("/members/abcdef123456789012345678/notifications", {}).and_return "[" << notification_payload << "]"
-      @notification = member.notifications.first
+      client.stub(:get).with("/members/abcdef123456789012345678").and_return user_payload
+      client.stub(:get).with("/members/abcdef123456789012345678/notifications", {}).and_return "[" << notification_payload << "]"
     end
 
     context "finding" do
+      let(:client) { Trello.client }
+
       it "can find a specific notification" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}").and_return notification_payload
-        Notification.find(notification_details['id']).should == @notification
+        client.stub(:get).with("/notifications/#{notification_details['id']}").and_return notification_payload
+        Notification.find(notification_details['id']).should == notification
       end
     end
 
     context "boards" do
       it "can retrieve the board" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}/board").and_return JSON.generate(boards_details.first)
-        @notification.board.id.should == boards_details.first['id']
+        client.stub(:get).with("/notifications/#{notification_details['id']}/board").and_return JSON.generate(boards_details.first)
+        notification.board.id.should == boards_details.first['id']
       end
     end
 
     context "lists" do
       it "can retrieve the list" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}/list").and_return JSON.generate(lists_details.first)
-        @notification.list.id.should == lists_details.first['id']
+        client.stub(:get).with("/notifications/#{notification_details['id']}/list").and_return JSON.generate(lists_details.first)
+        notification.list.id.should == lists_details.first['id']
       end
     end
 
     context "cards" do
       it "can retrieve the card" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}/card").and_return JSON.generate(cards_details.first)
-        @notification.card.id.should == cards_details.first['id']
+        client.stub(:get).with("/notifications/#{notification_details['id']}/card").and_return JSON.generate(cards_details.first)
+        notification.card.id.should == cards_details.first['id']
       end
     end
 
     context "members" do
       it "can retrieve the member" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}/member").and_return user_payload
-        @notification.member.id.should == user_details['id']
+        client.stub(:get).with("/notifications/#{notification_details['id']}/member").and_return user_payload
+        notification.member.id.should == user_details['id']
       end
 
       it "can retrieve the member creator" do
-        Client.stub(:get).with("/members/#{user_details['id']}").and_return user_payload
-        @notification.member_creator.id.should == user_details['id']
+        client.stub(:get).with("/members/#{user_details['id']}").and_return user_payload
+        notification.member_creator.id.should == user_details['id']
       end
     end
 
     context "organization" do
       it "can retrieve the organization" do
-        Client.stub(:get).with("/notifications/#{notification_details['id']}/organization").and_return JSON.generate(orgs_details.first)
-        @notification.organization.id.should == orgs_details.first['id']
+        client.stub(:get).with("/notifications/#{notification_details['id']}/organization").and_return JSON.generate(orgs_details.first)
+        notification.organization.id.should == orgs_details.first['id']
       end
     end
 
     context "local" do
       it "gets the read status" do
-        @notification.unread?.should == notification_details['unread']
+        notification.unread?.should == notification_details['unread']
       end
 
       it "gets the type" do
-        @notification.type.should == notification_details['type']
+        notification.type.should == notification_details['type']
       end
 
       it "gets the date" do
-        @notification.date.should == notification_details['date']
+        notification.date.should == notification_details['date']
       end
 
       it "gets the data" do
-        @notification.data.should == notification_details['data']
+        notification.data.should == notification_details['data']
       end
 
       it "gets the member creator id" do
-        @notification.member_creator_id.should == notification_details['idMemberCreator']
+        notification.member_creator_id.should == notification_details['idMemberCreator']
       end
     end
   end
-end
+end