ruby-tapas-downloader 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f1d7cdcdb5cde17aa928fc89ebfacbdf92bca457
-  data.tar.gz: ae43b73c4d94581a915152adfa26e02b66614098
+  metadata.gz: 0f0fe636f9c2f5518dc74c455c8849b99c41d2c5
+  data.tar.gz: f78d4d669319e1d23328523c2cbab951fcc6637f
 SHA512:
-  metadata.gz: 3c3f891b4221a29852407722e8f639a7ac7b58a32489489d51364dbccc687f729a32763533ba186cc5b6e024c003b104ed37020bcb520f70893da917c7d0c827
-  data.tar.gz: b1b99d005782033bdd131110379a96c828f674a86b38ae267f7c563b1c895dac12f193160c9f69e55438b3ea75c6982903decb39f303281c6aed4001f8d9a6e5
+  metadata.gz: 9c0eade07ae42f0a3fc8ecd795457e78cf27c0c497464ef18be91c71ce5b66e425debf47bf023a33911328550d08621fe95a0f78dd7ee25321d435696e8a1fa8
+  data.tar.gz: 8cdfc7d654377226ccd8fada6e2c3c34c0534f58a208930babfcabf119ede9e31ce8119e0cf441626c9605edb3e34d524ccb83ce6c8fff71189aba9af896631c

data/lib/ruby-tapas-downloader.rb

@@ -7,6 +7,7 @@ require 'cgi'
 require 'logger'
 require 'pathname'
 
+# Root module for Ruby Tapas downloader
 module RubyTapasDownloader
   class << self
     # The Logger for RubyTapasDownloader.

data/lib/ruby_tapas_downloader/cli.rb

@@ -4,12 +4,11 @@ require 'user-configurations'
 require_relative '../ruby-tapas-downloader'
 
 # The Command Line Interface for Ruby Tapas Downloader.
-module RubyTapasDownloader
-  class CLI < Thor
-    # Long description for download action
-    def self.download_long_description
-      env_vars = RubyTapasDownloader::Config::CONFIG_KEYS.join(',')
-      <<-LONG_DESC
+class RubyTapasDownloader::CLI < Thor
+  # Long description for download action
+  def self.download_long_description
+    env_vars = RubyTapasDownloader::Config::CONFIG_KEYS.join(',')
+    <<-LONG_DESC
 To download you need to be authenticated, you have tree options:
 
 - Pass the params described before
@@ -17,80 +16,79 @@ To download you need to be authenticated, you have tree options:
 - Use `ruby-tapas-downloader configure`
 
 - Pass/export env vars: #{ env_vars }
-      LONG_DESC
-    end
+    LONG_DESC
+  end
 
-    # Perform complete download procedure.
-    desc 'download', 'Download new content'
-    option(
-      :email, required: true, default: Config.default_email, aliases: '-e'
-    )
-    option(
-      :password,
-      required: true,
-      default: Config.default_password,
-      aliases: '-p'
-    )
-    option(
-      :download_path,
-      required: true,
-      default: Config.default_download_path,
-      aliases: '-d'
+  # Perform complete download procedure.
+  desc 'download', 'Download new content'
+  option(
+    :email, required: true, default: Config.default_email, aliases: '-e'
+  )
+  option(
+    :password,
+    required: true,
+    default: Config.default_password,
+    aliases: '-p'
+  )
+  option(
+    :download_path,
+    required: true,
+    default: Config.default_download_path,
+    aliases: '-d'
+  )
+  long_desc download_long_description
+  def download
+    create_agent
+    login
+    fetch_feed
+    create_catalog
+    download_catalog
+  end
+
+  # Configure user preferences
+  desc 'configure -e foo@bar.com -p 123 -l .', 'Configure user preferences'
+  option :email,         required: true, aliases: '-e'
+  option :password,      required: true, aliases: '-p'
+  option :download_path, required: true, aliases: '-d'
+  def configure
+    RubyTapasDownloader::Config.update(
+      email: email, password: password, download_path: download_path
     )
-    long_desc download_long_description
-    def download
-      create_agent
-      login
-      fetch_feed
-      create_catalog
-      download_catalog
-    end
-
-    # Configure user preferences
-    desc 'configure -e foo@bar.com -p 123 -l .', 'Configure user preferences'
-    option :email,         required: true, aliases: '-e'
-    option :password,      required: true, aliases: '-p'
-    option :download_path, required: true, aliases: '-d'
-    def configure
-      RubyTapasDownloader::Config.update(
-        email: email, password: password, download_path: download_path
-      )
-    end
-
-    private
-
-    def email
-      options[:email]
-    end
-
-    def password
-      options[:password]
-    end
-
-    def download_path
-      options[:download_path]
-    end
-
-    def create_agent
-      @agent = Mechanize.new
-    end
-
-    def login
-      RubyTapasDownloader::Login.new(agent, email, password).login
-    end
-
-    def fetch_feed
-      @feed = RubyTapasDownloader::FeedFetcher.new(agent, email, password).fetch
-    end
-
-    def create_catalog
-      @catalog = RubyTapasDownloader::Extractors::Catalog.new.extract feed
-    end
-
-    def download_catalog
-      @catalog.download download_path, agent
-    end
-
-    attr_accessor :agent, :feed
   end
+
+  private
+
+  def email
+    options[:email]
+  end
+
+  def password
+    options[:password]
+  end
+
+  def download_path
+    options[:download_path]
+  end
+
+  def create_agent
+    @agent = Mechanize.new
+  end
+
+  def login
+    RubyTapasDownloader::Login.new(agent, email, password).login
+  end
+
+  def fetch_feed
+    @feed = RubyTapasDownloader::FeedFetcher.new(agent, email, password).fetch
+  end
+
+  def create_catalog
+    @catalog = RubyTapasDownloader::Extractors::Catalog.new.extract feed
+  end
+
+  def download_catalog
+    @catalog.download download_path, agent
+  end
+
+  attr_accessor :agent, :feed
 end

data/lib/ruby_tapas_downloader/config.rb

@@ -9,7 +9,6 @@ class RubyTapasDownloader::Config
   ]
 
   class << self
-
     # Retrieve urls stored in `urls.yml`.
     # @return [Hash] the urls stored in `urls.yml`.
     def urls

data/lib/ruby_tapas_downloader/downloadables/catalog.rb

@@ -5,7 +5,7 @@ class RubyTapasDownloader::Downloadables::Catalog <
   # @return [Set<RubyTapasDownloader::Downloadables::Episode>] the Episodes.
   attr_reader :episodes
 
-  def initialize episodes
+  def initialize(episodes)
     @episodes = episodes
   end
 
@@ -13,18 +13,18 @@ class RubyTapasDownloader::Downloadables::Catalog <
   #
   # @param basepath [String] the path to place download.
   # @param agent [Mechanize] the Mechanize agent.
-  def download basepath, agent
+  def download(basepath, agent)
     RubyTapasDownloader.logger.info 'Starting download of catalog in ' \
                                     "`#{ basepath }'..."
     FileUtils.mkdir_p basepath
     episodes.each { |episode| episode.download basepath, agent }
   end
 
-  def == other
+  def ==(other)
     episodes == other.episodes
   end
 
-  def eql? other
+  def eql?(other)
     episodes.eql? other.episodes
   end
 

data/lib/ruby_tapas_downloader/downloadables/episode.rb

@@ -12,7 +12,7 @@ class RubyTapasDownloader::Downloadables::Episode <
   #   for that episode.
   attr_reader :files
 
-  def initialize title, link, files
+  def initialize(title, link, files)
     @title = title
     @link  = link
     @files = files
@@ -25,11 +25,10 @@ class RubyTapasDownloader::Downloadables::Episode <
     @sanitized_title ||= title.downcase.gsub(/[^\w<>#?!$]+/, '-')
   end
 
-
   # Download the Episode.
   #
   # @param (see: RubyTapasDownloader::Downloadables::Catalog#download)
-  def download basepath, agent
+  def download(basepath, agent)
     episode_path = File.join basepath, sanitized_title
     RubyTapasDownloader.logger.info 'Starting download of episode ' \
                                     "`#{ title }' in `#{ episode_path }'..."
@@ -37,11 +36,11 @@ class RubyTapasDownloader::Downloadables::Episode <
     files.each { |file| file.download episode_path, agent }
   end
 
-  def == other
+  def ==(other)
     title == other.title && link == other.link && files == other.files
   end
 
-  def eql? other
+  def eql?(other)
     title.eql?(other.title) && link.eql?(other.link) && files.eql?(other.files)
   end
 

data/lib/ruby_tapas_downloader/downloadables/file.rb

@@ -8,7 +8,7 @@ class RubyTapasDownloader::Downloadables::File <
   # @return [String] the link to download the File.
   attr_reader :link
 
-  def initialize name, link
+  def initialize(name, link)
     @name = name
     @link = link
   end
@@ -16,20 +16,20 @@ class RubyTapasDownloader::Downloadables::File <
   # Download the File.
   #
   # @param (see: RubyTapasDownloader::Downloadables::Catalog#download)
-  def download basepath, agent
+  def download(basepath, agent)
     FileUtils.mkdir_p basepath
 
     file_path = File.join(basepath, name)
     RubyTapasDownloader.logger.info "Starting download of file `#{ name }' " \
                                     "in `#{ file_path }'..."
-    agent.download link, file_path unless File.exists? file_path
+    agent.download link, file_path unless File.exist? file_path
   end
 
-  def == other
+  def ==(other)
     name == other.name && link == other.link
   end
 
-  def eql? other
+  def eql?(other)
     name.eql?(other.name) && link.eql?(other.link)
   end
 

data/lib/ruby_tapas_downloader/extractors/catalog.rb

@@ -2,20 +2,20 @@
 class RubyTapasDownloader::Extractors::Catalog < RubyTapasDownloader::Extractor
   # @param episode_extractor [RubyTapasDownloader::Extractors::Episode] the
   #   Episode Extractor.
-  def initialize episode_extractor =
-                                   RubyTapasDownloader::Extractors::Episode.new
+  def initialize(episode_extractor =
+                                   RubyTapasDownloader::Extractors::Episode.new)
     @episode_extractor = episode_extractor
   end
 
   # @param feed [RSS::Rss] the feed extracted with `RSS::Parser.parse`.
   # @return [RubyTapasDownloader::Downloadables::Catalog] the Catalog extracted
   #   from feed.
-  def extract feed
+  def extract(feed)
     episodes = Set.new
 
-    feed.items.each { |item|
+    feed.items.each do |item|
       episodes << @episode_extractor.extract(item)
-    }
+    end
 
     RubyTapasDownloader::Downloadables::Catalog.new episodes
   end

data/lib/ruby_tapas_downloader/extractors/episode.rb

@@ -2,7 +2,7 @@
 class RubyTapasDownloader::Extractors::Episode < RubyTapasDownloader::Extractor
   # @param files_extractor [RubyTapasDownloader::Extractors::Files] the
   #   Files Extractor.
-  def initialize files_extractor = RubyTapasDownloader::Extractors::Files.new
+  def initialize(files_extractor = RubyTapasDownloader::Extractors::Files.new)
     @files_extractor = files_extractor
   end
 
@@ -10,7 +10,7 @@ class RubyTapasDownloader::Extractors::Episode < RubyTapasDownloader::Extractor
   #   `feed.items[i]`.
   # @return [RubyTapasDownloader::Downloadables::Episode] the Episode extracted
   #   from feed item.
-  def extract item
+  def extract(item)
     title = CGI.unescapeHTML item.title
     link  = item.link
     files = @files_extractor.extract item.description

data/lib/ruby_tapas_downloader/extractors/files.rb

@@ -4,14 +4,14 @@ class RubyTapasDownloader::Extractors::Files < RubyTapasDownloader::Extractor
   #   `feed.items[i].description`.
   # @return [Set<RubyTapasDownloader::Downloadables::File>] the Set of Files
   #   extracted from feed item description.
-  def extract item_description
+  def extract(item_description)
     files = Set.new
     document = REXML::Document.new item_description
-    document.elements.each("/div[@class='blog-entry']/ul/li/a") { |element|
+    document.elements.each("/div[@class='blog-entry']/ul/li/a") do |element|
       name = element.text
       link = element.attribute('href').to_s
       files << RubyTapasDownloader::Downloadables::File.new(name, link)
-    }
+    end
     files
   end
 end

data/lib/ruby_tapas_downloader/feed_fetcher.rb

@@ -9,7 +9,7 @@ class RubyTapasDownloader::FeedFetcher
   # @return [String] the password for the user.
   attr_reader :password
 
-  def initialize agent, email, password
+  def initialize(agent, email, password)
     @agent    = agent
     @email    = email
     @password = password

data/lib/ruby_tapas_downloader/login.rb

@@ -11,7 +11,7 @@ class RubyTapasDownloader::Login
   # @return [String] the password for the user.
   attr_reader :password
 
-  def initialize agent, email, password
+  def initialize(agent, email, password)
     @agent    = agent
     @email    = email
     @password = password

data/lib/ruby_tapas_downloader/version.rb

@@ -1,3 +1,4 @@
+# Gem current version
 module RubyTapasDownloader
-  VERSION = '2.0.1'
+  VERSION = '2.0.2'
 end

metadata

@@ -1,85 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: ruby-tapas-downloader
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Leandro Facchinetti
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-12 00:00:00.000000000 Z
+date: 2014-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
 - !ruby/object:Gem::Dependency
   name: user-configurations
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.19'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.19'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: pry-debugger
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '1.3'
 description: It downloads all episodes and attachments, organizes them for later use
   and keeps an easy to use index of episodes.
 email: ruby-tapas-downloader@leafac.com
@@ -119,17 +119,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Downloader for Avdi Grimm Ruby Tapas