ruby-saml 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57e7a2eb4f514972244fc12215e6586386fb5fe3
-  data.tar.gz: cf05522f6c29de7ae71c30407a93ee2cfe5926b9
+  metadata.gz: 99b6868dbb0c85f62887107838735de63e1d9136
+  data.tar.gz: 15eeebe4a761be9840b5136dfe957fb966f9519d
 SHA512:
-  metadata.gz: 039cc1a41f64dd95707f441afc2015bc44948944fa0356ead52280d5420ebc314d9b004f3e048694356aa40b36546c0a3a98e2f8e4c98f79079b199629f4872f
-  data.tar.gz: 57a46834046c71fce8a1845487e6dfb53fb6b9dadac4d411462e2e2731c8457b162be13563fbad92f3f15e7639916c59e8a266842d018191c40cbfb5f77038c6
+  metadata.gz: 98a67ff93d0195daf43d1d4ecefea284be38566f85717314d2ec301d7fda271f14a1cbc60527d172fdc8314175f4ed67e30304ae9a2f840fa99988928c372745
+  data.tar.gz: e528f8945eea81bdbeedd9c2bf7bd9f66e466ca941852758b79d2ad84e05a59516057a9a173538de29336863f935bb649ca5083049e707f6f0bcb6a0b269ce3c

data/README.md

@@ -1,5 +1,12 @@
 # Ruby SAML [![Build Status](https://secure.travis-ci.org/onelogin/ruby-saml.png)](http://travis-ci.org/onelogin/ruby-saml)
 
+## Note on versions 0.8.6 and 0.8.7
+Version `0.8.6` introduced an incompatibility with regards to manipulating the `OneLogin::RubySaml::Response#attributes` property; in this version 
+the `#attributes` property is a class (`OneLogin::RubySaml::Attributes`) which implements the `Enumerator` module, thus any non-overriden Hash method
+will throw a NoMethodError.
+Version `0.8.7` overrides the behavior of class `OneLogin::RubySaml::Attributes` by making any method not found on the class be tested on the 
+internal hash structure, thus all methods available in the `Hash` class are now available in `OneLogin::RubySaml::Response#attributes`.
+
 ## Updating from 0.7.x to 0.8.x
 Version `0.8.x` changes the namespace of the gem from `OneLogin::Saml` to `OneLogin::RubySaml`.  Please update your implementations of the gem accordingly.
 

data/lib/onelogin/ruby-saml/attributes.rb

@@ -48,7 +48,7 @@ module OneLogin
       # @param name [String] The attribute name to be checked
       #
       def include?(name)
-        attributes.has_key?(canonize_name(name))
+        attributes.has_key?(canonize_name(name)) || attributes.has_key?(name)
       end
       
       # Return first value for an attribute
@@ -56,7 +56,7 @@ module OneLogin
       # @return [String] The value (First occurrence)
       #
       def single(name)
-        attributes[canonize_name(name)].first if include?(name)
+        multi(name).first if include?(name)
       end
 
       # Return all values for an attribute
@@ -64,7 +64,15 @@ module OneLogin
       # @return [Array] Values of the attribute
       #
       def multi(name)
-        attributes[canonize_name(name)]
+        values = attributes[canonize_name(name)] || attributes[name]
+        
+        if values.is_a?(Array)
+          values
+        elsif !values.nil?
+          Array(values)
+        else
+          nil
+        end
       end
 
       # Retrieve attribute value(s)
@@ -76,7 +84,7 @@ module OneLogin
       #                          response.attributes['mail']  # => ['user@example.com','user@example.net']
       #
       def [](name)
-        self.class.single_value_compatibility ? single(canonize_name(name)) : multi(canonize_name(name))
+        self.class.single_value_compatibility ? single(name) : multi(name)
       end
 
       # @return [Array] Return all attributes as an array
@@ -113,6 +121,10 @@ module OneLogin
         end
       end
 
+      def respond_to?(name)
+        attributes.respond_to?(name) || super
+      end
+
       protected
 
       # stringifies all names so both 'email' and :email return the same result
@@ -123,6 +135,13 @@ module OneLogin
         name.to_s
       end
 
+      def method_missing(name, *args, &block)
+        if attributes.respond_to?(name)
+          attributes.send(name, *args, &block)
+        else
+          super
+        end
+      end
     end
   end
 end

data/lib/onelogin/ruby-saml/version.rb

@@ -1,5 +1,5 @@
 module OneLogin
   module RubySaml
-    VERSION = '0.8.6'
+    VERSION = '0.8.7'
   end
 end

data/test/response_test.rb

@@ -236,6 +236,28 @@ class RubySamlTest < Test::Unit::TestCase
         assert_equal "smith", response_with_multiple_attribute_statements.attributes[:surname]
         assert_equal "bob", response_with_multiple_attribute_statements.attributes[:firstname]
       end
+
+      should "be manipulable by hash methods such as #merge and not raise an exception" do
+        response = OneLogin::RubySaml::Response.new(response_document)
+        response.attributes.merge({ :testing_attribute => "test" })
+      end
+
+      should "be manipulable by hash methods such as #shift and not raise an exception" do
+        response = OneLogin::RubySaml::Response.new(response_document)
+        response.attributes.shift
+      end
+
+      should "be manipulable by hash methods such as #merge! and actually contain the value" do
+        response = OneLogin::RubySaml::Response.new(response_document)
+        response.attributes.merge!({ :testing_attribute => "test" })
+        assert response.attributes[:testing_attribute]
+      end
+
+      should "be manipulable by hash methods such as #shift and actually remove the value" do
+        response = OneLogin::RubySaml::Response.new(response_document)
+        removed_value = response.attributes.shift
+        assert_nil response.attributes[removed_value[0]]
+      end
     end
 
     context "#session_expires_at" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-saml
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - OneLogin LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-08 00:00:00.000000000 Z
+date: 2019-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uuid