ruby-saml 0.8.16 → 0.9

data/lib/onelogin/ruby-saml/response.rb

@@ -1,30 +1,30 @@
 require "xml_security"
 require "time"
 require "nokogiri"
-require "onelogin/ruby-saml/utils"
-require 'onelogin/ruby-saml/attributes'
 
 # Only supports SAML 2.0
 module OneLogin
   module RubySaml
 
-    class Response
+    class Response < SamlMessage
       ASSERTION = "urn:oasis:names:tc:SAML:2.0:assertion"
       PROTOCOL  = "urn:oasis:names:tc:SAML:2.0:protocol"
       DSIG      = "http://www.w3.org/2000/09/xmldsig#"
 
       # TODO: This should probably be ctor initialized too... WDYT?
       attr_accessor :settings
+      attr_accessor :errors
 
       attr_reader :options
       attr_reader :response
       attr_reader :document
 
       def initialize(response, options = {})
+        @errors = []
         raise ArgumentError.new("Response cannot be nil") if response.nil?
         @options  = options
-        @response = OneLogin::RubySaml::Utils.decode_raw_saml(response)
-        @document = XMLSecurity::SignedDocument.new(@response)
+        @response = decode_raw_saml(response)
+        @document = XMLSecurity::SignedDocument.new(@response, @errors)
       end
 
       def is_valid?
@@ -35,16 +35,18 @@ module OneLogin
         validate(false)
       end
 
+      def errors
+        @errors
+      end
+
       # The value of the user identifier as designated by the initialization request response
       def name_id
         @name_id ||= begin
           node = xpath_first_from_signed_assertion('/a:Subject/a:NameID')
-          Utils.element_text(node)
+          node.nil? ? nil : node.text
         end
       end
 
-      alias nameid name_id
-
       def sessionindex
         @sessionindex ||= begin
           node = xpath_first_from_signed_assertion('/a:AuthnStatement')
@@ -52,9 +54,9 @@ module OneLogin
         end
       end
 
-      # Gets the Attributes from the AttributeStatement element.
-      #
+      # Returns OneLogin::RubySaml::Attributes enumerable collection.
       # All attributes can be iterated over +attributes.each+ or returned as array by +attributes.all+
+      #
       # For backwards compatibility ruby-saml returns by default only the first value for a given attribute with
       #    attributes['name']
       # To get all of the attributes, use:
@@ -63,36 +65,24 @@ module OneLogin
       #    OneLogin::RubySaml::Attributes.single_value_compatibility = false
       # Now this will return an array:
       #    attributes['name']
-      #
-      # @return [Attributes] OneLogin::RubySaml::Attributes enumerable collection.
-      #
       def attributes
         @attr_statements ||= begin
           attributes = Attributes.new
 
-          stmt_elements = xpath_from_signed_assertion('/a:AttributeStatement')
-          stmt_elements.each do |stmt_element|
-            stmt_element.elements.each do |attr_element|
-              name = attr_element.attributes["Name"]
-              values = attr_element.elements.collect{|e|
-                if (e.elements.nil? || e.elements.size == 0)
-                  # SAMLCore requires that nil AttributeValues MUST contain xsi:nil XML attribute set to "true" or "1"
-                  # otherwise the value is to be regarded as empty.
-                  ["true", "1"].include?(e.attributes['xsi:nil']) ? nil : Utils.element_text(e)
-                # explicitly support saml2:NameID with saml2:NameQualifier if supplied in attributes
-                # this is useful for allowing eduPersonTargetedId to be passed as an opaque identifier to use to
-                # identify the subject in an SP rather than email or other less opaque attributes
-                # NameQualifier, if present is prefixed with a "/" to the value
-                else
-                 REXML::XPath.match(e,'a:NameID', { "a" => ASSERTION }).collect{|n|
-                    (n.attributes['NameQualifier'] ? n.attributes['NameQualifier'] +"/" : '') + Utils.element_text(n)
-                  }
-                end
-              }
-
-              attributes.add(name, values.flatten)
-            end
+          stmt_element = xpath_first_from_signed_assertion('/a:AttributeStatement')
+          return attributes if stmt_element.nil?
+
+          stmt_element.elements.each do |attr_element|
+            name  = attr_element.attributes["Name"]
+            values = attr_element.elements.collect{|e|
+              # SAMLCore requires that nil AttributeValues MUST contain xsi:nil XML attribute set to "true" or "1"
+              # otherwise the value is to be regarded as empty.
+              ["true", "1"].include?(e.attributes['xsi:nil']) ? nil : e.text.to_s
+            }
+
+            attributes.add(name, values)
           end
+
           attributes
         end
       end
@@ -113,6 +103,13 @@ module OneLogin
         end
       end
 
+      def status_message
+        @status_message ||= begin
+          node = REXML::XPath.first(document, "/p:Response/p:Status/p:StatusMessage", { "p" => PROTOCOL, "a" => ASSERTION })
+          node.text if node
+        end
+      end
+
       # Conditions (if any) for the assertion to run
       def conditions
         @conditions ||= xpath_first_from_signed_assertion('/a:Conditions')
@@ -130,223 +127,43 @@ module OneLogin
         @issuer ||= begin
           node = REXML::XPath.first(document, "/p:Response/a:Issuer", { "p" => PROTOCOL, "a" => ASSERTION })
           node ||= xpath_first_from_signed_assertion('/a:Issuer')
-          Utils.element_text(node)
-        end
-      end
-
-      # Gets the Issuers (from Response and Assertion).
-      # (returns the first node that matches the supplied xpath from the Response and from the Assertion)
-      # @return [Array] Array with the Issuers (REXML::Element)
-      #
-      def issuers
-        @issuers ||= begin
-          issuer_response_nodes = REXML::XPath.match(
-            document,
-            "/p:Response/a:Issuer",
-            { "p" => PROTOCOL, "a" => ASSERTION }
-          )
-
-          unless issuer_response_nodes.size == 1
-            error_msg = "Issuer of the Response not found or multiple."
-            raise ValidationError.new(error_msg)
-          end
-
-          issuer_assertion_nodes = xpath_from_signed_assertion("/a:Issuer")
-          unless issuer_assertion_nodes.size == 1
-            error_msg = "Issuer of the Assertion not found or multiple."
-            raise ValidationError.new(error_msg)
-          end
-
-          nodes = issuer_response_nodes + issuer_assertion_nodes
-          nodes.map { |node| Utils.element_text(node) }.compact.uniq
-        end
-      end
-
-      # @return [Array] The Audience elements from the Contitions of the SAML Response.
-      #
-      def audiences
-        @audiences ||= begin
-          nodes = xpath_from_signed_assertion('/a:Conditions/a:AudienceRestriction/a:Audience')
-          nodes.map { |node| Utils.element_text(node) }.reject(&:empty?)
+          node.nil? ? nil : node.text
         end
       end
 
       private
 
-      def validation_error(message)
-        raise ValidationError.new(message)
-      end
-
       def validate(soft = true)
-        validate_structure(soft)       &&
-        validate_success_status(soft)  &&
-        validate_num_assertion         &&
-        validate_signed_elements(soft) &&
-        validate_response_state(soft)  &&
-        validate_conditions(soft)      &&
-        validate_audience(soft)        &&
-        validate_issuer(soft)          &&
-        validate_signature(soft)       &&
-        success?
+        valid_saml?(document, soft)      &&
+        validate_response_state(soft) &&
+        validate_conditions(soft)     &&
+        validate_issuer(soft)         &&
+        document.validate_document(get_fingerprint, soft) &&
+        validate_success_status(soft)
       end
 
-      # Validates that the SAML Response only contains a single Assertion (encrypted or not).
-      # @return [Boolean] True if the SAML Response contains one unique Assertion, otherwise False
-      #
-      def validate_num_assertion(soft = true)
-        assertions = REXML::XPath.match(
-          document,
-          "//a:Assertion",
-          { "a" => ASSERTION }
-        )
-        encrypted_assertions = REXML::XPath.match(
-          document,
-          "//a:EncryptedAssertion",
-          { "a" => ASSERTION }
-        )
-
-        unless assertions.size + encrypted_assertions.size == 1
-          return soft ? false : validation_error("SAML Response must contain 1 assertion")
-        end
-
-        true
-      end
-
-      # Validates the Signed elements
-      # @return [Boolean] True if there is 1 or 2 Elements signed in the SAML Response
-      #                        an are a Response or an Assertion Element, otherwise False if soft=True
-      #
-      def validate_signed_elements(soft)
-        signature_nodes = REXML::XPath.match(
-          document,
-          "//ds:Signature",
-          {"ds"=>DSIG}
-        )
-        signed_elements = []
-        verified_seis = []
-        verified_ids = []
-        signature_nodes.each do |signature_node|
-          signed_element = signature_node.parent.name
-          if signed_element != 'Response' && signed_element != 'Assertion'
-            return soft ? false : validation_error("Invalid Signature Element '#{signed_element}'. SAML Response rejected")
-          end
-
-          if signature_node.parent.attributes['ID'].nil?
-            return soft ? false : validation_error("Signed Element must contain an ID. SAML Response rejected")
-          end
-
-          id = signature_node.parent.attributes.get_attribute("ID").value
-          if verified_ids.include?(id)
-            return soft ? false : validation_error("Duplicated ID. SAML Response rejected")
-          end
-          verified_ids.push(id)
-
-          # Check that reference URI matches the parent ID and no duplicate References or IDs
-          ref = REXML::XPath.first(signature_node, ".//ds:Reference", {"ds"=>DSIG})
-          if ref
-            uri = ref.attributes.get_attribute("URI")
-            if uri && !uri.value.empty?
-              sei = uri.value[1..-1]
-
-              unless sei == id
-                return soft ? false : validation_error("Found an invalid Signed Element. SAML Response rejected")
-              end
-
-              if verified_seis.include?(sei)
-                return soft ? false : validation_error("Duplicated Reference URI. SAML Response rejected")
-              end
-
-              verified_seis.push(sei)
-            end
-          end
-
-          signed_elements << signed_element
-        end
-
-        unless signature_nodes.length < 3 && !signed_elements.empty?
-          return soft ? false : validation_error("Found an unexpected number of Signature Element. SAML Response rejected")
-        end
-
-        true
-      end
-
-      # Validates the Status of the SAML Response
-      # @return [Boolean] True if the SAML Response contains a Success code, otherwise False if soft == false
-      # @raise [ValidationError] if soft == false and validation fails
-      #
       def validate_success_status(soft = true)
-        return true if success?
-
-        return false unless soft
-
-        error_msg = 'The status code of the Response was not Success'
-        status_error_msg = OneLogin::RubySaml::Utils.status_error_msg(error_msg, status_code, status_message)
-        return validation_error(status_error_msg)
-      end
-
-      # Checks if the Status has the "Success" code
-      # @return [Boolean] True if the StatusCode is Sucess
-      #
-      def success?
-        status_code == "urn:oasis:names:tc:SAML:2.0:status:Success"
-      end
-
-      # @return [String] StatusCode value from a SAML Response.
-      #
-      def status_code
-        @status_code ||= begin
-          nodes = REXML::XPath.match(
-            document,
-            "/p:Response/p:Status/p:StatusCode",
-            { "p" => PROTOCOL }
-          )
-          if nodes.size == 1
-            node = nodes[0]
-            code = node.attributes["Value"] if node && node.attributes
-
-            unless code == "urn:oasis:names:tc:SAML:2.0:status:Success"
-              nodes = REXML::XPath.match(
-                document,
-                "/p:Response/p:Status/p:StatusCode/p:StatusCode",
-                { "p" => PROTOCOL }
-              )
-              statuses = nodes.collect do |inner_node|
-                inner_node.attributes["Value"]
-              end
-              extra_code = statuses.join(" | ")
-              if extra_code
-                code = "#{code} | #{extra_code}"
-              end
-            end
-            code
-          end
-        end
-      end
-
-      # @return [String] the StatusMessage value from a SAML Response.
-      #
-      def status_message
-        @status_message ||= begin
-          nodes = REXML::XPath.match(
-            document,
-            "/p:Response/p:Status/p:StatusMessage",
-            { "p" => PROTOCOL }
-          )
-          if nodes.size == 1
-            Utils.element_text(nodes.first)
-          end
+        if success?
+          true
+        else
+          soft ? false : validation_error(status_message)
         end
       end
 
       def validate_structure(soft = true)
         Dir.chdir(File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'schemas'))) do
-          @schema = Nokogiri::XML::Schema(IO.read('saml20protocol_schema.xsd'))
+          @schema = Nokogiri::XML::Schema(IO.read('saml-schema-protocol-2.0.xsd'))
           @xml = Nokogiri::XML(self.document.to_s)
         end
         if soft
-          @schema.validate(@xml).map{ return false }
+          @schema.validate(@xml).map{
+            @errors << "Schema validation failed";
+            return false
+          }
         else
-          @schema.validate(@xml).map{ |error| validation_error("#{error.message}\n\n#{@xml.to_s}") }
+          @schema.validate(@xml).map{ |error| @errors << "#{error.message}\n\n#{@xml.to_s}";
+            validation_error("#{error.message}\n\n#{@xml.to_s}")
+          }
         end
       end
 
@@ -382,24 +199,13 @@ module OneLogin
         node
       end
 
-      # Extracts all the appearances that matchs the subelt (pattern)
-      # Search on any Assertion that is signed, or has a Response parent signed
-      # @param subelt [String] The XPath pattern
-      # @return [Array of REXML::Element] Return all matches
-      #
-      def xpath_from_signed_assertion(subelt=nil)
-        node = REXML::XPath.match(
-            document,
-            "/p:Response/a:Assertion[@ID=$id]#{subelt}",
-            { "p" => PROTOCOL, "a" => ASSERTION },
-            { 'id' => document.signed_element_id }
-        )
-        node.concat( REXML::XPath.match(
-            document,
-            "/p:Response[@ID=$id]/a:Assertion#{subelt}",
-            { "p" => PROTOCOL, "a" => ASSERTION },
-            { 'id' => document.signed_element_id }
-        ))
+      def get_fingerprint
+        if settings.idp_cert
+          cert = OpenSSL::X509::Certificate.new(settings.idp_cert)
+          Digest::SHA1.hexdigest(cert.to_der).upcase.scan(/../).join(":")
+        else
+          settings.idp_cert_fingerprint
+        end
       end
 
       def validate_conditions(soft = true)
@@ -409,10 +215,12 @@ module OneLogin
         now = Time.now.utc
 
         if not_before && (now + (options[:allowed_clock_drift] || 0)) < not_before
+          @errors << "Current time is earlier than NotBefore condition #{(now + (options[:allowed_clock_drift] || 0))} < #{not_before})"
           return soft ? false : validation_error("Current time is earlier than NotBefore condition")
         end
 
         if not_on_or_after && now >= not_on_or_after
+          @errors << "Current time is on or after NotOnOrAfter condition (#{now} >= #{not_on_or_after})"
           return soft ? false : validation_error("Current time is on or after NotOnOrAfter condition")
         end
 
@@ -422,64 +230,9 @@ module OneLogin
       def validate_issuer(soft = true)
         return true if settings.idp_entity_id.nil?
 
-        begin
-          obtained_issuers = issuers
-        rescue ValidationError => e
-          return soft ? false : validation_error("Error while extracting issuers")
-        end
-
-        obtained_issuers.each do |issuer|
-          unless OneLogin::RubySaml::Utils.uri_match?(issuer, settings.idp_entity_id)
-            error_msg = "Doesn't match the issuer, expected: <#{settings.idp_entity_id}>, but was: <#{issuer}>"
-            return soft ? false : validation_error(error_msg)
-          end
+        unless URI.parse(issuer) == URI.parse(settings.idp_entity_id)
+          return soft ? false : validation_error("Doesn't match the issuer, expected: <#{settings.idp_entity_id}>, but was: <#{issuer}>")
         end
-
-        true
-      end
-
-      def validate_signature(soft = true)
-        error_msg = "Invalid Signature on SAML Response"
-
-        sig_elements = REXML::XPath.match(
-          document,
-          "/p:Response[@ID=$id]/ds:Signature]",
-          { "p" => PROTOCOL, "ds" => DSIG },
-          { 'id' => document.signed_element_id }
-        )
-
-        # Check signature nodes
-        if sig_elements.nil? || sig_elements.size == 0
-          sig_elements = REXML::XPath.match(
-            document,
-            "/p:Response/a:Assertion[@ID=$id]/ds:Signature",
-            {"p" => PROTOCOL, "a" => ASSERTION, "ds"=>DSIG},
-            { 'id' => document.signed_element_id }
-          )
-        end
-
-        if sig_elements.size != 1
-          if  sig_elements.size == 0
-             error_msg += ". Signed element id ##{doc.signed_element_id} is not found"
-          else
-             error_msg += ". Signed element id ##{doc.signed_element_id} is found more than once"
-          end
-          return soft ? false : validation_error(error_msg)
-        end
-
-        opts = {}
-        opts[:fingerprint_alg] = OpenSSL::Digest::SHA1.new
-        opts[:cert] = settings.get_idp_cert
-        fingerprint = settings.get_fingerprint
-
-        unless fingerprint
-          return soft ? false : validation_error("No fingerprint or certificate on settings")
-        end
-
-        unless document.validate_document(fingerprint, soft, opts)
-          return soft ? false : validation_error(error_msg)
-        end
-
         true
       end
 
@@ -488,19 +241,6 @@ module OneLogin
           Time.parse(node.attributes[attribute])
         end
       end
-
-      def validate_audience(soft = true)
-        return true if audiences.empty? || settings.sp_entity_id.nil? || settings.sp_entity_id.empty?
-
-        unless audiences.include? settings.sp_entity_id
-          s = audiences.count > 1 ? 's' : '';
-          error_msg = "Invalid Audience#{s}. The audience#{s} #{audiences.join(',')}, did not match the expected audience #{settings.sp_entity_id}"
-          return soft ? false : validation_error(error_msg)
-        end
-
-        true
-      end
-
     end
   end
 end