ruby-saml 0.4.3 → 0.4.4

data/VERSION

@@ -1 +1 @@
-0.4.3
+0.4.4

data/lib/onelogin/saml/response.rb

@@ -29,8 +29,8 @@ module Onelogin::Saml
     # The value of the user identifier as designated by the initialization request response
     def name_id
       @name_id ||= begin
-        node  = REXML::XPath.first(document, "/p:Response/a:Assertion[@ID='#{document.signed_element_id[1,document.signed_element_id.size]}']/a:Subject/a:NameID", { "p" => PROTOCOL, "a" => ASSERTION })
-        node.text
+        node = REXML::XPath.first(document, "/p:Response/a:Assertion[@ID='#{document.signed_element_id[1,document.signed_element_id.size]}']/a:Subject/a:NameID", { "p" => PROTOCOL, "a" => ASSERTION })
+        node.nil? ? nil : node.text
       end
     end
 
@@ -50,6 +50,8 @@ module Onelogin::Saml
         result = {}
 
         stmt_element = REXML::XPath.first(document, "/p:Response/a:Assertion/a:AttributeStatement", { "p" => PROTOCOL, "a" => ASSERTION })
+        return {} if stmt_element.nil?
+
         stmt_element.elements.each do |attr_element|
           name  = attr_element.attributes["Name"]
           value = attr_element.elements.first.text

data/ruby-saml.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ruby-saml}
-  s.version = "0.4.3"
+  s.version = "0.4.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["OneLogin LLC"]
-  s.date = %q{2011-06-04}
+  s.date = %q{2011-06-10}
   s.description = %q{SAML toolkit for Ruby on Rails}
   s.email = %q{support@onelogin.com}
   s.extra_rdoc_files = [

data/test/ruby-saml_test.rb

@@ -38,7 +38,7 @@ class RubySamlTest < Test::Unit::TestCase
       response = Onelogin::Saml::Response.new(response_document_3)
       assert !response.name_id.nil?
     end
-    
+
     should "check time conditions" do
       response = Onelogin::Saml::Response.new(response_document)
       assert !response.check_conditions
@@ -111,6 +111,11 @@ class RubySamlTest < Test::Unit::TestCase
         response = Onelogin::Saml::Response.new(response_document_3)
         assert_equal "someone@example.com", response.attributes["http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress"]
       end
+
+      should "not raise on responses without attributes" do
+        response = Onelogin::Saml::Response.new(response_document_4)
+        assert_equal Hash.new, response.attributes
+      end
     end
 
     context "#session_expires_at" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-saml
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: false
   segments: 
   - 0
   - 4
-  - 3
-  version: 0.4.3
+  - 4
+  version: 0.4.4
 platform: ruby
 authors: 
 - OneLogin LLC
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-04 00:00:00 -06:00
+date: 2011-06-10 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency