ruby-saml-mod 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 70a7eb538a2bbed9d2269ccf27a1ae560a40734c
-  data.tar.gz: dca9f7dd1a7e5e7d3a7e8967af606b3688144c09
+  metadata.gz: e9d404302ea776f3b175212215249f3061ea501b
+  data.tar.gz: 3d108e0a906275c86781028092469fab13f948be
 SHA512:
-  metadata.gz: 1be665813508c314582bebac318758085c74ca7fd3621c58e6df191df83639981eb48fa3b3d6cbad8047765962abddd6fb920a8b8d0f9062d2075293f1ba8d87
-  data.tar.gz: a9d34492f6c2e8feb08a1bccccb2a53545c88ef336bc1cfb8345fff663ccbee7857bc338970d233877a8b295b44d03779b5f5cadcdeaa2655b5af57acb24e134
+  metadata.gz: 33820de0297276af1bc4e3999cfbfa99fa9fd3ed30944f738a25d74dc519f79093894e28d295a8d99ef63c325668280471a5dec25d1b89ea0075e3d554a1e274
+  data.tar.gz: 1f21a8319c552f3a55aff13ec07989f7c24913f05e5930cce0e6b62fcd985a09d4698f9b560ff3da6a0eeebab9c9980922594c160b59c359c50bea32e3832d38

data/lib/onelogin/saml/logout_request.rb

@@ -33,7 +33,7 @@ module Onelogin::Saml
 
     def generate
       <<-XML
-        <samlp:LogoutRequest xmlns:samlp="#{Onelogin::NAMESPACES['samlp']}" xmlns:saml="#{Onelogin::NAMESPACES['saml']}" ID="#{self.id}" Version="2.0" IssueInstant="#{self.issue_instant}" Destination="#{self.destination}">
+        <samlp:LogoutRequest xmlns:samlp="#{Onelogin::NAMESPACES['samlp']}" xmlns:saml="#{Onelogin::NAMESPACES['saml']}" ID="#{self.id}" Version="2.0" IssueInstant="#{self.issue_instant}" Destination="#{CGI.escapeHTML(self.destination)}">
           <saml:Issuer>#{self.issuer}</saml:Issuer>
           <saml:NameID NameQualifier="#{self.name_qualifier}" SPNameQualifier="#{self.issuer}" Format="#{self.name_identifier_format}">#{self.name_id}</saml:NameID>
           <samlp:SessionIndex>#{self.session_index}</samlp:SessionIndex>

data/lib/onelogin/saml/logout_response.rb

@@ -20,8 +20,8 @@ module Onelogin::Saml
 
     def generate
       <<-XML
-        <samlp:LogoutResponse xmlns:samlp="#{Onelogin::NAMESPACES['samlp']}" xmlns:saml="#{Onelogin::NAMESPACES['saml']}" ID="#{self.id}" Version="2.0" IssueInstant="#{self.issue_instant}" Destination="#{self.destination}" InResponseTo="#{self.in_response_to}">
-          <saml:Issuer>#{self.issuer}</saml:Issuer>
+        <samlp:LogoutResponse xmlns:samlp="#{Onelogin::NAMESPACES['samlp']}" xmlns:saml="#{Onelogin::NAMESPACES['saml']}" ID="#{self.id}" Version="2.0" IssueInstant="#{self.issue_instant}" Destination="#{CGI.escapeHTML(self.destination)}" InResponseTo="#{self.in_response_to}">
+          <saml:Issuer>#{CGI.escapeHTML(self.issuer)}</saml:Issuer>
           <samlp:Status>
             <samlp:StatusCode Value="#{Onelogin::Saml::StatusCodes::SUCCESS_URI}"></samlp:StatusCode>
             <samlp:StatusMessage>#{STATUS_MESSAGE}</samlp:StatusMessage>

data/spec/logout_request_spec.rb

@@ -65,12 +65,12 @@ describe Onelogin::Saml::LogoutRequest do
     settings = Onelogin::Saml::Settings.new(
       :xmlsec_certificate => fixture_path("test1-cert.pem"),
       :xmlsec_privatekey => fixture_path("test1-key.pem"),
-      :idp_slo_target_url => "http://idp.example.com/saml2?existing=param",
+      :idp_slo_target_url => "http://idp.example.com/saml2?existing=param&existing=param",
       :idp_cert_fingerprint => 'def18dbed547cdf3d52b627f41637c443045fe33',
       :name_identifier_format => Onelogin::Saml::NameIdentifiers::UNSPECIFIED
     )
     request = Onelogin::Saml::LogoutRequest.generate(name_qualifier, name_id, session_index, settings)
-    expect(request.forward_url).to match(%r{^http://idp.example.com/saml2\?existing=param&})
+    expect(request.forward_url).to match(%r{^http://idp.example.com/saml2\?existing=param\&existing=param&})
     expect(verify_query_string_signature(settings, request.forward_url)).to be_true
   end
 

data/spec/logout_response_spec.rb

@@ -6,8 +6,8 @@ describe Onelogin::Saml::LogoutResponse do
   let(:id) { Onelogin::Saml::LogoutResponse.generate_unique_id(42) }
   let(:issue_instant) { Onelogin::Saml::LogoutResponse.get_timestamp }
   let(:in_response_to) { Onelogin::Saml::LogoutResponse.generate_unique_id(42) }
-  let(:idp_slo_target_url) { 'http://idp.example.com/saml2' }
-  let(:issuer) { 'http://idp.example.com/saml2' }
+  let(:idp_slo_target_url) { 'http://idp.example.com/saml2?existing=param&existing=param' }
+  let(:issuer) { 'http://idp.example.com/saml2?existing=param&existing=param' }
   let(:session) { {} }
 
   let(:settings) do
@@ -26,7 +26,7 @@ describe Onelogin::Saml::LogoutResponse do
 
   it "includes destination in the saml:LogoutRequest attributes" do
     value = xml.find_first('/samlp:LogoutResponse', Onelogin::NAMESPACES).attributes['Destination']
-    expect(value).to eq "http://idp.example.com/saml2"
+    expect(value).to eq "http://idp.example.com/saml2?existing=param&existing=param"
   end
 
   it "includes id in the saml:LogoutRequest attributes" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-saml-mod
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - OneLogin LLC
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: libxml-ruby