ruby-rails-extensions 1.1.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e8f9814c953c52a6b56ec84e47dcb454cfab59a93b0df09b9ab13c4316dde06
-  data.tar.gz: a048a5ade66c437bd04dabd3b144d91c60db8fc9743df5844731c7623ee8016a
+  metadata.gz: 55be0ba360ddc75f362e31c5e4dd863f6816b897e3fb722db748698a379e586f
+  data.tar.gz: 879cdcb54384e5927bacbad99714f54c2d737a86f55aac79d4f97d83de658b59
 SHA512:
-  metadata.gz: b3cbde7896d269f925aa33a25be9e7d9819a2ef351a4681b56f3afc1794c8e5d6c8e4104fd7b0570c9cd0ed3e30dcb2e1722442edb3b3322e031022500dd25ee
-  data.tar.gz: 74694442b83d70c7c7562838879014ecee55a5e9b66392be54414c20f1c6f7457375f9907ae11c2cc9a0787836deaa618c3ccc444516c50678abc53626915245
+  metadata.gz: 868b8f77e7e7ec4d974ac7af0e0f07352362d009ff1ab748868965a072f4c7cafd1ea9ec44ec30a6828f19a7d59a9ec1b4bafd7272a25fde053f7d442809f6ca
+  data.tar.gz: 43d272c9b3bc33ccceef003fc3f4e8be1bb3dd6ec83dd6b42879186e7c52dab68c57b0cfa8b6fe5a5660e756a06c0b2110fab411bed6d1e239b5866c8a310a58

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 Unreleased Changes
 ------------------
 
+2.0.0 (2024-07-26)
+------------------
+
+* Possible breaking change:
+  * The check for `method_defined?` was removed because the whole point of this gem is to define the methonds in that
+    block. This means there are some things assumed the developer using this gem already has, from this gem or rails,
+    e.g. `Enumerable#compact_blank_join` relies on `Enumerable#compact_blank`
+
 1.1.1 (2024-03-01)
 ------------------
 

data/lib/ruby-rails-extensions/extensions/all_keys.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
 Hash.class_eval do
-  unless method_defined?(:all_keys?)
-    # @see Enumerable#all?
-    def all_keys?(...)
-      keys.all?(...)
-    end
+  # @see Enumerable#all?
+  def all_keys?(...)
+    keys.all?(...)
   end
 end

data/lib/ruby-rails-extensions/extensions/all_values.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
 Hash.class_eval do
-  unless method_defined?(:all_values?)
-    # @see Enumerable#all?
-    def all_values?(...)
-      values.all?(...)
-    end
+  # @see Enumerable#all?
+  def all_values?(...)
+    values.all?(...)
   end
 end

data/lib/ruby-rails-extensions/extensions/any_key.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
 Hash.class_eval do
-  unless method_defined?(:any_key?)
-    # @see Enumerable#any?
-    def any_key?(...)
-      keys.any?(...)
-    end
+  # @see Enumerable#any?
+  def any_key?(...)
+    keys.any?(...)
   end
 end

data/lib/ruby-rails-extensions/extensions/any_value.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
 
 Hash.class_eval do
-  unless method_defined?(:any_value?)
-    # @see Enumerable#any?
-    def any_value?(...)
-      values.any?(...)
-    end
+  # @see Enumerable#any?
+  def any_value?(...)
+    values.any?(...)
   end
 end

data/lib/ruby-rails-extensions/extensions/assign_nil.rb

@@ -1,67 +1,62 @@
 # frozen_string_literal: true
 
-if defined?(ActiveModel::AttributeAssignment) && Hash.method_defined?(:stringify_keys)
-  module ActiveModel
-    module AttributeAssignment
-      unless method_defined?(:assign_nil_attributes)
-        # Allows you to set nil attributes by passing in a hash of attributes with
-        # keys matching the attribute names.
-        #
-        # @raise [ActiveModel::ForbiddenAttributesError] If the passed hash responds to `permitted?` method
-        #   and the return value of this method is +false+.
-        #
-        # @example
-        #
-        #   class Cat
-        #     include ActiveModel::AttributeAssignment
-        #     attr_accessor :name, :status
-        #   end
-        #
-        #   cat = Cat.new
-        #   cat.assign_nil_attributes(name: "Gorby")
-        #   cat.name # => 'Gorby'
-        #   cat.status # => nil
-        #   cat.assign_nil_attributes(status: "yawning")
-        #   cat.name # => 'Gorby'
-        #   cat.status # => 'yawning'
-        #   cat.assign_nil_attributes(status: "sleeping")
-        #   cat.name # => 'Gorby'
-        #   cat.status # => 'yawning'
-        #
-        # @param new_attributes
-        #
-        # @return [void]
-        #
-        def assign_nil_attributes(new_attributes)
-          unless new_attributes.respond_to?(:stringify_keys)
-            raise(ArgumentError, 'When assigning attributes, you must pass a hash as an argument.')
-          end
+# requires `ActiveModel::AttributeAssignment` and `Hash#stringify_keys`
+module ActiveModel
+  module AttributeAssignment
+    # Allows you to set nil attributes by passing in a hash of attributes with
+    # keys matching the attribute names.
+    #
+    # @raise [ActiveModel::ForbiddenAttributesError] If the passed hash responds to `permitted?` method
+    #   and the return value of this method is +false+.
+    #
+    # @example
+    #
+    #   class Cat
+    #     include ActiveModel::AttributeAssignment
+    #     attr_accessor :name, :status
+    #   end
+    #
+    #   cat = Cat.new
+    #   cat.assign_nil_attributes(name: "Gorby")
+    #   cat.name # => 'Gorby'
+    #   cat.status # => nil
+    #   cat.assign_nil_attributes(status: "yawning")
+    #   cat.name # => 'Gorby'
+    #   cat.status # => 'yawning'
+    #   cat.assign_nil_attributes(status: "sleeping")
+    #   cat.name # => 'Gorby'
+    #   cat.status # => 'yawning'
+    #
+    # @param new_attributes
+    #
+    # @return [void]
+    #
+    def assign_nil_attributes(new_attributes)
+      unless new_attributes.respond_to?(:stringify_keys)
+        raise(ArgumentError, 'When assigning attributes, you must pass a hash as an argument.')
+      end
 
-          return if new_attributes.empty?
+      return if new_attributes.empty?
 
-          attributes = new_attributes.stringify_keys
+      attributes = new_attributes.stringify_keys
 
-          _assign_nil_attributes(sanitize_for_mass_assignment(attributes))
-        end
-      end
+      _assign_nil_attributes(sanitize_for_mass_assignment(attributes))
+    end
 
-      private
+    private
 
-        unless private_method_defined?(:_assign_nil_attributes)
-          # Assign any `nil` attribute
-          #
-          # @param attributes [Hash]
-          #
-          # @return [void]
-          #
-          def _assign_nil_attributes(attributes)
-            attributes.each do |k, v|
-              next unless v.nil?
+      # Assign any `nil` attribute
+      #
+      # @param attributes [Hash]
+      #
+      # @return [void]
+      #
+      def _assign_nil_attributes(attributes)
+        attributes.each do |k, v|
+          next unless v.nil?
 
-              _assign_attribute(k, v)
-            end
-          end
+          _assign_attribute(k, v)
         end
-    end
+      end
   end
 end

data/lib/ruby-rails-extensions/extensions/clean_string.rb

@@ -1,41 +1,33 @@
 # frozen_string_literal: true
 
 String.class_eval do
-  unless method_defined?(:clean!)
-    # Remove all non-UTF-8 chars from a string.
-    #
-    # @param replace_with [String, nil] What to replace invalid chars with.
-    #
-    # @return [String]
-    #
-    def clean!(replace_with = '')
-      replace(encode('UTF-8', invalid: :replace, undef: :replace, replace: replace_with))
-    end
+  # Remove all non-UTF-8 chars from a string.
+  #
+  # @param replace_with [String, nil] What to replace invalid chars with.
+  #
+  # @return [String]
+  #
+  def clean!(replace_with = '')
+    replace(encode('UTF-8', invalid: :replace, undef: :replace, replace: replace_with))
   end
 
-  unless method_defined?(:clean)
-    # @see {#clean!}
-    def clean(replace_with = '')
-      dup.clean!(replace_with)
-    end
+  # @see {#clean!}
+  def clean(replace_with = '')
+    dup.clean!(replace_with)
   end
 
-  unless method_defined?(:clean_binary!)
-    # Remove all non-UTF-8 chars from a string and convert to binary.
-    #
-    # @param replace_with [String, nil] What to replace invalid chars with.
-    #
-    # @return [String]
-    #
-    def clean_binary!(replace_with = '')
-      replace(encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: replace_with))
-    end
+  # Remove all non-UTF-8 chars from a string and convert to binary.
+  #
+  # @param replace_with [String, nil] What to replace invalid chars with.
+  #
+  # @return [String]
+  #
+  def clean_binary!(replace_with = '')
+    replace(encode('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: replace_with))
   end
 
-  unless method_defined?(:clean_binary)
-    # @see {#clean_binary!}
-    def clean_binary(replace_with = '')
-      dup.clean_binary!(replace_with)
-    end
+  # @see {#clean_binary!}
+  def clean_binary(replace_with = '')
+    dup.clean_binary!(replace_with)
   end
 end

data/lib/ruby-rails-extensions/extensions/compact_blank_join.rb

@@ -1,13 +1,11 @@
 # frozen_string_literal: true
 
 Enumerable.class_eval do
-  if method_defined?(:compact_blank) && !method_defined?(:compact_blank_join)
-    # Joins the elements together after calling `compact_blank`
-    #
-    # @return [String]
-    #
-    def compact_blank_join(using = '')
-      compact_blank.join(using)
-    end
+  # Joins the elements together after calling `compact_blank`
+  #
+  # @return [String]
+  #
+  def compact_blank_join(using = '')
+    compact_blank.join(using)
   end
 end

data/lib/ruby-rails-extensions/extensions/compact_map.rb

@@ -4,26 +4,22 @@ require 'forwardable'
 require 'set'
 
 Array.class_eval do
-  unless method_defined?(:compact_map)
-    # @return [Array]
-    # Similar to `filter_map` but excludes `nil` instead of falsy
-    def compact_map
-      return to_enum(:compact_map) unless block_given?
+  # @return [Array]
+  # Similar to `filter_map` but excludes `nil` instead of falsy
+  def compact_map
+    return to_enum(:compact_map) unless block_given?
 
-      r = []
-      each do |*args|
-        result = yield(*args)
-        r.push(result) unless result.nil?
-      end
-      r
+    r = []
+    each do |*args|
+      result = yield(*args)
+      r.push(result) unless result.nil?
     end
+    r
   end
 end
 
 Set.class_eval do
-  unless method_defined?(:compact_map)
-    extend Forwardable
+  extend Forwardable
 
-    def_delegators :to_a, :compact_map
-  end
+  def_delegators :to_a, :compact_map
 end

data/lib/ruby-rails-extensions/extensions/current_day.rb

@@ -3,10 +3,8 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:current_day)
-    # :nodoc:
-    def current_day
-      beginning_of_day..end_of_day
-    end
+  # :nodoc:
+  def current_day
+    beginning_of_day..end_of_day
   end
 end

data/lib/ruby-rails-extensions/extensions/current_month.rb

@@ -3,19 +3,15 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:current_month)
-    # :nodoc:
-    def current_month
-      beginning_of_month..end_of_month
-    end
+  # :nodoc:
+  def current_month
+    beginning_of_month..end_of_month
   end
 end
 
 Date.class_eval do
-  unless method_defined?(:current_month)
-    # :nodoc:
-    def current_month
-      beginning_of_month..end_of_month
-    end
+  # :nodoc:
+  def current_month
+    beginning_of_month..end_of_month
   end
 end

data/lib/ruby-rails-extensions/extensions/current_week.rb

@@ -3,19 +3,15 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:current_week)
-    # @return Range<DateTime>
-    def current_week
-      beginning_of_week..end_of_week
-    end
+  # @return Range<DateTime>
+  def current_week
+    beginning_of_week..end_of_week
   end
 end
 
 Date.class_eval do
-  unless method_defined?(:current_week)
-    # @return Range<Date>
-    def current_week
-      beginning_of_week..end_of_week
-    end
+  # @return Range<Date>
+  def current_week
+    beginning_of_week..end_of_week
   end
 end

data/lib/ruby-rails-extensions/extensions/day_of_week.rb

@@ -3,19 +3,15 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:day_of_week)
-    # @return [String] - Full day word
-    def day_of_week
-      strftime('%A')
-    end
+  # @return [String] - Full day word
+  def day_of_week
+    strftime('%A')
   end
 end
 
 Date.class_eval do
-  unless method_defined?(:day_of_week)
-    # @return [String] - Full day word
-    def day_of_week
-      strftime('%A')
-    end
+  # @return [String] - Full day word
+  def day_of_week
+    strftime('%A')
   end
 end

data/lib/ruby-rails-extensions/extensions/display_military.rb

@@ -3,19 +3,15 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:display_military)
-    # @return [String]
-    def display_military(all = false)
-      strftime(all ? '%m/%d/%Y %T' : '%-m/%-d/%y %T')
-    end
+  # @return [String]
+  def display_military(all = false)
+    strftime(all ? '%m/%d/%Y %T' : '%-m/%-d/%y %T')
   end
 end
 
 Time.class_eval do
-  unless method_defined?(:display_military)
-    # @return [String]
-    def display_military(all = false)
-      to_datetime.display_military(all)
-    end
+  # @return [String]
+  def display_military(all = false)
+    to_datetime.display_military(all)
   end
 end

data/lib/ruby-rails-extensions/extensions/display_user.rb

@@ -3,28 +3,22 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:display_user)
-    # @return [String] - mm/dd/yyyy HH:MM:SS AM/PM or m/d/yy HH:MM:SS AM/PM
-    def display_user(all = false)
-      strftime(all ? '%m/%d/%Y %r' : '%-m/%-d/%y %r')
-    end
+  # @return [String] - mm/dd/yyyy HH:MM:SS AM/PM or m/d/yy HH:MM:SS AM/PM
+  def display_user(all = false)
+    strftime(all ? '%m/%d/%Y %r' : '%-m/%-d/%y %r')
   end
 end
 
 Time.class_eval do
-  unless method_defined?(:display_user)
-    # @return [String] - mm/dd/yyyy or m/d/yy
-    def display_user(all = false)
-      to_datetime.display_user(all)
-    end
+  # @return [String] - mm/dd/yyyy or m/d/yy
+  def display_user(all = false)
+    to_datetime.display_user(all)
   end
 end
 
 Date.class_eval do
-  unless method_defined?(:display_user)
-    # @return [String] - mm/dd/yyyy or m/d/yy
-    def display_user(all = false)
-      strftime(all ? '%m/%d/%Y' : '%-m/%-d/%y')
-    end
+  # @return [String] - mm/dd/yyyy or m/d/yy
+  def display_user(all = false)
+    strftime(all ? '%m/%d/%Y' : '%-m/%-d/%y')
   end
 end

data/lib/ruby-rails-extensions/extensions/find_bang.rb

@@ -4,21 +4,17 @@ require 'forwardable'
 require 'set'
 
 Array.class_eval do
-  unless method_defined?(:find!)
-    # :nodoc:
-    def find!(&block)
-      x = find(&block)
-      raise(RubyRailsExtensions::Errors::NotFoundError, 'Not found') if x.nil?
+  # :nodoc:
+  def find!(&block)
+    x = find(&block)
+    raise(RubyRailsExtensions::Errors::NotFoundError, 'Not found') if x.nil?
 
-      x
-    end
+    x
   end
 end
 
 Set.class_eval do
-  unless method_defined?(:find!)
-    extend Forwardable
+  extend Forwardable
 
-    def_delegators :to_a, :find!
-  end
+  def_delegators :to_a, :find!
 end

data/lib/ruby-rails-extensions/extensions/find_dupes.rb

@@ -1,16 +1,14 @@
 # frozen_string_literal: true
 
 Array.class_eval do
-  unless method_defined?(:find_dupes)
-    # @param threshold [Integer] default 1
-    #
-    # @return [Array] excluding items that appear more than `threshold` times
-    #
-    def find_dupes(threshold = 1)
-      results = select { |item| count(item) > threshold }
-      results.uniq!
+  # @param threshold [Integer] default 1
+  #
+  # @return [Array] excluding items that appear more than `threshold` times
+  #
+  def find_dupes(threshold = 1)
+    results = select { |item| count(item) > threshold }
+    results.uniq!
 
-      results
-    end
+    results
   end
 end

data/lib/ruby-rails-extensions/extensions/first_dupe.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
 Array.class_eval do
-  unless method_defined?(:first_dupe)
-    # @param threshold [Integer] default 1
-    # @return [*] first items that appears more than `threshold` times
-    def first_dupe(threshold = 1)
-      find { |item| count(item) > threshold }
-    end
+  # @param threshold [Integer] default 1
+  # @return [*] first items that appears more than `threshold` times
+  def first_dupe(threshold = 1)
+    find { |item| count(item) > threshold }
   end
 end

data/lib/ruby-rails-extensions/extensions/google_format.rb

@@ -3,10 +3,8 @@
 require 'date'
 
 DateTime.class_eval do
-  unless method_defined?(:google_format)
-    # @return [String] yyyy-mm-ddThh:mm:ss+hhmm
-    def google_format
-      strftime('%FT%T%z')
-    end
+  # @return [String] yyyy-mm-ddThh:mm:ss+hhmm
+  def google_format
+    strftime('%FT%T%z')
   end
 end

data/lib/ruby-rails-extensions/extensions/hash_only.rb

@@ -1,27 +1,23 @@
 # frozen_string_literal: true
 
 Hash.class_eval do
-  unless method_defined?(:only)
-    # The opposite of +Hash.except+.
-    # ~/.rvm/gems/ruby-2.1.2/gems/activesupport-4.2.5/lib/active_support/core_ext/hash/except.rb
-    # https://apidock.com/rails/Hash/except
-    #
-    # Selects only the supplied keys.
-    #
-    # http://api.rubyonrails.org/classes/Hash.html#method-i-slice
-    #
-    def only(*keys)
-      slice(*keys)
-    end
+  # The opposite of +Hash.except+.
+  # ~/.rvm/gems/ruby-2.1.2/gems/activesupport-4.2.5/lib/active_support/core_ext/hash/except.rb
+  # https://apidock.com/rails/Hash/except
+  #
+  # Selects only the supplied keys.
+  #
+  # http://api.rubyonrails.org/classes/Hash.html#method-i-slice
+  #
+  def only(*keys)
+    slice(*keys)
   end
 
-  unless method_defined?(:only!)
-    # See +only+
-    #
-    # http://apidock.com/rails/v4.1.8/Hash/extract%21
-    #
-    def only!(*keys)
-      slice!(*keys)
-    end
+  # See +only+
+  #
+  # http://apidock.com/rails/v4.1.8/Hash/extract%21
+  #
+  def only!(*keys)
+    slice!(*keys)
   end
 end

data/lib/ruby-rails-extensions/extensions/humanize_symbol.rb

@@ -3,9 +3,7 @@
 require 'forwardable'
 
 Symbol.class_eval do
-  unless method_defined?(:humanize)
-    extend Forwardable
+  extend Forwardable
 
-    def_delegators :to_s, :humanize
-  end
+  def_delegators :to_s, :humanize
 end