ruby-pwsh 0.10.2 → 0.11.0.rc.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0192c9fd1e6f719c01cfbc185c847943ec0878c1fbfda56749a52dfd5d7fca7
-  data.tar.gz: 5d40c16d7f2efe2585a0c65d0e6050aaa72e4083510cbac376038a85ec725264
+  metadata.gz: a3357d3c933ddf7b2ecce5d3be1958e9d6aaf6b9966f0b4e4d1f45c40f13963c
+  data.tar.gz: 59e415fc5c1804e09c481bfb6a3c8aa58a7b9767dd04f0a31b3f65c6986ab9c0
 SHA512:
-  metadata.gz: 1e1356eb57e96fa78906861bdd6bf887c5f9eb14175f5408e4db779a3b66ac1bc9bf92d1436f36d019da8b3e18f0bfbc175170d8e3058eff6c3e51235b433ac0
-  data.tar.gz: de4bdce317e05453eb9179df50f065c09c16da4529b304ed0adb7e4becc3c8378ea0f67d69444209ac72d6a5f19881b594f624c311412e8fa32fdcb4bdb9b34d
+  metadata.gz: dd03304fb4b624296d2770b33296464ca7968e0d1f3b5ee31ddad4490892fcefeca55359447dad2389fb7123bb6b95f42d287f1dd29c50a4ccdd0244338d862e
+  data.tar.gz: 0a4c863c752858ee96975d0278220ca914ba1ea5e02bddd57ab8c798b23c775c2914e81a67482c3bfa5b54af64e0f55946e99af0c2d0fef2b7470c3aec379c86

data/.rubocop.yml

@@ -1,41 +1,19 @@
-Gemspec/RequiredRubyVersion:
-  Enabled: false
-Layout/EndOfLine:
-  Description: Don't enforce CRLF on Windows.
-  Enabled: false
-Metrics/LineLength:
-  Description: People have wide screens, use them.
-  Max: 200
-Metrics/BlockLength:
-  Enabled: false
-Metrics/MethodLength:
-  Enabled: false
-Metrics/ClassLength:
-  Enabled: false
-Metrics/PerceivedComplexity:
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Enabled: false
-Metrics/AbcSize:
-  Enabled: false
+inherit_from: .rubocop_todo.yml
 
-# requires 2.3's squiggly HEREDOC support, which we can't use, yet
-# see http://www.virtuouscode.com/2016/01/06/about-the-ruby-squiggly-heredoc-syntax/
-Layout/HeredocIndentation:
-  Enabled: false
-# Need to ignore rubocop complaining about the name of the library.
-Naming/FileName:
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
+AllCops:
   Exclude:
-    - lib/ruby-pwsh.rb
-Style/RescueStandardError:
-  Enabled: false
-Style/ExpandPathArguments:
-  Enabled: false
-Style/Documentation:
-  Enabled: false
+    - Gemfile
+    - Rakefile
+    - spec/fixtures/**/*
+    - vendor/bundle/**/*
+  NewCops: enable
+  SuggestExtensions: false
+  TargetRubyVersion: '2.7'
+
+# Disabled
 Style/ClassAndModuleChildren:
-  Exclude:
-    - lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb
-Style/ClassVars:
-  Exclude:
-    - lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb
+  Enabled: false

data/README.md

@@ -74,47 +74,51 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 Steps to release an update to the gem and module include:
 
-1. Ensure that the release branch is up to date with the main:
+1. From main, checkout a new working branch for the release prep (where xyz is the appropriate version, sans periods):
    ```bash
-   git push upstream upstream/main:release --force
+   git checkout -b maint-release_prep_xyz
    ```
-1. Checkout a new working branch for the release prep (where xyz is the appropriate version, sans periods):
-   ```bash
-   git checkout -b maint/release/prep-xyz upstream/release
-   ```
-1. Update the version in `lib/pwsh/version.rb` and `metadata.json` to the appropriate version for the new release.
-1. Run the changelog update task (make sure to verify the changelog, correctly tagging PRs as needed):
+
+2. Update the version in `lib/pwsh/version.rb` and `metadata.json` to the appropriate version for the new release.
+
+3. Run the changelog update task (make sure to verify the changelog, correctly tagging PRs as needed):
    ```bash
    bundle exec rake changelog
    ```
-1. Commit your changes with a short, sensible commit message, like:
-   ```text
+
+   4. Commit your changes with a short, sensible commit message, like:
+   ```bash
    git add lib/pwsh/version.rb
    git add metadata.json
    git add CHANGELOG.md
    git commit -m '(MAINT) Prep for x.y.z release'
    ```
-1. Push your changes and submit a pull request for review _against the **release** branch_:
-   ```bash
-   git push -u origin maint/release/prep-xyz
-   ```
-1. Ensure tests pass and the code is merged to `release`.
-1. Grab the commit hash from the merge commit on release, use that as the tag for the version (replacing `x.y.z` with the appropriate version and  `commithash` with the relevant one), then push the tags to upstream:
+
+5. Push your changes and submit a pull request for review _against main:
    ```bash
-   bundle exec rake tag['x.y.z', 'commithash']
+   git push -u origin maint_release_prep_xyz
    ```
-1. Build the Ruby gem and publish:
+
+6. Ensure tests pass and the code is merged to `main`.
+
+7. Once the release_prep PR has been merged, checkout main and pull down the latests changes.
    ```bash
-   bundle exec rake build
-   bundle exec rake push['ruby-pwsh-x.y.z.gem']
+   git checkout main
+   git pull
    ```
-1. Verify that the correct version now exists on [RubyGems](https://rubygems.org/search?query=ruby-pwsh)
-1. Build the Puppet module:
+
+8. Assuming that the release_prep merge commit is at the HEAD of main we can simply create and push a tag as follows (replacing xyz with the appropriate version).
    ```bash
-   bundle exec rake build_module
+   git tag -a xyx -m "Release xyz"
+   git push --follow-tags
    ```
-1. Publish the updated module version (found in the `pkg` folder) to [the Forge](https://forge.puppet.com/puppetlabs/pwshlib).
-1. Submit the [mergeback PR from the release branch to main](https://github.com/puppetlabs/ruby-pwsh/compare/main...release).
+
+9. Execute the publish workflow. This will:
+   - Create a GitHub release
+   - Build and publish the Gem
+   - Build and publish the Puppet module
+
+10. Finally check that the expected versions are present on rubygems.org and the Forge.
 
 ## Known Issues
 

data/lib/puppet/provider/dsc_base_provider/dsc_base_provider.rb

@@ -79,13 +79,16 @@ class Puppet::Provider::DscBaseProvider
             end
             downcased_result = recursively_downcase(canonicalized)
             downcased_resource = recursively_downcase(r)
+            # Ensure that metaparameters are preserved when we canonicalize the resource.
+            metaparams = downcased_resource.select { |key, _value| Puppet::Type.metaparam?(key) }
+            canonicalized.merge!(metaparams) unless metaparams.nil?
             downcased_result.each do |key, value|
               # Canonicalize to the manifest value unless the downcased strings match and the attribute is not an enum:
               # - When the values don't match at all, the manifest value is desired;
               # - When the values match case insensitively but the attribute is an enum, prefer the casing of the manifest enum.
               # - When the values match case insensitively and the attribute is not an enum, prefer the casing from invoke_get_method
               canonicalized[key] = r[key] unless same?(value, downcased_resource[key]) && !enum_attributes(context).include?(key)
-              canonicalized.delete(key) unless downcased_resource.keys.include?(key)
+              canonicalized.delete(key) unless downcased_resource.key?(key)
             end
             # Cache the actually canonicalized resource separately
             @@cached_canonicalized_resource << canonicalized.dup
@@ -131,7 +134,7 @@ class Puppet::Provider::DscBaseProvider
         (mandatory_get_attributes(context) - namevar_attributes(context)).include?(attribute)
       end
       # If dsc_psdscrunascredential was specified, re-add it here.
-      mandatory_properties[:dsc_psdscrunascredential] = canonicalized_resource[:dsc_psdscrunascredential] if canonicalized_resource.keys.include?(:dsc_psdscrunascredential)
+      mandatory_properties[:dsc_psdscrunascredential] = canonicalized_resource[:dsc_psdscrunascredential] if canonicalized_resource.key?(:dsc_psdscrunascredential)
     end
     names.collect do |name|
       name = { name: name } if name.is_a? String
@@ -250,7 +253,7 @@ class Puppet::Provider::DscBaseProvider
 
     begin
       data = JSON.parse(output)
-    rescue => e
+    rescue StandardError => e
       context.err(e)
       return nil
     end
@@ -260,7 +263,7 @@ class Puppet::Provider::DscBaseProvider
     unless error.nil? || error.empty?
       # NB: We should have a way to stop processing this resource *now* without blowing up the whole Puppet run
       # Raising an error stops processing but blows things up while context.err alerts but continues to process
-      if error =~ /Logon failure: the user has not been granted the requested logon type at this computer/
+      if error.include?('Logon failure: the user has not been granted the requested logon type at this computer')
         logon_error = "PSDscRunAsCredential account specified (#{name_hash[:dsc_psdscrunascredential]['user']}) does not have appropriate logon rights; are they an administrator?"
         name_hash[:name].nil? ? context.err(logon_error) : context.err(name_hash[:name], logon_error)
         @@logon_failures << name_hash[:dsc_psdscrunascredential].dup
@@ -340,19 +343,19 @@ class Puppet::Provider::DscBaseProvider
       end
       # PowerShell does not distinguish between a return of empty array/string
       #  and null but Puppet does; revert to those values if specified.
-      data[type_key] = [] if data[type_key].nil? && query_props.keys.include?(type_key) && query_props[type_key].is_a?(Array)
+      data[type_key] = [] if data[type_key].nil? && query_props.key?(type_key) && query_props[type_key].is_a?(Array)
     end
     # If a resource is found, it's present, so refill this Puppet-only key
-    data.merge!({ name: name_hash[:name] })
+    data[:name] = name_hash[:name]
 
     # Have to check for this to avoid a weird canonicalization warning
     # The Resource API calls canonicalize against the current state which
     # will lead to dsc_ensure being set to absent in the name_hash even if
     # it was set to present in the manifest
-    name_hash_has_nil_keys = name_hash.select { |_k, v| v.nil? }.count.positive?
+    name_hash_has_nil_keys = name_hash.count { |_k, v| v.nil? }.positive?
     # We want to throw away all of the empty keys if and only if the manifest
     # declaration is for an absent resource and the resource is actually absent
-    data.reject! { |_k, v| v.nil? } if data[:dsc_ensure] == 'Absent' && name_hash[:dsc_ensure] == 'Absent' && !name_hash_has_nil_keys
+    data.compact! if data[:dsc_ensure] == 'Absent' && name_hash[:dsc_ensure] == 'Absent' && !name_hash_has_nil_keys
 
     # Sort the return for order-insensitive nested enumerable comparison:
     data = recursively_sort(data)
@@ -448,7 +451,7 @@ class Puppet::Provider::DscBaseProvider
     # path to allow multiple modules to with shared dsc_resources to be installed side by side
     # The old vendored_modules_path: puppet_x/dsc_resources
     # The new vendored_modules_path: puppet_x/<module_name>/dsc_resources
-    root_module_path = load_path.select { |path| path.match?(%r{#{puppetize_name(module_name)}/lib}) }.first
+    root_module_path = load_path.find { |path| path.match?(%r{#{puppetize_name(module_name)}/lib}) }
     vendored_path = if root_module_path.nil?
                       File.expand_path(Pathname.new(__FILE__).dirname + '../../../' + "puppet_x/#{puppetize_name(module_name)}/dsc_resources") # rubocop:disable Style/StringConcatenation
                     else
@@ -498,7 +501,7 @@ class Puppet::Provider::DscBaseProvider
   # @return [String] a uuid with underscores instead of dashes.
   def random_variable_name
     # PowerShell variables can't include dashes
-    SecureRandom.uuid.gsub('-', '_')
+    SecureRandom.uuid.tr('-', '_')
   end
 
   # Return a Hash containing all of the variables defined for instantiation as well as the Ruby hash for their
@@ -637,7 +640,7 @@ class Puppet::Provider::DscBaseProvider
   # @param context [Object] the Puppet runtime context to operate in and send feedback to
   # @return [Array] returns an array of attribute names as symbols which are enums
   def enum_attributes(context)
-    context.type.attributes.select { |_name, properties| properties[:type].match(/Enum\[/) }.keys
+    context.type.attributes.select { |_name, properties| properties[:type].include?('Enum[') }.keys
   end
 
   # Look through a fully formatted string, replacing all instances where a value matches the formatted properties
@@ -667,7 +670,7 @@ class Puppet::Provider::DscBaseProvider
   def munge_psmodulepath(resource)
     return unless resource[:dscmeta_resource_implementation] == 'Class'
 
-    vendor_path = resource[:vendored_modules_path].gsub('/', '\\')
+    vendor_path = resource[:vendored_modules_path].tr('/', '\\')
     <<~MUNGE_PSMODULEPATH.strip
       $UnmungedPSModulePath = [System.Environment]::GetEnvironmentVariable('PSModulePath','machine')
       $MungedPSModulePath = $env:PSModulePath + ';#{vendor_path}'
@@ -728,7 +731,7 @@ class Puppet::Provider::DscBaseProvider
       # name = property_name.to_s.gsub(/^dsc_/, '').to_sym
       # Process nested CIM instances first as those neeed to be passed to higher-order
       # instances and must therefore be declared before they must be referenced
-      cim_instance_hashes = nested_cim_instances(property_hash[:value]).flatten.reject(&:nil?)
+      cim_instance_hashes = nested_cim_instances(property_hash[:value]).flatten.compact
       # Sometimes the instances are an empty array
       unless cim_instance_hashes.count.zero?
         cim_instance_hashes.each do |instance|
@@ -740,7 +743,7 @@ class Puppet::Provider::DscBaseProvider
         end
       end
       # We have to handle arrays of CIM instances slightly differently
-      if property_hash[:mof_type] =~ /\[\]$/
+      if /\[\]$/.match?(property_hash[:mof_type])
         class_name = property_hash[:mof_type].gsub('[]', '')
         property_hash[:value].each do |hash|
           variable_name = random_variable_name
@@ -844,7 +847,7 @@ class Puppet::Provider::DscBaseProvider
       params_block = params_block.gsub("#{param_block_name} = @()", "#{param_block_name} = [#{properties[:mof_type]}]@()")
     end
     # HACK: make CIM instances work:
-    resource[:parameters].select { |_key, hash| hash[:mof_is_embedded] && hash[:mof_type] =~ /\[\]/ }.each do |_property_name, property_hash|
+    resource[:parameters].select { |_key, hash| hash[:mof_is_embedded] && hash[:mof_type].include?('[]') }.each do |_property_name, property_hash|
       formatted_property_hash = interpolate_variables(format(property_hash[:value]))
       params_block = params_block.gsub(formatted_property_hash, "[CimInstance[]]#{formatted_property_hash}")
     end
@@ -858,7 +861,7 @@ class Puppet::Provider::DscBaseProvider
   # @param resource [Hash] a hash with the information needed to run `Invoke-DscResource`
   # @return [String] A string representing the PowerShell script which will invoke the DSC Resource.
   def ps_script_content(resource)
-    template_path = File.expand_path('../', __FILE__)
+    template_path = File.expand_path(__dir__)
     # Defines the helper functions
     functions     = File.new("#{template_path}/invoke_dsc_resource_functions.ps1").read
     # Defines the response hash and the runtime settings
@@ -885,7 +888,7 @@ class Puppet::Provider::DscBaseProvider
   def format(value)
     Pwsh::Util.format_powershell_value(value)
   rescue RuntimeError => e
-    raise unless e.message =~ /Sensitive \[value redacted\]/
+    raise unless e.message.include?('Sensitive [value redacted]')
 
     Pwsh::Util.format_powershell_value(unwrap(value))
   end
@@ -945,12 +948,12 @@ class Puppet::Provider::DscBaseProvider
   def handle_secrets(text, replacement, error_message)
     # Every secret unwrapped in this module will unwrap as "'secret#{SECRET_POSTFIX}'"
     # Currently, no known resources specify a SecureString instead of a PSCredential object.
-    return text unless text.match(/#{Regexp.quote(SECRET_POSTFIX)}/)
+    return text unless /#{Regexp.quote(SECRET_POSTFIX)}/.match?(text)
 
     # In order to reduce time-to-parse, look at each line individually and *only* attempt
     # to substitute if a naive match for the secret postfix is found on the line.
     modified_text = text.split("\n").map do |line|
-      if line.match(/#{Regexp.quote(SECRET_POSTFIX)}/)
+      if /#{Regexp.quote(SECRET_POSTFIX)}/.match?(line)
         line.gsub(SECRET_DATA_REGEX, replacement)
       else
         line
@@ -960,7 +963,7 @@ class Puppet::Provider::DscBaseProvider
     modified_text = modified_text.join("\n")
 
     # Something has gone wrong, error loudly
-    raise error_message if modified_text =~ /#{Regexp.quote(SECRET_POSTFIX)}/
+    raise error_message if /#{Regexp.quote(SECRET_POSTFIX)}/.match?(modified_text)
 
     modified_text
   end

data/lib/pwsh/version.rb

@@ -2,5 +2,5 @@
 
 module Pwsh
   # The version of the ruby-pwsh gem
-  VERSION = '0.10.2'
+  VERSION = '0.11.0.rc.1'
 end

data/lib/pwsh/windows_powershell.rb

@@ -82,7 +82,7 @@ if Pwsh::Util.on_windows?
           HKLM.open(PS_ONE_REG_PATH, ACCESS_TYPE) do |reg|
             version = reg[REG_KEY]
           end
-        rescue
+        rescue StandardError
           version = nil
         end
         version
@@ -98,7 +98,7 @@ if Pwsh::Util.on_windows?
           HKLM.open(PS_THREE_REG_PATH, ACCESS_TYPE) do |reg|
             version = reg[REG_KEY]
           end
-        rescue
+        rescue StandardError
           version = nil
         end
         version

data/lib/pwsh.rb

@@ -55,7 +55,7 @@ module Pwsh
         # ignore any errors trying to tear down this unusable instance
         begin
           manager.exit unless manager.nil? # rubocop:disable Style/SafeNavigation
-        rescue
+        rescue StandardError
           nil
         end
         @@instances[key] = Manager.new(cmd, args, options)
@@ -151,7 +151,7 @@ module Pwsh
                     UNIXSocket.new(pipe_path)
                   end
           break
-        rescue
+        rescue StandardError
           sleep sleep_interval
         end
       end
@@ -208,7 +208,6 @@ module Pwsh
       out[:stderr] = out[:stderr].nil? ? [] : [out[:stderr]]
       out[:stderr] += err unless err.nil?
       out[:native_stdout] = native_stdout
-
       out
     end
 
@@ -224,7 +223,7 @@ module Pwsh
       # rather than expecting the pipe.close to terminate it
       begin
         write_pipe(pipe_command(:exit)) unless @pipe.closed?
-      rescue
+      rescue StandardError
         nil
       end
 
@@ -245,8 +244,8 @@ module Pwsh
     # @return [String] full path to the bootstrap template
     def self.template_path
       # A PowerShell -File compatible path to bootstrap the instance
-      path = File.expand_path('../templates', __FILE__)
-      path = File.join(path, 'init.ps1').gsub('/', '\\')
+      path = File.expand_path('templates', __dir__)
+      path = File.join(path, 'init.ps1').tr('/', '\\')
       "\"#{path}\""
     end
 
@@ -268,7 +267,7 @@ module Pwsh
 
         # Lower bound protection. The polling resolution is only 50ms.
         timeout_ms = 50 if timeout_ms < 50
-      rescue
+      rescue StandardError
         timeout_ms = 300 * 1000
       end
 
@@ -308,17 +307,17 @@ module Pwsh
 
       # PS Side expects Invoke-PowerShellUserCode is always the return value here
       # TODO: Refactor to use <<~ as soon as we can :sob:
-      <<-CODE
-$params = @{
-  Code                     = @'
-#{powershell_code}
-'@
-  TimeoutMilliseconds      = #{timeout_ms}
-  WorkingDirectory         = "#{working_dir}"
-  AdditionalEnvironmentVariables = #{additional_environment_variables}
-}
-
-Invoke-PowerShellUserCode @params
+      <<~CODE
+        $params = @{
+          Code                     = @'
+        #{powershell_code}
+        '@
+          TimeoutMilliseconds      = #{timeout_ms}
+          WorkingDirectory         = "#{working_dir}"
+          AdditionalEnvironmentVariables = #{additional_environment_variables}
+        }
+
+        Invoke-PowerShellUserCode @params
       CODE
     end
 
@@ -336,10 +335,10 @@ Invoke-PowerShellUserCode @params
     #
     # @return [String] the absolute path to the PowerShell executable. Returns 'powershell.exe' if no more specific path found.
     def self.powershell_path
-      if File.exist?("#{ENV['SYSTEMROOT']}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe")
-        "#{ENV['SYSTEMROOT']}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe"
-      elsif File.exist?("#{ENV['SYSTEMROOT']}\\system32\\WindowsPowershell\\v1.0\\powershell.exe")
-        "#{ENV['SYSTEMROOT']}\\system32\\WindowsPowershell\\v1.0\\powershell.exe"
+      if File.exist?("#{ENV.fetch('SYSTEMROOT', nil)}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe")
+        "#{ENV.fetch('SYSTEMROOT', nil)}\\sysnative\\WindowsPowershell\\v1.0\\powershell.exe"
+      elsif File.exist?("#{ENV.fetch('SYSTEMROOT', nil)}\\system32\\WindowsPowershell\\v1.0\\powershell.exe")
+        "#{ENV.fetch('SYSTEMROOT', nil)}\\system32\\WindowsPowershell\\v1.0\\powershell.exe"
       else
         'powershell.exe'
       end
@@ -353,7 +352,7 @@ Invoke-PowerShellUserCode @params
       # Convert all the key names to upcase so we can be sure to find PATH etc.
       # Also while ruby can have difficulty changing the case of some UTF8 characters, we're
       # only going to use plain ASCII names so this is safe.
-      current_path = Pwsh::Util.on_windows? ? ENV.select { |k, _| k.upcase == 'PATH' }.values[0] : ENV['PATH']
+      current_path = Pwsh::Util.on_windows? ? ENV.select { |k, _| k.casecmp('PATH').zero? }.values[0] : ENV.fetch('PATH', nil)
       current_path = '' if current_path.nil?
 
       # Prefer any additional paths
@@ -367,10 +366,10 @@ Invoke-PowerShellUserCode @params
         # TODO: What about PS 8?
         # TODO: Need to check on French/Turkish windows if ENV['PROGRAMFILES'] parses UTF8 names correctly
         # TODO: Need to ensure ENV['PROGRAMFILES'] is case insensitive, i.e. ENV['PROGRAMFiles'] should also resolve on Windows
-        search_paths += ";#{ENV['PROGRAMFILES']}\\PowerShell\\6" \
-                        ";#{ENV['PROGRAMFILES(X86)']}\\PowerShell\\6" \
-                        ";#{ENV['PROGRAMFILES']}\\PowerShell\\7" \
-                        ";#{ENV['PROGRAMFILES(X86)']}\\PowerShell\\7"
+        search_paths += ";#{ENV.fetch('PROGRAMFILES', nil)}\\PowerShell\\6" \
+                        ";#{ENV.fetch('PROGRAMFILES(X86)', nil)}\\PowerShell\\6" \
+                        ";#{ENV.fetch('PROGRAMFILES', nil)}\\PowerShell\\7" \
+                        ";#{ENV.fetch('PROGRAMFILES(X86)', nil)}\\PowerShell\\7"
       end
       raise 'No paths discovered to search for Powershell!' if search_paths.split(File::PATH_SEPARATOR).empty?
 
@@ -433,7 +432,7 @@ Invoke-PowerShellUserCode @params
         # as this resolves to a HANDLE and then calls the Windows API
         !stream.stat.nil?
     # Any exceptions mean the stream is dead
-    rescue
+    rescue StandardError
       false
     end
 
@@ -497,9 +496,7 @@ Invoke-PowerShellUserCode @params
     #
     # @return nil
     def write_pipe(input)
-      # For Compat with Ruby 2.1 and lower, it's important to use syswrite and
-      # not write - otherwise, the pipe breaks after writing 1024 bytes.
-      written = @pipe.syswrite(input)
+      written = @pipe.write(input)
       @pipe.flush
 
       if written != input.length # rubocop:disable Style/GuardClause
@@ -541,7 +538,7 @@ Invoke-PowerShellUserCode @params
       read_from_pipe(pipe, 0) { |s| output << s } while self.class.readable?(pipe)
 
       # String has been binary up to this point, so force UTF-8 now
-      output == [] ? [] : [output.join('').force_encoding(Encoding::UTF_8)]
+      output == [] ? [] : [output.join.force_encoding(Encoding::UTF_8)]
     end
 
     # Open threads and pipes to read stdout and stderr from the PowerShell manager,
@@ -592,8 +589,8 @@ Invoke-PowerShellUserCode @params
 
       [
         output,
-        stdout == [] ? nil : stdout.join(''), # native stdout
-        stderr_reader.value                   # native stderr
+        stdout == [] ? nil : stdout.join, # native stdout
+        stderr_reader.value # native stderr
       ]
     ensure
       # Failsafe if the prior unlock was never reached / Mutex wasn't unlocked