ruby-progress 1.3.1 → 1.3.2

data/lib/ruby-progress/cli/fill_options.rb

@@ -28,6 +28,7 @@ module RubyProgress
           report: false
         }
 
+        # rubocop:disable Metrics/BlockLength
         begin
           OptionParser.new do |opts|
             opts.banner = 'Usage: prg fill [options]'
@@ -106,6 +107,14 @@ module RubyProgress
               options[:success_message] = msg
             end
 
+            opts.on('--success-icon ICON', 'Custom success icon to show with completion messages') do |ic|
+              options[:success_icon] = ic
+            end
+
+            opts.on('--error-icon ICON', 'Custom error icon to show with failure messages') do |ic|
+              options[:error_icon] = ic
+            end
+
             opts.on('--error MESSAGE', 'Error message to display on cancellation') do |msg|
               options[:error_message] = msg
             end
@@ -121,6 +130,21 @@ module RubyProgress
               options[:daemon] = true
             end
 
+            opts.on('--daemon-as NAME', 'Run in daemon mode with custom name (creates /tmp/ruby-progress/NAME.pid)') do |name|
+              options[:daemon] = true
+              options[:daemon_name] = name
+            end
+
+            # Accept --daemon-name as alias for --daemon-as
+            opts.on('--daemon-name NAME', 'Alias for --daemon-as (compat)') do |name|
+              options[:daemon] = true
+              options[:daemon_name] = name
+            end
+
+            opts.on('--no-detach', 'When used with --daemon/--daemon-as: run background child but do not fully detach from the terminal') do
+              options[:no_detach] = true
+            end
+
             opts.on('--pid-file FILE', 'PID file location (default: /tmp/ruby-progress/fill.pid)') do |file|
               options[:pid_file] = file
             end
@@ -129,10 +153,36 @@ module RubyProgress
               options[:stop] = true
             end
 
+            opts.on('--stop-id NAME', 'Stop daemon by name (implies --stop)') do |name|
+              # Backwards-compatible shorthand used in demos: set stop flag
+              options[:stop] = true
+              # Normalize to canonical keys used by FillCLI (daemon_name/status_name)
+              options[:stop_name] = name
+              options[:daemon_name] = name
+              options[:status_name] = name
+            end
+
             opts.on('--status', 'Show daemon status') do
               options[:status] = true
             end
 
+            opts.on('--status-id NAME', 'Show daemon status by name') do |name|
+              options[:status] = true
+              # Normalize to canonical key
+              options[:status_name] = name
+              options[:daemon_name] = name
+            end
+
+            opts.on('--stop-success MESSAGE', 'Stop daemon with success message (implies --stop)') do |msg|
+              options[:stop] = true
+              options[:stop_success] = msg
+            end
+            opts.on('--stop-error MESSAGE', 'Stop daemon with error message (implies --stop)') do |msg|
+              options[:stop] = true
+              options[:stop_error] = msg
+            end
+            opts.on('--stop-checkmark', 'When stopping, include a success checkmark') { options[:stop_checkmark] = true }
+
             opts.separator ''
             opts.separator 'General:'
 
@@ -148,6 +198,7 @@ module RubyProgress
               options[:help] = true
             end
           end.parse!
+        # rubocop:enable Metrics/BlockLength
         rescue OptionParser::InvalidOption => e
           warn "Invalid option: #{e.args.first}"
           warn ''
@@ -155,7 +206,6 @@ module RubyProgress
           warn "Run 'prg fill --help' for more information."
           exit 1
         end
-
         options
       end
 

data/lib/ruby-progress/cli/job_cli.rb

@@ -28,12 +28,43 @@ module JobCLI
       options = { wait: false }
       opt = OptionParser.new do |o|
         o.banner = 'Usage: prg job send [options]'
-        o.on('--pid-file PATH', 'Path to daemon pid file') { |v| options[:pid_file] = v }
-        o.on('--daemon-name NAME', 'Daemon name (maps to /tmp/ruby-progress/NAME.pid)') { |v| options[:daemon_name] = v }
-        o.on('--command CMD', 'Command to run') { |v| options[:command] = v }
-        o.on('--stdin', 'Read command from stdin (overrides --command)') { options[:stdin] = true }
-        o.on('--wait', 'Wait for result file and print it') { options[:wait] = true }
-        o.on('--timeout SECONDS', Integer, 'Timeout seconds for wait') { |v| options[:timeout] = v }
+        o.on('--pid-file PATH', 'Path to daemon pid file') do |v|
+          options[:pid_file] = v
+        end
+        o.on('--daemon-name NAME', 'Daemon name (maps to /tmp/ruby-progress/NAME.pid)') do |v|
+          options[:daemon_name] = v
+        end
+        o.on('--command CMD', 'Command to run') do |v|
+          options[:command] = v
+        end
+        o.on('--stdin', 'Read command from stdin (overrides --command)') do
+          options[:stdin] = true
+        end
+        o.on('--advance', 'Send an advance action (no value)') do
+          options[:action] = 'advance'
+        end
+        o.on('--percent N', Integer, 'Send a percent action with value N') do |v|
+          options[:action] = 'percent'
+          options[:value] = v
+        end
+        o.on('--complete', 'Send a complete action (no value)') do
+          options[:action] = 'complete'
+        end
+        o.on('--cancel', 'Send a cancel action (no value)') do
+          options[:action] = 'cancel'
+        end
+        o.on('--action ACTION', 'Send a custom action name') do |v|
+          options[:action] = v
+        end
+        o.on('--value VAL', 'Value for the action (string or number)') do |v|
+          options[:value] = v
+        end
+        o.on('--wait', 'Wait for result file and print it') do
+          options[:wait] = true
+        end
+        o.on('--timeout SECONDS', Integer, 'Timeout seconds for wait') do |v|
+          options[:timeout] = v
+        end
       end
 
       rest = opt.parse(argv)
@@ -63,16 +94,25 @@ module JobCLI
             opts[:command]
           end
 
-    unless cmd && !cmd.strip.empty?
-      warn 'No command specified. Use --command or --stdin.'
-      exit 1
+    is_action = !opts[:action].nil? && opts[:action] != false
+
+    if is_action
+      if cmd && !cmd.strip.empty?
+        warn 'Cannot specify both --command/--stdin and an action flag'
+        exit 1
+      end
+    else
+      unless cmd && !cmd.strip.empty?
+        warn 'No command specified. Use --command, --stdin, or pass an action flag.'
+        exit 1
+      end
     end
 
     job_id = SecureRandom.uuid
     tmp = File.join(job_dir, "#{job_id}.json.tmp")
     final = File.join(job_dir, "#{job_id}.json")
 
-    payload = { 'id' => job_id, 'command' => cmd }
+    payload = build_payload(opts, job_id, cmd)
 
     File.write(tmp, JSON.dump(payload))
     FileUtils.mv(tmp, final)
@@ -96,4 +136,24 @@ module JobCLI
       puts job_id
     end
   end
+
+  # Build the JSON payload for a job based on parsed options.
+  def self.build_payload(opts, job_id, cmd)
+    payload = { 'id' => job_id }
+
+    is_action = !opts[:action].nil? && opts[:action] != false
+
+    if is_action
+      payload['action'] = opts[:action]
+      if opts.key?(:value)
+        val = opts[:value]
+        payload['value'] = val.to_i if val.is_a?(String) && val =~ /^\d+$/
+        payload['value'] ||= val
+      end
+    else
+      payload['command'] = cmd
+    end
+
+    payload
+  end
 end

data/lib/ruby-progress/cli/ripple_cli.rb

@@ -33,8 +33,13 @@ module RippleCLI
       )
       exit
     elsif options[:daemon]
-      # For daemon mode, detach so shell has no tracked job
-      PrgCLI.daemonize
+      # For daemon mode, detach so shell has no tracked job unless the user
+      # requested a non-detaching background child via --no-detach.
+      if options[:no_detach]
+        PrgCLI.backgroundize
+      else
+        PrgCLI.daemonize
+      end
 
       # For daemon mode, default message if none provided
       text = options[:message] || ARGV.join(' ')
@@ -63,13 +68,17 @@ module RippleCLI
   end
 
   def self.run_with_command(text, options)
-    if $stdout.tty? && options[:output] == :stdout
+    if $stdout.tty?
+      # Interactive TTY: use PTY-based capture so the animation can run while the
+      # command executes. We only print captured stdout if options[:output] == :stdout.
       oc = RubyProgress::OutputCapture.new(command: options[:command], lines: options[:output_lines] || 3, position: options[:output_position] || :above)
       oc.start
 
-      # Create rippler and attach output capture so redraw occurs each frame
+      # Create rippler. Attach output capture only when the user requested
+      # live stdout display via --stdout; otherwise start the PTY reader so
+      # we can collect the child's exit status but do not call redraw.
       rippler = RubyProgress::Ripple.new(text, options)
-      rippler.instance_variable_set(:@output_capture, oc)
+      rippler.instance_variable_set(:@output_capture, oc) if options[:output] == :stdout
 
       thread = Thread.new { loop { rippler.advance } }
       oc.wait
@@ -77,17 +86,24 @@ module RippleCLI
 
       captured_lines = oc.lines
       captured_output = captured_lines.join("\n")
-      success = true
+      success = oc.exit_status.nil? || oc.exit_status.zero?
     else
-      # Fallback to legacy capture (non-interactive / CI)
+      # Non-interactive / CI: fallback to legacy synchronous capture
       captured_output = `#{options[:command]} 2>&1`
       success = $CHILD_STATUS.success?
     end
 
     puts captured_output if options[:output] == :stdout
+
     if options[:success_message] || options[:complete_checkmark]
       message = success ? options[:success_message] : options[:fail_message] || options[:success_message]
-      RubyProgress::Ripple.complete(text, message, options[:complete_checkmark], success)
+      RubyProgress::Ripple.complete(
+        text,
+        message,
+        options[:complete_checkmark],
+        success,
+        icons: { success: options[:success_icon], error: options[:error_icon] }
+      )
     end
     exit success ? 0 : 1
   end
@@ -147,7 +163,8 @@ module RippleCLI
               message,
               success: success_val,
               show_checkmark: check,
-              output_stream: :stdout
+              output_stream: :stdout,
+              icons: { success: options[:success_icon], error: options[:error_icon] }
             )
           end
         rescue StandardError
@@ -196,7 +213,8 @@ module RippleCLI
           job['message'],
           success: success,
           show_checkmark: job['checkmark'] || false,
-          output_stream: :stdout
+          output_stream: :stdout,
+          icons: { success: options[:success_icon], error: options[:error_icon] }
         )
       end
 

data/lib/ruby-progress/cli/ripple_options.rb

@@ -71,6 +71,14 @@ module RippleCLI
             options[:success_message] = msg
           end
 
+          opts.on('--success-icon ICON', 'Custom success icon to show with completion messages') do |ic|
+            options[:success_icon] = ic
+          end
+
+          opts.on('--error-icon ICON', 'Custom error icon to show with failure messages') do |ic|
+            options[:error_icon] = ic
+          end
+
           opts.on('--error MESSAGE', 'Error message to display') do |msg|
             options[:fail_message] = msg
           end
@@ -94,6 +102,10 @@ module RippleCLI
             options[:daemon] = true
           end
 
+          opts.on('--no-detach', 'When used with --daemon: run background child but do not fully detach from the terminal') do
+            options[:no_detach] = true
+          end
+
           opts.on('--pid-file FILE', 'Write process ID to file (default: /tmp/ruby-progress/progress.pid)') do |file|
             options[:pid_file] = file
           end

data/lib/ruby-progress/cli/twirl_options.rb

@@ -32,6 +32,12 @@ module TwirlCLI
           options[:style] = style
         end
 
+        opts.on('-d', '--direction DIRECTION', 'Animation direction (forward/bidirectional or f/b)') do |direction|
+          # Twirl is a spinner and doesn't visibly change with direction, but accept the
+          # flag for parity with other subcommands (Worm/Ripple) so scripts can use it.
+          options[:direction] = direction =~ /^f/i ? :forward_only : :bidirectional
+        end
+
         opts.on('--ends CHARS', 'Start/end characters (even number of chars, split in half)') do |chars|
           options[:ends] = chars
         end
@@ -55,6 +61,14 @@ module TwirlCLI
           options[:success] = text
         end
 
+        opts.on('--success-icon ICON', 'Custom success icon to show with completion messages') do |ic|
+          options[:success_icon] = ic
+        end
+
+        opts.on('--error-icon ICON', 'Custom error icon to show with failure messages') do |ic|
+          options[:error_icon] = ic
+        end
+
         opts.on('--error MESSAGE', 'Error message to display') do |text|
           options[:error] = text
         end
@@ -74,6 +88,10 @@ module TwirlCLI
           options[:daemon] = true
         end
 
+        opts.on('--no-detach', 'When used with --daemon/--daemon-as: run background child but do not fully detach from the terminal') do
+          options[:no_detach] = true
+        end
+
         opts.on('--daemon-as NAME', 'Run in daemon mode with custom name (creates /tmp/ruby-progress/NAME.pid)') do |name|
           options[:daemon] = true
           options[:daemon_name] = name

data/lib/ruby-progress/cli/twirl_runner.rb

@@ -58,7 +58,8 @@ module TwirlRunner
       RubyProgress::Utils.display_completion(
         final_msg,
         success: success,
-        show_checkmark: options[:checkmark]
+        show_checkmark: options[:checkmark],
+        icons: { success: options[:success_icon], error: options[:error_icon] }
       )
     end
 
@@ -78,7 +79,8 @@ module TwirlRunner
         RubyProgress::Utils.display_completion(
           options[:success] || 'Complete',
           success: true,
-          show_checkmark: options[:checkmark]
+          show_checkmark: options[:checkmark],
+          icons: { success: options[:success_icon], error: options[:error_icon] }
         )
       end
     end
@@ -124,7 +126,8 @@ module TwirlRunner
               job['message'],
               success: success,
               show_checkmark: job['checkmark'] || false,
-              output_stream: :stdout
+              output_stream: :stdout,
+              icons: { success: options[:success_icon], error: options[:error_icon] }
             )
           end
 
@@ -152,7 +155,8 @@ module TwirlRunner
               message,
               success: success_val,
               show_checkmark: check,
-              output_stream: :stdout
+              output_stream: :stdout,
+              icons: { success: options[:success_icon], error: options[:error_icon] }
             )
           end
         rescue StandardError

data/lib/ruby-progress/cli/twirl_spinner.rb

@@ -10,9 +10,23 @@ require_relative '../utils'
 class TwirlSpinner
   def initialize(message, options = {})
     @message = message
-    @style = parse_style(options[:style] || 'dots')
     @speed = parse_speed(options[:speed] || 'medium')
-    @frames = RubyProgress::INDICATORS[@style] || RubyProgress::INDICATORS[:dots]
+
+    style_opt = options[:style].to_s
+    if style_opt.start_with?('custom=')
+      chars = style_opt.sub('custom=', '')
+      @frames = if chars.length >= 3
+                  chars.chars
+                elsif chars.length == 2
+                  [chars[0], chars[1], chars[1]]
+                else
+                  [chars, chars, chars]
+                end
+      @style = :custom
+    else
+      @style = parse_style(style_opt.empty? ? 'dots' : style_opt)
+      @frames = RubyProgress::INDICATORS[@style] || RubyProgress::INDICATORS[:dots]
+    end
     @start_chars, @end_chars = RubyProgress::Utils.parse_ends(options[:ends])
     @index = 0
   end
@@ -36,6 +50,8 @@ class TwirlSpinner
 
     style_lower = style_input.to_s.downcase.strip
 
+    # parse_style returns a symbol key for RubyProgress::INDICATORS
+
     indicator_keys = RubyProgress::INDICATORS.keys.map(&:to_s)
     return style_lower.to_sym if indicator_keys.include?(style_lower)
 

data/lib/ruby-progress/cli/worm_cli.rb

@@ -33,8 +33,14 @@ module WormCLI
       )
       exit
     elsif options[:daemon]
-      # Detach before starting daemon logic so there's no tracked shell job
-      PrgCLI.daemonize
+      # Detach (or background without detaching) before starting daemon logic
+      # so the invoking shell/script continues immediately.
+      if options[:no_detach]
+        PrgCLI.backgroundize
+      else
+        PrgCLI.daemonize
+      end
+
       run_daemon_mode(options)
     else
       progress = RubyProgress::Worm.new(options)
@@ -86,7 +92,8 @@ module WormCLI
               job['message'],
               success: success,
               show_checkmark: job['checkmark'] || false,
-              output_stream: :stdout
+              output_stream: :stdout,
+              icons: { success: options[:success_icon], error: options[:error_icon] }
             )
           end
 
@@ -99,7 +106,8 @@ module WormCLI
       progress.run_daemon_mode(
         success_message: options[:success],
         show_checkmark: options[:checkmark],
-        control_message_file: RubyProgress::Daemon.control_message_file(pid_file)
+        control_message_file: RubyProgress::Daemon.control_message_file(pid_file),
+        icons: { success: options[:success_icon], error: options[:error_icon] }
       )
     ensure
       job_thread&.kill

data/lib/ruby-progress/cli/worm_options.rb

@@ -63,6 +63,14 @@ module WormCLI
             options[:success] = text
           end
 
+          opts.on('--success-icon ICON', 'Custom success icon to show with completion messages') do |ic|
+            options[:success_icon] = ic
+          end
+
+          opts.on('--error-icon ICON', 'Custom error icon to show with failure messages') do |ic|
+            options[:error_icon] = ic
+          end
+
           opts.on('--error MESSAGE', 'Error message to display') do |text|
             options[:error] = text
           end
@@ -93,6 +101,10 @@ module WormCLI
             options[:daemon_name] = name
           end
 
+          opts.on('--no-detach', 'When used with --daemon/--daemon-as: run background child but do not fully detach from the terminal') do
+            options[:no_detach] = true
+          end
+
           opts.on('--pid-file FILE', 'Write process ID to file (default: /tmp/ruby-progress/progress.pid)') do |file|
             options[:pid_file] = file
           end

data/lib/ruby-progress/cli/worm_runner.rb

@@ -1,7 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-# rubocop:disable Metrics/ModuleLength
 require 'open3'
 require 'json'
 require_relative '../utils'
@@ -120,7 +119,7 @@ module WormRunner
     @running = false
   end
 
-  def run_daemon_mode(success_message: nil, show_checkmark: false, control_message_file: nil)
+  def run_daemon_mode(success_message: nil, show_checkmark: false, control_message_file: nil, icons: {})
     @running = true
     stop_requested = false
 
@@ -163,7 +162,8 @@ module WormRunner
           final_message,
           success: final_success,
           show_checkmark: final_checkmark,
-          output_stream: :stdout
+          output_stream: :stdout,
+          icons: icons
         )
       end
 
@@ -278,5 +278,3 @@ module WormRunner
     dots.join
   end
 end
-
-# rubocop:enable Metrics/ModuleLength

data/lib/ruby-progress/fill.rb

@@ -95,7 +95,7 @@ module RubyProgress
     end
 
     # Complete the progress bar and show success message
-    def complete(message = nil)
+    def complete(message = nil, icons: {})
       @current_progress = @length
       render
 
@@ -105,7 +105,8 @@ module RubyProgress
           completion_message,
           success: true,
           show_checkmark: true,
-          output_stream: :warn
+          output_stream: :warn,
+          icons: icons
         )
       else
         $stderr.puts # Just add a newline if no message
@@ -124,7 +125,8 @@ module RubyProgress
         error_msg,
         success: false,
         show_checkmark: true,
-        output_stream: :warn
+        output_stream: :warn,
+        icons: {}
       )
     end