ruby-plsql 0.7.1 → 0.9.0

data/lib/plsql/procedure_call.rb

@@ -1,11 +1,16 @@
 module PLSQL
-  class ProcedureCall #:nodoc:
+  class ProcedureCall # :nodoc:
     def initialize(procedure, args = [], options = {})
       @procedure = procedure
       @schema = @procedure.schema
       @dbms_output_stream = @schema.dbms_output_stream
       @skip_self = options[:skip_self]
       @self = options[:self]
+
+      if args.size == 1 && args[0].is_a?(Hash) && args[0].keys.all? { |k| k.is_a?(Symbol) }
+        args[0] = args[0].map { |k, v| [k.downcase, v] }.to_h
+      end
+
       @overload = get_overload_from_arguments_list(args)
       @procedure.ensure_tmp_tables_created(@overload) if @procedure.respond_to?(:ensure_tmp_tables_created)
       construct_sql(args)
@@ -110,7 +115,7 @@ module PLSQL
       MATCHING_TYPES = {
         integer: ["NUMBER", "NATURAL", "NATURALN", "POSITIVE", "POSITIVEN", "SIGNTYPE", "SIMPLE_INTEGER", "PLS_INTEGER", "BINARY_INTEGER"],
         decimal: ["NUMBER", "BINARY_FLOAT", "BINARY_DOUBLE"],
-        string: ["VARCHAR", "VARCHAR2", "NVARCHAR2", "CHAR", "NCHAR", "CLOB", "BLOB", "XMLTYPE"],
+        string: ["VARCHAR", "VARCHAR2", "NVARCHAR2", "CHAR", "NCHAR", "CLOB", "BLOB", "XMLTYPE", "OPAQUE/XMLTYPE"],
         date: ["DATE"],
         time: ["DATE", "TIMESTAMP", "TIMESTAMP WITH TIME ZONE", "TIMESTAMP WITH LOCAL TIME ZONE"],
         boolean: ["PL/SQL BOOLEAN"],
@@ -144,10 +149,10 @@ module PLSQL
       end
 
       def construct_sql(args)
-        @declare_sql = ""
-        @assignment_sql = ""
-        @call_sql = ""
-        @return_sql = ""
+        @declare_sql = +""
+        @assignment_sql = +""
+        @call_sql = +""
+        @return_sql = +""
         @return_vars = []
         @return_vars_metadata = {}
 
@@ -213,7 +218,7 @@ module PLSQL
         end
         add_out_variables
 
-        @sql = @declare_sql.empty? ? "" : "DECLARE\n" << @declare_sql
+        @sql = @declare_sql.empty? ? +"" : +"DECLARE\n" << @declare_sql
         @sql << "BEGIN\n" << @assignment_sql << dbms_output_enable_sql << @call_sql << @return_sql << "END;\n"
       end
 
@@ -235,8 +240,8 @@ module PLSQL
           @bind_values[argument] = value.nil? ? nil : (value ? 1 : 0)
           @bind_metadata[argument] = argument_metadata.merge(data_type: "NUMBER", data_precision: 1)
           "l_#{argument}"
-        when "UNDEFINED"
-          if argument_metadata[:type_name] == "XMLTYPE"
+        when "UNDEFINED", "XMLTYPE", "OPAQUE/XMLTYPE"
+          if argument_metadata[:type_name] == "XMLTYPE" || argument_metadata[:data_type] =~ /XMLTYPE/
             @declare_sql << "l_#{argument} XMLTYPE;\n"
             @assignment_sql << "l_#{argument} := XMLTYPE(:#{argument});\n" if not value.nil?
             @bind_values[argument] = value if not value.nil?
@@ -321,7 +326,7 @@ module PLSQL
           "l_#{argument} #{argument_metadata[:sql_type_name]};\n"
         else
           fields_metadata = argument_metadata[:fields]
-          sql = "TYPE t_#{argument} IS RECORD (\n"
+          sql = +"TYPE t_#{argument} IS RECORD (\n"
           sql << record_fields_sorted_by_position(fields_metadata).map do |field|
             metadata = fields_metadata[field]
             "#{field} #{type_to_sql(metadata)}"
@@ -336,7 +341,7 @@ module PLSQL
       end
 
       def record_assignment_sql_values_metadata(argument, argument_metadata, record_value)
-        sql = ""
+        sql = +""
         bind_values = {}
         bind_metadata = {}
         (record_value || {}).each do |key, value|
@@ -390,8 +395,8 @@ module PLSQL
             end
           end
           "l_#{argument} := " if is_return_value
-        when "UNDEFINED"
-          if argument_metadata[:type_name] == "XMLTYPE"
+        when "UNDEFINED", "XMLTYPE", "OPAQUE/XMLTYPE"
+          if argument_metadata[:type_name] == "XMLTYPE" || argument_metadata[:data_type] =~ /XMLTYPE/
             @declare_sql << "l_#{argument} XMLTYPE;\n" if is_return_value
             bind_variable = :"o_#{argument}"
             @return_vars << bind_variable
@@ -512,8 +517,8 @@ module PLSQL
         when "PL/SQL BOOLEAN"
           numeric_value = @cursor[":o_#{argument}"]
           numeric_value.nil? ? nil : numeric_value == 1
-        when "UNDEFINED"
-          if argument_metadata[:type_name] == "XMLTYPE"
+        when "UNDEFINED", "XMLTYPE", "OPAQUE/XMLTYPE"
+          if argument_metadata[:type_name] == "XMLTYPE" || argument_metadata[:data_type] =~ /XMLTYPE/
             @cursor[":o_#{argument}"]
           end
         else

data/lib/plsql/schema.rb

@@ -4,8 +4,8 @@ module PLSQL
 
     @@schemas = {}
 
-    class <<self
-      def find_or_new(connection_alias) #:nodoc:
+    class << self
+      def find_or_new(connection_alias) # :nodoc:
         connection_alias ||= :default
         if @@schemas[connection_alias]
           @@schemas[connection_alias]
@@ -15,7 +15,7 @@ module PLSQL
       end
     end
 
-    def initialize(raw_conn = nil, schema = nil, original_schema = nil) #:nodoc:
+    def initialize(raw_conn = nil, schema = nil, original_schema = nil) # :nodoc:
       self.connection = raw_conn
       @schema_name = schema ? schema.to_s.upcase : nil
       @original_schema = original_schema
@@ -25,11 +25,11 @@ module PLSQL
     # Returns connection wrapper object (this is not raw OCI8 or JDBC connection!)
     attr_reader :connection
 
-    def root_schema #:nodoc:
+    def root_schema # :nodoc:
       @original_schema || self
     end
 
-    def raw_connection=(raw_conn) #:nodoc:
+    def raw_connection=(raw_conn) # :nodoc:
       @connection = raw_conn ? Connection.create(raw_conn) : nil
       reset_instance_variables
     end
@@ -99,8 +99,12 @@ module PLSQL
         @original_schema.default_timezone
       else
         @default_timezone ||
-          # Use ActiveRecord class default_timezone when ActiveRecord connection is used
-          (@connection && (ar_class = @connection.activerecord_class) && ar_class.default_timezone) ||
+          # Use ActiveRecord default_timezone when ActiveRecord connection is used,
+          # preferring the connection's activerecord_class so a subclass override
+          # (available in AR < 8.0) is honored before falling back to the
+          # module-level accessor (AR 7.0+; the only one in AR 8.0+).
+          (@connection && (ar_class = @connection.activerecord_class) &&
+            (ar_class.respond_to?(:default_timezone) ? ar_class.default_timezone : ActiveRecord.default_timezone)) ||
           # default to local timezone
           :local
       end
@@ -117,7 +121,7 @@ module PLSQL
 
     # Same implementation as for ActiveRecord
     # DateTimes aren't aware of DST rules, so use a consistent non-DST offset when creating a DateTime with an offset in the local zone
-    def local_timezone_offset #:nodoc:
+    def local_timezone_offset # :nodoc:
       ::Time.local(2007).utc_offset.to_r / 86400
     end
 
@@ -234,7 +238,7 @@ module PLSQL
       end
 
       def _errors(object_schema_name, object_name, object_type)
-        result = ""
+        result = +""
         previous_line = 0
         select_all(
           "SELECT e.line, e.position, e.text error_text, s.text source_text

data/lib/plsql/sequence.rb

@@ -1,5 +1,5 @@
 module PLSQL
-  module SequenceClassMethods #:nodoc:
+  module SequenceClassMethods # :nodoc:
     def find(schema, sequence)
       if schema.select_first(
         "SELECT sequence_name FROM all_sequences
@@ -27,7 +27,7 @@ module PLSQL
   class Sequence
     extend SequenceClassMethods
 
-    def initialize(schema, sequence, override_schema_name = nil) #:nodoc:
+    def initialize(schema, sequence, override_schema_name = nil) # :nodoc:
       @schema = schema
       @schema_name = override_schema_name || schema.schema_name
       @sequence_name = sequence.to_s.upcase

data/lib/plsql/table.rb

@@ -1,5 +1,5 @@
 module PLSQL
-  module TableClassMethods #:nodoc:
+  module TableClassMethods # :nodoc:
     def find(schema, table)
       if schema.select_first(
         "SELECT table_name FROM all_tables
@@ -33,9 +33,9 @@ module PLSQL
   class Table
     extend TableClassMethods
 
-    attr_reader :columns, :schema_name, :table_name #:nodoc:
+    attr_reader :columns, :schema_name, :table_name # :nodoc:
 
-    def initialize(schema, table, override_schema_name = nil) #:nodoc:
+    def initialize(schema, table, override_schema_name = nil) # :nodoc:
       @schema = schema
       @schema_name = override_schema_name || schema.schema_name
       @table_name = table.to_s.upcase
@@ -87,9 +87,9 @@ module PLSQL
     def select(first_or_all, sql_params = "", *bindvars)
       case first_or_all
       when :first, :all
-        select_sql = "SELECT * "
+        select_sql = +"SELECT * "
       when :count
-        select_sql = "SELECT COUNT(*) "
+        select_sql = +"SELECT COUNT(*) "
       else
         raise ArgumentError, "Only :first, :all or :count are supported"
       end
@@ -172,6 +172,7 @@ module PLSQL
       end
 
       table_proc = TableProcedure.new(@schema, self, :insert)
+      record = record.map { |k, v| [k.downcase.to_sym, v] }.to_h
       table_proc.add_insert_arguments(record)
 
       call = ProcedureCall.new(table_proc, table_proc.argument_values)
@@ -250,7 +251,7 @@ module PLSQL
     end
 
     # wrapper class to simulate Procedure class for ProcedureClass#exec
-    class TableProcedure #:nodoc:
+    class TableProcedure # :nodoc:
       attr_reader :arguments, :argument_list, :return, :out_list, :schema
 
       def initialize(schema, table, operation)

data/lib/plsql/type.rb

@@ -1,5 +1,5 @@
 module PLSQL
-  module TypeClassMethods #:nodoc:
+  module TypeClassMethods # :nodoc:
     def find(schema, type)
       if schema.select_first(
         "SELECT type_name FROM all_types
@@ -33,9 +33,9 @@ module PLSQL
   class Type
     extend TypeClassMethods
 
-    attr_reader :typecode, :attributes, :schema_name, :type_name, :type_object_id #:nodoc:
+    attr_reader :typecode, :attributes, :schema_name, :type_name, :type_object_id # :nodoc:
 
-    def initialize(schema, type, override_schema_name = nil) #:nodoc:
+    def initialize(schema, type, override_schema_name = nil) # :nodoc:
       @schema = schema
       @schema_name = override_schema_name || schema.schema_name
       @type_name = type.to_s.upcase
@@ -107,7 +107,7 @@ module PLSQL
       end
     end
 
-    def method_missing(method, *args, &block) #:nodoc:
+    def method_missing(method, *args, &block) # :nodoc:
       if procedure = find_procedure(method)
         procedure.exec_with_options(args, {}, &block)
       else
@@ -115,7 +115,7 @@ module PLSQL
       end
     end
 
-    def find_procedure(new_or_procedure) #:nodoc:
+    def find_procedure(new_or_procedure) # :nodoc:
       @type_procedures[new_or_procedure] ||= begin
         procedure_name = new_or_procedure == :new ? @type_name : new_or_procedure
         # find defined procedure for type
@@ -134,7 +134,7 @@ module PLSQL
     end
 
     # wrapper class to simulate Procedure class for ProcedureClass#exec
-    class TypeProcedure #:nodoc:
+    class TypeProcedure # :nodoc:
       include ProcedureCommon
 
       def initialize(schema, type, procedure)
@@ -250,7 +250,7 @@ module PLSQL
     end
   end
 
-  class ObjectInstance < Hash #:nodoc:
+  class ObjectInstance < Hash # :nodoc:
     attr_accessor :plsql_type
 
     def self.create(type, attributes)

data/lib/plsql/variable.rb

@@ -1,5 +1,5 @@
 module PLSQL
-  module VariableClassMethods #:nodoc:
+  module VariableClassMethods # :nodoc:
     def find(schema, variable, package, override_schema_name = nil)
       variable_upcase = variable.to_s.upcase
       schema.select_all(
@@ -17,10 +17,10 @@ module PLSQL
     end
   end
 
-  class Variable #:nodoc:
+  class Variable # :nodoc:
     extend VariableClassMethods
 
-    attr_reader :schema_name, :package_name, :variable_name #:nodoc:
+    attr_reader :schema_name, :package_name, :variable_name # :nodoc:
 
     def initialize(schema, variable, package, variable_type, override_schema_name = nil)
       @schema = schema
@@ -95,7 +95,7 @@ module PLSQL
       end
 
       # wrapper class to simulate Procedure class for ProcedureClass#exec
-      class VariableProcedure #:nodoc:
+      class VariableProcedure # :nodoc:
         attr_reader :arguments, :argument_list, :return, :out_list, :schema
 
         def initialize(schema, variable, operation, metadata)

data/lib/plsql/version.rb

@@ -1,3 +1,3 @@
-module PLSQL #:nodoc:
+module PLSQL # :nodoc:
   VERSION = File.read(File.dirname(__FILE__) + "/../../VERSION").chomp
 end

data/lib/plsql/view.rb

@@ -1,5 +1,5 @@
 module PLSQL
-  module ViewClassMethods #:nodoc:
+  module ViewClassMethods # :nodoc:
     def find(schema, view)
       if schema.select_first(
         "SELECT view_name FROM all_views
@@ -33,6 +33,6 @@ module PLSQL
   class View < Table
     extend ViewClassMethods
 
-    alias :view_name :table_name #:nodoc:
+    alias :view_name :table_name # :nodoc:
   end
 end

metadata

@@ -1,43 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-plsql
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.9.0
 platform: ruby
 authors:
 - Raimonds Simanovskis
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: juwelier
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -67,33 +38,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.1'
 - !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: activerecord-oracle_enhanced-adapter
+  name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -122,33 +79,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
-description: |2
-    ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures.
-    It could be used both for accessing Oracle PL/SQL API procedures in legacy applications
-    as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.
+description: |-
+  ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures.
+  It could be used both for accessing Oracle PL/SQL API procedures in legacy applications
+  as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.
 email: raimonds.simanovskis@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- ".codeclimate.yml"
-- ".github/stale.yml"
-- ".rubocop.yml"
-- ".travis.yml"
-- ".travis/oracle/download.sh"
-- ".travis/oracle/install.sh"
-- ".travis/setup_accounts.sh"
-- Gemfile
 - History.txt
 - License.txt
 - README.md
-- Rakefile
 - VERSION
-- Vagrantfile
-- gemfiles/Gemfile.activerecord-5.0
-- gemfiles/Gemfile.activerecord-5.1
-- gemfiles/Gemfile.activerecord-5.2
 - lib/plsql/connection.rb
 - lib/plsql/helpers.rb
 - lib/plsql/jdbc_connection.rb
@@ -167,30 +111,10 @@ files:
 - lib/plsql/view.rb
 - lib/ruby-plsql.rb
 - lib/ruby_plsql.rb
-- ruby-plsql.gemspec
-- spec/plsql/connection_spec.rb
-- spec/plsql/package_spec.rb
-- spec/plsql/procedure_spec.rb
-- spec/plsql/schema_spec.rb
-- spec/plsql/sequence_spec.rb
-- spec/plsql/sql_statements_spec.rb
-- spec/plsql/table_spec.rb
-- spec/plsql/type_spec.rb
-- spec/plsql/variable_spec.rb
-- spec/plsql/version_spec.rb
-- spec/plsql/view_spec.rb
-- spec/spec.opts
-- spec/spec_helper.rb
-- spec/support/create_arunit_user.sql
-- spec/support/custom_config.rb.sample
-- spec/support/file_check_script.sh
-- spec/support/test_db.rb
-- spec/support/unlock_and_setup_hr_user.sql
-homepage: http://github.com/rsim/ruby-plsql
+homepage: https://github.com/rsim/ruby-plsql
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -205,9 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
-signing_key: 
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Ruby API for calling Oracle PL/SQL procedures.
 test_files: []

data/.codeclimate.yml

@@ -1,30 +0,0 @@
-checks:
-  argument-count:
-    enabled: false
-  complex-logic:
-    enabled: false
-  file-lines:
-    enabled: false
-  method-complexity:
-    enabled: false
-  method-count:
-    enabled: false
-  method-lines:
-    enabled: false
-  nested-control-flow:
-    enabled: false
-  return-statements:
-    enabled: false
-  similar-code:
-    enabled: false
-  identical-code:
-    enabled: false
-
-engines:
-  rubocop:
-    enabled: true
-    channel: rubocop-0-58
-
-ratings:
-  paths:
-  - "**.rb"

data/.github/stale.yml

@@ -1,37 +0,0 @@
-# Configuration for probot-stale - https://github.com/probot/stale
-
-# Number of days of inactivity before an Issue or Pull Request becomes stale
-daysUntilStale: 60
-# Number of days of inactivity before a stale Issue or Pull Request is closed
-daysUntilClose: 7
-# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
-exemptLabels:
-  - pinned
-  - security
-  - "[Status] Maybe Later"
-# Label to use when marking as stale
-staleLabel: wontfix
-# Comment to post when marking as stale. Set to `false` to disable
-markComment: >
-  This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when removing the stale label. Set to `false` to disable
-unmarkComment: false
-# Comment to post when closing a stale Issue or Pull Request. Set to `false` to disable
-closeComment: false
-# Limit the number of actions per hour, from 1-30. Default is 30
-limitPerRun: 30
-# Limit to only `issues` or `pulls`
-# only: issues
-#
-# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls':
-# pulls:
-#   daysUntilStale: 30
-#   markComment: >
-#     This pull request has been automatically marked as stale because it has not had
-#     recent activity. It will be closed if no further activity occurs. Thank you
-#     for your contributions.
-# issues:
-#   exemptLabels:
-#     - confirmed