ruby-paloalto-client 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 891c7018edef362497d303ebdc67fa8bb8302f3a
-  data.tar.gz: 57b28f4a5d6e4efe54cf3477aa6a3ac85cd9f893
+  metadata.gz: a06152dd488c1a8d36ac2f47ac28670bfde84fcb
+  data.tar.gz: 7e164cad49c518012be0200af326ef2a9e0b8c4a
 SHA512:
-  metadata.gz: 8590c3367f11adab04ffe41ef95522921e830d3493b0c5db0821552f4755cd6ac76b9c143fdc656759b1b7a12c7fe664f0d08f099454aee64396eb1390b0279a
-  data.tar.gz: e1ca7bc8ca9189e0a14cac849e1780e467ac91e3021c2375e1d9872327857b05c69a7b4b43e5c872f82d7872525698360e32b54a5700d6e27bb8027e5381757f
+  metadata.gz: 80a24f2db0629f423b871310a0c1028eb5c399c78e246629f66a79261e621dc65bae522a0aeba7d5a1782101b19159d42263929c92324e71edf34821131311bd
+  data.tar.gz: bea1dea302b1fbabd9ad0e19ee58c506419980988f08bd58eaac3b77bb5c1ebdd38799f5c4af2f5fc1a2fdd7dc3faeae9803c0f4b0318c82b12cfd8de7a30204

data/lib/palo_alto/client/version.rb

@@ -1,5 +1,5 @@
 module PaloAlto
   module Client
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/palo_alto/models/log_entry.rb

@@ -3,7 +3,7 @@ module PaloAlto
     class LogEntry
       attr_accessor :log_id, :serial, :seqno, :type
 
-      SUPPORTED_TYPES = [ "traffic", "system", "data" ]
+      SUPPORTED_TYPES = [ "traffic", "system" ]
 
       # Create and returns a new PaloAlto::Models::LogEntry instance with the given parameters
       #

data/lib/palo_alto/v6/virtual_system_api.rb

@@ -46,8 +46,10 @@ module PaloAlto
 
             # get all address group members for the virtual system
             vsys_entry.xpath('address-group/entry').each do |address_group_entry|
+              # handle an optional 'description' parameter
+              description   = (desc_xpath = address_group_entry.xpath('description')).empty? ? "" : desc_xpath.first.content
               address_group = PaloAlto::Models::AddressGroup.new(name:        address_group_entry.xpath('@name').to_s,
-                                                                 description: address_group_entry.xpath('description').first.content)
+                                                                 description: description)
 
               # associate addresses with the address group
               address_group_entry.xpath('*/member').each do |address_entry|

data/spec/lib/palo-alto/models/log_entry_spec.rb

@@ -71,16 +71,6 @@ describe "PaloAlto::Models::LogEntry" do
           expect(PaloAlto::Models::LogEntry.from_xml(xml_data: system_log_xml)).to be_instance_of(PaloAlto::Models::SystemLogEntry)
         end
       end
-
-      describe "for data logs" do
-        let(:data_log_xmlfile)  { File.open(fixture_file("data_logs.xml")).read }
-        let(:data_log_nokogiri) { Nokogiri::XML(data_log_xmlfile) }
-        let(:data_log_xml)      { data_log_nokogiri.xpath('//response/result/log/logs/*')[0] }
-
-        it "returns a PaloAlto::Models::DataLogEntry instance" do
-          expect(PaloAlto::Models::LogEntry.from_xml(xml_data: data_log_xml)).to be_instance_of(PaloAlto::Models::DataLogEntry)
-        end
-      end
     end
   end
 end

data/spec/lib/palo-alto/v6/virtual_system_api_spec.rb

@@ -17,11 +17,12 @@ describe "PaloAlto::V6::VirtualSystemApi" do
   end
 
   describe ".virtual_systems" do
-    let(:virtual_system_xml)                  { File.open(fixture_file("virtual_systems.xml")).read }
-    let(:blank_virtual_system_xml)            { File.open(fixture_file("blank_virtual_systems.xml")).read }
-    let(:no_rulebase_virtual_system_xml)      { File.open(fixture_file("no_rulebase_virtual_systems.xml")).read }
-    let(:no_address_virtual_system_xml)       { File.open(fixture_file("no_address_virtual_systems.xml")).read }
-    let(:no_address_group_virtual_system_xml) { File.open(fixture_file("no_address_group_virtual_systems.xml")).read }
+    let(:virtual_system_xml)                                 { File.open(fixture_file("virtual_systems.xml")).read }
+    let(:blank_virtual_system_xml)                           { File.open(fixture_file("blank_virtual_systems.xml")).read }
+    let(:no_rulebase_virtual_system_xml)                     { File.open(fixture_file("no_rulebase_virtual_systems.xml")).read }
+    let(:no_address_virtual_system_xml)                      { File.open(fixture_file("no_address_virtual_systems.xml")).read }
+    let(:no_address_group_virtual_system_xml)                { File.open(fixture_file("no_address_group_virtual_systems.xml")).read }
+    let(:blank_address_group_description_virtual_system_xml) { File.open(fixture_file("address_group_missing_description.xml")).read }
 
     describe "when virtual systems exist" do
       it "parses the XML response into the required format" do
@@ -65,6 +66,13 @@ describe "PaloAlto::V6::VirtualSystemApi" do
 
           expect(@virtual_systems[0].address_groups[0].addresses).to_not be_empty
         end
+
+        it "assigns a blank 'description' when the address group has no description" do
+          expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(blank_address_group_description_virtual_system_xml)
+          @virtual_systems = DummyClass.virtual_systems
+
+          expect(@virtual_systems[0].address_groups[0].description).to eq("")
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-paloalto-client
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Justin Karimi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-04 00:00:00.000000000 Z
+date: 2015-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri