ruby-openid 2.6.0 → 2.7.0

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of ruby-openid might be problematic. Click here for more details.

Files changed (49) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +8 -0
  3. data/lib/openid/association.rb +1 -1
  4. data/lib/openid/cryptutil.rb +5 -5
  5. data/lib/openid/message.rb +1 -1
  6. data/lib/openid/trustroot.rb +2 -2
  7. data/lib/openid/urinorm.rb +4 -6
  8. data/lib/openid/util.rb +0 -2
  9. data/lib/openid/version.rb +1 -1
  10. data/test/discoverdata.rb +1 -2
  11. data/test/test_accept.rb +4 -5
  12. data/test/test_association.rb +4 -3
  13. data/test/test_associationmanager.rb +22 -24
  14. data/test/test_ax.rb +9 -9
  15. data/test/test_checkid_request.rb +6 -8
  16. data/test/test_consumer.rb +5 -5
  17. data/test/test_cryptutil.rb +5 -5
  18. data/test/test_dh.rb +2 -2
  19. data/test/test_discover.rb +19 -23
  20. data/test/test_discovery_manager.rb +6 -7
  21. data/test/test_extension.rb +2 -2
  22. data/test/test_fetchers.rb +16 -16
  23. data/test/test_filters.rb +7 -7
  24. data/test/test_idres.rb +25 -40
  25. data/test/test_kvform.rb +5 -5
  26. data/test/test_kvpost.rb +2 -2
  27. data/test/test_linkparse.rb +3 -5
  28. data/test/test_message.rb +19 -19
  29. data/test/test_nonce.rb +2 -2
  30. data/test/test_oauth.rb +3 -3
  31. data/test/test_openid_yadis.rb +2 -2
  32. data/test/test_pape.rb +4 -4
  33. data/test/test_parsehtml.rb +3 -3
  34. data/test/test_responses.rb +2 -2
  35. data/test/test_server.rb +53 -53
  36. data/test/test_sreg.rb +6 -6
  37. data/test/test_stores.rb +12 -12
  38. data/test/test_trustroot.rb +2 -2
  39. data/test/test_ui.rb +2 -2
  40. data/test/test_urinorm.rb +2 -2
  41. data/test/test_util.rb +2 -2
  42. data/test/test_xrds.rb +15 -15
  43. data/test/test_xri.rb +4 -4
  44. data/test/test_xrires.rb +2 -2
  45. data/test/test_yadis_discovery.rb +5 -5
  46. data/test/testutil.rb +8 -1
  47. metadata +18 -7
  48. data/lib/openid/extras.rb +0 -13
  49. data/test/test_extras.rb +0 -35
@@ -1,11 +1,11 @@
1
- require "test/unit"
1
+ require "minitest/autorun"
2
2
  require "testutil"
3
3
  require "rexml/document"
4
4
  require "openid/yadis/xrds"
5
5
  require "openid/yadis/filters"
6
6
 
7
7
  module OpenID
8
- class BasicServiceEndpointTest < Test::Unit::TestCase
8
+ class BasicServiceEndpointTest < Minitest::Test
9
9
  def test_match_types
10
10
  # Make sure the match_types operation returns the expected
11
11
  # results with various inputs.
@@ -39,7 +39,7 @@ module OpenID
39
39
  end
40
40
  end
41
41
 
42
- class TransformFilterMakerTest < Test::Unit::TestCase
42
+ class TransformFilterMakerTest < Minitest::Test
43
43
  def make_service_element(types, uris)
44
44
  service = REXML::Element.new('Service')
45
45
  types.each { |type_text|
@@ -143,7 +143,7 @@ module OpenID
143
143
  end
144
144
  end
145
145
 
146
- class CompoundFilterTest < Test::Unit::TestCase
146
+ class CompoundFilterTest < Minitest::Test
147
147
  def test_get_service_endpoints
148
148
  first = ["bogus", "test"]
149
149
  second = ["third"]
@@ -159,7 +159,7 @@ module OpenID
159
159
  end
160
160
  end
161
161
 
162
- class MakeFilterTest < Test::Unit::TestCase
162
+ class MakeFilterTest < Minitest::Test
163
163
  def test_parts_nil
164
164
  result = Yadis.make_filter(nil)
165
165
  assert result.is_a?(Yadis::TransformFilterMaker)
@@ -182,7 +182,7 @@ module OpenID
182
182
  end
183
183
  end
184
184
 
185
- class MakeCompoundFilterTest < Test::Unit::TestCase
185
+ class MakeCompoundFilterTest < Minitest::Test
186
186
  def test_no_filters
187
187
  result = Yadis.mk_compound_filter([])
188
188
  assert result.subfilters == []
@@ -251,7 +251,7 @@ module OpenID
251
251
  # Pass various non-filter objects and make sure the filter
252
252
  # machinery explodes.
253
253
  [nil, ["bogus"], [1], [nil, "bogus"]].each { |thing|
254
- assert_raise(TypeError) {
254
+ assert_raises(TypeError) {
255
255
  Yadis.mk_compound_filter(thing)
256
256
  }
257
257
  }
@@ -1,4 +1,4 @@
1
- require "test/unit"
1
+ require "minitest/autorun"
2
2
  require "testutil"
3
3
  require "util"
4
4
  require "openid/consumer/idres"
@@ -18,7 +18,7 @@ module OpenID
18
18
  end
19
19
  end
20
20
 
21
- class CheckForFieldsTest < Test::Unit::TestCase
21
+ class CheckForFieldsTest < Minitest::Test
22
22
  include ProtocolErrorMixin
23
23
 
24
24
  BASE_FIELDS = ['return_to', 'assoc_handle', 'sig', 'signed']
@@ -142,21 +142,17 @@ module OpenID
142
142
  def test_success_openid1
143
143
  msg = mkMsg(OPENID1_NS, OPENID1_FIELDS, OPENID1_SIGNED)
144
144
  idres = IdResHandler.new(msg, nil)
145
- assert_nothing_raised {
146
- idres.send(:check_for_fields)
147
- }
145
+ idres.send(:check_for_fields)
148
146
  end
149
147
 
150
148
  def test_success_openid1_1
151
149
  msg = mkMsg(OPENID11_NS, OPENID1_FIELDS, OPENID1_SIGNED)
152
150
  idres = IdResHandler.new(msg, nil)
153
- assert_nothing_raised {
154
- idres.send(:check_for_fields)
155
- }
151
+ idres.send(:check_for_fields)
156
152
  end
157
153
  end
158
154
 
159
- class ReturnToArgsTest < Test::Unit::TestCase
155
+ class ReturnToArgsTest < Minitest::Test
160
156
  include OpenID::ProtocolErrorMixin
161
157
 
162
158
  def check_return_to_args(query)
@@ -175,13 +171,11 @@ module OpenID
175
171
  end
176
172
 
177
173
  def test_return_to_args_okay
178
- assert_nothing_raised {
179
- check_return_to_args({
180
- 'openid.mode' => 'id_res',
181
- 'openid.return_to' => 'http://example.com/?foo=bar',
182
- 'foo' => 'bar',
183
- })
184
- }
174
+ check_return_to_args({
175
+ 'openid.mode' => 'id_res',
176
+ 'openid.return_to' => 'http://example.com/?foo=bar',
177
+ 'foo' => 'bar',
178
+ })
185
179
  end
186
180
 
187
181
  def test_unexpected_arg_okay
@@ -206,7 +200,7 @@ module OpenID
206
200
  end
207
201
  end
208
202
 
209
- class ReturnToVerifyTest < Test::Unit::TestCase
203
+ class ReturnToVerifyTest < Minitest::Test
210
204
  def test_bad_return_to
211
205
  return_to = "http://some.url/path?foo=bar"
212
206
 
@@ -250,9 +244,7 @@ module OpenID
250
244
  args['openid.return_to'] = return_to
251
245
  msg = Message.from_post_args(args)
252
246
  idres = IdResHandler.new(msg, base)
253
- assert_nothing_raised {
254
- idres.send(:verify_return_to)
255
- }
247
+ idres.send(:verify_return_to)
256
248
  end
257
249
  end
258
250
  end
@@ -264,7 +256,7 @@ module OpenID
264
256
  end
265
257
  end
266
258
 
267
- class CheckSigTest < Test::Unit::TestCase
259
+ class CheckSigTest < Minitest::Test
268
260
  include ProtocolErrorMixin
269
261
  include TestUtil
270
262
 
@@ -301,9 +293,7 @@ module OpenID
301
293
  end
302
294
 
303
295
  def test_sign_good
304
- assert_nothing_raised {
305
- call_check_sig(&method(:no_check_auth))
306
- }
296
+ call_check_sig(&method(:no_check_auth))
307
297
  end
308
298
 
309
299
  def test_bad_sig
@@ -423,7 +413,7 @@ module OpenID
423
413
 
424
414
  end
425
415
 
426
- class CheckAuthResponseTest < Test::Unit::TestCase
416
+ class CheckAuthResponseTest < Minitest::Test
427
417
  include TestUtil
428
418
  include ProtocolErrorMixin
429
419
 
@@ -482,7 +472,7 @@ module OpenID
482
472
  end
483
473
  end
484
474
 
485
- class NonceTest < Test::Unit::TestCase
475
+ class NonceTest < Minitest::Test
486
476
  include TestUtil
487
477
  include ProtocolErrorMixin
488
478
 
@@ -513,9 +503,7 @@ module OpenID
513
503
  {'openid.ns' => OPENID1_NS},
514
504
  {'openid.ns' => OPENID11_NS}
515
505
  ].each do |args|
516
- assert_nothing_raised {
517
- call_check_nonce({'rp_nonce' => @nonce}.merge(args), true)
518
- }
506
+ call_check_nonce({'rp_nonce' => @nonce}.merge(args), true)
519
507
  end
520
508
  end
521
509
 
@@ -536,10 +524,8 @@ module OpenID
536
524
  end
537
525
 
538
526
  def test_openid2_success
539
- assert_nothing_raised {
540
- call_check_nonce({'openid.response_nonce' => @nonce,
541
- 'openid.ns' => OPENID2_NS}, true)
542
- }
527
+ call_check_nonce({'openid.response_nonce' => @nonce,
528
+ 'openid.ns' => OPENID2_NS}, true)
543
529
  end
544
530
 
545
531
  def test_openid1_ignore_response_nonce
@@ -555,9 +541,7 @@ module OpenID
555
541
 
556
542
  def test_no_store
557
543
  @store = nil
558
- assert_nothing_raised {
559
- call_check_nonce({'rp_nonce' => @nonce})
560
- }
544
+ call_check_nonce({'rp_nonce' => @nonce})
561
545
  end
562
546
 
563
547
  def test_already_used
@@ -573,7 +557,7 @@ module OpenID
573
557
  end
574
558
  end
575
559
 
576
- class DiscoveryVerificationTest < Test::Unit::TestCase
560
+ class DiscoveryVerificationTest < Minitest::Test
577
561
  include ProtocolErrorMixin
578
562
  include TestUtil
579
563
 
@@ -875,7 +859,7 @@ module OpenID
875
859
  end
876
860
  end
877
861
 
878
- class IdResTopLevelTest < Test::Unit::TestCase
862
+ class IdResTopLevelTest < Minitest::Test
879
863
  def test_id_res
880
864
  endpoint = OpenIDServiceEndpoint.new
881
865
  endpoint.server_url = 'http://invalid/server'
@@ -919,9 +903,10 @@ module OpenID
919
903
  end
920
904
 
921
905
 
922
- class DiscoverAndVerifyTest < Test::Unit::TestCase
906
+ class DiscoverAndVerifyTest < Minitest::Test
923
907
  include ProtocolErrorMixin
924
908
  include TestUtil
909
+ OpenID.extend(OverrideMethodMixin)
925
910
 
926
911
  def test_no_services
927
912
  me = self
@@ -942,7 +927,7 @@ module OpenID
942
927
  end
943
928
  end
944
929
 
945
- class VerifyDiscoveredServicesTest < Test::Unit::TestCase
930
+ class VerifyDiscoveredServicesTest < Minitest::Test
946
931
  include ProtocolErrorMixin
947
932
  include TestUtil
948
933
 
@@ -1,11 +1,11 @@
1
- require 'test/unit'
1
+ require 'minitest/autorun'
2
2
  require 'openid/kvform'
3
3
  require 'openid/util'
4
4
  require 'util'
5
5
 
6
6
  include OpenID
7
7
 
8
- class KVFormTests < Test::Unit::TestCase
8
+ class KVFormTests < Minitest::Test
9
9
  include OpenID::TestUtil
10
10
 
11
11
  def test_kvdict
@@ -57,7 +57,7 @@ class KVFormTests < Test::Unit::TestCase
57
57
  # Strict mode should raise KVFormError instead of logging
58
58
  # messages
59
59
  if warnings > 0
60
- assert_raise(KVFormError) do
60
+ assert_raises(KVFormError) do
61
61
  Util.kv_to_seq(kv, true)
62
62
  end
63
63
  end
@@ -120,7 +120,7 @@ class KVFormTests < Test::Unit::TestCase
120
120
  # Strict mode should raise KVFormError instead of logging
121
121
  # messages
122
122
  if warnings > 0
123
- assert_raise(KVFormError) do
123
+ assert_raises(KVFormError) do
124
124
  Util.seq_to_kv(seq, true)
125
125
  end
126
126
  end
@@ -151,7 +151,7 @@ class KVFormTests < Test::Unit::TestCase
151
151
  def _run_kvexcTest(case_)
152
152
  seq = case_
153
153
 
154
- assert_raise(KVFormError) do
154
+ assert_raises(KVFormError) do
155
155
  Util.seq_to_kv(seq)
156
156
  end
157
157
  end
@@ -1,11 +1,11 @@
1
- require "test/unit"
1
+ require "minitest/autorun"
2
2
  require "testutil"
3
3
  require "openid/kvpost"
4
4
  require "openid/kvform"
5
5
  require "openid/message"
6
6
 
7
7
  module OpenID
8
- class KVPostTestCase < Test::Unit::TestCase
8
+ class KVPostTestCase < Minitest::Test
9
9
  include FetcherMixin
10
10
 
11
11
  def mk_resp(status, resp_hash)
@@ -1,8 +1,8 @@
1
- require 'test/unit'
1
+ require 'minitest/autorun'
2
2
  require 'testutil'
3
3
  require 'openid/consumer/html_parse'
4
4
 
5
- class LinkParseTestCase < Test::Unit::TestCase
5
+ class LinkParseTestCase < Minitest::Test
6
6
  include OpenID::TestDataMixin
7
7
 
8
8
  def attr_cmp(expected, found)
@@ -105,9 +105,7 @@ class LinkParseTestCase < Test::Unit::TestCase
105
105
  else
106
106
  html = "<html><body>hello joel\255</body></html>"
107
107
  end
108
- assert_nothing_raised do
109
- OpenID::parse_link_attrs(html)
110
- end
108
+ OpenID::parse_link_attrs(html)
111
109
 
112
110
  end
113
111
  end
@@ -1,5 +1,5 @@
1
1
  # last synced with Python openid.test.test_message on 6/29/2007.
2
- require 'test/unit'
2
+ require 'minitest/autorun'
3
3
  require 'util'
4
4
  require 'openid/message'
5
5
  require 'rexml/document'
@@ -14,7 +14,7 @@ module OpenID
14
14
 
15
15
  if expected.nil?
16
16
  assert_equal(@m.get_arg(ns, key, :a_default), :a_default)
17
- assert_raise(Message::KeyNotFound) { @m.get_arg(ns, key, NO_DEFAULT) }
17
+ assert_raises(Message::KeyNotFound) { @m.get_arg(ns, key, NO_DEFAULT) }
18
18
  else
19
19
  assert_equal(@m.get_arg(ns, key, :a_default), expected)
20
20
  assert_equal(@m.get_arg(ns, key, NO_DEFAULT), expected)
@@ -24,7 +24,7 @@ module OpenID
24
24
 
25
25
  end
26
26
 
27
- class EmptyMessageTestCase < Test::Unit::TestCase
27
+ class EmptyMessageTestCase < Minitest::Test
28
28
  include GetArgsMixin
29
29
 
30
30
  def setup
@@ -77,7 +77,7 @@ module OpenID
77
77
  end
78
78
 
79
79
  def test_get_key_openid
80
- assert_raise(UndefinedOpenIDNamespace) {
80
+ assert_raises(UndefinedOpenIDNamespace) {
81
81
  @m.get_key(OPENID_NS, nil)
82
82
  }
83
83
  end
@@ -99,7 +99,7 @@ module OpenID
99
99
  end
100
100
 
101
101
  def test_has_key
102
- assert_raise(UndefinedOpenIDNamespace) {
102
+ assert_raises(UndefinedOpenIDNamespace) {
103
103
  @m.has_key?(OPENID_NS, 'foo')
104
104
  }
105
105
  end
@@ -121,7 +121,7 @@ module OpenID
121
121
  end
122
122
 
123
123
  def test_get_arg
124
- assert_raise(UndefinedOpenIDNamespace) {
124
+ assert_raises(UndefinedOpenIDNamespace) {
125
125
  @m.get_args(OPENID_NS)
126
126
  }
127
127
  end
@@ -143,7 +143,7 @@ module OpenID
143
143
  end
144
144
 
145
145
  def test_get_args
146
- assert_raise(UndefinedOpenIDNamespace) {
146
+ assert_raises(UndefinedOpenIDNamespace) {
147
147
  @m.get_args(OPENID_NS)
148
148
  }
149
149
  end
@@ -165,7 +165,7 @@ module OpenID
165
165
  end
166
166
 
167
167
  def test_update_args
168
- assert_raise(UndefinedOpenIDNamespace) {
168
+ assert_raises(UndefinedOpenIDNamespace) {
169
169
  @m.update_args(OPENID_NS, {'does not'=>'matter'})
170
170
  }
171
171
  end
@@ -194,7 +194,7 @@ module OpenID
194
194
  end
195
195
 
196
196
  def test_set_arg
197
- assert_raise(UndefinedOpenIDNamespace) {
197
+ assert_raises(UndefinedOpenIDNamespace) {
198
198
  @m.set_arg(OPENID_NS,'does not','matter')
199
199
  }
200
200
  end
@@ -221,7 +221,7 @@ module OpenID
221
221
  end
222
222
 
223
223
  def test_del_arg
224
- assert_raise(UndefinedOpenIDNamespace) {
224
+ assert_raises(UndefinedOpenIDNamespace) {
225
225
  @m.set_arg(OPENID_NS, 'does not', 'matter')
226
226
  }
227
227
  end
@@ -253,13 +253,13 @@ module OpenID
253
253
  end
254
254
 
255
255
  def test_set_openid_namespace
256
- assert_raise(InvalidOpenIDNamespace) {
256
+ assert_raises(InvalidOpenIDNamespace) {
257
257
  @m.set_openid_namespace('http://invalid/', false)
258
258
  }
259
259
  end
260
260
  end
261
261
 
262
- class OpenID1MessageTest < Test::Unit::TestCase
262
+ class OpenID1MessageTest < Minitest::Test
263
263
  include GetArgsMixin
264
264
 
265
265
  def setup
@@ -497,7 +497,7 @@ module OpenID
497
497
 
498
498
  def test_equal
499
499
  assert_equal(Message.new, Message.new)
500
- assert_not_equal(Message.new, nil)
500
+ refute_equal(Message.new, nil)
501
501
  end
502
502
 
503
503
  def test_from_openid_args_undefined_ns
@@ -520,7 +520,7 @@ module OpenID
520
520
  end
521
521
  end
522
522
 
523
- class OpenID1ExplicitMessageTest < Test::Unit::TestCase
523
+ class OpenID1ExplicitMessageTest < Minitest::Test
524
524
  # XXX - check to make sure the test suite will get built the way this
525
525
  # expects.
526
526
  def setup
@@ -586,7 +586,7 @@ module OpenID
586
586
 
587
587
  end
588
588
 
589
- class OpenID2MessageTest < Test::Unit::TestCase
589
+ class OpenID2MessageTest < Minitest::Test
590
590
  include TestUtil
591
591
 
592
592
  def setup
@@ -837,7 +837,7 @@ module OpenID
837
837
  # .fromPostArgs covers .fromPostArgs, .fromOpenIDArgs,
838
838
  # ._fromOpenIDArgs, and .fromOpenIDArgs (since it calls
839
839
  # .fromPostArgs).
840
- assert_raise(AssertionError) {
840
+ assert_raises(AssertionError) {
841
841
  Message.from_post_args(args)
842
842
  }
843
843
  }
@@ -877,7 +877,7 @@ module OpenID
877
877
  end
878
878
 
879
879
  def test_argList
880
- assert_raise(ArgumentError) {
880
+ assert_raises(ArgumentError) {
881
881
  Message.from_post_args({'arg' => [1, 2, 3]})
882
882
  }
883
883
  end
@@ -891,7 +891,7 @@ module OpenID
891
891
  end
892
892
  end
893
893
 
894
- class MessageTest < Test::Unit::TestCase
894
+ class MessageTest < Minitest::Test
895
895
  def setup
896
896
  @postargs = {
897
897
  'openid.ns' => OPENID2_NS,
@@ -1042,7 +1042,7 @@ module OpenID
1042
1042
  end
1043
1043
  end
1044
1044
 
1045
- class NamespaceMapTestCase < Test::Unit::TestCase
1045
+ class NamespaceMapTestCase < Minitest::Test
1046
1046
 
1047
1047
  def test_onealias
1048
1048
  nsm = NamespaceMap.new