ruby-ogginfo 0.7 → 0.7.1

data/test/test_ruby-ogginfo.rb

@@ -34,35 +34,6 @@ class OggInfoTest < Test::Unit::TestCase
     end
   end
 
-  def test_writing_to_spedial_filenames
-    filename = "fichier éé.ogg"
-    FileUtils.cp(@tempfile, filename)
-    begin
-      OggInfo.open(@tempfile) do |ogg|
-        ogg.tag.title = "a"*200
-      end
-      #system("ls", "-l", filename)
-    ensure
-      FileUtils.rm_f(filename) 
-    end
-  end
-
-  def test_good_writing_of_utf8_strings
-    tag = { "title" => "this is a éé utf8 string",
-            "artist" => "and è another one à"}
-    tag_test("tag_writing", tag)
-  end
-
-  def test_tag_writing
-    data = "a"*256
-    tag_test("tag_writing", "title" => data, "artist" => data )
-  end
-
-  def test_big_tags
-    data = "a"*60000
-    tag_test("big_tags", "title" => data, "artist" => data )
-  end
-
   def test_should_not_fail_when_input_is_truncated
     ogg_length = nil
     OggInfo.open(@tempfile) do |ogg|
@@ -134,23 +105,4 @@ class OggInfoTest < Test::Unit::TestCase
     tf.close
     tf
   end
-
-  def tag_test(test_name, tag) 
-    OggInfo.open(@tempfile) do |ogg|
-      tag.each { |k,v| ogg.tag[k] = v }
-    end
-
-    OggInfo.open(@tempfile) do |ogg|
-      assert_equal tag, ogg.tag
-    end
-    system("cp #{@tempfile} /tmp/test_#{RUBY_VERSION}_#{test_name}.ogg")
-    test_length
-    assert_nothing_raised do
-      io = open(@tempfile)
-      reader = Ogg::Reader.new(io)
-      reader.each_pages do |page|
-        page
-      end
-    end
-  end
 end

data/test/test_ruby-othercodecs.rb

@@ -9,17 +9,14 @@ require "tempfile"
 require File.join(File.dirname(__FILE__), "test_helper")
 
 class OtherCodecsInfoTest < Test::Unit::TestCase
-  CODECS = [:speex, :opus]
-
   def setup
     @fixtures = load_fixtures 
   end
 
   def test_generated_info
-    CODECS.each do |codec|
-      OggInfo.open(@fixtures[codec]) do |ogg|
+    @fixtures.each do |codec, tempfile|
+      OggInfo.open(tempfile) do |ogg|
         assert_equal 2, ogg.channels
-        assert_equal 48000, ogg.samplerate
         case codec 
         when :speex
           assert_equal "spxinfotest", ogg.tag.author
@@ -27,15 +24,21 @@ class OtherCodecsInfoTest < Test::Unit::TestCase
           assert_in_delta(3, ogg.length, 0.2, "length has not been correctly guessed for codec \"#{codec}\"")
           assert_in_delta 64000, ogg.bitrate, 2000
           assert_equal "artist", ogg.tag.artist
+          assert_equal 48000, ogg.samplerate
+        when :ogg
+          assert_in_delta(3, ogg.length, 0.5, "length has not been correctly guessed for codec \"#{codec}\"")
+          assert_in_delta 64000, ogg.bitrate, 10000
+          assert_equal "artist", ogg.tag.artist
+          assert_equal 44100, ogg.samplerate
         end
       end
     end
   end
 
   def test_tag_writing
-    CODECS.each do |codec|
+    @fixtures.each do |codec, tempfile|
       tag = {"title" => "mytitle", "test" => "myartist" }
-      OggInfo.open(@fixtures[codec]) do |ogg|
+      OggInfo.open(tempfile) do |ogg|
         ogg.tag.clear
         tag.each { |k,v| ogg.tag[k] = v }
       end
@@ -45,4 +48,57 @@ class OtherCodecsInfoTest < Test::Unit::TestCase
       end
     end
   end
+
+  def test_good_writing_of_utf8_strings
+    tag = { "title" => "this is a éé utf8 string",
+            "artist" => "and è another one à"}
+    tag_test("tag_writing", tag)
+  end
+
+  def test_tag_writing
+    data = "a"*256
+    tag_test("tag_writing", "title" => data, "artist" => data )
+  end
+
+  def test_big_tags
+    data = "a"*60000
+    tag_test("big_tags", "title" => data, "artist" => data )
+  end
+
+  def tag_test(test_name, tag)
+    @fixtures.each do |codec, tempfile|
+      OggInfo.open(tempfile) do |ogg|
+        ogg.tag.clear
+        tag.each { |k,v| ogg.tag[k] = v }
+      end
+
+      OggInfo.open(tempfile) do |ogg|
+        assert_equal tag, ogg.tag
+      end
+      FileUtils.cp(tempfile, "/tmp/test_#{RUBY_VERSION}_#{test_name}.ogg")
+      assert_nothing_raised do
+        io = open(tempfile)
+        reader = Ogg::Reader.new(io)
+        reader.each_pages do |page|
+          page
+        end
+      end
+    end
+  end
+
+  def test_unicode_support
+    @fixtures.each do |codec, tempfile|
+      filename = "fichier éé.#{codec}"
+      FileUtils.cp(tempfile, filename)
+      begin
+        OggInfo.open(tempfile) do |ogg|
+          ogg.tag.artist = "artistéoo"
+          ogg.tag.title = "a"*200
+        end
+      ensure
+        FileUtils.rm_f(filename) 
+      end
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-ogginfo
 version: !ruby/object:Gem::Version
-  version: '0.7'
+  version: 0.7.1
 platform: ruby
 authors:
 - Guillaume Pierronnet