ruby-oembed 0.8.3 → 0.8.5

data/spec/formatter/xml/nokogiri_backend_spec.rb

@@ -0,0 +1,58 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe "OEmbed::Formatter::XML::Backends::Nokogiri" do
+  include OEmbedSpecHelper
+
+  before(:all) do
+    lambda {
+      OEmbed::Formatter::XML.backend = 'Nokogiri'
+    }.should raise_error(LoadError)
+    
+    require 'nokogiri'
+    
+    lambda {
+      OEmbed::Formatter::XML.backend = 'Nokogiri'
+    }.should_not raise_error
+  end
+
+  it "should support XML" do
+    proc { OEmbed::Formatter.supported?(:xml) }.
+    should_not raise_error(OEmbed::FormatNotSupported)
+  end
+  
+  it "should be using the Nokogiri backend" do
+    OEmbed::Formatter::XML.backend.should == OEmbed::Formatter::XML::Backends::Nokogiri
+  end
+  
+  it "should decode an XML String" do
+    decoded = OEmbed::Formatter.decode(:xml, valid_response(:xml))
+    # We need to compare keys & values separately because we don't expect all
+    # non-string values to be recognized correctly.
+    decoded.keys.should == valid_response(:object).keys
+    decoded.values.map{|v|v.to_s}.should == valid_response(:object).values.map{|v|v.to_s}
+  end
+  
+  it "should raise an OEmbed::ParseError when decoding an invalid XML String" do
+    lambda {
+      decode = OEmbed::Formatter.decode(:xml, invalid_response('unclosed_container', :xml))
+    }.should raise_error(OEmbed::ParseError)
+    lambda {
+      decode = OEmbed::Formatter.decode(:xml, invalid_response('unclosed_tag', :xml))
+    }.should raise_error(OEmbed::ParseError)
+    lambda {
+      decode = OEmbed::Formatter.decode(:xml, invalid_response('invalid_syntax', :xml))
+    }.should raise_error(OEmbed::ParseError)
+  end
+  
+  it "should raise an OEmbed::ParseError when decoding fails with an unexpected error" do
+    error_to_raise = ArgumentError
+    OEmbed::Formatter::XML.backend.parse_error.should_not be_kind_of(error_to_raise)
+    
+    ::Nokogiri::XML::Document.should_receive(:parse).
+      and_raise(error_to_raise.new("unknown error"))
+    
+    lambda {
+      decode = OEmbed::Formatter.decode(:xml, valid_response(:xml))
+    }.should raise_error(OEmbed::ParseError)
+  end
+end

data/spec/provider_discovery_spec.rb

@@ -0,0 +1,116 @@
+require File.dirname(__FILE__) + '/spec_helper'
+require 'vcr'
+
+VCR.config do |c|
+  c.default_cassette_options = { :record => :new_episodes }
+  c.cassette_library_dir = 'spec/cassettes'
+  c.stub_with :fakeweb
+end
+
+describe OEmbed::ProviderDiscovery do
+  before(:all) do
+    VCR.insert_cassette('OEmbed_ProviderDiscovery')
+  end
+  after(:all) do
+    VCR.eject_cassette
+  end
+  
+  include OEmbedSpecHelper
+  
+  {
+    'youtube' => [
+      'http://www.youtube.com/watch?v=u6XAPnuFjJc',
+      'http://www.youtube.com/oembed',
+      :json,
+    ],
+    'vimeo' => [
+      'http://vimeo.com/27953845',
+      {:json=>'http://vimeo.com/api/oembed.json',:xml=>'http://vimeo.com/api/oembed.xml'},
+      :json,
+    ],
+    #'noteflight' => [
+    #  'http://www.noteflight.com/scores/view/09665392c94475f65dfaf5f30aadb6ed0921939d',
+    #  'http://www.noteflight.com/services/oembed',
+    #  :json,
+    #],
+    #'wordpress' => [
+    #  'http://sweetandweak.wordpress.com/2011/09/23/nothing-starts-the-morning-like-a-good-dose-of-panic/',
+    #  'http://public-api.wordpress.com/oembed/1.0/',
+    #  :json,
+    #],
+  }.each do |context, urls|
+    
+    given_url, expected_endpoint, expected_format = urls
+    
+    context "with #{context} url" do
+      
+      describe "discover_provider" do
+
+        before(:all) do
+          @provider_default = OEmbed::ProviderDiscovery.discover_provider(given_url)
+          @provider_json = OEmbed::ProviderDiscovery.discover_provider(given_url, :format=>:json)
+          @provider_xml = OEmbed::ProviderDiscovery.discover_provider(given_url, :format=>:xml)
+        end
+
+        it "should return the correct Class" do
+          @provider_default.should be_instance_of(OEmbed::Provider)
+          @provider_json.should be_instance_of(OEmbed::Provider)
+          @provider_xml.should be_instance_of(OEmbed::Provider)
+        end
+
+        it "should detect the correct URL" do
+          if expected_endpoint.is_a?(Hash)
+            @provider_json.endpoint.should eq(expected_endpoint[expected_format])
+            @provider_json.endpoint.should eq(expected_endpoint[:json])
+            @provider_xml.endpoint.should eq(expected_endpoint[:xml])
+          else
+            @provider_default.endpoint.should eq(expected_endpoint)
+            @provider_json.endpoint.should eq(expected_endpoint)
+            @provider_xml.endpoint.should eq(expected_endpoint)
+          end
+        end
+
+        it "should return the correct format" do
+          @provider_default.format.should eq(expected_format)
+          @provider_json.format.should eq(:json)
+          @provider_xml.format.should eq(:xml)
+        end
+      end # discover_provider
+
+      describe "get" do
+      
+        before(:all) do
+          @response_default = OEmbed::ProviderDiscovery.get(given_url)
+          @response_json = OEmbed::ProviderDiscovery.get(given_url, :format=>:json)
+          @response_xml = OEmbed::ProviderDiscovery.get(given_url, :format=>:xml)
+        end
+      
+        it "should return the correct Class" do
+          @response_default.should be_kind_of(OEmbed::Response)
+          @response_json.should be_kind_of(OEmbed::Response)
+          @response_xml.should be_kind_of(OEmbed::Response)
+        end
+      
+        it "should return the correct format" do
+          @response_default.format.should eq(expected_format.to_s)
+          @response_json.format.should eq('json')
+          @response_xml.format.should eq('xml')
+        end
+      
+        it "should return the correct data" do
+          @response_default.type.should_not be_nil
+          @response_json.type.should_not be_nil
+          @response_xml.type.should_not be_nil
+          
+          # Technically, the following values _could_ be blank, but for the 
+          # examples urls we're using we expect them not to be.
+          @response_default.title.should_not be_nil
+          @response_json.title.should_not be_nil
+          @response_xml.title.should_not be_nil
+        end
+      end # get
+    end
+    
+  end # each service
+  
+end

data/spec/provider_spec.rb

@@ -266,7 +266,8 @@ describe OEmbed::Provider do
 
     it "should raise error on all other responses" do
       Net::HTTPResponse::CODE_TO_OBJ.delete_if do |code, res|
-        ["200", "404", "501"].include?(code)
+        ("200".."299").include?(code) ||
+        ["404", "501"].include?(code)
       end.each do |code, res|
         r = res.new("1.1", code, "Message")
         Net::HTTP.stub!(:start).and_return(r)

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+require 'vcr'
 require File.dirname(__FILE__) + '/../lib/oembed'
 
 module OEmbedSpecHelper
@@ -45,7 +46,7 @@ module OEmbedSpecHelper
         "__id__" => 1234
       }
     when 'json'
-      <<-JSON
+      <<-JSON.strip
         {
           "type": "photo",
           "version": "1.0",
@@ -54,7 +55,7 @@ module OEmbedSpecHelper
         }
       JSON
     when 'xml'
-      <<-XML
+      <<-XML.strip
         <?xml version="1.0" encoding="utf-8" standalone="yes"?>
         <oembed>
         	<type>photo</type>

metadata

@@ -1,15 +1,10 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: ruby-oembed
-version: !ruby/object:Gem::Version 
-  hash: 57
+version: !ruby/object:Gem::Version
+  version: 0.8.5
   prerelease: 
-  segments: 
-  - 0
-  - 8
-  - 3
-  version: 0.8.3
 platform: ruby
-authors: 
+authors:
 - Magnus Holm
 - Alex Kessinger
 - Aris Bartee
@@ -17,92 +12,108 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-06-26 00:00:00 -07:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+date: 2011-11-15 00:00:00.000000000Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: jeweler
-  prerelease: false
-  type: :development
-  requirement: *id001
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
+  requirement: &2170353860 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  name: rake
-  prerelease: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id002
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *2170353860
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &2170353280 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2170353280
+- !ruby/object:Gem::Dependency
   name: json
+  requirement: &2170352700 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
+  version_requirements: *2170352700
+- !ruby/object:Gem::Dependency
+  name: xml-simple
+  requirement: &2170352120 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id003
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *2170352120
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: &2170351480 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  name: xml-simple
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
+  version_requirements: *2170351480
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: &2170350980 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :development
-  requirement: *id004
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
+  prerelease: false
+  version_requirements: *2170350980
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: &2170350500 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 2
-        - 0
-        version: "2.0"
-  name: rspec
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
   prerelease: false
+  version_requirements: *2170350500
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: &2170350020 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id005
-description: An oEmbed consumer library written in Ruby, letting you easily get embeddable HTML representations of supported web pages, based on their URLs. See http://oembed.com for more information about the protocol.
+  prerelease: false
+  version_requirements: *2170350020
+description: An oEmbed consumer library written in Ruby, letting you easily get embeddable
+  HTML representations of supported web pages, based on their URLs. See http://oembed.com
+  for more information about the protocol.
 email: arisbartee@gmail.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
 - README.rdoc
-files: 
+files:
 - .rvmrc
+- .travis.yml
 - .yardopts
 - CHANGELOG.rdoc
 - Gemfile
@@ -121,6 +132,7 @@ files:
 - lib/oembed/formatter/json/backends/jsongem.rb
 - lib/oembed/formatter/json/backends/yaml.rb
 - lib/oembed/formatter/xml.rb
+- lib/oembed/formatter/xml/backends/nokogiri.rb
 - lib/oembed/formatter/xml/backends/rexml.rb
 - lib/oembed/formatter/xml/backends/xmlsimple.rb
 - lib/oembed/provider.rb
@@ -137,57 +149,51 @@ files:
 - lib/tasks/oembed.rake
 - lib/tasks/rspec.rake
 - ruby-oembed.gemspec
+- spec/cassettes/OEmbed_ProviderDiscovery.yml
 - spec/formatter/ducktype_backend_spec.rb
 - spec/formatter/json/.DS_Store
 - spec/formatter/json/jsongem_backend_spec.rb
 - spec/formatter/json/yaml_backend_spec.rb
+- spec/formatter/xml/nokogiri_backend_spec.rb
 - spec/formatter/xml/rexml_backend_spec.rb
 - spec/formatter/xml/xmlsimple_backend_spec.rb
 - spec/formatter_spec.rb
+- spec/provider_discovery_spec.rb
 - spec/provider_spec.rb
 - spec/providers_spec.rb
 - spec/response_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://github.com/judofyr/ruby-oembed
-licenses: 
+licenses:
 - MIT
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --main
 - README.rdoc
 - --title
-- ruby-oembed-0.8.3
+- ruby-oembed-0.8.5
 - --inline-source
 - --exclude
 - tasks
 - CHANGELOG.rdoc
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.4.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: oEmbed for Ruby
 test_files: []
-