ruby-oembed 0.14.1 → 0.15.0

data/spec/response_spec.rb

@@ -36,14 +36,14 @@ describe OEmbed::Response do
   }
 
   let(:qik) {
-    qik = OEmbed::Provider.new("http://qik.com/api/oembed.{format}", :xml)
+    qik = OEmbed::Provider.new("http://qik.com/api/oembed.{format}", format: :xml)
     qik << "http://qik.com/video/*"
     qik << "http://qik.com/*"
     qik
   }
 
   let(:viddler) {
-    viddler = OEmbed::Provider.new("http://lab.viddler.com/services/oembed/", :json)
+    viddler = OEmbed::Provider.new("http://lab.viddler.com/services/oembed/", format: :json)
     viddler << "http://*.viddler.com/*"
     viddler
   }

data/spec/spec_helper.rb

@@ -1,16 +1,27 @@
 require 'rubygems'
 
 require 'vcr'
-VCR.config do |c|
+VCR.configure do |c|
   c.default_cassette_options = { :record => :new_episodes }
   c.cassette_library_dir = 'spec/cassettes'
   c.hook_into :webmock
+  # Try to prevent a real-world Facebook token from being recorded by VCR
+  if ENV['OEMBED_FACEBOOK_TOKEN'] && !ENV['OEMBED_FACEBOOK_TOKEN'].to_s.empty?
+    c.filter_sensitive_data('A_FAKE_TOKEN_FOR_TESTS') { ENV['OEMBED_FACEBOOK_TOKEN'] }
+    c.filter_sensitive_data('A_FAKE_TOKEN_FOR_TESTS') { ::CGI.escape(ENV['OEMBED_FACEBOOK_TOKEN']) }
+  else
+    # If the developer doesn't have an OEMBED_FACEBOOK_TOKEN set
+    # use a fake one that will match data in the vcr cassettes.
+    ENV['OEMBED_FACEBOOK_TOKEN'] = 'A_FAKE_TOKEN_FOR_TESTS'
+  end
 end
 
 require 'webmock/rspec'
 require 'coveralls'
 Coveralls.wear!
 
+require 'support/shared_examples_for_providers'
+
 require File.dirname(__FILE__) + '/../lib/oembed'
 
 RSpec.configure do |config|
@@ -18,6 +29,13 @@ RSpec.configure do |config|
   config.tty = true
   config.color = true
   config.example_status_persistence_file_path = '.rspec-status'
+  config.filter_run_including :focus => true unless ENV['RUN_ALL_TESTS']
+  config.run_all_when_everything_filtered = true
+end
+
+def use_custom_vcr_casette(casette_name)
+  before(:all) { VCR.insert_cassette(casette_name) }
+  after(:all) { VCR.eject_cassette }
 end
 
 module OEmbedSpecHelper

data/spec/support/shared_examples_for_providers.rb

@@ -1,37 +1,49 @@
 RSpec.shared_examples "an OEmbed::Providers instance" do |expected_valid_urls, expected_invalid_urls|
+  subject { provider }
+
   expected_valid_urls.each do |valid_url|
     context "given the valid URL #{valid_url}" do
-      describe ".include?" do
-        it "should be true" do
-          expect(provider_class.include?(valid_url)).to be_truthy
-        end
-      end
+      it { should include(valid_url) }
 
       describe ".get" do
-        it "should return a response" do
-          response = nil
-          expect {
-            response = provider_class.get(valid_url)
-          }.to_not raise_error
-          expect(response).to be_a(OEmbed::Response)
-        end
+        subject { provider.get(valid_url) }
+
+        it { should be_a(OEmbed::Response) }
       end
     end
   end
 
   expected_invalid_urls.each do |invalid_url|
     context "given the invalid URL #{invalid_url}" do
-      describe ".include?" do
-        it "should be false" do
-          expect(provider_class.include?(invalid_url)).to be_falsey
+      it { should_not include(invalid_url) }
+
+      describe ".get" do
+        subject { provider.get(invalid_url) }
+
+        it "should raise an OEmbed::NotFound error" do
+          expect { subject }.to raise_error(OEmbed::NotFound)
         end
       end
+    end
+  end
 
-      describe ".get" do
-        it "should not find a response" do
-          expect {
-            provider_class.get(invalid_url)
-          }.to raise_error(OEmbed::NotFound)
+  describe "OEmbed::Providers.register(provider)" do
+    before(:each) { OEmbed::Providers.register(provider) }
+    after(:each) { OEmbed::Providers.unregister_all }
+
+    describe('.get') do
+      expected_valid_urls.each do |valid_url|
+        context "given the valid URL #{valid_url}" do
+          subject { OEmbed::Providers.get(valid_url) }
+          it { should be_a(OEmbed::Response) }
+        end
+      end
+      expected_invalid_urls.each do |invalid_url|
+        context "given the invalid URL #{invalid_url}" do
+          let(:url) { invalid_url }
+          it "should raise an OEmbed::NotFound error" do
+            expect { expect(OEmbed::Providers.get(url)) }.to raise_error(OEmbed::NotFound)
+          end
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-oembed
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.15.0
 platform: ruby
 authors:
 - Magnus Holm
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-28 00:00:00.000000000 Z
+date: 2021-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: xml-simple
@@ -82,9 +82,11 @@ files:
 - lib/oembed/providers/aggregators/embedly_urls.yml
 - lib/oembed/providers/aggregators/noembed_urls.yml
 - lib/oembed/providers/aggregators/oohembed_urls.yml
+- lib/oembed/providers/builtin_providers.rb
 - lib/oembed/providers/facebook_post.rb
 - lib/oembed/providers/facebook_video.rb
 - lib/oembed/providers/instagram.rb
+- lib/oembed/providers/tik_tok.rb
 - lib/oembed/response.rb
 - lib/oembed/response/link.rb
 - lib/oembed/response/photo.rb
@@ -96,7 +98,12 @@ files:
 - ruby-oembed.gemspec
 - spec/cassettes/OEmbed_Provider.yml
 - spec/cassettes/OEmbed_ProviderDiscovery.yml
+- spec/cassettes/OEmbed_Providers_CodePen.yml
+- spec/cassettes/OEmbed_Providers_FacebookPost.yml
+- spec/cassettes/OEmbed_Providers_FacebookVideo.yml
+- spec/cassettes/OEmbed_Providers_Instagram.yml
 - spec/cassettes/OEmbed_Providers_Slideshare.yml
+- spec/cassettes/OEmbed_Providers_TikTok.yml
 - spec/cassettes/OEmbed_Providers_Twitter.yml
 - spec/cassettes/OEmbed_Providers_Youtube.yml
 - spec/formatter/ducktype_backend_spec.rb
@@ -109,8 +116,12 @@ files:
 - spec/formatter_spec.rb
 - spec/provider_discovery_spec.rb
 - spec/provider_spec.rb
-- spec/providers/facebook_spec.rb
+- spec/providers/code_pen_spec.rb
+- spec/providers/facebook_post_spec.rb
+- spec/providers/facebook_video_spec.rb
+- spec/providers/instagram_spec.rb
 - spec/providers/slideshare_spec.rb
+- spec/providers/tik_tok_spec.rb
 - spec/providers/twitter_spec.rb
 - spec/providers/youtube_spec.rb
 - spec/providers_spec.rb
@@ -127,7 +138,7 @@ rdoc_options:
 - "--main"
 - README.rdoc
 - "--title"
-- ruby-oembed-0.14.1
+- ruby-oembed-0.15.0
 - "--inline-source"
 - "--exclude"
 - tasks
@@ -152,7 +163,12 @@ summary: oEmbed for Ruby
 test_files:
 - spec/cassettes/OEmbed_Provider.yml
 - spec/cassettes/OEmbed_ProviderDiscovery.yml
+- spec/cassettes/OEmbed_Providers_CodePen.yml
+- spec/cassettes/OEmbed_Providers_FacebookPost.yml
+- spec/cassettes/OEmbed_Providers_FacebookVideo.yml
+- spec/cassettes/OEmbed_Providers_Instagram.yml
 - spec/cassettes/OEmbed_Providers_Slideshare.yml
+- spec/cassettes/OEmbed_Providers_TikTok.yml
 - spec/cassettes/OEmbed_Providers_Twitter.yml
 - spec/cassettes/OEmbed_Providers_Youtube.yml
 - spec/formatter/ducktype_backend_spec.rb
@@ -165,8 +181,12 @@ test_files:
 - spec/formatter_spec.rb
 - spec/provider_discovery_spec.rb
 - spec/provider_spec.rb
-- spec/providers/facebook_spec.rb
+- spec/providers/code_pen_spec.rb
+- spec/providers/facebook_post_spec.rb
+- spec/providers/facebook_video_spec.rb
+- spec/providers/instagram_spec.rb
 - spec/providers/slideshare_spec.rb
+- spec/providers/tik_tok_spec.rb
 - spec/providers/twitter_spec.rb
 - spec/providers/youtube_spec.rb
 - spec/providers_spec.rb

data/spec/providers/facebook_spec.rb

@@ -1,50 +0,0 @@
-require File.join(File.dirname(__FILE__), '../spec_helper')
-
-describe 'Facebook providers' do
-  let(:access_token) { 'my-fake-access-token' }
-
-  describe 'FacebookPost provider' do
-    let(:provider) { OEmbed::Providers::FacebookPost.new(access_token: access_token) }
-    let(:embed_url) { 'https://www.facebook.com/exampleuser/posts/1234567890' }
-
-    it 'sets the endpoint URL' do
-      expect(provider.endpoint).to(
-        eq("https://graph.facebook.com/v8.0/oembed_post?access_token=#{access_token}")
-      )
-    end
-
-    it 'recognizes embed URLs' do
-      expect(provider).to include(embed_url)
-    end
-  end
-
-  describe 'FacebookVideo provider' do
-    let(:provider) { OEmbed::Providers::FacebookVideo.new(access_token: access_token) }
-    let(:embed_url) { 'https://www.facebook.com/exampleuser/videos/1234567890' }
-
-    it 'sets the endpoint URL' do
-      expect(provider.endpoint).to(
-        eq("https://graph.facebook.com/v8.0/oembed_video?access_token=#{access_token}")
-      )
-    end
-
-    it 'recognizes embed URLs' do
-      expect(provider).to include(embed_url)
-    end
-  end
-
-  describe 'Instagram provider' do
-    let(:provider) { OEmbed::Providers::Instagram.new(access_token: access_token) }
-    let(:embed_url) { 'https://www.instagram.com/p/r4nd0m1mg/' }
-
-    it 'sets the endpoint URL' do
-      expect(provider.endpoint).to(
-        eq("https://graph.facebook.com/v8.0/instagram_oembed?access_token=#{access_token}")
-      )
-    end
-
-    it 'recognizes embed URLs' do
-      expect(provider).to include(embed_url)
-    end
-  end
-end