ruby-oembed 0.11.0 → 0.14.1

data/spec/cassettes/OEmbed_Providers_Youtube.yml

@@ -0,0 +1,211 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://www.youtube.com/oembed/?format=json&scheme=https&url=https://www.youtube.com/watch?v=pO5L6vXtxsI
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Mozilla/5.0 (compatible; ruby-oembed/0.14.0)
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Strict-Transport-Security:
+      - max-age=31536000
+      Cache-Control:
+      - no-cache
+      Content-Type:
+      - application/json
+      P3p:
+      - CP="This is not a P3P policy! See http://support.google.com/accounts/answer/151657?hl=en
+        for more info."
+      Expires:
+      - Tue, 27 Apr 1971 19:44:06 GMT
+      X-Content-Type-Options:
+      - nosniff
+      Date:
+      - Mon, 28 Dec 2020 15:32:04 GMT
+      Server:
+      - YouTube Frontend Proxy
+      X-Xss-Protection:
+      - '0'
+      Alt-Svc:
+      - h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443";
+        ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
+      Accept-Ranges:
+      - none
+      Vary:
+      - Accept-Encoding
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: '{"title":"CKEditor 4.5 - Embedding Media Resources with oEmbed","author_name":"CKEditor
+        Ecosystem","author_url":"https://www.youtube.com/c/CKEditor","type":"video","height":270,"width":480,"version":"1.0","provider_name":"YouTube","provider_url":"https://www.youtube.com/","thumbnail_height":360,"thumbnail_width":480,"thumbnail_url":"https://i.ytimg.com/vi/pO5L6vXtxsI/hqdefault.jpg","html":"\u003ciframe
+        width=\u0022480\u0022 height=\u0022270\u0022 src=\u0022https://www.youtube.com/embed/pO5L6vXtxsI?feature=oembed\u0022
+        frameborder=\u00220\u0022 allow=\u0022accelerometer; autoplay; clipboard-write;
+        encrypted-media; gyroscope; picture-in-picture\u0022 allowfullscreen\u003e\u003c/iframe\u003e"}'
+  recorded_at: Mon, 28 Dec 2020 15:32:04 GMT
+- request:
+    method: get
+    uri: https://www.youtube.com/oembed/?format=json&scheme=https&url=http://www.youtube.com/watch?v=pO5L6vXtxsI
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Mozilla/5.0 (compatible; ruby-oembed/0.14.0)
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      P3p:
+      - CP="This is not a P3P policy! See http://support.google.com/accounts/answer/151657?hl=en
+        for more info."
+      Cache-Control:
+      - no-cache
+      Content-Type:
+      - application/json
+      Strict-Transport-Security:
+      - max-age=31536000
+      Expires:
+      - Tue, 27 Apr 1971 19:44:06 GMT
+      X-Content-Type-Options:
+      - nosniff
+      Date:
+      - Mon, 28 Dec 2020 15:32:04 GMT
+      Server:
+      - YouTube Frontend Proxy
+      X-Xss-Protection:
+      - '0'
+      Alt-Svc:
+      - h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443";
+        ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
+      Accept-Ranges:
+      - none
+      Vary:
+      - Accept-Encoding
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: '{"title":"CKEditor 4.5 - Embedding Media Resources with oEmbed","author_name":"CKEditor
+        Ecosystem","author_url":"https://www.youtube.com/c/CKEditor","type":"video","height":270,"width":480,"version":"1.0","provider_name":"YouTube","provider_url":"https://www.youtube.com/","thumbnail_height":360,"thumbnail_width":480,"thumbnail_url":"https://i.ytimg.com/vi/pO5L6vXtxsI/hqdefault.jpg","html":"\u003ciframe
+        width=\u0022480\u0022 height=\u0022270\u0022 src=\u0022https://www.youtube.com/embed/pO5L6vXtxsI?feature=oembed\u0022
+        frameborder=\u00220\u0022 allow=\u0022accelerometer; autoplay; clipboard-write;
+        encrypted-media; gyroscope; picture-in-picture\u0022 allowfullscreen\u003e\u003c/iframe\u003e"}'
+  recorded_at: Mon, 28 Dec 2020 15:32:04 GMT
+- request:
+    method: get
+    uri: https://www.youtube.com/oembed/?format=json&scheme=https&url=https://youtu.be/pO5L6vXtxsI
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Mozilla/5.0 (compatible; ruby-oembed/0.14.0)
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Expires:
+      - Tue, 27 Apr 1971 19:44:06 GMT
+      P3p:
+      - CP="This is not a P3P policy! See http://support.google.com/accounts/answer/151657?hl=en
+        for more info."
+      Content-Type:
+      - application/json
+      Cache-Control:
+      - no-cache
+      X-Content-Type-Options:
+      - nosniff
+      Strict-Transport-Security:
+      - max-age=31536000
+      Date:
+      - Mon, 28 Dec 2020 15:32:04 GMT
+      Server:
+      - YouTube Frontend Proxy
+      X-Xss-Protection:
+      - '0'
+      Alt-Svc:
+      - h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443";
+        ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
+      Accept-Ranges:
+      - none
+      Vary:
+      - Accept-Encoding
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: UTF-8
+      string: '{"title":"CKEditor 4.5 - Embedding Media Resources with oEmbed","author_name":"CKEditor
+        Ecosystem","author_url":"https://www.youtube.com/c/CKEditor","type":"video","height":270,"width":480,"version":"1.0","provider_name":"YouTube","provider_url":"https://www.youtube.com/","thumbnail_height":360,"thumbnail_width":480,"thumbnail_url":"https://i.ytimg.com/vi/pO5L6vXtxsI/hqdefault.jpg","html":"\u003ciframe
+        width=\u0022480\u0022 height=\u0022270\u0022 src=\u0022https://www.youtube.com/embed/pO5L6vXtxsI?feature=oembed\u0022
+        frameborder=\u00220\u0022 allow=\u0022accelerometer; autoplay; clipboard-write;
+        encrypted-media; gyroscope; picture-in-picture\u0022 allowfullscreen\u003e\u003c/iframe\u003e"}'
+  recorded_at: Mon, 28 Dec 2020 15:32:04 GMT
+- request:
+    method: get
+    uri: https://www.youtube.com/oembed/?format=json&scheme=https&url=https://youtu.be/NHriYTkvd0g
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Mozilla/5.0 (compatible; ruby-oembed/0.14.0)
+  response:
+    status:
+      code: 403
+      message: Forbidden
+    headers:
+      Strict-Transport-Security:
+      - max-age=31536000
+      Content-Length:
+      - '9'
+      X-Content-Type-Options:
+      - nosniff
+      Content-Type:
+      - text/html; charset=utf-8
+      Cache-Control:
+      - no-cache
+      P3p:
+      - CP="This is not a P3P policy! See http://support.google.com/accounts/answer/151657?hl=en
+        for more info."
+      Expires:
+      - Tue, 27 Apr 1971 19:44:06 GMT
+      Date:
+      - Mon, 28 Dec 2020 15:32:04 GMT
+      Server:
+      - YouTube Frontend Proxy
+      X-Xss-Protection:
+      - '0'
+      Alt-Svc:
+      - h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443";
+        ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
+    body:
+      encoding: UTF-8
+      string: Forbidden
+  recorded_at: Mon, 28 Dec 2020 15:32:04 GMT
+recorded_with: VCR 6.0.0

data/spec/provider_discovery_spec.rb

@@ -24,8 +24,8 @@ describe OEmbed::ProviderDiscovery do
       :json,
     ],
     'vimeo' => [
-      'http://vimeo.com/27953845',
-      {:json=>'http://vimeo.com/api/oembed.json', :xml=>'http://vimeo.com/api/oembed.xml'},
+      'https://vimeo.com/27953845',
+      {:json=>'https://vimeo.com/api/oembed.json', :xml=>'https://vimeo.com/api/oembed.xml'},
       :json,
     ],
     'facebook-photo' => [
@@ -38,11 +38,6 @@ describe OEmbed::ProviderDiscovery do
       'https://www.tumblr.com/oembed/1.0',
       :json
     ],
-    'noteflight' => [
-      'http://www.noteflight.com/scores/view/09665392c94475f65dfaf5f30aadb6ed0921939d',
-      {:json=>'http://www.noteflight.com/services/oembed', :xml=>'http://www.noteflight.com/services/oembed'},
-      :json,
-    ],
     # TODO: Enhance ProviderDiscovery to support arbitrary query parameters. See https://github.com/ruby-oembed/ruby-oembed/issues/15
     #'wordpress' => [
     #  'http://sweetandweak.wordpress.com/2011/09/23/nothing-starts-the-morning-like-a-good-dose-of-panic/',

data/spec/provider_spec.rb

@@ -49,108 +49,108 @@ describe OEmbed::Provider do
   end
 
   it "should allow no URI schema to be given" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-
-    expect(provier).to include("http://foo.com/1")
-    expect(provier).to include("http://bar.foo.com/1")
-    expect(provier).to include("http://bar.foo.com/show/1")
-    expect(provier).to include("https://bar.foo.com/1")
-    expect(provier).to include("http://asdf.com/1")
-    expect(provier).to include("asdf")
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+
+    expect(provider).to include("http://foo.com/1")
+    expect(provider).to include("http://bar.foo.com/1")
+    expect(provider).to include("http://bar.foo.com/show/1")
+    expect(provider).to include("https://bar.foo.com/1")
+    expect(provider).to include("http://asdf.com/1")
+    expect(provider).to include("asdf")
   end
 
   it "should allow a String as a URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << "http://bar.foo.com/*"
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << "http://bar.foo.com/*"
 
-    expect(provier).to include("http://bar.foo.com/1")
-    expect(provier).to include("http://bar.foo.com/show/1")
+    expect(provider).to include("http://bar.foo.com/1")
+    expect(provider).to include("http://bar.foo.com/show/1")
 
-    expect(provier).to_not include("https://bar.foo.com/1")
-    expect(provier).to_not include("http://foo.com/1")
+    expect(provider).to_not include("https://bar.foo.com/1")
+    expect(provider).to_not include("http://foo.com/1")
   end
 
   it "should allow multiple path wildcards in a String URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << "http://bar.foo.com/*/show/*"
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << "http://bar.foo.com/*/show/*"
 
-    expect(provier).to include("http://bar.foo.com/photo/show/1")
-    expect(provier).to include("http://bar.foo.com/video/show/2")
-    expect(provier).to include("http://bar.foo.com/help/video/show/2")
+    expect(provider).to include("http://bar.foo.com/photo/show/1")
+    expect(provider).to include("http://bar.foo.com/video/show/2")
+    expect(provider).to include("http://bar.foo.com/help/video/show/2")
 
-    expect(provier).to_not include("https://bar.foo.com/photo/show/1")
-    expect(provier).to_not include("http://foo.com/video/show/2")
-    expect(provier).to_not include("http://bar.foo.com/show/1")
-    expect(provier).to_not include("http://bar.foo.com/1")
+    expect(provider).to_not include("https://bar.foo.com/photo/show/1")
+    expect(provider).to_not include("http://foo.com/video/show/2")
+    expect(provider).to_not include("http://bar.foo.com/show/1")
+    expect(provider).to_not include("http://bar.foo.com/1")
   end
 
   it "should NOT allow multiple domain wildcards in a String URI schema", :pending => true do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
 
-    expect { provier << "http://*.com/*" }.
+    expect { provider << "http://*.com/*" }.
     to raise_error(ArgumentError)
 
-    expect(provier).to_not include("http://foo.com/1")
+    expect(provider).to_not include("http://foo.com/1")
   end
 
   it "should allow a sub-domain wildcard in String URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << "http://*.foo.com/*"
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << "http://*.foo.com/*"
 
-    expect(provier).to include("http://bar.foo.com/1")
-    expect(provier).to include("http://foo.foo.com/2")
-    expect(provier).to include("http://foo.com/3")
+    expect(provider).to include("http://bar.foo.com/1")
+    expect(provider).to include("http://foo.foo.com/2")
+    expect(provider).to include("http://foo.com/3")
 
-    expect(provier).to_not include("https://bar.foo.com/1")
-    expect(provier).to_not include("http://my.bar.foo.com/1")
+    expect(provider).to_not include("https://bar.foo.com/1")
+    expect(provider).to_not include("http://my.bar.foo.com/1")
 
-    provier << "http://my.*.foo.com/*"
+    provider << "http://my.*.foo.com/*"
   end
 
   it "should allow multiple sub-domain wildcards in a String URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << "http://*.my.*.foo.com/*"
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << "http://*.my.*.foo.com/*"
 
-    expect(provier).to include("http://my.bar.foo.com/1")
-    expect(provier).to include("http://my.foo.com/2")
-    expect(provier).to include("http://bar.my.bar.foo.com/3")
+    expect(provider).to include("http://my.bar.foo.com/1")
+    expect(provider).to include("http://my.foo.com/2")
+    expect(provider).to include("http://bar.my.bar.foo.com/3")
 
-    expect(provier).to_not include("http://bar.foo.com/1")
-    expect(provier).to_not include("http://foo.bar.foo.com/1")
+    expect(provider).to_not include("http://bar.foo.com/1")
+    expect(provider).to_not include("http://foo.bar.foo.com/1")
   end
 
   it "should NOT allow a scheme wildcard in a String URI schema", :pending => true do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
 
-    expect { provier << "*://foo.com/*" }.
+    expect { provider << "*://foo.com/*" }.
     to raise_error(ArgumentError)
 
-    expect(provier).to_not include("http://foo.com/1")
+    expect(provider).to_not include("http://foo.com/1")
   end
 
   it "should allow a scheme other than http in a String URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << "https://foo.com/*"
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << "https://foo.com/*"
 
-    expect(provier).to include("https://foo.com/1")
+    expect(provider).to include("https://foo.com/1")
 
     gopher_url = "gopher://foo.com/1"
-    expect(provier).to_not include(gopher_url)
-    provier << "gopher://foo.com/*"
-    expect(provier).to include(gopher_url)
+    expect(provider).to_not include(gopher_url)
+    provider << "gopher://foo.com/*"
+    expect(provider).to include(gopher_url)
   end
 
   it "should allow a Regexp as a URI schema" do
-    provier = OEmbed::Provider.new("http://foo.com/oembed")
-    provier << %r{^https?://([^\.]*\.)?foo.com/(show/)?\d+}
+    provider = OEmbed::Provider.new("http://foo.com/oembed")
+    provider << %r{^https?://([^\.]*\.)?foo.com/(show/)?\d+}
 
-    expect(provier).to include("http://bar.foo.com/1")
-    expect(provier).to include("http://bar.foo.com/show/1")
-    expect(provier).to include("http://foo.com/1")
-    expect(provier).to include("https://bar.foo.com/1")
+    expect(provider).to include("http://bar.foo.com/1")
+    expect(provider).to include("http://bar.foo.com/show/1")
+    expect(provider).to include("http://foo.com/1")
+    expect(provider).to include("https://bar.foo.com/1")
 
-    expect(provier).to_not include("http://bar.foo.com/video/1")
-    expect(provier).to_not include("gopher://foo.com/1")
+    expect(provider).to_not include("http://bar.foo.com/video/1")
+    expect(provider).to_not include("gopher://foo.com/1")
   end
 
   it "should by default use OEmbed::Formatter.default" do
@@ -267,37 +267,30 @@ describe OEmbed::Provider do
       @vimeo_ssl << "http://*.vimeo.com/*"
       @vimeo_ssl << "https://*.vimeo.com/*"
 
-      expect {
-        res = @vimeo_ssl.send(:raw, example_url(:vimeo_ssl))
-        expect(res).to eq(example_body(:vimeo_ssl))
-      }.not_to raise_error
+      res = @vimeo_ssl.send(:raw, example_url(:vimeo_ssl))
+      expect(res).to eq(example_body(:vimeo_ssl).strip)
     end
 
     it "should raise an UnknownFormat error on 501" do
-      # Note: This test relies on a custom-written VCR response in the
-      # cassettes/OEmbed_Provider.yml file.
+      stub_request(:get, /flickr/).to_return(status: 501)
 
       expect {
-        @flickr.send(:raw, File.join(example_url(:flickr), '501'))
+        result = @flickr.send(:raw, File.join(example_url(:flickr), '501'))
       }.to raise_error(OEmbed::UnknownFormat)
     end
 
     it "should raise a NotFound error on 404" do
-      # Note: This test relies on a custom-written VCR response in the
-      # cassettes/OEmbed_Provider.yml file.
+      stub_request(:get, /flickr/).to_return(status: 404)
 
       expect {
         @flickr.send(:raw, File.join(example_url(:flickr), '404'))
       }.to raise_error(OEmbed::NotFound)
     end
 
-    it "should raise an UnknownResponse error on other responses" do
-      # Note: This test relies on a custom-written VCR response in the
-      # cassettes/OEmbed_Provider.yml file.
-
-      statuses_to_check = ['405', '500']
+    ['405', '500'].each do |status|
+      it "should raise an UnknownResponse error on other responses (#{status})" do
+        stub_request(:get, /flickr/).to_return(status: status)
 
-      statuses_to_check.each do |status|
         expect {
           @flickr.send(:raw, File.join(example_url(:flickr), status))
         }.to raise_error(OEmbed::UnknownResponse)
@@ -364,7 +357,7 @@ describe OEmbed::Provider do
       @viddler.get(example_url(:viddler))
     end
 
-    it "handles the :timeout option" do
+    it "handles the :timeout option", pending: true do
       expect_any_instance_of(Net::HTTP).to receive(:open_timeout=).with(5)
       expect_any_instance_of(Net::HTTP).to receive(:read_timeout=).with(5)
       @flickr.get(example_url(:flickr), :timeout => 5)