ruby-net-nntp 0.2.1 → 0.2.2

data/CHANGELOG

@@ -1,4 +1,25 @@
-2007-08-22 17:00 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (1eb71d8b00b4 [tip])
+2008-01-17 15:01 +0100  Anton 'tony' Bangratz  <tony@twincode.net>  (e2a61a62dc59 [tip])
+
+	* .autotest, README, lib/net/nntp.rb, lib/net/nntp/version.rb, tags,
+	test/functional/test_nntp.rb, test/mock/mock_socket.rb:
+	doc fix, connected? method, code coverage
+
+	 * added some documentation, fixed doc error for 'raw'
+	response
+		* added acknowledgments to documentation
+		* added connected? method
+		* added more tests for better coverage
+
+2007-11-19 12:12 +0100  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (75b6c0f1fefa)
+
+	* lib/net/nntp/article.rb, lib/net/nntp/version.rb, tags,
+	test/unit/test_nntp_article.rb:
+	Bugfix release
+
+	 - fixed header parsing, closing #2
+		- fixed body parsing bug, closing #4
+
+2007-08-22 17:00 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (1eb71d8b00b4)
 
 	* lib/net/nntp.rb, lib/net/nntp/version.rb,
 	test/functional/test_nntp.rb:

data/README

@@ -38,3 +38,9 @@ to avoid conflicts with Object#id.
 
 Additionally, on request, Net::NNTP::Article has been changed from being a mere proxy for Net::NNTP#xover
 result lines to being able to parse HEAD, BODY and ARTICLE results and return a corresponding instance.
+
+== Acknowledgments
+
+Thanks to Ward Bekker and Geff Hanoian for finding and fixing bugs and providing me with useful hints and enhancements.
+Thanks to J�rgen Strobel for providing support and hosting of the code libraries and bug tracking system. Thanks to Tom
+Copeland and Rich Kilmer for rubyforge, and big thanks to Matz and everyone of the core team for Ruby.

data/lib/net/nntp.rb

@@ -65,6 +65,11 @@ module Net
       @welcome
     end
 
+    # Checks if socket is still valid and connected
+    def connected?
+      @socket && !@socket.closed?
+    end
+
     # Sends QUIT command to server and closes the connection (unless force_close is set to false). Returns response.
     def quit(force_close=true)
       send_cmd "QUIT"
@@ -269,7 +274,7 @@ module Net
       end
     end
 
-    # Issues 'BODY' command to NNTP server, returning raw response.
+    # Issues 'BODY' command to NNTP server, returning raw response as array of lines.
     # options:: messageid|id
     #
     # Throws CommandFailedError
@@ -350,6 +355,9 @@ module Net
       @socket.write(cmd+"\r\n")
     end
 
+    # Reads response from server socket. On multiline responses according to RFC, the response will be returned as an
+    # array of lines, else as an array including the response on one line. Parameter force_online can be used to
+    # override this behaviour and just read one line from the server.
     def read_response(force_oneline=false)
       response = ''
       str = ''

data/lib/net/nntp/version.rb

@@ -1,5 +1,5 @@
 module Net      
   class NNTP
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/test/functional/test_nntp.rb

@@ -37,9 +37,25 @@ module TestNet
     def test_connect
       assert_nothing_raised do
         @nntp.connect
+        assert @nntp.connected?
       end
     end
 
+    def test_close
+      assert_nothing_raised do
+        @nntp.connect
+        assert @nntp.connected?
+        @nntp.close
+        assert !@nntp.connected?
+      end
+    end
+
+    def test_quit
+      @nntp.connect
+      quit = @nntp.quit.join
+      assert_equal '200', quit[0..2]
+    end
+
     def test_response_timeout
       assert_equal 10, @nntp.response_timeout
       @nntp.response_timeout = 11

data/test/mock/mock_socket.rb

@@ -6,11 +6,18 @@ class MockSocket < Test::Unit::MockObject( TCPSocket )
     @authenticated = false
     @group_selected = nil
     @last_article = nil
+    @is_closed = false
   end
 
-  def alive?
+
+  def closed?
+    super
+    @is_closed
+  end
+
+  def close
     super
-    true
+    @is_closed=true
   end
 
   def recv(len)

metadata

@@ -1,38 +1,41 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.4
-specification_version: 1
 name: ruby-net-nntp
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
-date: 2007-11-19 00:00:00 +01:00
-summary: Net::XXX style NNTP Library for easy access.
-require_paths: 
-- lib
-email: anton.bangratz@gmail.com
-homepage: 
-rubyforge_project: 
-description: ""
-autorequire: 
-default_executable: 
-bindir: bin
-has_rdoc: true
-required_ruby_version: !ruby/object:Gem::Version::Requirement 
-  requirements: 
-  - - ">"
-    - !ruby/object:Gem::Version 
-      version: 0.0.0
-  version: 
+  version: 0.2.2
 platform: ruby
-signing_key: 
-cert_chain: 
-post_install_message: 
 authors: 
 - Anton Bangratz
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2008-01-17 00:00:00 +01:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: log4r
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+    version: 
+description: ""
+email: anton.bangratz@gmail.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: 
+- README
+- CHANGELOG
+- MIT-LICENSE
 files: 
 - lib/net
 - lib/net/nntp
-- lib/net/nntp/group.rb
 - lib/net/nntp/article.rb
+- lib/net/nntp/group.rb
 - lib/net/nntp/version.rb
 - lib/net/nntp.rb
 - test/functional
@@ -40,41 +43,45 @@ files:
 - test/mock
 - test/mock/mock_socket.rb
 - test/unit
-- test/unit/test_nntp_group.rb
 - test/unit/test_nntp_article.rb
+- test/unit/test_nntp_group.rb
 - README
 - CHANGELOG
 - MIT-LICENSE
-test_files: 
-- test/functional
-- test/functional/test_nntp.rb
-- test/mock
-- test/mock/mock_socket.rb
-- test/unit
-- test/unit/test_nntp_group.rb
-- test/unit/test_nntp_article.rb
+has_rdoc: true
+homepage: 
+post_install_message: 
 rdoc_options: 
 - -S
 - -N
 - --main
 - README
-extra_rdoc_files: 
-- README
-- CHANGELOG
-- MIT-LICENSE
-executables: []
-
-extensions: []
-
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
 requirements: []
 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: log4r
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Version::Requirement 
-    requirements: 
-    - - ">"
-      - !ruby/object:Gem::Version 
-        version: 0.0.0
-    version: 
+rubyforge_project: 
+rubygems_version: 1.0.1
+signing_key: 
+specification_version: 2
+summary: Net::XXX style NNTP Library for easy access.
+test_files: 
+- test/functional
+- test/functional/test_nntp.rb
+- test/mock
+- test/mock/mock_socket.rb
+- test/unit
+- test/unit/test_nntp_article.rb
+- test/unit/test_nntp_group.rb