ruby-mp3info 0.7.1 → 0.7.2

data/History.txt

@@ -1,3 +1,7 @@
+=== 0.7.2 / 2012-12-24
+
+* do not try to commit changes to IO or StringIO
+
 === 0.7.1 / 2012-04-01
 
 * convert to utf-16 little endian (instead of big) for more compatibility

data/README.txt

@@ -56,7 +56,7 @@ mp3 files.
 
 == REQUIREMENTS:
 
-* iconv
+* iconv when using ruby 1.8
 
 == INSTALL:
 

data/lib/mp3info.rb

@@ -18,7 +18,7 @@ end
 
 class Mp3Info
 
-  VERSION = "0.7.1"
+  VERSION = "0.7.2"
 
   LAYER = [ nil, 3, 2, 1]
   BITRATE = {
@@ -234,7 +234,7 @@ class Mp3Info
   def reload
     @header = {}
 
-    if @filename_or_io.is_a?(StringIO)
+    if @filename_or_io.is_a?(StringIO) || @filename_or_io.is_a?(IO)
       @io_is_a_file = false
       @io = @filename_or_io
       @io_size = @io.size
@@ -683,7 +683,7 @@ private
       @length = ((stream_size << 3)/1000.0)/@bitrate
       # read the first 100 frames and decide if the mp3 is vbr and needs full scan
       begin
-        bitrate, length = frame_scan(100)
+        bitrate = frame_scan(100).first
         if @bitrate != bitrate
           @vbr = true
           @bitrate, @length = frame_scan

data/lib/mp3info/extension_modules.rb

@@ -65,11 +65,7 @@ class Mp3Info
     end
 
     def self.ruby_18_encode(from, to, value)
-      begin
-        Iconv.iconv(to, from, value).first
-      rescue Iconv::Failure
-        value
-      end
+      Iconv.iconv(to, from, value).first
     end
 
     def self.decode_utf16(out)

data/lib/mp3info/id3v2.rb

@@ -223,7 +223,7 @@ class ID3v2 < DelegateClass(Hash)
     original_pos = @io.pos
     @io.extend(Mp3Info::Mp3FileMethods)
     version_maj, version_min, flags = @io.read(3).unpack("CCB4")
-    @unsync, ext_header, experimental, footer = (0..3).collect { |i| flags[i].chr == '1' }
+    @unsync, ext_header, _, _ = (0..3).collect { |i| flags[i].chr == '1' }  # _, _ = experimental, footer
     raise(ID3v2Error, "can't find version_maj ('#{version_maj}')") unless [2, 3, 4].include?(version_maj)
     @version_maj, @version_min = version_maj, version_min
     @tag_length = @io.get_syncsafe

data/test/test_ruby-mp3info.rb

@@ -447,6 +447,13 @@ class Mp3InfoTest < Test::Unit::TestCase
     assert_equal(expected, s.bytes.map{|b| b.to_s(16).rjust(2,"0")}.to_a.join(" "))
   end
 
+  def test_modifying_an_io
+    io = open(TEMP_FILE, "r")
+    Mp3Info.open(io) do |mp3| 
+      mp3.tag.artist = "test_artist"
+    end
+  end
+
   def compute_audio_content_mp3_digest(mp3)
     pos, size = mp3.audio_content
     data = File.open(mp3.filename) do |f|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-mp3info
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,30 +9,40 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-01 00:00:00.000000000Z
+date: 2012-12-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rdoc
-  requirement: &73102580 !ruby/object:Gem::Requirement
+  name: hoe-yard
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: 0.1.2
   type: :development
   prerelease: false
-  version_requirements: *73102580
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 0.1.2
 - !ruby/object:Gem::Dependency
   name: hoe
-  requirement: &73101600 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '3.4'
   type: :development
   prerelease: false
-  version_requirements: *73101600
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.4'
 description: ! 'ruby-mp3info read low-level informations and manipulate tags on
 
   mp3 files.'
@@ -58,8 +68,9 @@ homepage: http://github.com/moumar/ruby-mp3info
 licenses: []
 post_install_message: 
 rdoc_options:
-- --main
-- README.txt
+- --title
+- TestRuby::TestMp3info Documentation
+- --quiet
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -76,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: ruby-mp3info
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: ruby-mp3info read low-level informations and manipulate tags on mp3 files.