ruby-marc-spec 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7c07c75f4d7301b6a165724f8753630010c0df3b468b81c2debcc6ad38fb4d1
-  data.tar.gz: 36e1a57d33df1a5fe2553ec3fce562e08e58d2664c55262a644eeb49fecad4e4
+  metadata.gz: bf2331d16b9bc58bb638a8114e8e2cb752b5ed1fc328a2ed2a5bc12a0dcaf5d9
+  data.tar.gz: b77bbe6bfae6926f4771ad0c3ca91d4c037cf254880d6a89846c7ea13a2dd11a
 SHA512:
-  metadata.gz: b08b4c373d701cf2e0a2e43c45fbb7081893f257437e7b8e6e6c4583e0cf4440869b3e25f0f31006f2c8be8a63953468ec39af8c94d9a03dc6bb1ccedbc4baef
-  data.tar.gz: b49627593b4e74361e443f4536145cc365d3ace763f87ee312263a968b65002f1696c389b14fc45376ac168950ae3293746f0435723080c98b51a26029931094
+  metadata.gz: 2f9ae89dcdb0249075a2bed9e605b2b7bb5dd906f0c907d1646fcaa6686c8198a6f0e154c9ebe1d2692c854d79c1082cb3a924bb33aa1c6406c03026ca65f63a
+  data.tar.gz: 1d408f4496ec3fb1221497d977716442ab35f799baa1d33109d1e5cd2b6af618b909a0f83db39b0bc2b74a3559672c3d54d596334679d815ed45bec3e9a455b7

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 0.1.3 (2022-02-02)
+
+- Fix issue where applying subspecs against a subfield value as an implicit
+  left-hand subterm would produce `NoMethodError`.
+
 # 0.1.2 (2022-02-01)
 
 - Adds `MARC::Spec#exists?` to check if a MARC record has data matching a

data/lib/marc/spec/module_info.rb

@@ -7,7 +7,7 @@ module MARC
       SUMMARY = 'MARCspec for Ruby'.freeze
       DESCRIPTION = 'An implementation of the MARCspec query language for Ruby and ruby-marc'.freeze
       LICENSE = 'MIT'.freeze
-      VERSION = '0.1.2'.freeze
+      VERSION = '0.1.3'.freeze
       HOMEPAGE = 'https://github.com/BerkeleyLibrary/marc-spec'.freeze
     end
   end

data/lib/marc/spec/queries/condition_context.rb

@@ -15,7 +15,7 @@ module MARC
         end
 
         def operand_value(operand, implicit: false)
-          return context_result if implicit && operand.nil?
+          return operand_value(context_result) if implicit && operand.nil?
 
           raw_value = operand_value_raw(operand)
           is_boolean = [true, false].include?(raw_value)
@@ -25,16 +25,11 @@ module MARC
         private
 
         def operand_value_raw(operand)
-          return unless operand
-
-          case operand
-          when ComparisonString
-            operand.str_exact
-          when Condition
-            operand.met?(self)
-          when Query
-            operand.execute(executor, [context_field], context_result)
-          end
+          return operand.str_exact if operand.is_a?(ComparisonString)
+          return operand.met?(self) if operand.is_a?(Condition)
+          return operand.execute(executor, [context_field], context_result) if operand.is_a?(Query)
+
+          operand
         end
 
         def as_string(op_val)

data/spec/marc/spec/queries/query_spec.rb

@@ -208,9 +208,20 @@ module MARC::Spec
             }
             verify_all(examples)
           end
+
+          it 'can check for substrings in subfield values' do
+            df260 = marc_record['260']
+            df260a = df260.subfields.find { |sf| sf.code == 'a' }
+            examples = {
+              '260{$a~\Diego}' => [df260],
+              '260$a{~\Diego}' => [df260a],
+              '260$a{~\Los\sAngeles}' => [],
+              '260{$a~\Los\sAngeles}' => []
+            }
+            verify_all(examples)
+          end
         end
       end
     end
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-marc-spec
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - David Moles