ruby-lsp 0.9.3 → 0.10.0

data/lib/ruby_lsp/requests/definition.rb

@@ -17,14 +17,14 @@ module RubyLsp
     # require "some_gem/file" # <- Request go to definition on this string will take you to the file
     # Product.new # <- Request go to definition on this class name will take you to its declaration.
     # ```
-    class Definition < Listener
+    class Definition < ExtensibleListener
       extend T::Sig
       extend T::Generic
 
       ResponseType = type_member { { fixed: T.nilable(T.any(T::Array[Interface::Location], Interface::Location)) } }
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig do
         params(
@@ -36,15 +36,37 @@ module RubyLsp
         ).void
       end
       def initialize(uri, nesting, index, emitter, message_queue)
-        super(emitter, message_queue)
-
         @uri = uri
         @nesting = nesting
         @index = index
-        @response = T.let(nil, ResponseType)
+        @_response = T.let(nil, ResponseType)
+
+        super(emitter, message_queue)
+
         emitter.register(self, :on_command, :on_const, :on_const_path_ref)
       end
 
+      sig { override.params(ext: Extension).returns(T.nilable(RubyLsp::Listener[ResponseType])) }
+      def initialize_external_listener(ext)
+        ext.create_definition_listener(@uri, @nesting, @index, @emitter, @message_queue)
+      end
+
+      sig { override.params(other: Listener[ResponseType]).returns(T.self_type) }
+      def merge_response!(other)
+        other_response = other._response
+
+        case @_response
+        when Interface::Location
+          @_response = [@_response, *other_response]
+        when Array
+          @_response.concat(Array(other_response))
+        when nil
+          @_response = other_response
+        end
+
+        self
+      end
+
       sig { params(node: SyntaxTree::ConstPathRef).void }
       def on_const_path_ref(node)
         name = full_constant_name(node)
@@ -67,14 +89,16 @@ module RubyLsp
         string = argument.parts.first
         return unless string.is_a?(SyntaxTree::TStringContent)
 
-        required_file = "#{string.value}.rb"
-
         case message
         when "require"
-          candidate = find_file_in_load_path(required_file)
+          entry = @index.search_require_paths(string.value).find do |indexable_path|
+            indexable_path.require_path == string.value
+          end
+
+          if entry
+            candidate = entry.full_path
 
-          if candidate
-            @response = Interface::Location.new(
+            @_response = Interface::Location.new(
               uri: URI::Generic.from_path(path: candidate).to_s,
               range: Interface::Range.new(
                 start: Interface::Position.new(line: 0, character: 0),
@@ -83,19 +107,18 @@ module RubyLsp
             )
           end
         when "require_relative"
+          required_file = "#{string.value}.rb"
           path = @uri.to_standardized_path
           current_folder = path ? Pathname.new(CGI.unescape(path)).dirname : Dir.pwd
           candidate = File.expand_path(File.join(current_folder, required_file))
 
-          if candidate
-            @response = Interface::Location.new(
-              uri: URI::Generic.from_path(path: candidate).to_s,
-              range: Interface::Range.new(
-                start: Interface::Position.new(line: 0, character: 0),
-                end: Interface::Position.new(line: 0, character: 0),
-              ),
-            )
-          end
+          @_response = Interface::Location.new(
+            uri: URI::Generic.from_path(path: candidate).to_s,
+            range: Interface::Range.new(
+              start: Interface::Position.new(line: 0, character: 0),
+              end: Interface::Position.new(line: 0, character: 0),
+            ),
+          )
         end
       end
 
@@ -112,7 +135,7 @@ module RubyLsp
           nil
         end
 
-        @response = entries.filter_map do |entry|
+        @_response = entries.filter_map do |entry|
           location = entry.location
           # If the project has Sorbet, then we only want to handle go to definition for constants defined in gems, as an
           # additional behavior on top of jumping to RBIs. Sorbet can already handle go to definition for all constants
@@ -133,18 +156,6 @@ module RubyLsp
           )
         end
       end
-
-      sig { params(file: String).returns(T.nilable(String)) }
-      def find_file_in_load_path(file)
-        return unless file.include?("/")
-
-        $LOAD_PATH.each do |p|
-          found = Dir.glob("**/#{file}", base: p).first
-          return "#{p}/#{found}" if found
-        end
-
-        nil
-      end
     end
   end
 end

data/lib/ruby_lsp/requests/document_highlight.rb

@@ -28,7 +28,7 @@ module RubyLsp
       ResponseType = type_member { { fixed: T::Array[Interface::DocumentHighlight] } }
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig do
         params(
@@ -41,7 +41,7 @@ module RubyLsp
       def initialize(target, parent, emitter, message_queue)
         super(emitter, message_queue)
 
-        @response = T.let([], T::Array[Interface::DocumentHighlight])
+        @_response = T.let([], T::Array[Interface::DocumentHighlight])
 
         return unless target && parent
 
@@ -83,7 +83,7 @@ module RubyLsp
       sig { params(match: Support::HighlightTarget::HighlightMatch).void }
       def add_highlight(match)
         range = range_from_syntax_tree_node(match.node)
-        @response << Interface::DocumentHighlight.new(range: range, kind: match.type)
+        @_response << Interface::DocumentHighlight.new(range: range, kind: match.type)
       end
     end
   end

data/lib/ruby_lsp/requests/document_link.rb

@@ -73,7 +73,7 @@ module RubyLsp
       end
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig { params(uri: URI::Generic, emitter: EventEmitter, message_queue: Thread::Queue).void }
       def initialize(uri, emitter, message_queue)
@@ -84,7 +84,7 @@ module RubyLsp
         path = uri.to_standardized_path
         version_match = path ? /(?<=%40)[\d.]+(?=\.rbi$)/.match(path) : nil
         @gem_version = T.let(version_match && version_match[0], T.nilable(String))
-        @response = T.let([], T::Array[Interface::DocumentLink])
+        @_response = T.let([], T::Array[Interface::DocumentLink])
 
         emitter.register(self, :on_comment)
       end
@@ -99,7 +99,7 @@ module RubyLsp
         file_path = self.class.gem_paths.dig(uri.gem_name, gem_version, CGI.unescape(uri.path))
         return if file_path.nil?
 
-        @response << Interface::DocumentLink.new(
+        @_response << Interface::DocumentLink.new(
           range: range_from_syntax_tree_node(node),
           target: "file://#{file_path}##{uri.line_number}",
           tooltip: "Jump to #{file_path}##{uri.line_number}",

data/lib/ruby_lsp/requests/document_symbol.rb

@@ -26,7 +26,7 @@ module RubyLsp
     #   end
     # end
     # ```
-    class DocumentSymbol < Listener
+    class DocumentSymbol < ExtensibleListener
       extend T::Sig
       extend T::Generic
 
@@ -47,22 +47,18 @@ module RubyLsp
       end
 
       sig { override.returns(T::Array[Interface::DocumentSymbol]) }
-      attr_reader :response
+      attr_reader :_response
 
       sig { params(emitter: EventEmitter, message_queue: Thread::Queue).void }
       def initialize(emitter, message_queue)
-        super
-
         @root = T.let(SymbolHierarchyRoot.new, SymbolHierarchyRoot)
-        @response = T.let(@root.children, T::Array[Interface::DocumentSymbol])
+        @_response = T.let(@root.children, T::Array[Interface::DocumentSymbol])
         @stack = T.let(
           [@root],
           T::Array[T.any(SymbolHierarchyRoot, Interface::DocumentSymbol)],
         )
 
-        @external_listeners.concat(
-          Extension.extensions.filter_map { |ext| ext.create_document_symbol_listener(emitter, message_queue) },
-        )
+        super
 
         emitter.register(
           self,
@@ -79,10 +75,15 @@ module RubyLsp
         )
       end
 
+      sig { override.params(extension: RubyLsp::Extension).returns(T.nilable(Listener[ResponseType])) }
+      def initialize_external_listener(extension)
+        extension.create_document_symbol_listener(@emitter, @message_queue)
+      end
+
       # Merges responses from other listeners
       sig { override.params(other: Listener[ResponseType]).returns(T.self_type) }
       def merge_response!(other)
-        @response.concat(other.response)
+        @_response.concat(other.response)
         self
       end
 

data/lib/ruby_lsp/requests/hover.rb

@@ -13,7 +13,7 @@ module RubyLsp
     # ```ruby
     # String # -> Hovering over the class reference will show all declaration locations and the documentation
     # ```
-    class Hover < Listener
+    class Hover < ExtensibleListener
       extend T::Sig
       extend T::Generic
 
@@ -30,7 +30,7 @@ module RubyLsp
       )
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig do
         params(
@@ -41,27 +41,29 @@ module RubyLsp
         ).void
       end
       def initialize(index, nesting, emitter, message_queue)
-        super(emitter, message_queue)
-
         @nesting = nesting
         @index = index
-        @external_listeners.concat(
-          Extension.extensions.filter_map { |ext| ext.create_hover_listener(emitter, message_queue) },
-        )
-        @response = T.let(nil, ResponseType)
+        @_response = T.let(nil, ResponseType)
+
+        super(emitter, message_queue)
         emitter.register(self, :on_const_path_ref, :on_const)
       end
 
+      sig { override.params(extension: RubyLsp::Extension).returns(T.nilable(Listener[ResponseType])) }
+      def initialize_external_listener(extension)
+        extension.create_hover_listener(@emitter, @message_queue)
+      end
+
       # Merges responses from other hover listeners
       sig { override.params(other: Listener[ResponseType]).returns(T.self_type) }
       def merge_response!(other)
         other_response = other.response
         return self unless other_response
 
-        if @response.nil?
-          @response = other.response
+        if @_response.nil?
+          @_response = other.response
         else
-          @response.contents.value << "\n\n" << other_response.contents.value
+          @_response.contents.value << "\n\n" << other_response.contents.value
         end
 
         self
@@ -89,29 +91,10 @@ module RubyLsp
         entries = @index.resolve(name, @nesting)
         return unless entries
 
-        title = +"```ruby\n#{name}\n```"
-        definitions = []
-        content = +""
-        entries.each do |entry|
-          loc = entry.location
-
-          # We always handle locations as zero based. However, for file links in Markdown we need them to be one based,
-          # which is why instead of the usual subtraction of 1 to line numbers, we are actually adding 1 to columns. The
-          # format for VS Code file URIs is `file:///path/to/file.rb#Lstart_line,start_column-end_line,end_column`
-          uri = URI::Generic.from_path(
-            path: entry.file_path,
-            fragment: "L#{loc.start_line},#{loc.start_column + 1}-#{loc.end_line},#{loc.end_column + 1}",
-          )
-
-          definitions << "[#{entry.file_name}](#{uri})"
-          content << "\n\n#{entry.comments.join("\n")}" unless entry.comments.empty?
-        end
-
-        contents = Interface::MarkupContent.new(
-          kind: "markdown",
-          value: "#{title}\n\n**Definitions**: #{definitions.join(" | ")}\n\n#{content}",
+        @_response = Interface::Hover.new(
+          range: range_from_syntax_tree_node(node),
+          contents: markdown_from_index_entries(name, entries),
         )
-        @response = Interface::Hover.new(range: range_from_syntax_tree_node(node), contents: contents)
       end
     end
   end

data/lib/ruby_lsp/requests/inlay_hints.rb

@@ -27,13 +27,13 @@ module RubyLsp
       RESCUE_STRING_LENGTH = T.let("rescue".length, Integer)
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig { params(range: T::Range[Integer], emitter: EventEmitter, message_queue: Thread::Queue).void }
       def initialize(range, emitter, message_queue)
         super(emitter, message_queue)
 
-        @response = T.let([], ResponseType)
+        @_response = T.let([], ResponseType)
         @range = range
 
         emitter.register(self, :on_rescue)
@@ -47,7 +47,7 @@ module RubyLsp
         loc = node.location
         return unless visible?(node, @range)
 
-        @response << Interface::InlayHint.new(
+        @_response << Interface::InlayHint.new(
           position: { line: loc.start_line - 1, character: loc.start_column + RESCUE_STRING_LENGTH },
           label: "StandardError",
           padding_left: true,

data/lib/ruby_lsp/requests/semantic_highlighting.rb

@@ -105,7 +105,7 @@ module RubyLsp
       end
 
       sig { override.returns(ResponseType) }
-      attr_reader :response
+      attr_reader :_response
 
       sig do
         params(
@@ -117,7 +117,7 @@ module RubyLsp
       def initialize(emitter, message_queue, range: nil)
         super(emitter, message_queue)
 
-        @response = T.let([], ResponseType)
+        @_response = T.let([], ResponseType)
         @range = range
         @special_methods = T.let(nil, T.nilable(T::Array[String]))
 
@@ -174,7 +174,7 @@ module RubyLsp
         # When finding a module or class definition, we will have already pushed a token related to this constant. We
         # need to look at the previous two tokens and if they match this locatione exactly, avoid pushing another token
         # on top of the previous one
-        return if @response.last(2).any? { |token| token.location == node.location }
+        return if @_response.last(2).any? { |token| token.location == node.location }
 
         add_token(node.location, :namespace)
       end
@@ -327,7 +327,7 @@ module RubyLsp
       def add_token(location, type, modifiers = [])
         length = location.end_char - location.start_char
         modifiers_indices = modifiers.filter_map { |modifier| TOKEN_MODIFIERS[modifier] }
-        @response.push(
+        @_response.push(
           SemanticToken.new(
             location: location,
             length: length,

data/lib/ruby_lsp/requests/support/common.rb

@@ -74,6 +74,39 @@ module RubyLsp
             data: data,
           )
         end
+
+        sig { params(title: String, entries: T::Array[RubyIndexer::Index::Entry]).returns(Interface::MarkupContent) }
+        def markdown_from_index_entries(title, entries)
+          markdown_title = "```ruby\n#{title}\n```"
+          definitions = []
+          content = +""
+          entries.each do |entry|
+            loc = entry.location
+
+            # We always handle locations as zero based. However, for file links in Markdown we need them to be one
+            # based, which is why instead of the usual subtraction of 1 to line numbers, we are actually adding 1 to
+            # columns. The format for VS Code file URIs is
+            # `file:///path/to/file.rb#Lstart_line,start_column-end_line,end_column`
+            uri = URI::Generic.from_path(
+              path: entry.file_path,
+              fragment: "L#{loc.start_line},#{loc.start_column + 1}-#{loc.end_line},#{loc.end_column + 1}",
+            )
+
+            definitions << "[#{entry.file_name}](#{uri})"
+            content << "\n\n#{entry.comments.join("\n")}" unless entry.comments.empty?
+          end
+
+          Interface::MarkupContent.new(
+            kind: "markdown",
+            value: <<~MARKDOWN.chomp,
+              #{markdown_title}
+
+              **Definitions**: #{definitions.join(" | ")}
+
+              #{content}
+            MARKDOWN
+          )
+        end
       end
     end
   end

data/lib/ruby_lsp/requests.rb

@@ -17,7 +17,7 @@ module RubyLsp
   # - [CodeActionResolve](rdoc-ref:RubyLsp::Requests::CodeActionResolve)
   # - [DocumentHighlight](rdoc-ref:RubyLsp::Requests::DocumentHighlight)
   # - [InlayHint](rdoc-ref:RubyLsp::Requests::InlayHints)
-  # - [PathCompletion](rdoc-ref:RubyLsp::Requests::PathCompletion)
+  # - [Completion](rdoc-ref:RubyLsp::Requests::Completion)
   # - [CodeLens](rdoc-ref:RubyLsp::Requests::CodeLens)
   # - [Definition](rdoc-ref:RubyLsp::Requests::Definition)
   # - [ShowSyntaxTree](rdoc-ref:RubyLsp::Requests::ShowSyntaxTree)
@@ -38,7 +38,7 @@ module RubyLsp
     autoload :CodeActionResolve, "ruby_lsp/requests/code_action_resolve"
     autoload :DocumentHighlight, "ruby_lsp/requests/document_highlight"
     autoload :InlayHints, "ruby_lsp/requests/inlay_hints"
-    autoload :PathCompletion, "ruby_lsp/requests/path_completion"
+    autoload :Completion, "ruby_lsp/requests/completion"
     autoload :CodeLens, "ruby_lsp/requests/code_lens"
     autoload :Definition, "ruby_lsp/requests/definition"
     autoload :ShowSyntaxTree, "ruby_lsp/requests/show_syntax_tree"
@@ -53,7 +53,6 @@ module RubyLsp
       autoload :Sorbet, "ruby_lsp/requests/support/sorbet"
       autoload :HighlightTarget, "ruby_lsp/requests/support/highlight_target"
       autoload :RailsDocumentClient, "ruby_lsp/requests/support/rails_document_client"
-      autoload :PrefixTree, "ruby_lsp/requests/support/prefix_tree"
       autoload :Common, "ruby_lsp/requests/support/common"
       autoload :FormatterRunner, "ruby_lsp/requests/support/formatter_runner"
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lsp
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.10.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-09-01 00:00:00.000000000 Z
+date: 2023-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: language_server-protocol
@@ -67,7 +67,7 @@ dependencies:
         version: '0.9'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -77,7 +77,7 @@ dependencies:
         version: '0.9'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
 description: An opinionated language server for Ruby
 email:
 - ruby@shopify.com
@@ -97,12 +97,15 @@ files:
 - lib/ruby-lsp.rb
 - lib/ruby_indexer/lib/ruby_indexer/configuration.rb
 - lib/ruby_indexer/lib/ruby_indexer/index.rb
+- lib/ruby_indexer/lib/ruby_indexer/indexable_path.rb
+- lib/ruby_indexer/lib/ruby_indexer/prefix_tree.rb
 - lib/ruby_indexer/lib/ruby_indexer/visitor.rb
 - lib/ruby_indexer/ruby_indexer.rb
 - lib/ruby_indexer/test/classes_and_modules_test.rb
 - lib/ruby_indexer/test/configuration_test.rb
 - lib/ruby_indexer/test/constant_test.rb
 - lib/ruby_indexer/test/index_test.rb
+- lib/ruby_indexer/test/prefix_tree_test.rb
 - lib/ruby_indexer/test/test_case.rb
 - lib/ruby_lsp/check_docs.rb
 - lib/ruby_lsp/document.rb
@@ -116,6 +119,7 @@ files:
 - lib/ruby_lsp/requests/code_action_resolve.rb
 - lib/ruby_lsp/requests/code_actions.rb
 - lib/ruby_lsp/requests/code_lens.rb
+- lib/ruby_lsp/requests/completion.rb
 - lib/ruby_lsp/requests/definition.rb
 - lib/ruby_lsp/requests/diagnostics.rb
 - lib/ruby_lsp/requests/document_highlight.rb
@@ -126,7 +130,6 @@ files:
 - lib/ruby_lsp/requests/hover.rb
 - lib/ruby_lsp/requests/inlay_hints.rb
 - lib/ruby_lsp/requests/on_type_formatting.rb
-- lib/ruby_lsp/requests/path_completion.rb
 - lib/ruby_lsp/requests/selection_ranges.rb
 - lib/ruby_lsp/requests/semantic_highlighting.rb
 - lib/ruby_lsp/requests/show_syntax_tree.rb
@@ -135,7 +138,6 @@ files:
 - lib/ruby_lsp/requests/support/dependency_detector.rb
 - lib/ruby_lsp/requests/support/formatter_runner.rb
 - lib/ruby_lsp/requests/support/highlight_target.rb
-- lib/ruby_lsp/requests/support/prefix_tree.rb
 - lib/ruby_lsp/requests/support/rubocop_diagnostic.rb
 - lib/ruby_lsp/requests/support/rubocop_diagnostics_runner.rb
 - lib/ruby_lsp/requests/support/rubocop_formatting_runner.rb
@@ -170,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.18
+rubygems_version: 3.4.19
 signing_key: 
 specification_version: 4
 summary: An opinionated language server for Ruby

data/lib/ruby_lsp/requests/path_completion.rb

@@ -1,65 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-module RubyLsp
-  module Requests
-    # ![Path completion demo](../../path_completion.gif)
-    #
-    # The [completion](https://microsoft.github.io/language-server-protocol/specification#textDocument_completion)
-    # request looks up Ruby files in the $LOAD_PATH to suggest path completion inside `require` statements.
-    #
-    # # Example
-    #
-    # ```ruby
-    # require "ruby_lsp/requests" # --> completion: suggests `base_request`, `code_actions`, ...
-    # ```
-    class PathCompletion < Listener
-      extend T::Sig
-      extend T::Generic
-
-      ResponseType = type_member { { fixed: T::Array[Interface::CompletionItem] } }
-
-      sig { override.returns(ResponseType) }
-      attr_reader :response
-
-      sig { params(emitter: EventEmitter, message_queue: Thread::Queue).void }
-      def initialize(emitter, message_queue)
-        super
-        @response = T.let([], ResponseType)
-        @tree = T.let(Support::PrefixTree.new(collect_load_path_files), Support::PrefixTree)
-
-        emitter.register(self, :on_tstring_content)
-      end
-
-      sig { params(node: SyntaxTree::TStringContent).void }
-      def on_tstring_content(node)
-        @tree.search(node.value).sort.each do |path|
-          @response << build_completion(path, node)
-        end
-      end
-
-      private
-
-      sig { returns(T::Array[String]) }
-      def collect_load_path_files
-        $LOAD_PATH.flat_map do |p|
-          Dir.glob("**/*.rb", base: p)
-        end.map! do |result|
-          result.delete_suffix!(".rb")
-        end
-      end
-
-      sig { params(label: String, node: SyntaxTree::TStringContent).returns(Interface::CompletionItem) }
-      def build_completion(label, node)
-        Interface::CompletionItem.new(
-          label: label,
-          text_edit: Interface::TextEdit.new(
-            range: range_from_syntax_tree_node(node),
-            new_text: label,
-          ),
-          kind: Constant::CompletionItemKind::REFERENCE,
-        )
-      end
-    end
-  end
-end

data/lib/ruby_lsp/requests/support/prefix_tree.rb

@@ -1,80 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-module RubyLsp
-  module Requests
-    module Support
-      class PrefixTree
-        extend T::Sig
-
-        sig { params(items: T::Array[String]).void }
-        def initialize(items)
-          @root = T.let(Node.new(""), Node)
-
-          items.each do |item|
-            insert(item)
-          end
-        end
-
-        sig { params(prefix: String).returns(T::Array[String]) }
-        def search(prefix)
-          node = T.let(@root, Node)
-
-          prefix.each_char do |char|
-            snode = node.children[char]
-            return [] unless snode
-
-            node = snode
-          end
-
-          node.collect
-        end
-
-        private
-
-        sig { params(item: String).void }
-        def insert(item)
-          node = T.let(@root, Node)
-
-          item.each_char do |char|
-            node = node.children[char] ||= Node.new(node.value + char)
-          end
-
-          node.leaf = true
-        end
-
-        class Node
-          extend T::Sig
-
-          sig { returns(T::Hash[String, Node]) }
-          attr_reader :children
-
-          sig { returns(String) }
-          attr_reader :value
-
-          sig { returns(T::Boolean) }
-          attr_accessor :leaf
-
-          sig { params(value: String).void }
-          def initialize(value)
-            @children = T.let({}, T::Hash[String, Node])
-            @value = T.let(value, String)
-            @leaf = T.let(false, T::Boolean)
-          end
-
-          sig { returns(T::Array[String]) }
-          def collect
-            result = T.let([], T::Array[String])
-            result << value if leaf
-
-            children.each_value do |node|
-              result.concat(node.collect)
-            end
-
-            result
-          end
-        end
-      end
-    end
-  end
-end