ruby-lsp 0.17.17 → 0.18.0

data/lib/ruby_lsp/requests/type_hierarchy_supertypes.rb

@@ -3,20 +3,9 @@
 
 module RubyLsp
   module Requests
-    # ![Type hierarchy supertypes demo](../../type_hierarchy_supertypes.gif)
-    #
     # The [type hierarchy supertypes
     # request](https://microsoft.github.io/language-server-protocol/specification#typeHierarchy_supertypes)
     # displays the list of ancestors (supertypes) for the selected type.
-    #
-    # # Example
-    #
-    # ```ruby
-    # class Foo; end
-    # class Bar < Foo; end
-    #
-    # puts Bar # <-- right click on `Bar` and select "Show Type Hierarchy"
-    # ```
     class TypeHierarchySupertypes < Request
       extend T::Sig
 

data/lib/ruby_lsp/requests/workspace_symbol.rb

@@ -3,21 +3,9 @@
 
 module RubyLsp
   module Requests
-    # ![Workspace symbol demo](../../workspace_symbol.gif)
-    #
     # The [workspace symbol](https://microsoft.github.io/language-server-protocol/specification#workspace_symbol)
     # request allows fuzzy searching declarations in the entire project. On VS Code, use CTRL/CMD + T to search for
     # symbols.
-    #
-    # # Example
-    #
-    # ```ruby
-    # # Searching for `Floo` will fuzzy match and return all declarations according to the query, including this `Foo`
-    # class
-    # class Foo
-    # end
-    # ```
-    #
     class WorkspaceSymbol < Request
       extend T::Sig
       include Support::Common

data/lib/ruby_lsp/ruby_document.rb

@@ -121,12 +121,13 @@ module RubyLsp
       end
     end
 
-    sig { override.returns(ParseResultType) }
-    def parse
-      return @parse_result unless @needs_parsing
+    sig { override.returns(T::Boolean) }
+    def parse!
+      return false unless @needs_parsing
 
       @needs_parsing = false
       @parse_result = Prism.parse(@source)
+      true
     end
 
     sig { override.returns(T::Boolean) }

data/lib/ruby_lsp/server.rb

@@ -9,12 +9,6 @@ module RubyLsp
     sig { returns(GlobalState) }
     attr_reader :global_state
 
-    sig { params(test_mode: T::Boolean).void }
-    def initialize(test_mode: false)
-      super
-      @global_state = T.let(GlobalState.new, GlobalState)
-    end
-
     sig { override.params(message: T::Hash[Symbol, T.untyped]).void }
     def process_message(message)
       case message[:method]
@@ -98,6 +92,8 @@ module RubyLsp
       when "$/cancelRequest"
         @mutex.synchronize { @cancelled_requests << message[:params][:id] }
       end
+    rescue DelegateRequestError
+      send_message(Error.new(id: message[:id], code: DelegateRequestError::CODE, message: "DELEGATE_REQUEST"))
     rescue StandardError, LoadError => e
       # If an error occurred in a request, we have to return an error response or else the editor will hang
       if message[:id]
@@ -284,7 +280,15 @@ module RubyLsp
       RubyVM::YJIT.enable if defined?(RubyVM::YJIT.enable)
 
       if defined?(Requests::Support::RuboCopFormatter)
-        @global_state.register_formatter("rubocop", Requests::Support::RuboCopFormatter.new)
+        begin
+          @global_state.register_formatter("rubocop", Requests::Support::RuboCopFormatter.new)
+        rescue RuboCop::Error => e
+          # The user may have provided unknown config switches in .rubocop or
+          # is trying to load a non-existant config file.
+          send_message(Notification.window_show_error(
+            "RuboCop configuration error: #{e.message}. Formatting will not be available.",
+          ))
+        end
       end
       if defined?(Requests::Support::SyntaxTreeFormatter)
         @global_state.register_formatter("syntax_tree", Requests::Support::SyntaxTreeFormatter.new)
@@ -543,7 +547,7 @@ module RubyLsp
         return
       end
 
-      request = Requests::DocumentHighlight.new(document, params[:position], dispatcher)
+      request = Requests::DocumentHighlight.new(@global_state, document, params[:position], dispatcher)
       dispatcher.dispatch(document.parse_result.value)
       send_message(Result.new(id: message[:id], response: request.perform))
     end
@@ -740,6 +744,17 @@ module RubyLsp
 
     sig { params(message: T::Hash[Symbol, T.untyped]).void }
     def text_document_completion_item_resolve(message)
+      # When responding to a delegated completion request, it means we're handling a completion item that isn't related
+      # to Ruby (probably related to an ERB host language like HTML). We need to return the original completion item
+      # back to the editor so that it's displayed correctly
+      if message.dig(:params, :data, :delegateCompletion)
+        send_message(Result.new(
+          id: message[:id],
+          response: message[:params],
+        ))
+        return
+      end
+
       send_message(Result.new(
         id: message[:id],
         response: Requests::CompletionResolve.new(@global_state, message[:params]).perform,

data/lib/ruby_lsp/setup_bundler.rb

@@ -56,7 +56,7 @@ module RubyLsp
 
     # Sets up the custom bundle and returns the `BUNDLE_GEMFILE`, `BUNDLE_PATH` and `BUNDLE_APP_CONFIG` that should be
     # used for running the server
-    sig { returns([String, T.nilable(String), T.nilable(String)]) }
+    sig { returns(T::Hash[String, String]) }
     def setup!
       raise BundleNotLocked if @gemfile&.exist? && !@lockfile&.exist?
 
@@ -176,22 +176,18 @@ module RubyLsp
       dependencies
     end
 
-    sig { params(bundle_gemfile: T.nilable(Pathname)).returns([String, T.nilable(String), T.nilable(String)]) }
+    sig { params(bundle_gemfile: T.nilable(Pathname)).returns(T::Hash[String, String]) }
     def run_bundle_install(bundle_gemfile = @gemfile)
+      env = bundler_settings_as_env
+      env["BUNDLE_GEMFILE"] = bundle_gemfile.to_s
+
       # If the user has a custom bundle path configured, we need to ensure that we will use the absolute and not
       # relative version of it when running `bundle install`. This is necessary to avoid installing the gems under the
       # `.ruby-lsp` folder, which is not the user's intention. For example, if the path is configured as `vendor`, we
       # want to install it in the top level `vendor` and not `.ruby-lsp/vendor`
-      path = Bundler.settings["path"]
-      expanded_path = File.expand_path(path, @project_path) if path
-
-      # Use the absolute `BUNDLE_PATH` to prevent accidentally creating unwanted folders under `.ruby-lsp`
-      env = {}
-      env["BUNDLE_GEMFILE"] = bundle_gemfile.to_s
-      env["BUNDLE_PATH"] = expanded_path if expanded_path
-
-      local_config_path = File.join(@project_path, ".bundle")
-      env["BUNDLE_APP_CONFIG"] = local_config_path if Dir.exist?(local_config_path)
+      if env["BUNDLE_PATH"]
+        env["BUNDLE_PATH"] = File.expand_path(env["BUNDLE_PATH"], @project_path)
+      end
 
       # If `ruby-lsp` and `debug` (and potentially `ruby-lsp-rails`) are already in the Gemfile, then we shouldn't try
       # to upgrade them or else we'll produce undesired source control changes. If the custom bundle was just created
@@ -238,7 +234,29 @@ module RubyLsp
         return setup!
       end
 
-      [bundle_gemfile.to_s, expanded_path, env["BUNDLE_APP_CONFIG"]]
+      env
+    end
+
+    # Gather all Bundler settings (global and local) and return them as a hash that can be used as the environment
+    sig { returns(T::Hash[String, String]) }
+    def bundler_settings_as_env
+      local_config_path = File.join(@project_path, ".bundle")
+
+      # If there's no Gemfile or if the local config path does not exist, we return an empty setting set (which has the
+      # global settings included). Otherwise, we also load the local settings
+      settings = begin
+        Dir.exist?(local_config_path) ? Bundler::Settings.new(local_config_path) : Bundler::Settings.new
+      rescue Bundler::GemfileNotFound
+        Bundler::Settings.new
+      end
+
+      # Map all settings to their environment variable names with `key_for` and their values. For example, the if the
+      # setting name `e` is `path` with a value of `vendor/bundle`, then it will return `"BUNDLE_PATH" =>
+      # "vendor/bundle"`
+      settings.all.to_h do |e|
+        key = Bundler::Settings.key_for(e)
+        [key, settings[e].to_s]
+      end
     end
 
     sig { returns(T::Boolean) }

data/lib/ruby_lsp/type_inferrer.rb

@@ -121,8 +121,12 @@ module RubyLsp
       return Type.new(node_context.fully_qualified_name) if node_context.surrounding_method
 
       # If we're not inside a method, then we're inside the body of a class or module, which is a singleton
-      # context
-      Type.new("#{nesting.join("::")}::<Class:#{nesting.last}>")
+      # context.
+      #
+      # If the class/module definition is using compact style (e.g.: `class Foo::Bar`), then we need to split the name
+      # into its individual parts to build the correct singleton name
+      parts = nesting.flat_map { |part| part.split("::") }
+      Type.new("#{parts.join("::")}::<Class:#{parts.last}>")
     end
 
     sig do

data/lib/ruby_lsp/utils.rb

@@ -25,7 +25,17 @@ module RubyLsp
     end,
     String,
   )
-  GUESSED_TYPES_URL = "https://github.com/Shopify/ruby-lsp/blob/main/DESIGN_AND_ROADMAP.md#guessed-types"
+  GUESSED_TYPES_URL = "https://shopify.github.io/ruby-lsp/design-and-roadmap.html#guessed-types"
+
+  # Request delegation for embedded languages is not yet standardized into the language server specification. Here we
+  # use this custom error class as a way to return a signal to the client that the request should be delegated to the
+  # language server for the host language. The support for delegation is custom built on the client side, so each editor
+  # needs to implement their own until this becomes a part of the spec
+  class DelegateRequestError < StandardError
+    # A custom error code that clients can use to handle delegate requests. This is past the range of error codes listed
+    # by the specification to avoid conflicting with other error types
+    CODE = -32900
+  end
 
   # A notification to be sent to the client
   class Message

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lsp
 version: !ruby/object:Gem::Version
-  version: 0.17.17
+  version: 0.18.0
 platform: ruby
 authors:
 - Shopify
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-08-29 00:00:00.000000000 Z
+date: 2024-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: language_server-protocol
@@ -112,7 +112,6 @@ files:
 - lib/ruby_indexer/test/test_case.rb
 - lib/ruby_lsp/addon.rb
 - lib/ruby_lsp/base_server.rb
-- lib/ruby_lsp/check_docs.rb
 - lib/ruby_lsp/document.rb
 - lib/ruby_lsp/erb_document.rb
 - lib/ruby_lsp/global_state.rb
@@ -201,7 +200,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.17
+rubygems_version: 3.5.18
 signing_key:
 specification_version: 4
 summary: An opinionated language server for Ruby

data/lib/ruby_lsp/check_docs.rb

@@ -1,130 +0,0 @@
-# typed: strict
-# frozen_string_literal: true
-
-require "ruby_lsp/internal"
-require "objspace"
-
-module RubyLsp
-  # This rake task checks that all requests or addons are fully documented. Add the rake task to your Rakefile and
-  # specify the absolute path for all files that must be required in order to discover all requests and their related
-  # GIFs
-  #
-  #   # Rakefile
-  #   request_files = FileList.new("#{__dir__}/lib/ruby_lsp/requests/*.rb") do |fl|
-  #     fl.exclude(/base_request\.rb/)
-  #   end
-  #   gif_files = FileList.new("#{__dir__}/**/*.gif")
-  #   RubyLsp::CheckDocs.new(request_files, gif_files)
-  #   # Run with bundle exec rake ruby_lsp:check_docs
-  class CheckDocs < Rake::TaskLib
-    extend T::Sig
-
-    sig { params(require_files: Rake::FileList, gif_files: Rake::FileList).void }
-    def initialize(require_files, gif_files)
-      super()
-
-      @name = T.let("ruby_lsp:check_docs", String)
-      @file_list = require_files
-      @gif_list = gif_files
-      define_task
-    end
-
-    private
-
-    sig { void }
-    def define_task
-      desc("Checks if all Ruby LSP requests are documented")
-      task(@name) { run_task }
-    end
-
-    sig { params(request_path: String).returns(T::Boolean) }
-    def gif_exists?(request_path)
-      request_gif = request_path.gsub(".rb", ".gif").split("/").last
-
-      @gif_list.any? { |gif_path| gif_path.end_with?(request_gif) }
-    end
-
-    sig { void }
-    def run_task
-      # Require all files configured to make sure all requests are loaded
-      @file_list.each { |f| require(f.delete_suffix(".rb")) }
-
-      # Find all classes that inherit from BaseRequest, which are the ones we want to make sure are
-      # documented
-      features = ObjectSpace.each_object(Class).select do |k|
-        klass = T.unsafe(k)
-        klass < Requests::Request
-      end
-
-      missing_docs = T.let(Hash.new { |h, k| h[k] = [] }, T::Hash[String, T::Array[String]])
-
-      features.each do |klass|
-        class_name = T.unsafe(klass).name
-        file_path, line_number = Module.const_source_location(class_name)
-        next unless file_path && line_number
-
-        # Adjust the line number to start searching right above the class definition
-        line_number -= 2
-
-        lines = File.readlines(file_path)
-        docs = []
-
-        # Extract the documentation on top of the request constant
-        while (line = lines[line_number]&.strip) && line.start_with?("#")
-          docs.unshift(line)
-          line_number -= 1
-        end
-
-        documentation = docs.join("\n")
-
-        if docs.empty?
-          T.must(missing_docs[class_name]) << "No documentation found"
-        elsif !%r{\(https://microsoft.github.io/language-server-protocol/specification#.*\)}.match?(documentation)
-          T.must(missing_docs[class_name]) << <<~DOCS
-            Missing specification link. Requests and addons should include a link to the LSP specification for the
-            related feature. For example:
-
-            [Inlay hint](https://microsoft.github.io/language-server-protocol/specification#textDocument_inlayHint)
-          DOCS
-        elsif !documentation.include?("# Example")
-          T.must(missing_docs[class_name]) << <<~DOCS
-            Missing example. Requests and addons should include a code example that explains what the feature does.
-
-            # # Example
-            # ```ruby
-            # class Foo # <- information is shown here
-            # end
-            # ```
-          DOCS
-        elsif !/\[.* demo\]\(.*\.gif\)/.match?(documentation)
-          T.must(missing_docs[class_name]) << <<~DOCS
-            Missing demonstration GIF. Each request and addon must be documented with a GIF that shows the feature
-            working. For example:
-
-            # [Inlay hint demo](../../inlay_hint.gif)
-          DOCS
-        elsif !gif_exists?(file_path)
-          T.must(missing_docs[class_name]) << <<~DOCS
-            The GIF for the request documentation does not exist. Make sure to add it,
-            with the same naming as the request. For example:
-
-            # lib/ruby_lsp/requests/code_lens.rb
-            # foo/bar/code_lens.gif
-          DOCS
-        end
-      end
-
-      if missing_docs.any?
-        $stderr.puts(<<~WARN)
-          The following requests are missing documentation:
-
-          #{missing_docs.map { |k, v| "#{k}\n\n#{v.join("\n")}" }.join("\n\n")}
-        WARN
-
-        abort
-      end
-
-      puts "All requests are documented!"
-    end
-  end
-end