ruby-lsp 0.17.10 → 0.17.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7fafb2e9f1ef8ae394523d09256bce9016307821ab32ecd17fe645dd3f9d88f1
-  data.tar.gz: 74396754fdbf6dffb91ff4d6d237f67c26b92fd7ec0f187fc3e40627dc214de1
+  metadata.gz: 13815c41a1b7509782277cb5dac09481130e18efc4253a01cede31ca41b335a7
+  data.tar.gz: 40e6584ff6ff743ea1e62a29d6090d80bf318ae3dd5d90808de1b35723bea063
 SHA512:
-  metadata.gz: 8901ced915cabc4e749cc9451de7d7f9927c4025c6484002a682e65b1a20f7e52d38d3e5b52255b061998e8c114da8efeaaf605f0419fff8ed93c09cf00a2dae
-  data.tar.gz: 5679783fa6a828a7e6a3db9fb193ec9b4c1c094c6a67c187f7c2169f5f11fe53fe5024b0c7b0f08273eb46293639ff1d67f7787a851f4f1ac599be23a10ff7dd
+  metadata.gz: 74da4b254b598cd4b10701b65c49d045cc33be83330399e67602f8e43597c9e54567715343a67fa720b31084de540e498cc3d5525e64679500d52b4842e44cf7
+  data.tar.gz: 313695187e34ceb34c50d320bbe0abe0bda18d99157e8f4710faf8f72bc5028abd813511665fd4eac274dd73606eebb1c901b949fa307a8f925c2bfaa39b0c45

data/VERSION

@@ -1 +1 @@
-0.17.10
+0.17.11

data/lib/ruby_lsp/listeners/definition.rb

@@ -46,6 +46,7 @@ module RubyLsp
           :on_instance_variable_or_write_node_enter,
           :on_instance_variable_target_node_enter,
           :on_string_node_enter,
+          :on_symbol_node_enter,
           :on_super_node_enter,
           :on_forwarding_super_node_enter,
         )
@@ -54,9 +55,7 @@ module RubyLsp
       sig { params(node: Prism::CallNode).void }
       def on_call_node_enter(node)
         # Sorbet can handle go to definition for methods invoked on self on typed true or higher
-        if (@sorbet_level == Document::SorbetLevel::True || @sorbet_level == Document::SorbetLevel::Strict) &&
-            self_receiver?(node)
-        end
+        return if sorbet_level_true_or_higher?(@sorbet_level) && self_receiver?(node)
 
         message = node.message
         return unless message
@@ -83,6 +82,17 @@ module RubyLsp
         handle_require_definition(node, name)
       end
 
+      sig { params(node: Prism::SymbolNode).void }
+      def on_symbol_node_enter(node)
+        enclosing_call = @node_context.call_node
+        return unless enclosing_call
+
+        name = enclosing_call.name
+        return unless name == :autoload
+
+        handle_autoload_definition(enclosing_call)
+      end
+
       sig { params(node: Prism::BlockArgumentNode).void }
       def on_block_argument_node_enter(node)
         expression = node.expression
@@ -253,6 +263,17 @@ module RubyLsp
         end
       end
 
+      sig { params(node: Prism::CallNode).void }
+      def handle_autoload_definition(node)
+        argument = node.arguments&.arguments&.first
+        return unless argument.is_a?(Prism::SymbolNode)
+
+        constant_name = argument.value
+        return unless constant_name
+
+        find_in_index(constant_name)
+      end
+
       sig { params(value: String).void }
       def find_in_index(value)
         entries = @index.resolve(value, @node_context.nesting)

data/lib/ruby_lsp/requests/code_actions.rb

@@ -25,9 +25,12 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(Interface::CodeActionOptions) }
+        sig { returns(Interface::CodeActionRegistrationOptions) }
         def provider
-          Interface::CodeActionOptions.new(resolve_provider: true)
+          Interface::CodeActionRegistrationOptions.new(
+            document_selector: [Interface::DocumentFilter.new(language: "ruby")],
+            resolve_provider: true,
+          )
         end
       end
 

data/lib/ruby_lsp/requests/definition.rb

@@ -30,6 +30,12 @@ module RubyLsp
       extend T::Sig
       extend T::Generic
 
+      SPECIAL_METHOD_CALLS = [
+        :require,
+        :require_relative,
+        :autoload,
+      ].freeze
+
       sig do
         params(
           document: Document,
@@ -78,8 +84,9 @@ module RubyLsp
             parent,
             position,
           )
-        elsif target.is_a?(Prism::CallNode) && target.name != :require && target.name != :require_relative &&
-            !covers_position?(target.message_loc, position)
+        elsif target.is_a?(Prism::CallNode) && !SPECIAL_METHOD_CALLS.include?(target.message) && !covers_position?(
+          target.message_loc, position
+        )
           # If the target is a method call, we need to ensure that the requested position is exactly on top of the
           # method identifier. Otherwise, we risk showing definitions for unrelated things
           target = nil

data/lib/ruby_lsp/requests/diagnostics.rb

@@ -22,12 +22,13 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(T::Hash[Symbol, T::Boolean]) }
+        sig { returns(Interface::DiagnosticRegistrationOptions) }
         def provider
-          {
-            interFileDependencies: false,
-            workspaceDiagnostics: false,
-          }
+          Interface::DiagnosticRegistrationOptions.new(
+            document_selector: [Interface::DocumentFilter.new(language: "ruby")],
+            inter_file_dependencies: false,
+            workspace_diagnostics: false,
+          )
         end
       end
 

data/lib/ruby_lsp/requests/document_symbol.rb

@@ -34,14 +34,9 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(Interface::DocumentSymbolClientCapabilities) }
+        sig { returns(Interface::DocumentSymbolOptions) }
         def provider
-          Interface::DocumentSymbolClientCapabilities.new(
-            hierarchical_document_symbol_support: true,
-            symbol_kind: {
-              value_set: (Constant::SymbolKind::FILE..Constant::SymbolKind::TYPE_PARAMETER).to_a,
-            },
-          )
+          Interface::DocumentSymbolOptions.new
         end
       end
 

data/lib/ruby_lsp/requests/folding_ranges.rb

@@ -23,9 +23,13 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(Interface::FoldingRangeClientCapabilities) }
+        sig { returns(Interface::FoldingRangeRegistrationOptions) }
         def provider
-          Interface::FoldingRangeClientCapabilities.new(line_folding_only: true)
+          Interface::FoldingRangeRegistrationOptions.new(
+            document_selector: [
+              Interface::DocumentFilter.new(language: "ruby"),
+            ],
+          )
         end
       end
 

data/lib/ruby_lsp/requests/formatting.rb

@@ -27,6 +27,19 @@ module RubyLsp
 
       class Error < StandardError; end
 
+      class << self
+        extend T::Sig
+
+        sig { returns(Interface::DocumentFormattingRegistrationOptions) }
+        def provider
+          Interface::DocumentFormattingRegistrationOptions.new(
+            document_selector: [
+              Interface::DocumentFilter.new(language: "ruby"),
+            ],
+          )
+        end
+      end
+
       sig { params(global_state: GlobalState, document: Document).void }
       def initialize(global_state, document)
         super()

data/lib/ruby_lsp/requests/hover.rb

@@ -22,9 +22,9 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(Interface::HoverClientCapabilities) }
+        sig { returns(Interface::HoverOptions) }
         def provider
-          Interface::HoverClientCapabilities.new(dynamic_registration: false)
+          Interface::HoverOptions.new
         end
       end
 

data/lib/ruby_lsp/requests/on_type_formatting.rb

@@ -21,9 +21,10 @@ module RubyLsp
       class << self
         extend T::Sig
 
-        sig { returns(Interface::DocumentOnTypeFormattingOptions) }
+        sig { returns(Interface::DocumentOnTypeFormattingRegistrationOptions) }
         def provider
-          Interface::DocumentOnTypeFormattingOptions.new(
+          Interface::DocumentOnTypeFormattingRegistrationOptions.new(
+            document_selector: [Interface::DocumentFilter.new(language: "ruby")],
             first_trigger_character: "{",
             more_trigger_character: ["\n", "|", "d"],
           )

data/lib/ruby_lsp/server.rb

@@ -181,6 +181,7 @@ module RubyLsp
       hover_provider = Requests::Hover.provider if enabled_features["hover"]
       folding_ranges_provider = Requests::FoldingRanges.provider if enabled_features["foldingRanges"]
       semantic_tokens_provider = Requests::SemanticHighlighting.provider if enabled_features["semanticHighlighting"]
+      document_formatting_provider = Requests::Formatting.provider if enabled_features["formatting"]
       diagnostics_provider = Requests::Diagnostics.provider if enabled_features["diagnostics"]
       on_type_formatting_provider = Requests::OnTypeFormatting.provider if enabled_features["onTypeFormatting"]
       code_action_provider = Requests::CodeActions.provider if enabled_features["codeActions"]
@@ -202,7 +203,7 @@ module RubyLsp
           document_link_provider: document_link_provider,
           folding_range_provider: folding_ranges_provider,
           semantic_tokens_provider: semantic_tokens_provider,
-          document_formatting_provider: enabled_features["formatting"] && @global_state.formatter != "none",
+          document_formatting_provider: document_formatting_provider && @global_state.formatter != "none",
           document_highlight_provider: enabled_features["documentHighlights"],
           code_action_provider: code_action_provider,
           document_on_type_formatting_provider: on_type_formatting_provider,
@@ -421,8 +422,6 @@ module RubyLsp
 
       document = @store.get(uri)
 
-      return send_empty_response(message[:id]) if document.is_a?(ERBDocument)
-
       response = Requests::Formatting.new(@global_state, document).perform
       send_message(Result.new(id: message[:id], response: response))
     rescue Requests::Request::InvalidFormatter => error
@@ -448,8 +447,6 @@ module RubyLsp
       params = message[:params]
       document = @store.get(params.dig(:textDocument, :uri))
 
-      return send_empty_response(message[:id]) if document.is_a?(ERBDocument)
-
       send_message(
         Result.new(
           id: message[:id],
@@ -506,8 +503,6 @@ module RubyLsp
       params = message[:params]
       document = @store.get(params.dig(:textDocument, :uri))
 
-      return send_empty_response(message[:id]) if document.is_a?(ERBDocument)
-
       send_message(
         Result.new(
           id: message[:id],
@@ -563,8 +558,6 @@ module RubyLsp
 
       document = @store.get(uri)
 
-      return send_empty_response(message[:id]) if document.is_a?(ERBDocument)
-
       response = document.cache_fetch("textDocument/diagnostic") do |document|
         Requests::Diagnostics.new(@global_state, document).perform
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lsp
 version: !ruby/object:Gem::Version
-  version: 0.17.10
+  version: 0.17.11
 platform: ruby
 authors:
 - Shopify
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-30 00:00:00.000000000 Z
+date: 2024-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: language_server-protocol