ruby-lsp-refactor 0.1.0

data/test/ruby_lsp_refactor/conditional_listener_test.rb

@@ -0,0 +1,307 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class ConditionalListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      # ---------------------------------------------------------------------------
+      # Helpers
+      # ---------------------------------------------------------------------------
+
+      def find_action(actions, title)
+        actions.find { |a| a.title == title }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size, "Expected exactly one TextEdit, got #{edits.size}"
+        edits.first
+      end
+
+      # ===========================================================================
+      # 1. Convert to post-conditional (block if → post-if)
+      # ===========================================================================
+
+      def test_converts_simple_if_block_to_post_conditional
+        source = <<~RUBY
+          if user.qualified?
+            user.approve!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to post-conditional")
+        refute_nil action, "Expected a 'Convert to post-conditional' code action"
+
+        edit = single_edit(action)
+        assert_equal "user.approve! if user.qualified?", edit.new_text.strip
+      end
+
+      def test_does_not_offer_post_conditional_for_if_with_else
+        source = <<~RUBY
+          if user.qualified?
+            user.approve!
+          else
+            user.reject!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to post-conditional")
+      end
+
+      def test_does_not_offer_post_conditional_for_if_with_elsif
+        source = <<~RUBY
+          if user.admin?
+            user.grant_admin!
+          elsif user.qualified?
+            user.approve!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to post-conditional")
+      end
+
+      def test_does_not_offer_post_conditional_for_multi_statement_body
+        source = <<~RUBY
+          if user.qualified?
+            user.approve!
+            notify(user)
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to post-conditional")
+      end
+
+      def test_post_conditional_preserves_leading_indentation
+        source = <<~RUBY
+          def process
+            if user.qualified?
+              user.approve!
+            end
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        action  = find_action(actions, "Convert to post-conditional")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/\A  user\.approve! if user\.qualified\?/, edit.new_text)
+      end
+
+      def test_post_conditional_edit_range_covers_entire_if_block
+        source = <<~RUBY
+          if user.qualified?
+            user.approve!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        edit    = single_edit(find_action(actions, "Convert to post-conditional"))
+
+        assert_equal 0, edit.range.start.line
+        assert_equal 2, edit.range.end.line
+      end
+
+      def test_converts_unless_block_to_post_conditional
+        source = <<~RUBY
+          unless user.banned?
+            user.login!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to post-conditional")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal "user.login! unless user.banned?", edit.new_text.strip
+      end
+
+      # ===========================================================================
+      # 2. Convert to block if (post-if → block if)
+      # ===========================================================================
+
+      def test_converts_post_conditional_to_block_if
+        source = "user.approve! if user.qualified?\n"
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to block if")
+        refute_nil action, "Expected a 'Convert to block if' code action"
+
+        edit = single_edit(action)
+        assert_match(/if user\.qualified\?/, edit.new_text)
+        assert_match(/user\.approve!/, edit.new_text)
+        assert_match(/end/, edit.new_text)
+      end
+
+      def test_converts_post_conditional_unless_to_block_unless
+        source = "user.login! unless user.banned?\n"
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to block unless")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/unless user\.banned\?/, edit.new_text)
+        assert_match(/user\.login!/, edit.new_text)
+        assert_match(/end/, edit.new_text)
+      end
+
+      # ===========================================================================
+      # 3. Toggle if ↔ unless
+      # ===========================================================================
+
+      def test_toggles_if_to_unless
+        source = <<~RUBY
+          if user.active?
+            user.greet!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to unless")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/unless user\.active\?/, edit.new_text)
+        assert_match(/user\.greet!/, edit.new_text)
+      end
+
+      def test_toggles_unless_to_if
+        source = <<~RUBY
+          unless user.banned?
+            user.login!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to if")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/if user\.banned\?/, edit.new_text)
+        assert_match(/user\.login!/, edit.new_text)
+      end
+
+      def test_toggle_if_with_bang_predicate_strips_negation
+        source = <<~RUBY
+          if !user.banned?
+            user.login!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to unless")
+        refute_nil action
+
+        edit = single_edit(action)
+        # The `!` should be stripped: `unless user.banned?`
+        assert_match(/unless user\.banned\?/, edit.new_text)
+        refute_match(/!user/, edit.new_text)
+      end
+
+      def test_does_not_offer_toggle_when_else_present
+        source = <<~RUBY
+          if user.active?
+            greet!
+          else
+            reject!
+          end
+        RUBY
+
+        # Toggle should not appear; invert should appear instead.
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to unless")
+      end
+
+      # ===========================================================================
+      # 4. Invert if/else
+      # ===========================================================================
+
+      def test_inverts_if_else_branches
+        source = <<~RUBY
+          if user.admin?
+            grant!
+          else
+            deny!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Invert if/else")
+        refute_nil action
+
+        edit = single_edit(action)
+        # Predicate should be negated and branches swapped.
+        assert_match(/if !user\.admin\?/, edit.new_text)
+        # deny! should now be in the then-branch (first after if)
+        deny_pos  = edit.new_text.index("deny!")
+        grant_pos = edit.new_text.index("grant!")
+        assert deny_pos < grant_pos, "deny! should appear before grant! after inversion"
+      end
+
+      def test_invert_cancels_double_negation
+        source = <<~RUBY
+          if !user.banned?
+            allow!
+          else
+            block!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Invert if/else")
+        refute_nil action
+
+        edit = single_edit(action)
+        # `!(!user.banned?)` should simplify to `user.banned?`
+        assert_match(/if user\.banned\?/, edit.new_text)
+        refute_match(/!!/, edit.new_text)
+      end
+
+      def test_does_not_offer_invert_without_else
+        source = <<~RUBY
+          if user.active?
+            greet!
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Invert if/else")
+      end
+
+      # ===========================================================================
+      # Resilience
+      # ===========================================================================
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+
+      def test_does_not_raise_on_incomplete_if
+        source = "if user.qualified?\n"
+        assert_silent { code_actions_for(source, line: 0) }
+      end
+
+      def test_does_not_offer_action_when_cursor_is_outside_node
+        source = <<~RUBY
+          if user.qualified?
+            user.approve!
+          end
+          puts "done"
+        RUBY
+
+        actions = code_actions_for(source, line: 3)
+        assert_nil find_action(actions, "Convert to post-conditional")
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/hash_listener_test.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class HashListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title)
+        actions.find { |a| a.title == title }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size
+        edits.first
+      end
+
+      # ---------------------------------------------------------------------------
+      # Core acceptance
+      # ---------------------------------------------------------------------------
+
+      def test_converts_hash_rocket_to_keyword_syntax
+        source = "{ :foo => 1, :bar => 2 }\n"
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to keyword syntax")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal "{ foo: 1, bar: 2 }", edit.new_text
+      end
+
+      def test_converts_mixed_hash_only_rocket_pairs
+        # String key should be left verbatim; symbol rocket key should be converted.
+        source = %({ "name" => "Alice", :age => 30 }\n)
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to keyword syntax")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/age: 30/, edit.new_text)
+        assert_match(/"name" => "Alice"/, edit.new_text)
+      end
+
+      # ---------------------------------------------------------------------------
+      # Negative cases
+      # ---------------------------------------------------------------------------
+
+      def test_does_not_offer_action_for_already_keyword_hash
+        source = "{ foo: 1, bar: 2 }\n"
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to keyword syntax")
+      end
+
+      def test_does_not_offer_action_for_empty_hash
+        source = "{}\n"
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to keyword syntax")
+      end
+
+      # ---------------------------------------------------------------------------
+      # Resilience
+      # ---------------------------------------------------------------------------
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/method_listener_test.rb

@@ -0,0 +1,193 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class MethodListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title_pattern)
+        actions.find { |a| a.title.match?(title_pattern) }
+      end
+
+      def all_edits(action)
+        action.edit.changes.values.flatten
+      end
+
+      # ===========================================================================
+      # 1. Extract to method
+      # ===========================================================================
+
+      def test_extract_to_method_replaces_rhs_and_inserts_new_method
+        source = <<~RUBY
+          def process
+            result = expensive_computation
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        action  = find_action(actions, /Extract to method/)
+        refute_nil action
+
+        edits = all_edits(action)
+        assert_equal 2, edits.size
+
+        replace_edit = edits.find { |e| e.new_text.include?("result") && !e.new_text.include?("def") }
+        insert_edit  = edits.find { |e| e.new_text.include?("def result") }
+
+        refute_nil replace_edit, "Expected an edit replacing the RHS with a method call"
+        refute_nil insert_edit,  "Expected an edit inserting the new method definition"
+
+        assert_match(/def result/, insert_edit.new_text)
+        assert_match(/expensive_computation/, insert_edit.new_text)
+      end
+
+      def test_extract_to_method_passes_outer_variables_as_params
+        source = <<~RUBY
+          def process(data)
+            threshold = 10
+            result = data.select { |x| x > threshold }
+          end
+        RUBY
+
+        # Cursor on the `result =` line (line 2).
+        actions = code_actions_for(source, line: 2)
+        action  = find_action(actions, /Extract to method/)
+        refute_nil action
+
+        edits = all_edits(action)
+        insert_edit = edits.find { |e| e.new_text.include?("def result") }
+        refute_nil insert_edit
+
+        # `threshold` was defined before the extraction point and is used in the RHS.
+        assert_match(/def result\(threshold\)/, insert_edit.new_text)
+      end
+
+      # ===========================================================================
+      # 2. Add parameter
+      # ===========================================================================
+
+      def test_add_parameter_appends_to_existing_params
+        source = <<~RUBY
+          def greet(name)
+            puts name
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Add parameter")
+        refute_nil action
+
+        edits = all_edits(action)
+        assert_equal 1, edits.size
+
+        edit = edits.first
+        assert_equal ", new_param", edit.new_text
+      end
+
+      def test_add_parameter_creates_parens_when_no_params
+        source = <<~RUBY
+          def greet
+            puts "hello"
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Add parameter")
+        refute_nil action
+
+        edits = all_edits(action)
+        assert_equal 1, edits.size
+
+        edit = edits.first
+        assert_equal "(new_param)", edit.new_text
+      end
+
+      # ===========================================================================
+      # 3. Convert to keyword arguments
+      # ===========================================================================
+
+      def test_converts_positional_params_to_kwargs
+        source = <<~RUBY
+          def create(name, age)
+            User.new(name, age)
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to keyword arguments")
+        refute_nil action
+
+        edits = all_edits(action)
+        assert_equal 1, edits.size
+
+        edit = edits.first
+        assert_equal "name:, age:", edit.new_text
+      end
+
+      def test_does_not_offer_kwargs_conversion_when_no_positional_params
+        source = <<~RUBY
+          def greet
+            puts "hello"
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to keyword arguments")
+      end
+
+      # ===========================================================================
+      # 4. Extract to let (RSpec)
+      # ===========================================================================
+
+      def test_extract_to_let_inserts_let_block_and_removes_assignment
+        source = <<~RUBY
+          describe "User" do
+            it "logs in" do
+              user = User.new(name: "Alice")
+              expect(user.name).to eq("Alice")
+            end
+          end
+        RUBY
+
+        # Cursor on the `user =` line (line 2).
+        actions = code_actions_for(source, line: 2)
+        action  = find_action(actions, /Extract to let/)
+        refute_nil action
+
+        edits = all_edits(action)
+        assert_equal 2, edits.size
+
+        insert_edit = edits.find { |e| e.new_text.include?("let(") }
+        delete_edit = edits.find { |e| e.new_text == "" }
+
+        refute_nil insert_edit, "Expected an edit inserting a let block"
+        refute_nil delete_edit, "Expected an edit deleting the original assignment"
+
+        assert_match(/let\(:user\)/, insert_edit.new_text)
+        assert_match(/User\.new\(name: "Alice"\)/, insert_edit.new_text)
+      end
+
+      def test_does_not_offer_extract_to_let_outside_rspec_example
+        source = <<~RUBY
+          def setup
+            user = User.new
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        assert_nil find_action(actions, /Extract to let/)
+      end
+
+      # ---------------------------------------------------------------------------
+      # Resilience
+      # ---------------------------------------------------------------------------
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/string_listener_test.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class StringListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title)
+        actions.find { |a| a.title == title }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size
+        edits.first
+      end
+
+      # ---------------------------------------------------------------------------
+      # Core acceptance
+      # ---------------------------------------------------------------------------
+
+      def test_converts_single_quoted_string_to_double_quoted
+        source = "'hello world'\n"
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to interpolated string")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal '"hello world"', edit.new_text
+      end
+
+      def test_escapes_embedded_double_quotes
+        source = %('say "hi"' \n)
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to interpolated string")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal '"say \"hi\""', edit.new_text
+      end
+
+      # ---------------------------------------------------------------------------
+      # Negative cases
+      # ---------------------------------------------------------------------------
+
+      def test_does_not_offer_action_for_already_double_quoted_string
+        source = '"hello world"' + "\n"
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to interpolated string")
+      end
+
+      def test_does_not_offer_action_for_interpolated_string
+        source = '"hello #{name}"' + "\n"
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to interpolated string")
+      end
+
+      # ---------------------------------------------------------------------------
+      # Resilience
+      # ---------------------------------------------------------------------------
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end