ruby-lsp-refactor 0.1.0 → 0.1.2

data/test/ruby_lsp_refactor/string_freeze_listener_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class StringFreezeListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title)
+        actions.find { |a| a.title == title }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size
+        edits.first
+      end
+
+      def test_wraps_string_in_freeze
+        source = "\"hello world\"\n"
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Wrap in freeze")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal '"hello world".freeze', edit.new_text
+      end
+
+      def test_removes_freeze_from_frozen_string
+        source = "\"hello world\".freeze\n"
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Remove freeze")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal '"hello world"', edit.new_text
+      end
+
+      def test_does_not_offer_wrap_when_already_frozen
+        source = "\"hello\".freeze\n"
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Wrap in freeze")
+      end
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/string_listener_test.rb

@@ -47,13 +47,13 @@ module RubyLsp
       # ---------------------------------------------------------------------------
 
       def test_does_not_offer_action_for_already_double_quoted_string
-        source = '"hello world"' + "\n"
+        source = "\"hello world\"\n"
         actions = code_actions_for(source, line: 0)
         assert_nil find_action(actions, "Convert to interpolated string")
       end
 
       def test_does_not_offer_action_for_interpolated_string
-        source = '"hello #{name}"' + "\n"
+        source = "\"hello #{name}\"\n"
         actions = code_actions_for(source, line: 0)
         assert_nil find_action(actions, "Convert to interpolated string")
       end

data/test/ruby_lsp_refactor/super_listener_test.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class SuperListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title_pattern)
+        actions.find { |a| a.title.match?(title_pattern) }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size
+        edits.first
+      end
+
+      def test_converts_bare_super_to_explicit
+        source = <<~RUBY
+          def initialize(name, age)
+            super
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        action  = find_action(actions, /explicit super/)
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_equal "super(name, age)", edit.new_text.strip
+      end
+
+      def test_title_includes_param_names
+        source = <<~RUBY
+          def initialize(name, age)
+            super
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        action  = find_action(actions, /explicit super/)
+        refute_nil action
+        assert_match(/name, age/, action.title)
+      end
+
+      def test_does_not_offer_when_no_params
+        source = <<~RUBY
+          def initialize
+            super
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        assert_nil find_action(actions, /explicit super/)
+      end
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/tap_listener_test.rb

@@ -0,0 +1,144 @@
+# frozen_string_literal: true
+
+require "minitest/autorun"
+require "ruby_lsp/test_helper"
+
+module RubyLsp
+  module Refactor
+    class TapListenerTest < Minitest::Test
+      include RubyLsp::Refactor::TestHelper
+
+      def find_action(actions, title)
+        actions.find { |a| a.title == title }
+      end
+
+      def single_edit(action)
+        edits = action.edit.changes.values.flatten
+        assert_equal 1, edits.size
+        edits.first
+      end
+
+      # ── core acceptance ────────────────────────────────────────────────────
+
+      def test_converts_sequence_to_tap
+        source = <<~RUBY
+          def do_something
+            obj.do_first_thing
+            obj.do_second_thing
+            obj.do_third_thing
+            obj
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to tap")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/obj\.tap do \|o\|/, edit.new_text)
+        assert_match(/o\.do_first_thing/, edit.new_text)
+        assert_match(/o\.do_second_thing/, edit.new_text)
+        assert_match(/o\.do_third_thing/, edit.new_text)
+        assert_match(/end/, edit.new_text)
+        refute_match(/\bobj\b(?!\.tap)/, edit.new_text.sub("obj.tap", ""))
+      end
+
+      def test_preserves_method_arguments
+        source = <<~RUBY
+          def setup
+            user.assign_role(:admin)
+            user.set_name("Alice")
+            user
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        action  = find_action(actions, "Convert to tap")
+        refute_nil action
+
+        edit = single_edit(action)
+        assert_match(/user\.tap do \|o\|/, edit.new_text)
+        assert_match(/o\.assign_role\(:admin\)/, edit.new_text)
+        assert_match(/o\.set_name\("Alice"\)/, edit.new_text)
+      end
+
+      def test_preserves_indentation
+        source = <<~RUBY
+          class Builder
+            def build
+              obj.step_one
+              obj.step_two
+              obj
+            end
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 1)
+        action  = find_action(actions, "Convert to tap")
+        refute_nil action
+
+        edit = single_edit(action)
+        # The body range starts at the method body's indentation (4 spaces).
+        assert_match(/\A    obj\.tap do \|o\|/, edit.new_text)
+        assert_match(/      o\.step_one/, edit.new_text)
+      end
+
+      # ── negative cases ─────────────────────────────────────────────────────
+
+      def test_does_not_offer_when_last_statement_is_not_bare_receiver
+        source = <<~RUBY
+          def do_something
+            obj.step_one
+            obj.step_two
+            obj.result
+          end
+        RUBY
+
+        # last statement is a call on obj, not a bare variable read
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to tap")
+      end
+
+      def test_does_not_offer_when_receivers_differ
+        source = <<~RUBY
+          def do_something
+            foo.step_one
+            bar.step_two
+            foo
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to tap")
+      end
+
+      def test_does_not_offer_for_single_statement_method
+        source = <<~RUBY
+          def do_something
+            obj
+          end
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to tap")
+      end
+
+      def test_does_not_offer_outside_a_method
+        source = <<~RUBY
+          obj.step_one
+          obj.step_two
+          obj
+        RUBY
+
+        actions = code_actions_for(source, line: 0)
+        assert_nil find_action(actions, "Convert to tap")
+      end
+
+      # ── resilience ─────────────────────────────────────────────────────────
+
+      def test_does_not_raise_on_empty_source
+        assert_silent { code_actions_for("", line: 0) }
+      end
+    end
+  end
+end

data/test/ruby_lsp_refactor/variable_listener_test.rb

@@ -62,29 +62,6 @@ module RubyLsp
         assert_nil find_action(actions, /Inline variable/)
       end
 
-      # ===========================================================================
-      # 2. Extract local variable
-      # ===========================================================================
-
-      def test_extract_local_variable_inserts_assignment_above
-        source = "user.full_name.upcase\n"
-        actions = code_actions_for(source, line: 0)
-        action  = find_action(actions, "Extract local variable")
-        refute_nil action
-
-        edits = all_edits(action)
-        assert_equal 2, edits.size
-
-        insert_edit  = edits.find { |e| e.new_text.include?("variable =") }
-        replace_edit = edits.find { |e| e.new_text == "variable" }
-
-        refute_nil insert_edit
-        refute_nil replace_edit
-
-        assert_match(/variable = user\.full_name\.upcase/, insert_edit.new_text)
-        assert_equal 0, insert_edit.range.start.line
-      end
-
       # ---------------------------------------------------------------------------
       # Resilience
       # ---------------------------------------------------------------------------

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lsp-refactor
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Aboobacker MK
@@ -10,39 +10,39 @@ cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: ruby-lsp
+  name: prism
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.17'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
+        version: '0.29'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.17'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2'
+        version: '0.29'
 - !ruby/object:Gem::Dependency
-  name: prism
+  name: ruby-lsp
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.29'
+        version: '0.17'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.29'
+        version: '0.17'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +94,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - LICENSE.txt
 - README.md
@@ -101,20 +102,48 @@ files:
 - lib/ruby/lsp/refactor.rb
 - lib/ruby/lsp/refactor/version.rb
 - lib/ruby_lsp/ruby_lsp_refactor/addon.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/accessor_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/array_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/conditional_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/constant_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/early_return_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/enumerable_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/extract_include_file_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/extract_predicate_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/hash_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/logical_operator_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/method_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/raise_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/rescue_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/rspec_let_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/string_array_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/string_freeze_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/string_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/super_listener.rb
+- lib/ruby_lsp/ruby_lsp_refactor/listeners/tap_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/listeners/variable_listener.rb
 - lib/ruby_lsp/ruby_lsp_refactor/support/node_helpers.rb
 - lib/ruby_lsp/test_helper.rb
 - sig/ruby/lsp/refactor.rbs
+- test/ruby_lsp_refactor/accessor_listener_test.rb
 - test/ruby_lsp_refactor/array_listener_test.rb
 - test/ruby_lsp_refactor/conditional_listener_test.rb
+- test/ruby_lsp_refactor/constant_listener_test.rb
+- test/ruby_lsp_refactor/early_return_listener_test.rb
+- test/ruby_lsp_refactor/enumerable_listener_test.rb
+- test/ruby_lsp_refactor/extract_include_file_listener_test.rb
+- test/ruby_lsp_refactor/extract_predicate_listener_test.rb
 - test/ruby_lsp_refactor/hash_listener_test.rb
+- test/ruby_lsp_refactor/logical_operator_listener_test.rb
 - test/ruby_lsp_refactor/method_listener_test.rb
+- test/ruby_lsp_refactor/raise_listener_test.rb
+- test/ruby_lsp_refactor/rescue_listener_test.rb
+- test/ruby_lsp_refactor/rspec_let_listener_test.rb
+- test/ruby_lsp_refactor/string_array_listener_test.rb
+- test/ruby_lsp_refactor/string_freeze_listener_test.rb
 - test/ruby_lsp_refactor/string_listener_test.rb
+- test/ruby_lsp_refactor/super_listener_test.rb
+- test/ruby_lsp_refactor/tap_listener_test.rb
 - test/ruby_lsp_refactor/variable_listener_test.rb
 homepage: https://github.com/tachyons/ruby-lsp-refactor
 licenses: