ruby-lsp-rake 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79d35d3d42cb87be33f403580360e1af2a5c9055b61fff9a0f975807738320de
-  data.tar.gz: 166ec25de17e44c253a4e51ad26e7a593323880434a8550305cd143b9f530be8
+  metadata.gz: 452e879627dd3c27ad0098f47c1df078dfa3103abe4bf1af8629a016c35511ad
+  data.tar.gz: 3591baf6ef9331f441694d1044f80da452354ee8ea00f7228af253d63bad7949
 SHA512:
-  metadata.gz: d7c62408c9fdf6f62e3efbbba3c67c4011cf846abf8f0b576ae9b9e88e46585f1257ee92b271de14b55e225f586bd3aa31479b6c8ea47d6f13c73a5b27403793
-  data.tar.gz: 873b5c93130abec335efff99c581484160883e5c81c29029144d1b68f245547eb69a7bf4826d9fc1bc0812fde609fe3288718ae19b7d7545ebd7e61e93ee5b31
+  metadata.gz: fb7b7cc7734ea5f58179d5da0a7395fbd484dd2121197fc60d0fb5a04605ac9f403d54bf63ed858ce039a04b6b0496f91c92c3abf3a3118c4ae4cb70363ad39d
+  data.tar.gz: 03e832dce7066a16ca575886d1c4c8d2958bdc6d413c861df7d12ac18c00685ea48b57dc349f06beb4f5da383cfa35cf3c1c56e76d256ec63a3bbee5e01555de

data/.rubocop.yml

@@ -1,6 +1,10 @@
 AllCops:
   TargetRubyVersion: 3.0
   NewCops: disable
+  SuggestExtensions: false
+
+Style/Documentation:
+  Enabled: false
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
@@ -11,3 +15,12 @@ Style/StringLiteralsInInterpolation:
 Naming/FileName:
   Exclude:
   - "lib/ruby-lsp-rake.rb"
+
+Layout/LeadingCommentSpace:
+  Enabled: false
+
+Layout/LineLength:
+  Enabled: false
+
+plugins:
+  - rubocop-oneoff_codemod

data/Rakefile

@@ -9,7 +9,11 @@ require "rubocop/rake_task"
 
 RuboCop::RakeTask.new
 
-task default: %i[test rubocop srb:tc]
+task :quiet_test do
+  sh "rake test 2>/dev/null"
+end
+
+task default: %i[quiet_test rubocop srb:tc]
 
 namespace :srb do
   desc "Run sorbet type check"

data/lib/ruby_lsp/ruby_lsp_rake/addon.rb

@@ -10,10 +10,11 @@ require_relative "code_lens"
 
 module RubyLsp
   module Rake
-    class Addon < ::RubyLsp::Addon # rubocop:disable Style/Documentation
+    class Addon < ::RubyLsp::Addon
       extend T::Sig
 
-      sig { override.params(global_state: GlobalState, outgoing_queue: Thread::Queue).void }
+      # @override
+      #: (GlobalState global_state, Thread::Queue outgoing_queue) -> void
       def activate(global_state, outgoing_queue)
         @index = global_state.index
         @index.configuration.apply_config({ "included_patterns" => ["**/Rakefile", "lib/../Rakefile"] })
@@ -21,51 +22,36 @@ module RubyLsp
         outgoing_queue << Notification.window_log_message("Activated Ruby LSP Rake")
       end
 
-      sig { override.void }
+      # @override
+      #: -> void
       def deactivate; end
 
-      sig { override.returns(String) }
+      # @override
+      #: -> String
       def name
         "A Ruby LSP addon that adds extra editor functionality for Rake"
       end
 
-      sig { override.returns(String) }
+      # @override
+      #: -> String
       def version
         ::RubyLsp::Rake::VERSION
       end
 
-      sig do
-        override.params(
-          response_builder: ResponseBuilders::Hover,
-          node_context: NodeContext,
-          dispatcher: Prism::Dispatcher
-        ).void
-      end
+      # @override
+      #: (ResponseBuilders::Hover response_builder, NodeContext node_context, Prism::Dispatcher dispatcher) -> void
       def create_hover_listener(response_builder, node_context, dispatcher)
         Hover.new(response_builder, node_context, dispatcher, @index)
       end
 
-      sig do
-        override.params(
-          response_builder: ResponseBuilders::CollectionResponseBuilder[T.any(
-            Interface::Location, Interface::LocationLink
-          )],
-          _uri: URI::Generic,
-          node_context: NodeContext,
-          dispatcher: Prism::Dispatcher
-        ).void
-      end
+      # @override
+      #: (ResponseBuilders::CollectionResponseBuilder response_builder, URI::Generic _uri, NodeContext node_context, Prism::Dispatcher dispatcher) -> void
       def create_definition_listener(response_builder, _uri, node_context, dispatcher)
         Definition.new(response_builder, node_context, @index, dispatcher)
       end
 
-      sig do
-        override.params(
-          response_builder: ResponseBuilders::CollectionResponseBuilder[Interface::CodeLens],
-          uri: URI::Generic,
-          dispatcher: Prism::Dispatcher
-        ).void
-      end
+      # @override
+      #: (ResponseBuilders::CollectionResponseBuilder response_builder, URI::Generic uri, Prism::Dispatcher dispatcher) -> void
       def create_code_lens_listener(response_builder, uri, dispatcher)
         CodeLens.new(response_builder, uri, dispatcher)
       end

data/lib/ruby_lsp/ruby_lsp_rake/code_lens.rb

@@ -3,17 +3,11 @@
 
 module RubyLsp
   module Rake
-    class CodeLens # rubocop:disable Style/Documentation
+    class CodeLens
       extend T::Sig
       include Requests::Support::Common
 
-      sig do
-        params(
-          response_builder: ResponseBuilders::CollectionResponseBuilder[Interface::CodeLens],
-          uri: URI::Generic,
-          dispatcher: Prism::Dispatcher
-        ).void
-      end
+      #: (ResponseBuilders::CollectionResponseBuilder response_builder, URI::Generic uri, Prism::Dispatcher dispatcher) -> void
       def initialize(response_builder, uri, dispatcher)
         @response_builder = response_builder
         @path = T.let(T.unsafe(uri).to_standardized_path, T.nilable(String))
@@ -22,10 +16,10 @@ module RubyLsp
         dispatcher.register(self, :on_call_node_enter, :on_call_node_leave)
       end
 
-      sig { params(node: Prism::CallNode).void }
+      #: (Prism::CallNode node) -> void
       def on_call_node_enter(node) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
         return unless node.receiver.nil?
-        return unless node.name == :task || node.name == :namespace
+        return unless %i[task namespace].include? node.name
 
         arguments = node.arguments&.arguments
         return unless arguments
@@ -78,7 +72,7 @@ module RubyLsp
         )
       end
 
-      sig { params(node: Prism::CallNode).void }
+      #: (Prism::CallNode node) -> void
       def on_call_node_leave(node)
         return unless node.name == :namespace
 

data/lib/ruby_lsp/ruby_lsp_rake/definition.rb

@@ -3,20 +3,11 @@
 
 module RubyLsp
   module Rake
-    class Definition # rubocop:disable Style/Documentation
+    class Definition
       extend T::Sig
       include Requests::Support::Common
 
-      sig do
-        params(
-          response_builder: RubyLsp::ResponseBuilders::CollectionResponseBuilder[T.any(
-            Interface::Location, Interface::LocationLink
-          )],
-          node_context: NodeContext,
-          index: RubyIndexer::Index,
-          dispatcher: Prism::Dispatcher
-        ).void
-      end
+      #: (RubyLsp::ResponseBuilders::CollectionResponseBuilder response_builder, NodeContext node_context, RubyIndexer::Index index, Prism::Dispatcher dispatcher) -> void
       def initialize(response_builder, node_context, index, dispatcher)
         @response_builder = response_builder
         @node_context = node_context
@@ -26,17 +17,17 @@ module RubyLsp
         dispatcher.register(self, :on_symbol_node_enter, :on_string_node_enter)
       end
 
-      sig { params(node: Prism::SymbolNode).void }
+      #: (Prism::SymbolNode node) -> void
       def on_symbol_node_enter(node)
         handle_prerequisite(node)
       end
 
-      sig { params(node: Prism::StringNode).void }
+      #: (Prism::StringNode node) -> void
       def on_string_node_enter(node)
         handle_prerequisite(node)
       end
 
-      sig { params(node: T.any(Prism::SymbolNode, Prism::StringNode)).void }
+      #: ((Prism::SymbolNode | Prism::StringNode) node) -> void
       def handle_prerequisite(node) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
         call_node_name = @node_context.call_node&.name
         return unless call_node_name == :task
@@ -61,12 +52,12 @@ module RubyLsp
             when Prism::SymbolNode
               return unless name == v.value
             when Prism::ArrayNode
-              return unless v.elements.find do |node|
-                name == case node # rubocop:disable Metrics/BlockNesting
+              return unless v.elements.find do |n|
+                name == case n # rubocop:disable Metrics/BlockNesting
                         when Prism::StringNode
-                          node.content
+                          n.content
                         when Prism::SymbolNode
-                          node.value
+                          n.value
                         end
               end
             end

data/lib/ruby_lsp/ruby_lsp_rake/hover.rb

@@ -3,18 +3,12 @@
 
 module RubyLsp
   module Rake
-    class Hover # rubocop:disable Style/Documentation
+    class Hover
       extend T::Sig
       include Requests::Support::Common
 
-      sig do
-        override.params(
-          response_builder: ResponseBuilders::Hover,
-          node_context: NodeContext,
-          dispatcher: Prism::Dispatcher,
-          index: RubyIndexer::Index
-        ).void
-      end
+      # @override
+      #: (ResponseBuilders::Hover response_builder, NodeContext node_context, Prism::Dispatcher dispatcher, RubyIndexer::Index index) -> void
       def initialize(response_builder, node_context, dispatcher, index)
         @response_builder = response_builder
         @node_context = node_context
@@ -22,17 +16,17 @@ module RubyLsp
         @index = index
       end
 
-      sig { params(node: Prism::StringNode).void }
+      #: (Prism::StringNode node) -> void
       def on_string_node_enter(node)
         handle_prerequisite(node)
       end
 
-      sig { params(node: Prism::SymbolNode).void }
+      #: (Prism::SymbolNode node) -> void
       def on_symbol_node_enter(node)
         handle_prerequisite(node)
       end
 
-      sig { params(node: T.any(Prism::StringNode, Prism::SymbolNode)).void }
+      #: ((Prism::StringNode | Prism::SymbolNode) node) -> void
       def handle_prerequisite(node) # rubocop:disable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
         call_node_name = @node_context.call_node&.name
         return unless call_node_name == :task
@@ -57,12 +51,12 @@ module RubyLsp
             when Prism::SymbolNode
               return unless name == v.value
             when Prism::ArrayNode
-              return unless v.elements.find do |node|
-                name == case node # rubocop:disable Metrics/BlockNesting
+              return unless v.elements.find do |n|
+                name == case n # rubocop:disable Metrics/BlockNesting
                         when Prism::StringNode
-                          node.content
+                          n.content
                         when Prism::SymbolNode
-                          node.value
+                          n.value
                         end
               end
             end

data/lib/ruby_lsp/ruby_lsp_rake/indexing_enhancement.rb

@@ -3,22 +3,23 @@
 
 module RubyLsp
   module Rake
-    class IndexingEnhancement < RubyIndexer::Enhancement # rubocop:disable Style/Documentation
+    class IndexingEnhancement < RubyIndexer::Enhancement
       extend T::Sig
 
-      sig { params(listener: RubyIndexer::DeclarationListener).void }
+      #: (RubyIndexer::DeclarationListener listener) -> void
       def initialize(listener)
         super(listener)
-        @namespace_stack = []
-        @last_desc = nil
+        @namespace_stack = T.let([], T::Array[String])
+        @last_desc = T.let(nil, T.nilable(String))
       end
 
-      sig { override.params(node: Prism::CallNode).void }
+      # @override
+      #: (Prism::CallNode node) -> void
       def on_call_node_enter(node) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength,Metrics/PerceivedComplexity
         @last_desc = nil unless node.name == :task
 
-        return unless @listener.current_owner.nil?
-        return unless node.name == :task || node.name == :desc || node.name == :namespace
+        return unless T.cast(@listener, RubyIndexer::DeclarationListener).current_owner.nil?
+        return unless %i[task desc namespace].include? node.name
 
         arguments = node.arguments&.arguments
         return unless arguments
@@ -57,8 +58,8 @@ module RubyLsp
 
         ary = [*@namespace_stack, name]
         (1..(ary.size)).each do |i|
-          @listener.add_method(
-            "task:#{ary[-i..].join(":")}",
+          T.cast(@listener, RubyIndexer::DeclarationListener).add_method(
+            "task:#{ary[-i..]&.join(":")}",
             node.location,
             [],
             comments: @last_desc
@@ -68,9 +69,10 @@ module RubyLsp
         @last_desc = nil
       end
 
-      sig { override.params(node: Prism::CallNode).void }
+      # @override
+      #: (Prism::CallNode node) -> void
       def on_call_node_leave(node)
-        return unless @listener.current_owner.nil?
+        return unless T.cast(@listener, RubyIndexer::DeclarationListener).current_owner.nil?
         return unless node.name == :namespace
 
         @namespace_stack.pop

data/lib/ruby_lsp_rake/version.rb

@@ -3,6 +3,6 @@
 
 module RubyLsp
   module Rake
-    VERSION = "0.3.4"
+    VERSION = "0.3.5"
   end
 end

data/sorbet/config

@@ -2,3 +2,4 @@
 .
 --ignore=tmp/
 --ignore=vendor/
+--enable-experimental-rbs-comments

data/sorbet/rbi/gems/{ast@2.4.2.rbi → ast@2.4.3.rbi}

@@ -17,7 +17,7 @@
 # See also {AST::Node}, {AST::Processor::Mixin} and {AST::Sexp} for
 # additional recommendations and design patterns.
 #
-# source://ast/lib/ast.rb#13
+# source://ast//lib/ast.rb#13
 module AST; end
 
 # Node is an immutable class, instances of which represent abstract
@@ -56,7 +56,7 @@ module AST; end
 # temporary node type requires making globally visible changes to
 # the codebase.
 #
-# source://ast/lib/ast/node.rb#40
+# source://ast//lib/ast/node.rb#40
 class AST::Node
   # Constructs a new instance of Node.
   #
@@ -70,21 +70,21 @@ class AST::Node
   #
   # @return [Node] a new instance of Node
   #
-  # source://ast/lib/ast/node.rb#72
+  # source://ast//lib/ast/node.rb#72
   def initialize(type, children = T.unsafe(nil), properties = T.unsafe(nil)); end
 
   # Concatenates `array` with `children` and returns the resulting node.
   #
   # @return [AST::Node]
   #
-  # source://ast/lib/ast/node.rb#168
+  # source://ast//lib/ast/node.rb#168
   def +(array); end
 
   # Appends `element` to `children` and returns the resulting node.
   #
   # @return [AST::Node]
   #
-  # source://ast/lib/ast/node.rb#177
+  # source://ast//lib/ast/node.rb#177
   def <<(element); end
 
   # Compares `self` to `other`, possibly converting with `to_ast`. Only
@@ -92,14 +92,14 @@ class AST::Node
   #
   # @return [Boolean]
   #
-  # source://ast/lib/ast/node.rb#153
+  # source://ast//lib/ast/node.rb#153
   def ==(other); end
 
   # Appends `element` to `children` and returns the resulting node.
   #
   # @return [AST::Node]
   #
-  # source://ast/lib/ast/node.rb#177
+  # source://ast//lib/ast/node.rb#177
   def append(element); end
 
   # Returns the children of this node.
@@ -114,7 +114,7 @@ class AST::Node
   #
   # @return [Array]
   #
-  # source://ast/lib/ast/node.rb#56
+  # source://ast//lib/ast/node.rb#56
   def children; end
 
   # Nodes are already frozen, so there is no harm in returning the
@@ -123,14 +123,14 @@ class AST::Node
   #
   # @return self
   #
-  # source://ast/lib/ast/node.rb#115
+  # source://ast//lib/ast/node.rb#115
   def clone; end
 
   # Concatenates `array` with `children` and returns the resulting node.
   #
   # @return [AST::Node]
   #
-  # source://ast/lib/ast/node.rb#168
+  # source://ast//lib/ast/node.rb#168
   def concat(array); end
 
   # Enables matching for Node, where type is the first element
@@ -138,7 +138,7 @@ class AST::Node
   #
   # @return [Array]
   #
-  # source://ast/lib/ast/node.rb#253
+  # source://ast//lib/ast/node.rb#253
   def deconstruct; end
 
   # Nodes are already frozen, so there is no harm in returning the
@@ -147,7 +147,7 @@ class AST::Node
   #
   # @return self
   #
-  # source://ast/lib/ast/node.rb#115
+  # source://ast//lib/ast/node.rb#115
   def dup; end
 
   # Test if other object is equal to
@@ -155,14 +155,14 @@ class AST::Node
   # @param other [Object]
   # @return [Boolean]
   #
-  # source://ast/lib/ast/node.rb#85
+  # source://ast//lib/ast/node.rb#85
   def eql?(other); end
 
   # Returns the precomputed hash value for this node
   #
-  # @return [Fixnum]
+  # @return [Integer]
   #
-  # source://ast/lib/ast/node.rb#61
+  # source://ast//lib/ast/node.rb#61
   def hash; end
 
   # Converts `self` to a s-expression ruby string.
@@ -171,7 +171,7 @@ class AST::Node
   # @param indent [Integer] Base indentation level.
   # @return [String]
   #
-  # source://ast/lib/ast/node.rb#211
+  # source://ast//lib/ast/node.rb#211
   def inspect(indent = T.unsafe(nil)); end
 
   # Returns the children of this node.
@@ -186,12 +186,12 @@ class AST::Node
   #
   # @return [Array]
   #
-  # source://ast/lib/ast/node.rb#56
+  # source://ast//lib/ast/node.rb#56
   def to_a; end
 
   # @return [AST::Node] self
   #
-  # source://ast/lib/ast/node.rb#229
+  # source://ast//lib/ast/node.rb#229
   def to_ast; end
 
   # Converts `self` to a pretty-printed s-expression.
@@ -199,7 +199,7 @@ class AST::Node
   # @param indent [Integer] Base indentation level.
   # @return [String]
   #
-  # source://ast/lib/ast/node.rb#187
+  # source://ast//lib/ast/node.rb#187
   def to_s(indent = T.unsafe(nil)); end
 
   # Converts `self` to a pretty-printed s-expression.
@@ -207,7 +207,7 @@ class AST::Node
   # @param indent [Integer] Base indentation level.
   # @return [String]
   #
-  # source://ast/lib/ast/node.rb#187
+  # source://ast//lib/ast/node.rb#187
   def to_sexp(indent = T.unsafe(nil)); end
 
   # Converts `self` to an Array where the first element is the type as a Symbol,
@@ -215,14 +215,14 @@ class AST::Node
   #
   # @return [Array<Symbol, [...Array]>]
   #
-  # source://ast/lib/ast/node.rb#237
+  # source://ast//lib/ast/node.rb#237
   def to_sexp_array; end
 
   # Returns the type of this node.
   #
   # @return [Symbol]
   #
-  # source://ast/lib/ast/node.rb#43
+  # source://ast//lib/ast/node.rb#43
   def type; end
 
   # Returns a new instance of Node where non-nil arguments replace the
@@ -239,7 +239,7 @@ class AST::Node
   # @param properties [Hash, nil]
   # @return [AST::Node]
   #
-  # source://ast/lib/ast/node.rb#133
+  # source://ast//lib/ast/node.rb#133
   def updated(type = T.unsafe(nil), children = T.unsafe(nil), properties = T.unsafe(nil)); end
 
   protected
@@ -252,7 +252,7 @@ class AST::Node
   #
   # @return [nil]
   #
-  # source://ast/lib/ast/node.rb#98
+  # source://ast//lib/ast/node.rb#98
   def assign_properties(properties); end
 
   # Returns `@type` with all underscores replaced by dashes. This allows
@@ -261,7 +261,7 @@ class AST::Node
   #
   # @return [String]
   #
-  # source://ast/lib/ast/node.rb#264
+  # source://ast//lib/ast/node.rb#264
   def fancy_type; end
 
   private
@@ -276,7 +276,7 @@ end
 #
 # @deprecated Use {AST::Processor::Mixin} instead.
 #
-# source://ast/lib/ast/processor.rb#8
+# source://ast//lib/ast/processor.rb#8
 class AST::Processor
   include ::AST::Processor::Mixin
 end
@@ -519,14 +519,14 @@ end
 # use some partial evaluation before! The possibilites are
 # endless. Have fun.
 #
-# source://ast/lib/ast/processor/mixin.rb#240
+# source://ast//lib/ast/processor/mixin.rb#240
 module AST::Processor::Mixin
   # Default handler. Does nothing.
   #
   # @param node [AST::Node]
   # @return [AST::Node, nil]
   #
-  # source://ast/lib/ast/processor/mixin.rb#284
+  # source://ast//lib/ast/processor/mixin.rb#284
   def handler_missing(node); end
 
   # Dispatches `node`. If a node has type `:foo`, then a handler
@@ -540,7 +540,7 @@ module AST::Processor::Mixin
   # @param node [AST::Node, nil]
   # @return [AST::Node, nil]
   #
-  # source://ast/lib/ast/processor/mixin.rb#251
+  # source://ast//lib/ast/processor/mixin.rb#251
   def process(node); end
 
   # {#process}es each node from `nodes` and returns an array of
@@ -549,7 +549,7 @@ module AST::Processor::Mixin
   # @param nodes [Array<AST::Node>]
   # @return [Array<AST::Node>]
   #
-  # source://ast/lib/ast/processor/mixin.rb#274
+  # source://ast//lib/ast/processor/mixin.rb#274
   def process_all(nodes); end
 end
 
@@ -557,8 +557,8 @@ end
 # to define deeply nested ASTs from Ruby code, for example, in
 # tests. It should be used like this:
 #
-#     describe YourLanguage::AST do
-#       include Sexp
+#     describe YourLanguage do
+#       include ::AST::Sexp
 #
 #       it "should correctly parse expressions" do
 #         YourLanguage.parse("1 + 2 * 3").should ==
@@ -572,7 +572,7 @@ end
 #
 # This way the amount of boilerplate code is greatly reduced.
 #
-# source://ast/lib/ast/sexp.rb#20
+# source://ast//lib/ast/sexp.rb#20
 module AST::Sexp
   # Creates a {Node} with type `type` and children `children`.
   # Note that the resulting node is of the type AST::Node and not a
@@ -580,6 +580,6 @@ module AST::Sexp
   # This would not pose a problem with comparisons, as {Node#==}
   # ignores metadata.
   #
-  # source://ast/lib/ast/sexp.rb#26
+  # source://ast//lib/ast/sexp.rb#26
   def s(type, *children); end
 end