ruby-lsp-rails 0.3.19 → 0.3.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68571fad74f7aaf4caf243921b544515d55a0121dfcb4edf012ec39cdb77edf7
-  data.tar.gz: 2b703f0d4c79171e186722f77b779036df5ca9e40c8025b0ed62688c546871b2
+  metadata.gz: feb1936ab1a1b20409425b3d644ab0e3c158b6f21a6bdf024d73013ccac28120
+  data.tar.gz: f32daf2f444a0ca0fa2a55b0d2bdef2d67abfcf40b4bae5cd351eede9b50dc11
 SHA512:
-  metadata.gz: 33f5e99f7c2dd576ef8cc98d5e33f99909fee41adfe1ea9aa5692c0b4a24e31d3dec55080cc791a3f5e500e0fcba3aa4596a26350fc12c990b030cf51fe7ffde
-  data.tar.gz: 040b46b1fe55910199605c39b3193227ba634d9ff6adaf06a334036c05430b38a2ccfb593748752fbe0cbac3aa7a6a8c3e81192b4c3e4258e8a1ad90a6abfb53
+  metadata.gz: 72082ba3519fec8b3453201b9ffa9a270d745bdb4abff0e70edce58ad82024aae836a604bcdbdcec73f54faaae8b28e5a646ffec4bd0910c88099d425f3a6606
+  data.tar.gz: 4c53919cae2b20d3dbd6402721ebe9470ba89ab4a2db24cbc61f04484d8b19c23c7c99017042ac09fff55e4f3cf34c2830890a270245b89011a0691ba6ab11f1

data/lib/ruby_lsp/ruby_lsp_rails/document_symbol.rb

@@ -141,7 +141,7 @@ module RubyLsp
 
             arg_receiver = argument.receiver
 
-            name = arg_receiver.full_name if arg_receiver.is_a?(Prism::ConstantReadNode) ||
+            name = constant_name(arg_receiver) if arg_receiver.is_a?(Prism::ConstantReadNode) ||
               arg_receiver.is_a?(Prism::ConstantPathNode)
             next unless name
 
@@ -201,8 +201,8 @@ module RubyLsp
         arguments.each do |argument|
           case argument
           when Prism::ConstantReadNode, Prism::ConstantPathNode
-            name = argument.full_name
-            next if name.empty?
+            name = constant_name(argument)
+            next unless name
 
             append_document_symbol(
               name: "#{message} #{name}",

data/lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -15,8 +15,8 @@ module RubyLsp
         @stdout.write("Content-Length: #{json_message.length}\r\n\r\n#{json_message}")
       end
 
-      # Log a debug message to the editor's output
-      def debug_message(message)
+      # Log a message to the editor's output panel
+      def log_message(message)
         $stderr.puts(message)
       end
     end
@@ -119,12 +119,17 @@ module RubyLsp
           require params[:server_addon_path]
           ServerAddon.finalize_registrations!(@stdout)
         when "server_addon/delegate"
-          server_addon_name = params.delete(:server_addon_name)
-          request_name = params.delete(:request_name)
-          ServerAddon.delegate(server_addon_name, request_name, params)
+          server_addon_name = params[:server_addon_name]
+          request_name = params[:request_name]
+          ServerAddon.delegate(server_addon_name, request_name, params.except(:request_name, :server_addon_name))
         end
+        request_name = request
+        request_name = "#{params[:server_addon_name]}##{params[:request_name]}" if request == "server_addon/delegate"
+      # Since this is a common problem, we show a specific error message to the user, instead of the full stack trace.
+      rescue ActiveRecord::ConnectionNotEstablished
+        log_message("Request #{request_name} failed because database connection was not established.")
       rescue => e
-        send_message({ error: e.full_message(highlight: false) })
+        log_message("Request #{request_name} failed:\n" + e.full_message(highlight: false))
       end
 
       private
@@ -141,8 +146,10 @@ module RubyLsp
           ::Rails.application.routes.routes.find { |route| route.requirements == requirements }
         end
 
-        if route&.source_location
-          file, _, line = route.source_location.rpartition(":")
+        source_location = route&.respond_to?(:source_location) && route.source_location
+
+        if source_location
+          file, _, line = source_location.rpartition(":")
           body = {
             source_location: [::Rails.root.join(file).to_s, line],
             verb: route.verb,

data/lib/ruby_lsp_rails/version.rb

@@ -3,6 +3,6 @@
 
 module RubyLsp
   module Rails
-    VERSION = "0.3.19"
+    VERSION = "0.3.21"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lsp-rails
 version: !ruby/object:Gem::Version
-  version: 0.3.19
+  version: 0.3.21
 platform: ruby
 authors:
 - Shopify
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-11 00:00:00.000000000 Z
+date: 2024-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-lsp
@@ -80,7 +80,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.21
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: A Ruby LSP addon for Rails